summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2021-01-28TopLeft().Y() -> Top() etc.Caolán McNamara
TopLeft().X() -> Left() BottomLeft().X() -> Left() TopRight().X() -> Right() BottomRight().X() -> Right() TopLeft().Y() -> Top() TopRight().Y() -> Top() BottomLeft().Y() -> Bottom() BottomRight().Y() -> Bottom() Change-Id: I5050f619bf92cfc59b6f8dfe7c9f98ef1453c294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27tdf#138590 use the highlighted menu entry, not the combobox active textCaolán McNamara
Change-Id: I2fb68c1491d129d5fd9b963ae4db1fb83171a154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26fix gtk warning about missing 'weight' propertyCaolán McNamara
Change-Id: Ifada66e27955c23eefb41852204fd99f6711a7bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109962 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26move the label width matching into sourceCaolán McNamara
as mentioned in https://gerrit.libreoffice.org/c/core/+/109308 "tdf#119931 Fix accessibility warnings" so the .ui itself is clean and make this an explicit effort Change-Id: I782f79f8e3e022c86d860c946ec1426f26f57990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26tdf#119931 Fix accessibility warningsshubham656
Change-Id: I5d3e30fdb14e3753d52355eaaf60cd671b907a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109308 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26loplugin:passstuffbyrefNoel
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25avoid some ref-countingNoel Grandin
can just return a pointer here, instead of VclPtr. Change-Id: I9ab8962cbbe84ed4dfcfd658a6d758112914cb89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25tdf#119931 Fix accessibility warningsdiwanshu885
Change-Id: I21afac5d1a42073cd67b794a19d7ce7890ed61e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-24tdf#139136 Style Inspector: "true" and "false" now localizableshivam-51
Change-Id: Ib223e941ca4285a0eeae9127edc161311f56aa36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109709 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-24similar to tdf#139774 for a combobox sx10601 is probably a better choiceCaolán McNamara
see extensions/inc/bitmaps.hlst and framework/inc/bitmaps.hlst for the two similar cases which use sx10601 too Change-Id: If44c0dcdbabc83cf35e9c1320c20aac9fdb68523 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-24SdrMarkView::SetMarkHandles Merge identical if'sDr. David Alan Gilbert
Two neighbouring if's spotted by cppcheck with identical conditions; squash. Change-Id: I0b8822991564b994a9c908b28dcf3f2636bb68be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-24SvxLanguageBox::SetLanguageList Merge if'sDr. David Alan Gilbert
Cppcheck noticed a run of 3 if's with the same condition next to each other; they're fall out of e54d65dea830c which simplified the conditions to all be the same. Squash them. Change-Id: I5f0b928b9a629dc43cc62cc03ab6ced2a4b42b2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-24Use ContainerType().swap and avoid local variablesMike Kaganski
Change-Id: I773555180758a97aff37f9bc27de83c355d71521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-22tdf#135550 ListBox should triger an event when changed non-interactivelyCaolán McNamara
not just when changed by the user Change-Id: If2238341ff8465fee6375dad1ea9b4d7ec0110e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22tdf#139590 Drag and drop doesn't work in SdrObjEditViewCaolán McNamara
Change-Id: Id8deeee0c1a919f330bc6623f708453279a214c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21avmedia: add doc model for bitmap fill of slide narrationsMiklos Vajna
This allows specifying a custom bitmap for a media shape. It's mostly useful for audio-only streams where the additional bitmap may be e.g. a speaker icon to indicate this a narration. Change-Id: I21c1b492ac09b631cf6e3ec8120be8b82c01c26d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109763 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara
the gtk default is left aligned, change the vcl one to match and drop the deprecated and unnecessary [x|y]align Unfortunately on load glade's inline preview shows centered alignment, though its "true" preview tool shows left alignment and unsetting and resetting draw-indicator will update the preview to show the alignment which will be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502 See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my stab at making glade do the right thing. Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21_yes -> _YesCaolán McNamara
Change-Id: Ie85ea2b8a2620d0a62f39b39ebbb2ac41ab85d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-20Fix typosAndrea Gelmini
Change-Id: I8bab3efcd63c0f950bc3176e0d26cc896d601083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109559 Tested-by: Jenkins Reviewed-by: Dante DM <dante19031999@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-19Resolves: tdf#135617 grab focus to widget matching the line spacing stateCaolán McNamara
instead of leaving it at the first widget in the popup Change-Id: I0bc4c72f7972e339cd28cd6368a4784cdb11275f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19vcl: remove or rename too long methods names in VectorGraphicDataTomaž Vajngerl
Change-Id: I8a64d27927b608afdc7996e0b0bbc59a58fde90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108443 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-18devtools: handle the doc. model tree with attached obectsTomaž Vajngerl
Instead of filling the document model tree with fill* methods, refactor that to use objects that are attached (via get_id) to the tree nodes directly. For this introduce DocumentModelTreeEntry and subclasses, which implement what the current UNO object is that is being shown for a tree node and a "fill" virtual method, which is used to fill the child nodes of the tree when expanding a tree node. This makes the code much easier to work with and in addition it makes it possible to have all the tree nodes to fill the content on demand when expanded. Change-Id: Id5a027e060af90e483181439568f17d0172d1b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109500 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-18Bring uno:RefreshView to CalcSamuel Mehrbrodt
Allow refreshing the document layout via UNO slot Change-Id: I956bb884b1fb4231b1f617c4aa5a80ff9a45ec92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109230 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-01-18devtools: separate DocumentModelTreeHandler into its own file(s)Tomaž Vajngerl
Change-Id: Ie657fca3d7e221ca6fbce1016589bd86312530fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109499 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-18devtools: separate handling of document model tree into own classTomaž Vajngerl
This introduces DocumentModelTreeHandler which is used to handle the left-side document model tree. This makes it easier to track how the tree is populated and handled by encapsulation. Change-Id: I0c11d8012d149c6f4ce9a5067a8c368fb794efe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109498 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16snap near 0.5 align values to 0.5Caolán McNamara
Change-Id: Idcedba97e1738f097a36845614a17f143c20c7c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16devtools: Add more elements to the document model tree viewTomaž Vajngerl
This change adds more elements to the document model tree view. for all: style families and styles for Writer: shapes, graphic objects, OLE objects, frames, tables for Impress: master slides for Calc: shapes, charts, pivot tables Change-Id: Ic6d2c6c8f45fe7881e17aee3727864aeb4d701c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109376 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16make the Color constructors explicitly specify transparencyNoel
to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-16devtools: change to on-expand filling of the doc. model tree-viewTomaž Vajngerl
Instead of traversing the document model at once and filling the tree-view, only fill the root element names first, and fill the children on expand. For example first add "Paragraphs" root node, and when the user expands that node, fill the child nodes of the tree with actual paragraphs. Change-Id: Ifa71603a4fa1b69d2b1b590f0d0493e22092deb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109375 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-16devtools: fill left-side document model view for all document typesTomaž Vajngerl
Change-Id: I19f1cfdbdde86b3fbeb2a0a7e3e4255ef0055cf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109073 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-15replace stock button imagesCaolán McNamara
Change-Id: I9be83856c0dd15552a042f009464c279bf239848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button labelsCaolán McNamara
Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15pdfium: add wrapper for FPDF_FILLMODE_* definesMiklos Vajna
Which is, I think, the last direct pdfium usage outside vcl. Change-Id: I2e435e5a3669c6163bf2c20bc6d1d8bd4c88cecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109314 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-15Use value comparison hereMike Kaganski
This was always comparing pointers, ever since commit cb07ed8c74d71de9ef512c7a3568c7ee85585cef. They could only happen to be not different if they are both nullptr. But the uses of the function seem to expect value comparison (see SdrObjEditView::ImpChainingEventHdl, SdrObjEditView::SdrEndTextEdit). Change-Id: I2265dc8f0f7e4441940f8e19ec0b016b5f78e812 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109284 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-14cid#1471346 Uncaught exceptionCaolán McNamara
Change-Id: I535affd6597636aa32e1cf9c6005238f9503ef6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Asian phonetic guide dialog uses "close" widgetJulien Nabet
and not cancel one. widget response = -7 corresponds to GTK_RESPONSE_CLOSE See https://gtk.developpez.com/doc/en/gtk/GtkDialog.html label is "gtk-close" and the variable name is "m_xClosePB" Change-Id: I6ac8e1814ff3c594498d81e99e864939b6a2c23a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14cid#1471680 help coverity see that "Division or modulo by zero" is bogusCaolán McNamara
Change-Id: I3c349b2cc274de6a74cb1de71b630c4fcb64231e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Make Fontwork gallery dialog asyncSzymon Kłos
Change-Id: I156dc1b505b01dc7520ccfe80bbf97eba881d653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109092 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109258 Tested-by: Jenkins
2021-01-14Fontwork dialog: use iconviewSzymon Kłos
Change-Id: I5bb35407ca83c9b0cda6f6355e6e25c21fecb459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108960 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109181 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-14tdf#139567 set no-show-all to TrueCaolán McNamara
so changing child vis to false before parent is shown 'sticks' as a final visibility of false Change-Id: Ieee4e4c7f7bddf6204c61ca788d316d52ef5a6dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14pdfium: add an FPDFPageObj_GetStrokeWidth() wrapperMiklos Vajna
Change-Id: If411b788b3ea07c29377e01052ee6a48893ca482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109250 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-14tdf#138843 Show image file type inside image properties dialogshubham656
Change-Id: I77adc9c3cc9d3bd62f0f67345b7a025bcad2352a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108361 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-13transparency->alpha in GraphicAttrNoel
Change-Id: I1fe9311871724ff8b7b8960f5dba6e890198565c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-13devtools: move DevelopmentToolChildWindow to its own fileTomaž Vajngerl
Change-Id: I12326479afb5756729b62ff3676f995d16f64aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109045 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-13devtools: Add left-side tree of the document modelTomaž Vajngerl
This adds the graoundwork for displaying the DOM of the current document as a left-side tree and implements filling in the paragraphs for Writer. The content of the DOM tree is of course a WIP. Change-Id: I99c75b0c46d9a6a4ca398c46de0af759d459b7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108976 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-13devtools: Add treeview with content of current objectTomaž Vajngerl
Change-Id: I8d6dd035e60a7521c404e23045fade7eae47fc6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108975 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-13fix indents to be consistentCaolán McNamara
git show -w is empty on this commit Change-Id: Ifc139cf4557ae9c2664057d2ed87e020330d17c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-13devtools: Add selection change listener to DevToolsTomaž Vajngerl
Selection listener is needed so it is possible to react when the selection changes in the document. Change-Id: I94e9da06b3ceedbad13dd203f690037f3eafdb13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108259 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-13vcl: use BinaryDataContianer in VectorGraphicDataTomaž Vajngerl
This change is needed so we can use the same data in GfxLink and in VectorGraphicData. Currently the data needed to be duplicated, which is less than ideal. Change-Id: I79419921d09681fa8f0b1ac4bf8ea84199d4aae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108440 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-12-26 00:34:24 +0000