summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-12-20Fix metric spinbox tool item sizeJan-Marek Glogowski
Instead of guessing, use the CalcMinimumSize(), which also knows about theming. Change-Id: I747571b48c81166d11d03f99ab564b1a25165ef3
2016-12-20Result of css::ui::ContextChangeEventMultiplexer::get cannot be nullStephan Bergmann
Change-Id: I00fba6c2a79404c824feaa5bb302d37c4158f9a3
2016-12-20convert SFX_EVENT constants to scoped enumNoel Grandin
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never generated, so remove them and delete the code that receives them Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00 Reviewed-on: https://gerrit.libreoffice.org/32168 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19make sure the variables are set upMarkus Mohrhard
Change-Id: Ib710f1ee291fb15ad7b05a5d36824a129d407ccc
2016-12-19no need to wrap calls to SAL_INFO in #ifdef DBG_UTILNoel Grandin
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75 Reviewed-on: https://gerrit.libreoffice.org/32034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-17tdf#104722: Wrong text alignment when text box is smaller than the text insideTamás Zolnai
The default TextHorizontalAlignment is block. Setting paragraph alignment (on UI) works when this text alignment property is set to block (otherwise has no effect). In general this works on this way, but the existing algorithm did not work in those cases when the text was bigger than the container shape. Change-Id: I02dba76f8e3033a465bb14dc826521966bb30987 Reviewed-on: https://gerrit.libreoffice.org/32123 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-17Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann
...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-17fix !HAVE_FEATURE_DBCONNECTIVITY buildCaolán McNamara
Change-Id: I7a4fe41d6ff5c7b9fe9ed243b84779da9d2c8a68
2016-12-16svx: remove nonsense exception throwing codeMichael Stahl
Commit 60f11adb950e4f9645cc9ecb0f5af8235cc97366 added code to AccessibleShape::getAccessibleStateSet() that tries to retrieve some state from the parent, but the implementation of the base class AccessibleContextBase::getAccessibleParent() throws if it is already disposed, which is the condition checked just before, so surely this doesn't have any other effect than throw DisposedException, except possibly in the mpText == null case which is already handled in the other branch with identical code. Change-Id: Iaf109f69036437989abbbf914ef32cca1528a97e
2016-12-16tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee
2016-12-16avoid dynamic_castEike Rathke
Change-Id: I9f64eac95b39adc649b2e63cd5abdd6e7a448ee6
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14SafeMode: s/LibreOffice/%PRODUCTNAME/, small UI changesKatarina Behrens
nouns are written Upper Case only in German also Cancel button looks odd as secondary Change-Id: Id1b051cbb86ab69ea88c7b1da2cda3eb19f063de Reviewed-on: https://gerrit.libreoffice.org/31971 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-13add NUMBER_HEBREW and CHARS_HEBREW to RID_SVXSTRARY_NUMBERINGTYPEEike Rathke
So now we have listed all that are in cui/uiconfig/ui/numberingoptionspage.ui liststore1 as well. Change-Id: Ia0617c0d70af474eec9e57fc5040bb53736e3b7b
2016-12-13add "Linked graphics" to RID_SVXSTRARY_NUMBERINGTYPEEike Rathke
... and exclude it at the relevant places that load this resource. In preparation of eliminating another duplicated UI string definition instance. Change-Id: Ia500fffe5c044a76bce2d72e6ea22ff71bb1dfb1
2016-12-13rename to numberingtype instead of pagenumberingEike Rathke
... because that now is what it is about, it's just used in page numbering as well. Change-Id: I5516b6babcd5438b6505d189943c21abfbe35a7e
2016-12-13use RID_SVXSTRARY_PAGE_NUMBERING StringArray also in WriterEike Rathke
... and add the two missing extra strings from sw/source/ui/misc/numberingtypelistbox.src to svx/source/dialog/pagenumbering.src and filter them out for the page number dialog, so later we can get rid of yet a 3rd place where those strings are to be translated and maintained. Change-Id: If7d124692c752f341d4ea11a8914b099f711fa10
2016-12-13add missing legal and modelinesEike Rathke
Change-Id: If828b51fc72ecbeec7db7a2a1af0be1bb4cd753a
2016-12-13change from glew to epoxyCaolán McNamara
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12Mark as constTakeshi Abe
Change-Id: Ie4b7d45d26fbd839f9afcd11a7ba4bff80ed54e8 Reviewed-on: https://gerrit.libreoffice.org/31854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-10Remove superfluous jargon from user visible stringKhaled Hosny
No idea what “CTL” is supposed to convey here, they do not even look as well formed strings. Change-Id: I424072fb5efdecd9115649dd3abbd4e9d5dc032c Reviewed-on: https://gerrit.libreoffice.org/31837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-10fix build, invalid conversion from "const char*" to "int" [-fpermissive]Eike Rathke
Change-Id: Idc50ef5eb250a2a68ae6c6aaed969289baaf38f4
2016-12-09split markers for galaxy theme, when scaling use splitted markersTomaž Vajngerl
For markers (resize markers, anchors,...) we contain them all in one image atlas. This was generally done because of resource limitiations in Windows 95/98 which aren't a problem anymore in present systems. This is however problematic in HiDPI as we scale the image and the coordinates of aren't correct anymore. Another problem is that it uses its own cache instead of common cache in ImplImageTree. So this commit extracts all the markers into its own images for galaxy theme and uses them when we scale. In the future when we extracted all the markers to its own images for all icon themes we can remvoe the old code with the image atlas. Change-Id: Ibee181b529d30e20050df8cd396d338bd53532c0
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Match conditional for glxtest static library in vclTor Lillqvist
Change-Id: If5b4308a29c78ded311bf300416b2cb4f553a7d5
2016-12-07tdf#104405 Clone Formatting ignores vertical text alignmentNoel Grandin
Change-Id: I56cce69ddb21f7f9336b8f59e181e91306e92019 Reviewed-on: https://gerrit.libreoffice.org/31623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-07tdf#75280 Convert few inappropriate use of sal_uIntPtr to better integer typesGaurav Dhingra
partial fix for Tdf#75280 Change-Id: I81d78449b709c246289ebf6bf3e6cabf1198adcb Reviewed-on: https://gerrit.libreoffice.org/31579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-07tdf#91260 svx, sw: don't paint off-page part of drawing objectMichael Stahl
Since commit a4dee94afed9ade6ac50237c8d99a6e49d3bebc1 Writer no longer forces drawing objects to be entirely on one page. However since there is only one SdrPage for the entire document, a drawing object dangleing off the bottom of one page will be painted again on the next page, which is clearly undesirable since Word doesn't do that (and it also destroys the nice invariant that a fly on page N never overlaps a fly on page N+1). So force the SdrPageView code to ignore the drawing object on the next page, by passing in the area of the page frame so that ViewObjectContactOfSdrObj::isPrimitiveVisible() can verify that the anchor position of the SdrObject is actually on the painted page. This requires passing in another parameter; in the usual case the DisplayInfo::maRedrawArea already contains the page frame since commit 8af09bf33291df2fb2bfbbd6e42f9bf074fcc4fc, but there are special cases in SwFrame::Retouch() and SwFlyFrameFormat::MakeGraphic() where some sub-area is passed in, which cannot be used to check the anchor. Change-Id: Ia0476216ca41dbdaa3de1063fa18cb94fe2e5ae8
2016-12-07convert PolyFlags to scoped enumNoel Grandin
and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06SafeModeDialog: Rename widget to match labelSamuel Mehrbrodt
Change-Id: I6bb02527fa77846343e55ff73497d1b46b5e1ba8 Reviewed-on: https://gerrit.libreoffice.org/31699 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Rename to match realitySamuel Mehrbrodt
This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Simplify codeSamuel Mehrbrodt
Change-Id: Ibb154ebdacb6f445371cb55d795420f92bed0a22 Reviewed-on: https://gerrit.libreoffice.org/31691 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Could not activate checkboxes to remove extensionsSamuel Mehrbrodt
Because of missing event handler Change-Id: Id546a2b22a89321ca09ec29ba7787a1315753bcf Reviewed-on: https://gerrit.libreoffice.org/31692 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Change Read/Write access to Scoped Read/Write accessMark Page
Change-Id: Idbe8e393b64f2a151e20c1851d7c14fa161acf97 Reviewed-on: https://gerrit.libreoffice.org/31635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06convert PolyStyle to scoped enumNoel Grandin
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e Reviewed-on: https://gerrit.libreoffice.org/31633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05drop these intermediate Images and use BitmapEx directlyCaolán McNamara
Change-Id: Ief15df1722bb59323563c21d76f5af624fbef8c9
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05silence some BAD_SHIFTsCaolán McNamara
Change-Id: I2a669aff0a8a63eb4b16600344cea9f601d5e68a Reviewed-on: https://gerrit.libreoffice.org/31601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-04tdf#88206 replace cppu::WeakImplHelper* in svtools and svxJochen Nitschke
and remove unused implbase*.hxx and compbase*.hxx includes Change-Id: Iedf6b6dce09b5baf714a1b3394bb7fb3526cca82 Reviewed-on: https://gerrit.libreoffice.org/31594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02avoid valgrind warningDavid Tardon
Change-Id: I8ffb08bdab452f6a8618eaf466b722e7c8d226d9
2016-12-02use early return to simplify flowNoel Grandin
Change-Id: I98201eac2e038c152422bbc6380cfa321ba266df Reviewed-on: https://gerrit.libreoffice.org/31534 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02coverity#1371200 Missing move assignment operatorCaolán McNamara
adjust things to not need one Change-Id: I1079f50d8813f86c4828be602687b4cbffe61415