summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2019-05-16tdf#42949 Fix IWYU warnings in include/svx/[e-g]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16split methods upCaolán McNamara
Change-Id: Ib6f27574b8a45b29d6887d268f2e291314c796bf Reviewed-on: https://gerrit.libreoffice.org/72382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16refactor to move overlay creation to SdrPaintViewCaolán McNamara
Change-Id: Idbb734a44289d7ecead84f3c4ac2bc1ebc44ef40 Reviewed-on: https://gerrit.libreoffice.org/72381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13drop some unneeded includesCaolán McNamara
Change-Id: I3c9a3b73c099b70bdbd6b16688e83ee01231a27e Reviewed-on: https://gerrit.libreoffice.org/72204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13weld imapmenuCaolán McNamara
Change-Id: I0cc79534112ae8897a9887942238ff1236c4a3eb Reviewed-on: https://gerrit.libreoffice.org/72217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-11weld conditional formattingCaolán McNamara
Change-Id: Ia9c99a17d5a95d67a412cfde959192c99caa70be Reviewed-on: https://gerrit.libreoffice.org/71956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-11handle empty tools::Rectangle in svxNoel Grandin
Change-Id: I45e26c9cdc00ae6d3bc56534d612b83b5ac26074 Reviewed-on: https://gerrit.libreoffice.org/72125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-10tdf#119931 Fix a11y warnings in classificationdialog.uiSamuel Thibault
Make "Content" a label for the drawing area Change-Id: I2238ea42d33564d848376e3c33b9d9a46af094ae Reviewed-on: https://gerrit.libreoffice.org/72045 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-09tdf#125126 Use individual methods for polar handles in OOXML shapesRegina Henschel
Polar handles of preset custom shapes from OOXML import have shown the error, that handles are jumping or not movable or direction of handle movement was opposite to change of shape outline. Reason was that for backwards calculation a single method was used. But the meaning of the adjustment value is special to the handle and thus the backwards calculation too. Change-Id: Ia57b07ddc23efeb32ba569ce84d47b535e801750 Reviewed-on: https://gerrit.libreoffice.org/71831 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-09loplugin:unusedmethodsNoel Grandin
Change-Id: I7b4d2e5e611935284e2902b0089950768dfb7717 Reviewed-on: https://gerrit.libreoffice.org/72036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-09avoid copying when placing items into SfxItemSetNoel Grandin
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-08tdf#119931 Fix a11y warnings in compressgraphicdialog.uiRasmus Jonsson
Rearrange objects in code to correspond to actual layout & conform to rest of file. Change-Id: I9c86000f335c2d5305286b42b9cd434e922f07c6 Reviewed-on: https://gerrit.libreoffice.org/70340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08tdf#119931 fix a11y warnings in docking3deffects.uiRasmus Jonsson
+ rearrange code to correspond to actual layout in dialog Change-Id: I4a83f230e1d523a5d03121338de0466e9a61852e Reviewed-on: https://gerrit.libreoffice.org/70608 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08tdf#119931 Fix a11y warnings in classificationdialog.uiRasmus Jonsson
Remove warning suppressions. Create svx.false for false warnings. Rearrange objects in code to correspond to their actual position on the screen. Add new label for part entry box. Change-Id: I2a7293024427e65cca2ea754fac4fe1bc7d6d0bd Reviewed-on: https://gerrit.libreoffice.org/70338 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08improve tools::Rectangle->basegfx::B2?Rectangle conversionNoel Grandin
Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-05-08tdf#120269 Remove misleading description from safe mode dialogSamuel Mehrbrodt
Change-Id: Ieec62c2793419ee82ecd6f95497e710900ad9be1 Reviewed-on: https://gerrit.libreoffice.org/71886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-07tdf#63640 FILEOPEN/FILESAVE: particular .odt loads/saves very slow, part2Noel Grandin
Use the existing sorting functionality in SfxItemPool and extend it to search for NameOrIndex item in SvxUnoNameItemTable This is a little tricky in that we are defining only a partial ordering over the CntUnencodedStringItem (and their subclasses) items. Partial because I can only use the part of the item that is not randomly mutated by various code, which is why the other fields in the subclasses are mostly out of bounds. I had to exclude FillBitmapItem because it triggers a unit test failure and I cannot figure out why that specific item does not play nice with this optimisation. After this optimisation, the load time goes from 3.6s to 2s on my machine. Change-Id: I52d58c68db2536b69a7b0a9611a2b4c703bc4928 Reviewed-on: https://gerrit.libreoffice.org/71461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-07tdf#62699 Drop pass-through header file include/svx/xattr.hxxGabor Kelemen
Change-Id: I8db9a4de494fbd045a0f4da810c3887ce62dd350 Reviewed-on: https://gerrit.libreoffice.org/71595 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-03Use hasElements to check Sequence emptiness in sfx2..svxArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: Icabd773f3b924d465b33e8581175f1fcf70c282e Reviewed-on: https://gerrit.libreoffice.org/71704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-02fix bug in XFillBitmapItem::PutValueNoel Grandin
Change-Id: I798d0ea0fc0a0f24275f58932ea0c91077212d85 Reviewed-on: https://gerrit.libreoffice.org/71678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-01Fix typoAndrea Gelmini
Change-Id: I1c7c7c1fdbcf442e367fe3f61c1c6c9eeadc0a95 Reviewed-on: https://gerrit.libreoffice.org/71612 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-30tdf#115813 Get correct adjust value from XY handle of ooxml-shapeRegina Henschel
If an adjust value is not directly bind to a handle parameter but via formulas, the calculation of the adjust value depends on the individual shape. The error was, that one calculation method was applied to any OOXML-shape. User noticed, that handles did not stick to the position, where they are released but jumped to unexpected positions. The patch calculates guide formulas backwards to get an adjust value. The patch solves the problem for preset OOXML-shapes until some day a general method for any shape is implemented. Change-Id: I1a47082d5110a63530a273665d80348c119dc08b Reviewed-on: https://gerrit.libreoffice.org/71258 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-04-30svx: remove nested redundant #ifsMiklos Vajna
Change-Id: I325fbf7573903a1cb99ea1f1c81d6b5a482efe09 Reviewed-on: https://gerrit.libreoffice.org/71578 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-30tdf#62699 Drop pass-through header file include/svx/xlineit.hxxGabor Kelemen
Change-Id: I3ae76558f476934dffc2b43b19af848b5ad5015e Reviewed-on: https://gerrit.libreoffice.org/71454 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30improve loplugin:stringconstantNoel Grandin
to find more places we can elide the OUString() constructor at call sites Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713 Reviewed-on: https://gerrit.libreoffice.org/71514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30implement std::hash for css::uno::Reference and rtl::ReferenceNoel Grandin
The declaration in BarChart.cxx is particularly suspicious, because it was using a < for the KeyEqual template parameter. Been there since: commit b2c3233e5f267b5d244d722a94424a3b224b3314 Date: Thu Dec 21 20:08:33 2017 +0900 chart2: suspend/resume setting rects dirty for 3D shapes comphelper::OInterfaceCompare is no longer necessary Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975 Reviewed-on: https://gerrit.libreoffice.org/71537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30drop Graphic::operator boolNoel Grandin
which tends to interact in very weird ways with other code, for example it makes Graphic appear to have an operator< Change-Id: I335fe8f3644b710bc61291e625cbca7334a37716 Reviewed-on: https://gerrit.libreoffice.org/71532 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29tdf#62699 Drop pass-through header file include/svx/xfillit.hxxGabor Kelemen
Change-Id: I6598d81b166486f3c48b119cc136b9f6e6c2a12c Reviewed-on: https://gerrit.libreoffice.org/71336 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-29tdf#63640 FILEOPEN/FILESAVE: particular .odt loads/saves very slow, part3Noel Grandin
Reduce time spent constructing strings from char arrays just to do a comparison Change-Id: I7af99747530d91d57e1a5b789ca9989a616428fc Reviewed-on: https://gerrit.libreoffice.org/71464 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28prefix member variables of AnimationBitmapTomaž Vajngerl
Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a Reviewed-on: https://gerrit.libreoffice.org/71425 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-27tdf#120703 PVS: re-read aPrefSize after updating itMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 645, 655 Since commit 37aa7d81aacaae12dfe0fd2ade2779235bbf72f1 Change-Id: I7b4d2d58e51cf98ac6294d1feacd28c3a8761d81 Reviewed-on: https://gerrit.libreoffice.org/71431 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#62699 Drop pass-through header file include/svx/xtextit.hxxGabor Kelemen
Change-Id: Id48dc67443bbd28b0a7e2987b2546808cac8e8e2 Reviewed-on: https://gerrit.libreoffice.org/71334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#62699 Drop pass-through header file include/svx/xsetit.hxxGabor Kelemen
Change-Id: Id750f663389be36c669756e4bdd1e4e01be48199 Reviewed-on: https://gerrit.libreoffice.org/71327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27weld cluster of change tracking dialogsCaolán McNamara
Change-Id: I42ca7acb41699df91b91a9f59fc68cd30972a397 Reviewed-on: https://gerrit.libreoffice.org/70988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Removed executable permission on source filesAndrea Gelmini
Change-Id: Iaafc0f45282b0351c24b4ddc433ed1086177ff73 Reviewed-on: https://gerrit.libreoffice.org/71400 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-26Removed executions flags on source filesAndrea Gelmini
Change-Id: I165d417a8e28d5732945722158b83e2ac5edb402 Reviewed-on: https://gerrit.libreoffice.org/71388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25Cut down on -pthread/-lpthread proliferationStephan Bergmann
Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-25Convert remaining SdrHint to static_castXisco Fauli
follow-up of 10c934147d469965dba6abc78efd02759a010b8e Change-Id: I2085173dffd71dbbc68a0574400bebe132626dd9 Reviewed-on: https://gerrit.libreoffice.org/71284 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-24tdf#89522 PERF FILEOPEN xlsx, part 2Noel Grandin
re-arrange the conditions so we avoid the dynamic_cast most of the time. This takes the file-open time from 40s to 29s for me. Change-Id: If65a63502fd545003137747605332be65d5e91ca Reviewed-on: https://gerrit.libreoffice.org/71229 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#89522 PERF FILEOPEN xlsx, part 1Noel Grandin
Inherit from tools::WeakBase non-virtually, so that we can use a static_cast in tools::WeakReference::get instead of a dynamic_cast. This takes the file-open time from 1m21 to 40s for me. Add a clang plugin to make sure we don't accidentally end up inheriting from tools::WeakBase more than once. Change-Id: I9c7c36403333f99094e1f9d8cce2ecd9200377f9 Reviewed-on: https://gerrit.libreoffice.org/71231 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124197 Improve "Unexpected error" user-visible error message wordingDarkByt31
Change-Id: I11c2ac4855a5fec2d26255ec3ab14ffe50e0fbbe Reviewed-on: https://gerrit.libreoffice.org/71066 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-10 14:03:10 +0000