summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2021-02-11rename RestGeoData->RestoreGeoDataNoel Grandin
Change-Id: I5d584f40949e5c7f2fc7e126cd9cae81eed4db70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-11devtools: when selection changes, select obj. in DOM tree viewTomaž Vajngerl
When we inspect the current selected object, we search and select the object in the document model tree view if the object is in the tree view, or just unselect everything. Change-Id: I5dc5e323067bfb4aa3d2cd904d3f810719e45fad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110467 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-11devtools: move SelectionChangeHandler to its own fileTomaž Vajngerl
Change-Id: I78d3712caedeb2ad4741e3706beb43051a978801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110466 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-11devtools: rename LeftSideTreeView to DocumentModelTreeViewTomaž Vajngerl
Change-Id: I1a16f448a7e726e9c78d4b4a7b24ea8cef0e0d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110465 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-11devtools: use xInvocation to get values of all property typesTomaž Vajngerl
Without XInvocation we could only get the values of XPropertySet type of properties. XInvocation however supports getting values of all types of properties as it can invoke any kind of methods. Change-Id: I1f6c7b932b8bc554bcf6600a8c9eef81b7b2cfa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110464 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10devtools: show properties nested if the the property is an objectTomaž Vajngerl
If the property value is an object, show the expander and allow to show properties of that object nested. Change-Id: I93edf1a47738b9d6f15949dd4116b92ee54c8f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10devtools: handle object inspector with attached objectsTomaž Vajngerl
This changes the object inspector tree view to create child nodes on demand (when expanded) and attach specialized node objects to the node, which are responsible to get the specific introspection information for the current inspected UNO object. Change-Id: Ib8431cc2a2c6d6d3ac7fd9db5bc61c9071d5e8f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110462 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10devtools: add values for properties in object inspector tree viewTomaž Vajngerl
Change-Id: Ia53ea2cbc9797cd787d1ea3d841f947a515055e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110251 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-10loplugin:refcounting also check OWeakObject subclassesNoel
Change-Id: I2d89085a22d7424c6f8f7662307433ce50fc61d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10tdf#139511 Correct calculation of minimum row height during resize.Gülşah Köse
Change-Id: Id47b5877d56850c80395897a83daae8e24f5c099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110662 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10clean up SdrObject cloningNoel
using operator= implies that overwriting an SdrObject is a useful operation, but that is not at all true - they are typically linked into and referred to by many other things. So rather use a copy-constructor. Also clean up a couple of weird "do some stuff after the clone" code into the main copy constructor. Change-Id: Iefc1481b527602748b5f3abed06e7cca66c0581c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09loplugin:referencecasting check for Reference::queryNoel
Change-Id: I008d16d933c70df132699872ac4c39a5c1f87b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09return by unique_ptr from NewGeoDataNoel Grandin
Change-Id: Iab806959d79ce828069cb16b6a7883981d85dfaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-08update pchesCaolán McNamara
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-08tdf#139767 fix crash caused by the selection listenerTomaž Vajngerl
When development tools window was closed, the selection listener was still listening and tried to change the selection because it was never unregistered from the selection supplier. This caused a crash as it tried to change the object on an non existing tree view. This change modifies the selection change listener so that is adds itself to the selection supplier when constructed and removes itself from the selection supplier, when the development tools window is disposed. Change-Id: Ifcb56aaee8f3c5c71ec609e68ffc78573f1b4179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110121 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-05Make sanitiseMm100ToTwip simpler and more correctMike Kaganski
The result's absolute value is always smaller than n. Returning an uncorrected value taken from reversing multiplication and division order when intermediate value would overflow is better than arbitrary constant. Also further deduplicate Twips <-> 100th-mm conversion, and make sure they all are in a single header. Using conversion implementation that handles negatives correctly improves accuracy, as seen in unit tests; e.g. in testPictureEffectPreservation (the original doc had "dir" equal to "8100000", while we tested that it was "8076614" after roundtrip). Change-Id: Icd027af6238a9f45f916f53f8684506cc959e696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-05devtools: change "Current Selection" tree item to a toggle buttonTomaž Vajngerl
It is a bit awkward that the selection is a tree item so this changes it to be a toogle button, which when enabled, shows the object in the right-hand side object inspector and disables the left-hand side DOM object tree view in this case. Change-Id: I4ebd03a39c72109f0545206354aa7dbe85e9649a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110119 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-04have one set of twips<->mm conversionsNoel
Change-Id: I510f4a0524a7c72eb124cba103cbf398024976d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-04remove svx/mutxhelp.hxxNoel
which is a clone of cppu::BaseMutex Change-Id: I6db266a4b67ac2d8b6c389cd27bf5bc7b9ecc754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110402 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-04use more getSdrObjectFromXShapeNoel
Change-Id: Ia237643ab040425f231f781c86e7e060f0b53717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-03tdf#137121 add popup menu to style items used in styles preview windowJim Raykowski
Change-Id: Ib9bd6584416b24301d3d302165d12c89bcd1e178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109838 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-02-03use more unique_ptr in EnhancedCustomShape2dNoel
and fix some leaks in the unit tests Change-Id: I8d324a24de11b14b4820e3cdd7f078d5877489e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-03pass pointer rather than tools::WeakReference in CellUndoNoel
makes an upcoming change I have in mind simpler Change-Id: I5f077a8bb2a3d20db500ea8c65d87911daabfdd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-02use unique_ptr in ImpHandleMotionThroughBoxesKeyInputNoel
Change-Id: Ieccf70ca52a639204cd576449c0d89c3419835fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-02use unique_ptr in SdrEditView::ImpConvertOneObjNoel
Change-Id: I18a796291f4c2f3b203940f474e2785580bf7d1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-02loplugin:redundantcast catch more dynamic_castNoel
Change-Id: Ia28e58217cefa306567b53688d851fa210b7821c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110287 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-01devtools: show list of interfaces for the object in the inspectorTomaž Vajngerl
Change-Id: I2b0ff5b272a7d3b2ca2d76edfc6929f789277faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110118 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-01devtools: add "Current Selection" to the left-side tree viewTomaž Vajngerl
"Current Selection" shows in the object inspector the current selected object in the document. Change-Id: I944759b03b3b875e062de0d4555d93012eb48317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110117 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-30tdf#140013 change icon for list view in Template Manager & Remote Files dialogRizal Muttaqin
Change-Id: I37b04d39efa7b328cff0df54a5b187876db8ba5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110171 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-29loplugin:stringviewparam extend to new..Noel
O[U]StringBuffer methods Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28TopLeft().Y() -> Top() etc.Caolán McNamara
TopLeft().X() -> Left() BottomLeft().X() -> Left() TopRight().X() -> Right() BottomRight().X() -> Right() TopLeft().Y() -> Top() TopRight().Y() -> Top() BottomLeft().Y() -> Bottom() BottomRight().Y() -> Bottom() Change-Id: I5050f619bf92cfc59b6f8dfe7c9f98ef1453c294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27tdf#138590 use the highlighted menu entry, not the combobox active textCaolán McNamara
Change-Id: I2fb68c1491d129d5fd9b963ae4db1fb83171a154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26fix gtk warning about missing 'weight' propertyCaolán McNamara
Change-Id: Ifada66e27955c23eefb41852204fd99f6711a7bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109962 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26move the label width matching into sourceCaolán McNamara
as mentioned in https://gerrit.libreoffice.org/c/core/+/109308 "tdf#119931 Fix accessibility warnings" so the .ui itself is clean and make this an explicit effort Change-Id: I782f79f8e3e022c86d860c946ec1426f26f57990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26tdf#119931 Fix accessibility warningsshubham656
Change-Id: I5d3e30fdb14e3753d52355eaaf60cd671b907a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109308 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26loplugin:passstuffbyrefNoel
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25avoid some ref-countingNoel Grandin
can just return a pointer here, instead of VclPtr. Change-Id: I9ab8962cbbe84ed4dfcfd658a6d758112914cb89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25tdf#119931 Fix accessibility warningsdiwanshu885
Change-Id: I21afac5d1a42073cd67b794a19d7ce7890ed61e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-24tdf#139136 Style Inspector: "true" and "false" now localizableshivam-51
Change-Id: Ib223e941ca4285a0eeae9127edc161311f56aa36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109709 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-24similar to tdf#139774 for a combobox sx10601 is probably a better choiceCaolán McNamara
see extensions/inc/bitmaps.hlst and framework/inc/bitmaps.hlst for the two similar cases which use sx10601 too Change-Id: If44c0dcdbabc83cf35e9c1320c20aac9fdb68523 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-24SdrMarkView::SetMarkHandles Merge identical if'sDr. David Alan Gilbert
Two neighbouring if's spotted by cppcheck with identical conditions; squash. Change-Id: I0b8822991564b994a9c908b28dcf3f2636bb68be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-24SvxLanguageBox::SetLanguageList Merge if'sDr. David Alan Gilbert
Cppcheck noticed a run of 3 if's with the same condition next to each other; they're fall out of e54d65dea830c which simplified the conditions to all be the same. Squash them. Change-Id: I5f0b928b9a629dc43cc62cc03ab6ced2a4b42b2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-24Use ContainerType().swap and avoid local variablesMike Kaganski
Change-Id: I773555180758a97aff37f9bc27de83c355d71521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-22tdf#135550 ListBox should triger an event when changed non-interactivelyCaolán McNamara
not just when changed by the user Change-Id: If2238341ff8465fee6375dad1ea9b4d7ec0110e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22tdf#139590 Drag and drop doesn't work in SdrObjEditViewCaolán McNamara
Change-Id: Id8deeee0c1a919f330bc6623f708453279a214c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21avmedia: add doc model for bitmap fill of slide narrationsMiklos Vajna
This allows specifying a custom bitmap for a media shape. It's mostly useful for audio-only streams where the additional bitmap may be e.g. a speaker icon to indicate this a narration. Change-Id: I21c1b492ac09b631cf6e3ec8120be8b82c01c26d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109763 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara
the gtk default is left aligned, change the vcl one to match and drop the deprecated and unnecessary [x|y]align Unfortunately on load glade's inline preview shows centered alignment, though its "true" preview tool shows left alignment and unsetting and resetting draw-indicator will update the preview to show the alignment which will be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502 See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my stab at making glade do the right thing. Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21_yes -> _YesCaolán McNamara
Change-Id: Ie85ea2b8a2620d0a62f39b39ebbb2ac41ab85d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-20Fix typosAndrea Gelmini
Change-Id: I8bab3efcd63c0f950bc3176e0d26cc896d601083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109559 Tested-by: Jenkins Reviewed-by: Dante DM <dante19031999@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-19Resolves: tdf#135617 grab focus to widget matching the line spacing stateCaolán McNamara
instead of leaving it at the first widget in the popup Change-Id: I0bc4c72f7972e339cd28cd6368a4784cdb11275f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-12 08:13:27 +0000