summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2024-12-02svx: prefix members of E3dSphereObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: If10c0d7a40536f27fb18f7624c91092471d45996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177651 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-02tdf#161341 show/hide controls/shapes/pictures in view/printOliver Specht
Controls/shapes and images/objects have a display option in tools/options/ Writer/View and in print dialog there is "Form controls" and "Images and other graphic objects". With this change the options will actually be applied again. Change-Id: I52389a8519d863792a7cd126a95a389c90c05a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171905 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30tdf#164101: avoid incorrect OLE object scaling during loadingMike Kaganski
Use an internal property for that, alowing to pass the option from the import site to SdrOle2Obj::AddOwnLightClient. Maybe there is some more proper way to do this, but I couldn't find it. Change-Id: I74c881c5c35689a7b58d44d8d65c1010d202c98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177586 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-30tdf#130857 Search dialog: Use weld::Container ptr instead of BoxMichael Weghorn
None of the weld::Box methods are used, so having a pointer to the weld::Container subclass is sufficient in the "Find and Replace" dialog implementation. Change-Id: I1219dd657ab8fb6067c90aabdc27b2b84c0a1443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177577 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29fix various getSelectedItemPos implementationsNoel Grandin
clearly we do not often have combobox's that have nothing selected, otherwise these issues would have arisen sooner. The immediate cause of fixing this was the assert VCLXListBox::getSelectedItemPos which was triggered when using X-ray to examine a writer document Change-Id: Ia5ec713ef54a841010a9b680d4520f7160d48167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177532 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-29tdf#163989 a11y: Avoid "showing" event on empty notification labelMichael Weghorn
The label in the search bar has a notification a11y role in order for the text (like "Search key not found") to be announced when screen readers receive an event indicating that the notification became visible (an object:state-changed:showing event for AT-SPI on Linux). However, commit 48ba98a51f029cd14b5d982dab36eb581d40fef3 Date: Wed Nov 29 14:29:57 2023 +0100 Resolves tdf#158412 - Don't show chevron in quick find bar caused this event to be triggered also when the label has no text, which resulted in Orca just saying "Notification", without any indication what that notification might be. Avoid that by not setting the label to hidden at the beginning of LabelItemWindow::set_label if the label text is empty, so setting it to visible again doesn't have any effect if it's already visible when the method gets called. An alternative might be to switch to using dedicated notification events instead of using a label with a notification a11y role, now that that kind of event is available in AT-SPI2 since at-spi2-core-commit [1] commit 26835da29918be2c0da6c08fb70d893de22891d2 Author: Mike Gorse <mgorse@suse.com> Date: Thu Aug 4 12:38:27 2022 -0500 Add an "announcement" event/signal to allow objects to send notifications Fixes #63 [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/26835da29918be2c0da6c08fb70d893de22891d2 Change-Id: Ia4fbf9544f72e10c74e92487619222d59f55cfa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177523 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29tdf#164048 sw a11y: improve error/warning levels withBalazs Varga
adding two A11y issue level: Error and warning level, and categorizing our accesibility issues based on how the PAC 2024 tools and WCAG behave with the different warnings/errors. Change-Id: If4e4800497340318bb990326c64de655f24a47e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-29lok: jsdialog: enable font name box after saveSzymon Kłos
When we save - we block UI. In the lok we disable that for some cases like in commit e005690e9c648ce516c1ed60da6341c7215bf2c9 lok: avoid sending jsdialog messages during background save. But we also use save file to generate previews of shapes what happens on eg. resize in Online. Then we trigger disable and enable cycle for frames - and we end with FontNameBox enabled! That was causing the JSDialog combobox still being locked - because frame unlock was using direct VCL API, not weld:: one in the InterimItemWindow. Let's fix that with proper StateChanged handling. So now it is functional. But still I think there is some error in the logic - as after save we should beg the "before save" state of control not "always enabled". But it's different problem. Change-Id: Ia8e5c8c864156271b5f68d482234e83eb57b0deb (cherry picked from commit cbe229ec219e56ce1bb5dd9598f9052a98504249) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177489 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28svx: Simplify "Go to Page" dialog, let SpinButton do its jobMichael Weghorn
Set the allowed range using weld::SpinButton::set_range so that weld::SpinButton makes sure that a value within the correct range is set, instead of having a custom handler called when the text of the spinbutton changes that effectively does the same thing (+ manually setting cursor to the end of the edit, but sticking to the toolkit default there instead makes sense to me for consistency). Adjust the test case to no longer type invalid input for the page number ("3a"), as SalInstanceSpinButton doesn't parse the number then, but would set the value to the minimum (here: 1) instead. (If a different behavior were intended here, that should be implemented in SalInstanceSpinButton or the underlying VCL widgets to be consistent across dialogs.) In GotoPageDlg::GetPageSelection, use weld::SpinButton::get_value to get the integer value right away, instead of getting the text and converting that into an integer manually. All that custom handling provided an interesting test case while implementing support for that dialog using native Qt widgets, see commits up to commit 70825e677f808437bd47651ebecc8a0c53955676 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 28 00:30:10 2024 +0100 tdf#130857 qt weld: Notify about spinbox combined value+text change , but apart from that (which is done now), I think that a more standard approach makes more sense. Change-Id: I06492b6629a4210c6325d50467da8e195daa4c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177463 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-27tdf#130857 gotopagedialog.ui: Resave with glade 3.40Michael Weghorn
This is the .ui file for the "Edit" -> "Go to page" dialog in Writer. This luckily also moves the "page_value" GtkAdjustment to the top of the file, which (at least for now, in order to support that dialog) avoids the need to extend QtBuilder to implement handling of GtkAdjustments that are referenced in the .ui file before they are defined. (If it's still needed in the future, extracting some of the current logic from VclBuilder into the BuilderBase or WidgetBuilder base classes for reuse also by QtBuilder might be an idea.) Change-Id: Ic03acc1d514d412cd609543754829a370a5678e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177434 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-27tdf#94147 svx a11y: Honor animation setting in OverlayRectangleMichael Weghorn
Base the decision to disable animation of the overlay rectangle on whether animations are disabled (either explicitly in LibreOffice itself or when LibreOffice uses the default value of "System" for animations and animations are disabled in the OS/desktop environment) instead of on the fact whether or not high contrast mode is enabled. This is the same criterion as used for Calc's "marching ants" animation, see commit ef7429f86788f0616db5b274ec77eb67cd41cb3d Date: Mon Jul 29 11:36:29 2024 +0200 tdf#161765, tdf#115688 Let user choose which animation settings to use Change-Id: If14b05006b1b04be9c2da9089dfbfbca70e88f79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177417 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-27PVS: V560 A part of conditional expression is always true: bRotate90Xisco Fauli
Since commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: Ie2aeabafb1ff2a73b1c8cb90ee1a4d03a7482ab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177410 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-25svx: prefix members of SdrDragMoveMiklos Vajna
See tdf#94879 for motivation. Change-Id: I4945cec5ee88700360c5a8ff706105dbc7f95f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177229 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23Use specific SvtModuleOptions::Is*Installed for clarityMike Kaganski
Change-Id: Ibe64b9fcccf33471d96bb0fb1aa896cb456657f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177069 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-22loplugin:methodcyclesNoel Grandin
found cycle FmEntryData::FmEntryData(const FmEntryData &) svx/source/inc/fmexpl.hxx:148 FmFormData::FmFormData(const FmFormData &) svx/source/inc/fmexpl.hxx:230 FmControlData::FmControlData(const FmControlData &) svx/source/inc/fmexpl.hxx:252 std::unique_ptr<FmEntryData> FmEntryData::Clone() svx/source/inc/fmexpl.hxx:161 Change-Id: I2bef463f62b4513c473bb99eb999a97e99f5e602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176993 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-22PVS: V560 A part of conditional expression is always trueXisco Fauli
!aTempContentText.empty(). Change-Id: If61fc09e7e19786ee055b78442b69f0147c8da75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176998 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22tdf#163598 editeng: avoid using fake outline depthJustin Luth
Most implementations do not actually do anything meaningful with Get/SetDepth, so don't exception or accept their values. To fix the bug, I could have just checked for dynamic_cast<SvxEditEngineForwarder*> (since it supports EE_PARA_OUTLLEVEL directly) but this way seemed more encompassing. The potential downside is that EE_PARA_OUTLLEVEL will be requested as a real property after GetPropertyValueHelper with some of these dummy providers, and who knows what UNO might do about that... IF this patch causes problems, then I need to implement Get/SetDepth in SvxEditEngineForwarder (or consider the dummy providers as SupportsOutlineDepth). Change-Id: I74bf5e39a13bb1d588c39634347eb0982bda66b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176981 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-21remove OutDevSupportType::TransparentRectNoel Grandin
all our backends support transparency, and have some time, XRender support became mandatory a couple of years ago. Change-Id: Ie2db7e4665068fe88a926e9791d74a82c2e75834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-20Resolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-11-19tdf#163486: PVS: variable is used after it was movedXisco Fauli
Since commit 9fe2ead3d5355224dd94d6462b0ddc6100f6d4e3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Oct 8 06:43:18 2021 +0200 loplugin:moveparam in svx V1030 The 'aSdrObjects' variable is used after it was moved. Change-Id: I9b426204ff2e2e2d0f6b375e201259765aa12736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-19tdf#160084 Simplify comparison for basegfx::fToolsBogdan Buzea
Change-Id: I6ae56ad61ceec5bc34898befd636a0ceae8266e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176700 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-19svx: unused returnXisco Fauli
Change-Id: If747870121e3fc8c2d97b5fc769b2d928a4c3f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176777 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-19svx: prefix members of SvxB3DVectorItemMiklos Vajna
See tdf#94879 for motivation. Change-Id: I74c53028d9966ca4059c7a145b3fb0d914d8ae77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176770 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-19tdf#160267 Fix SVG and add PNG format from the clipboardOliver Specht
Since 6c04b8356c0764ba8ac51448eee5ff577b08d9e2 SVG was added to the supported clipboard formats but it did not work. SVG support is now fixed and PNG format is added in the gallery. Change-Id: Ic9cb2eebfc37bd38605dfaa3a1c353a7532af357 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165908 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-18cid#1606638 silence Overflowed integer argumentCaolán McNamara
and cid#1608572 Overflowed integer argument cid#1607772 Overflowed integer argument cid#1607196 Overflowed integer argument cid#1606568 Overflowed return value cid#1607573 Overflowed return value Change-Id: I9a701b19026572127399712c3b660094f2a0bd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176740 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-15render master and slide content separately (drawinglayer render)Miklos Vajna
This renders master and the main slide as 2 separate layers, which is useful because in a huge slideshow we can reuse the master slide and only render the rest of the slide, which should be more compact in size as the master slide is the one that usually contains the (complex) background. Change-Id: I5e86d718b7ab3b03bd0b6146ce4df218a4dd72d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176622 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-14tdf#36709 GUI changes for font-relative first-line indentJonathan Clark
This change includes GUI element changes to support viewing and editing first-line indent values with font-relative units in the paragraph style dialog. Change-Id: I72ada2565f51d70475eb17096a1317be9316b770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176595 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-11-14tdf#163486: PVS: Expression is always trueXisco Fauli
V560 A part of conditional expression is always true: mpPage. Change-Id: If132fa2d5116ec3517846e026bfd3f76ef2cd9a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176591 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-14svx: fix typoXisco Fauli
Change-Id: If344ad16098d8bb1549108700d40a7dff65debb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176590 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-14tdf#163486: PVS: container is emptyXisco Fauli
Since commit ecd615ab32fcacf8f8116672ebe631d1db72cb4e Author: Armin Le Grand (Allotropia) <Armin.Le.Grand@me.com> Date: Thu Nov 18 18:06:39 2021 +0100 VCL implement GetGlyphOutline fallback V557 The 'aDXArry' container is empty, the access to its elements is impossible. Change-Id: Ib67bbbf21f215bc27aa03b1a61dd7195c93e5311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176589 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-14tdf#163486: PVS: Expression is always trueXisco Fauli
V560 A part of conditional expression is always true: pView. Change-Id: I6c01996c66a0c1488080da532734c3c05820337d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176581 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-14tdf#163486: PVS: Expression is always trueXisco Fauli
V560 A part of conditional expression is always true: pV != nullptr. Change-Id: I4af6361993f3b172c54479e1011358c37fcde64b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176580 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-14Improve loplugin:dyncastvisibility to check for non-inline key functionsStephan Bergmann
This would have caught the issue discussed in 709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique RTTI". (The commit message talks about RTTI there, while what Clang actually compared for an optimized implementation of a dynamic_cast to a final class is vtable pointers, but the overall picture remains the same. Both RTTI and vtables are emitted along the key function, and if that is missing or inline, they are emitted for each dynamic library individually, and as internal symbols on macOS.) This commit also addresses all the issues found by the improved loplugin:dyncastvisibility on Linux. See the newly added TODO in compilerplugins/clang/dyncastvisibility.cxx and 86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function" for an issue with key functions for class template instantiations. Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-13svx: use a reference hereXisco Fauli
Change-Id: Ic92f640f79c8d1185be422eefaa61601eae9ae8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176555 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-13tdf#36709 editeng: Layout for font-relative first-line indentJonathan Clark
This change extends layout for font-relative paragraph first-line indentation into Edit Engine. Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#163486: PVS: variable was assigned the same valueXisco Fauli
V1048 The 'y' variable was assigned the same value. V1048 The 'x' variable was assigned the same value. Change-Id: I691b6f2c108dae48cf28d328f502847b8f6726f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176526 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-12loplugin:reftotemp in svxNoel Grandin
Change-Id: Ie5f9a7f0e6903476bd02391a71c1f3d75afaf09f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12tdf#157467 SvxPresetListBox: contextmenu must affect item under mouseJustin Luth
Yikes - especially when delete is involved. Previously it was deleting the in-use background, regardless of where the mouse right-click happened. You might wonder why not just query GetHighlightedItemId? That is because (at least for GTK) the highlightedItem is zero'd out as soon as the pop-up starts, i.e. when the mouse is moved over top of the context menu. Change-Id: Ib88cb0edb8c2c8f854c35821d8125a1991d12a55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176447 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-12Simplify a bitMike Kaganski
Change-Id: I970ae0afd01ceb4651c0e7bc722ac43b4e9aa0b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176469 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-12tdf#163486: PVS: simplify while loopXisco Fauli
V654 The condition of loop is always true. Change-Id: I9c7cc133cf197e899ac7e13ee3cedc97b7c4d0be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176406 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in svxNoel Grandin
Change-Id: I80bdcae1db64f7693600178d86c122c5875369b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-11svx: prefix members of E3dSceneMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ia235f420f9ae00ad25be4ca2c06ee942ffc3e6e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176369 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-10com::sun::star -> cssMike Kaganski
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-09cid#1607142 Overflowed constantCaolán McNamara
Change-Id: I840fbf1b472dbf0a41dc9032e4e75839dec8dc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08cid#1620539 Check of thread-shared field evades lock acquisitionCaolán McNamara
Change-Id: Ifd0008d8258b7fe9e72d40ae0384ff9f5e538190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-21 21:11:20 +0000