summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-06-10uitest: Add support for Calc / Format cell / background color selectorShiko
- Add wrapper for the color-win set - Add the factory function in the correct class - Add a demo for cell background color and recent color selector - Extend the ability of ComboBoxUIObject to be able to select with text Change-Id: Ie84ba7fff2f84c3fec7f5adbb5b1cdc6c80729f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95667 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-06-10sd signature line: set graphic of signature shapeMiklos Vajna
All placeholders are replaced, but the template is still English-only. Change-Id: Ia361447ff0a69fa0f80db4af07274d1a764a3d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95991 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMichael Warner
Change-Id: Id747848b222f69af3293a2095a62542f1e1116d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95215 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-09sd signature line: select certificate after drawing the shape's rectangleMiklos Vajna
Also move the shape-type-specific setup to FuConstructRectangle::SetAttributes() where the rest of the shape types are handled. Change-Id: I9ecf94957ec82ba187f2767b01d96fb14de2b657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95958 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09sd doc model xml dump: show grab-bag of shapeMiklos Vajna
Which is contained directly for some reason, not inside mpProperties. Change-Id: I0f7d2d5afbeae2d399710d5ce271f3ad4ab9866d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95913 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09tdf#126025: Non-const GetPropertyValueByName must use non-const Sequence []Stephan Bergmann
...which internally calls getArray to make sure it references a unique sequence. Regression introduced with 85f28ec44a2c169c91dac9346e9c71feda6a6cab "Clean up C- style casts from pointers to void". Change-Id: Id80b75f06322c65fc31040cc0b1892fe3a0aeaab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-08sd signature line: extract part of signature line UI from cui to svxMiklos Vajna
So the "sign existing pdf" code in sd can reuse that. Change-Id: If51fae203ed0c68ed8e5e63368e60ae1c705bade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95841 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-08svx: fix loplugin:elidestringvar warningMiklos Vajna
Change-Id: I5424388dfc37988b2f4e5f8f34dcb1a577d9bfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95806 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-08tdf#103474 handle quarter angles before using atan2Regina Henschel
sin(basegfx::deg2rad(fEAngleDeg)) does not result in 0 for fEAngleDeg=180 because of rounding errors and therefore atan2 later in the code gives wrong angle. Because the corresponding circle angle is the same as the ellipse angle for 0°, 90°, 180° and 270°, these angles are now handled before using atan2. Change-Id: Iae2a4d188b837ff787f2af4d79f874ba21c9aa2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95772 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-06-06Fix context moreoptions (svx/tablewindow)Julien Nabet
Change-Id: I730fa4295f8515280d3e179350da4c06649b0854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Upcoming loplugin:elidestringvar: svxStephan Bergmann
Change-Id: Ia7b4f69361b6cc29f6e5c0093b13cf0b48e25ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95576 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Update ShadowPrimitive2D to support shadow blurA_GAN
Add attribute for the blur radius and get function. give more range for the shadow depends on the size of the blur radius. update the blur radius to be imported in Hmm and the test function. Change-Id: I32faaf02884d9a6b2f11a9033178b3b6bb419580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95388 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04loplugin:simplifypointertobool improve (2)Noel Grandin
to look for the x.get() == null pattern, which can be simplified to !x Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03pdfium: only init pdfium library one and destroy on LO exitTomaž Vajngerl
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95391 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02OOXML support for shadow blurA_GAN
Add a new property for the blur radius and define an ID for it to support the import of OOX files. Add a test for importing the blur radius from PPTX file Change-Id: Iffaa33ff7159019ce9478cee558622bd61bcf60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95090 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02svx: add ability to show sub-selections in a marked objectTomaž Vajngerl
Draws selection rectangles inside the object window. Change-Id: I994477426489ea4cea89c86f9e51c9978f16b350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95347 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02Use "Radius" instead of "Rad" for new propertiesTomaž Vajngerl
Change-Id: Ifd232bccf1519e0ed68195cf4344893175a675e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95331 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02Removed executable permission on graphic filesAndrea Gelmini
Change-Id: I47099bd08e73ef726be60b740c4b72220cb7fc6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95362 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-02Removed the "Font.." things from the InspectorShivam Kumar Singh
Removed all the font related stuff and added a common property listing box for the 'Character' Properties. Another patch coming up for 'Paragraph' properties. Change-Id: I71de4d4fe6536f49e0e700c850e2e714287c5e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95228 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-02lok: add "Remove" param to .uno:ChangeTabStopTomaž Vajngerl
Change-Id: Ic6b71c0bb6177eb10f5be4197d77c5db5f5884a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02inline some use-once typedefsNoel Grandin
Change-Id: I335e0c5cf7944efa487e4535a9e6a5baab2f36dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-02svx: convert ImplMarkingOverlay and friends to use unique_ptrTomaž Vajngerl
Change-Id: I19ba9e93f2804fded237b760a28f3ce62e4b2c5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-01svx:unit tests for adding, acquiring, counting objects into gallery themeAditya
Change-Id: I256c6658a4257bc5bf8793153021efccef47bad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94646 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-01tdf#133547 Fix breaking of PDF graphic objectsTomaž Vajngerl
ImpSdrPdfImport did not handle -1 as the page number correctly. When the page number is -1 it means it was never explicitly set and should be treated as page with index 0 most of the time. So instead of allowing -1 as the page index, return it as 0 already in Graphic (VectorGraphicData). Change-Id: I3813f3ceeb5e41cb06fc40d67297d2439d7f3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95227 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-31Revert "tdf#88985 block app from exiting during macro execution"Jan-Marek Glogowski
This isn't needed anymore with the fixes for tdf#127205. Reverts commit 68cf256f506d4601a2d2cf3ec2d56713afd491e6. Change-Id: I1a7944632af8330f68d451d2c293143233039b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88837 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-05-30loplugin:simplifybool extend to expression like !(a < b || c > d)Noel Grandin
mostly to catch stuff from the flatten work, but I think this looks good in general Change-Id: I7be5b7bcf1f3d9f980c748ba20793965cef957e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-29Add blur attributies and definitons into shadow classes and properitiesA_GAN
Change-Id: I365f4bcfc8d772ea77cec1e4ce139b9fc16d9d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95000 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-28Resolves: tdf#133411 drop CONTENT_FLOWS_TO from dialog to search resultsCaolán McNamara
in the document, looks like only the calc one actually works, and when it works on large quantities of results calc grinds to a complete halt This was introduced with: commit b41332475783c31136673fb44cf4c411bb0148f8 Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 and has been a problem on and off with calc's potentially ~infinite grid There is the on-by-default search results dialog in calc (which has a limit on how many it shows) which provides an alternative route to iterate through the results Change-Id: I2685e480d2d15220be0bddbc83baad3992e7d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-28Related: tdf#133411 SetDocWin is using the previous search success stateCaolán McNamara
not the new state The order of calls probably didn't matter in the past where the use of the flag was deferred until the Accessibility data was queried which would happen in another event loop. This makes it more clear that it appears that only calc actually does anything productive here. I think this flow-to has created more trouble that its worth and I'll remove it but if we need to restore it, then this, I think, it the working state to restore to. Change-Id: Id6fbb483c081f6d5142100d70c1b29705dcb6452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26reduce dynamic_cast usage in an O(N^2) algorithmLuboš Luňák
When scrolling down in tdf#130431 this is the major CPU cost. Move the dynamic_cast out of the loops as much as possible. Change-Id: I0ea9f457bb17fbdde880f09b059f07dec4b1790b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94858 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-26tdf#49247, tdf#101181: gtk needs "upper", otherwise the control is disabledMike Kaganski
Change-Id: I3a3204ab0ad2376ee88adca5935813e241e6a049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-25svx:unit tests for theme count, gallery theme entry functions in galleryAditya
Change-Id: I7ff7f6f5607348e8ff135614d7de1957741a11fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93305 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-24inline some use-once typedefsNoel Grandin
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-24tdf#101181: drop useless "GlowEffect" boolean propertyMike Kaganski
Just use GlowEffectRad to indicate effect presense: radius of 0 means effect is disabled. Change-Id: Ic06bba34f5a851f120d3d00cb7e20c429ead9ee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94732 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-23svx: move LOKit specifics out of SetMarkHandles into own methodTomaž Vajngerl
The SdrMarkView::SetMarkHandles method is too big because it also hosts the LOKit sending of callbacks, so move that into it's own method. Would be a good idea to split even more and move into own class in a future commit. Change-Id: I7e6389bfa98f22c44863c6eddc840692a7f22605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94728 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22tdf#41995: sxx: ODF export: save SVG to ODF 1.2 as wellMichael Stahl
... and SVM into ODF 1.2 Extended (compatibility mode). Change-Id: I2056ddac40570fdf69178349ff546cd313709b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94575 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-21split out labelitemwindowCaolán McNamara
Change-Id: If5121b58538708a47783aee099bc426408989cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21FmXListBoxCell doesn't need to implement css::awt::XListBoxCaolán McNamara
FmXListBoxCell implements css::awt::XListBox but none of that functionality is needed locally where it is used to pick a value in a cell when edited interactively. As an XInterface a FmXListBoxCell does fall into the script::XEventAttacherManager attach/detach sink-hole so its very difficult to determine if it (and any of its siblings) really need to implement the amount of uno interfaces they actually implement, so this is a little speculative. See https://ask.libreoffice.org/en/question/152691/how-to-populate-combo-box-within-table-control-in-form/ for an example of the ComboBox interaction case which is similar to this ListBox case. The exotic "multiselection" option definitely isn't shown as an option in the property browser for a listbox column in the table control. Change-Id: I7bdc351e615c9df708a30e4396f6f352fabaed36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21weld ListBoxControlCaolán McNamara
Change-Id: I5a8c7d68e4c147eb938b0217dc6368c832e465c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20remove commented codeTomaž Vajngerl
Change-Id: Ief714e8905f9e79da8457bb33ce84b8f6d6bd30e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94602 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20weld ComboBoxControlCaolán McNamara
Change-Id: Ie862bb782b4c3e203af88d45c850ce0cab60f2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-19oox, svx, sw, xmlsecurity: clang-format these filesMiklos Vajna
I added these files more or less recently and they have long lines. Use clang-format to break at a sane column limit. Change-Id: Id4ef832e4843fc81f4a497385e49ccb835a7197f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94503 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-18Added a new tab "Styles Inspector" at the side barShivam Kumar Singh
Patch significance :- 1) Added a new tab "Styles Inspector" at the side bar 2) Added the "Character Styles" properties in the inspector Change-Id: I717f0a555d9c90f833c61b641c8eba53f93d4655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-16Resolves tdf#132852 - Area fill dialog spacingHeiko Tietze
WB_ITEMBORDER added to the widget style Change-Id: Ica898d3f23a7973bd002c3fcf52302b42cb0f269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94237 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-15Resolves: tdf#132461 set color on mouse release, not pressCaolán McNamara
and rearrange to allow dnd to drop the currently selected color, not the one seen by SelectHdl which is now called on mouse release which allows the dnd from color bar to gradiant tool to work as expected Change-Id: Ib54850ff8f73dc3a0d08c76060309a7a74d2cc8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-03 04:37:01 +0000