summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2016-02-12tdf#95857 Sort out German plurals ...danielt998
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-12GetActiveAccessibleCell: remove recently obsoleted IF clauseJustin Luth
Follow-up to commit 1fda8bf08123b521d9ad77eb542d7d1a3c63f54a The recently added ELSE component is more inclusive than the IF component, so there is no longer any need to check if a cell IsTextEditActive(). As long as the cell is active in any way, it will be returned. Change-Id: I92cf2a231db1e1457f81a2ef77811ed40078e647 Reviewed-on: https://gerrit.libreoffice.org/22262 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2016-02-12tdf#82396:Incorrect behavior on update of Size values in sidebarRishabh
Added limits for Width and Height Change-Id: I2aa80c86aeca826009b4594e5e9a0d5ed7f67ef9 Reviewed-on: https://gerrit.libreoffice.org/22274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-02-11Simplify ChildrenManagerStephan Bergmann
Change-Id: I43762aa8b572651676d8cac4848d4c6d478cf850
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-10vcl: move CommandEvent functions from header to cxx fileChris Sherlock
Moving functions from commandevent.hxx to commandevent.cxx, this means they are no longer inline, but there was no clear reason as to why they were inline in the first place! I've also reordered the header to ensure that CommandEvent is the first fully declared class, the data classes get declared after this (hence the forward declarations). This makes reading this header much easier. One more small thing: a few if statements had braces in the primary if block, but not in the else block, which is IMO bad style and can possibly lead to errors. I've made the else block use braces. Change-Id: I79b010bd66d3c9f4a74d4fa470f62d0263c811f4
2016-02-09Use rtl::Reference<CppType> instead of HardCppRef<UnoType,CppType>Stephan Bergmann
Change-Id: I089b5caca5e05726105f78aeb00db1869d0a17f4
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08tdf#96685 - set focus of accessible table cellsJustin Luth
Newly created accessible cells were not inheriting the focus setting of their peer. Also, IsTextEditActive was way too strict to determine whether a table cell was active or not. Typed text with the cursor in the cell was not enough to mark the cell as active for example. Finally, accessible nodes were not being created as additional cells gained focus for the first time. Change-Id: I5be4b1d660f01fc4de7281a319895a2c73e74c48 Reviewed-on: https://gerrit.libreoffice.org/21121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2016-02-08remove unused HelpText attribute from *.sdi filesNoel Grandin
Change-Id: I21bcf66c552cd38eaae1bdc85626aa9bd1782ebd
2016-02-08remove unnecessary module GUIDs in *.sdi filesNoel Grandin
Change-Id: I78784abc1031027d69bbe31d150bc78c8bfbfcf4
2016-02-08svx: SdrModel::mbTiledRendering is never readMiklos Vajna
Change-Id: I8571032b5c43a47872cb3364613ffb936624aa2d
2016-02-08remove some unnecessary declarations from *.sdi fileNoel Grandin
found with a bunch of grepping Change-Id: I920609fb7df5a5e55ecbf5c2bf4880ff972cfbed
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-05remove unnecessary comments from .SDI filesNoel Grandin
Change-Id: Ic78ae8ce5bf396f55fdc847d6b70476c9dab4ee9
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05remove commented out stuff from .SDI filesNoel Grandin
Change-Id: I1e893afcd33bf9a5cf934a021fe40548ddc33699
2016-02-05remove unused UUID and VERSION from .SDI filesNoel Grandin
Change-Id: Ieb3e47c10c497a6f642f28a6741ac0fd2ecfd419
2016-02-05remove unused Readonly from .SDI filesNoel Grandin
Change-Id: I179200ad65492c517ef5e986fd05758896d38813
2016-02-05remove unused Automation from .SDI filesNoel Grandin
Change-Id: I65e1ca6e022dc76ac96ed75da2c5e78e9356a3e9 Reviewed-on: https://gerrit.libreoffice.org/22107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04svx: replace boost::bind with C++11 lambdaMichael Stahl
Change-Id: I68f9559fab9a344979dc39b81f3738877483b5fe Reviewed-on: https://gerrit.libreoffice.org/22106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-04remove unused GET/SET/STATUSBARCONFIG in .SDI filesNoel Grandin
Change-Id: I74404d72e9146950a9881d2a59323c2bf08c9742 Reviewed-on: https://gerrit.libreoffice.org/22100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused RecordManual from SDI filesNoel Grandin
Change-Id: Ia6af0d00b68f5694c9fc9cc453fe36fb923f0a2d Reviewed-on: https://gerrit.libreoffice.org/22099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused HasDialog from SDI filesNoel Grandin
Change-Id: I26f2cef48fcc7a6c4a6b93668b836879254f3eb0 Reviewed-on: https://gerrit.libreoffice.org/22098 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused Synchron from SDI filesNoel Grandin
Change-Id: I0b8c63a97bfa4a49ac87869e164ab22d2aa99de3 Reviewed-on: https://gerrit.libreoffice.org/22097 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused Cachable keyword from SDI filesNoel Grandin
Change-Id: I60c423b799f34f79f58bc39cf7ea616ec4f5d16a Reviewed-on: https://gerrit.libreoffice.org/22096 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-03remove unused HasCoreId from SDI filesNoel Grandin
Change-Id: I4aca4b8a79ce92d64ce004ccdb7e9a0f408dc768
2016-02-03svx: can now do nAnz -> nCount without name clashesMiklos Vajna
Change-Id: Ifc884a44008de0a34c056348321e5344ab2cb1f1
2016-02-02remove B2DLineJoin::MiddleCaolán McNamara
and consistently map css::drawing::LineJoint_MIDDLE to the same thing that css::drawing::LineJoint_MITRE points to everywhere else Change-Id: I77b7586ea13f3fe84c0529172758256666488d36
2016-02-02tdf#84843 Stop using PseudoSlots for drawing slotsMaxim Monastirsky
Instead of fighting with this obsolete thing, let's just kill it. This fixes disabling in read-only doc, as well as pressed/unpressed states. Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115 Reviewed-on: https://gerrit.libreoffice.org/22010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02svx: prefix members of SvdProgressInfoMiklos Vajna
Change-Id: I23fa86080c001d3a78c3b7d7c49274f01444d9be
2016-02-01svx: nAnz -> nObjCountMiklos Vajna
Change-Id: I5d7f50d52aac9b1333828db1571163d7d5a624c4
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-30svx: PntAnz -> PointCountMiklos Vajna
Change-Id: I56ccaf5a78071a132c172e3946514624afe9dd80
2016-01-30tdf#91762: Check wether the row and the cell have text...Xisco Fauli
... in order to set the row's min height Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c After this commit, the row's min height was set based only on the cells containing text in the row, but the problem appeared when the row didn't have any cell with text. Change logic to check wether there's text in the cell and in the row. Now, height in SdImportTest::testRowHeight() is 507 instead of 508 but I can't figure it out why. However, I believe there's no harm in change the test from 508 to 507 as, visually speaking, the difference can't be distinguish. Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce Reviewed-on: https://gerrit.libreoffice.org/21692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-28Resolves: tdf#96580 Sequence::get doesn't return the start of the dataCaolán McNamara
it returns the start of the underlying uno_Sequence commit 78c83032b266fbb6fc20ddca86df80affaff7c24 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Sep 30 09:40:16 2015 +0100 maSvgDataArray only populates a uno::Sequence, so use that instead Change-Id: I335d5ee70e95e1a3b204d34f6df4cb62f3fb3cad Change-Id: I8d2c07fec039e58d3644e4ab5eb074ee215f075e
2016-01-28loplugin:fpcomparison in svx/Noel Grandin
Change-Id: I636dcdd51389f31eeb14cd1eb9a82a89599d3eea Reviewed-on: https://gerrit.libreoffice.org/21777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-27Resolves: rhbz#1301346 crash with null ObjListCaolán McNamara
Change-Id: Ia9446b06087907a2d9d1889ba7d4ccd1f78697d9
2016-01-26Resolves: tdf#97276 don't clip out line if the underlying page size is unknownCaolán McNamara
Change-Id: I77d88d8020e9ac26bd6b7277e6d8afefed5e3ee7
2016-01-25Make Position and Size sidebar tab visible when a line is selectedRishabh
Regression bug introduced by - https://gerrit.libreoffice.org/#/c/16165/ and removal of obsolete writer code. Change-Id: I8ab2e0c04b5c90fafdb43f34899053df7bd7fb4e Reviewed-on: https://gerrit.libreoffice.org/21739 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-01-25svx: SdrEdgeLineDeltaAnzItem -> SdrEdgeLineDeltaCountItemMiklos Vajna
Change-Id: I91791a3ea21ca7a68d4d1aa49e29cabc38c777ee