summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2013-03-27coverity#704341 Logically dead codeJulien Nabet
Change-Id: I5a097afe1c582eab023cecadc0b1cc77faf774a1 Reviewed-on: https://gerrit.libreoffice.org/3046 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-03-27coverity#704334/704335/704336 Logically dead codeJulien Nabet
Change-Id: Ieaa3c8ed735692a16c40ff01ea1dec52c2a29f31 Reviewed-on: https://gerrit.libreoffice.org/3045 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-03-27WaE: macro "_STRING_H" is not usedTor Lillqvist
Change-Id: Iabc3ab2d455a768f7af159490e0c26b694c01f34
2013-03-27WaE: macro is not used: _MATH_H weirdnessTor Lillqvist
Change-Id: I283767ba44012a740d49f1b8d9d1f6bf80d8b664
2013-03-27-Wunused-macrosStephan Bergmann
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27_USE_MATH_DEFINES is already taken care of by sal/config.hStephan Bergmann
Change-Id: Ib0dab05534c34eb407f3acee3b4a3638a36bdddc
2013-03-26Resolves fdo#61540K_Karthikeyan
On Insert before, the reference column whose size is going to be used for newly created column(s) is wrong. As the new columns are inserted before the reference column, the reference column moved to the new position by no., of new columns i.e (earlier+newcolumns). Change-Id: Ib52e3633aecb1220cdf709058391361376dc5f00 Reviewed-on: https://gerrit.libreoffice.org/2958 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-03-26sal_Bool to boolTakeshi Abe
Change-Id: I27a444a8313bff276e377ffb87458213f4e19707
2013-03-26Remove useless comments; add mode linesTakeshi Abe
Change-Id: Ib96d394954326a2c8f52ae4a161d9b505dbc35a3
2013-03-26drop external include guardDavid Tardon
Change-Id: I8cac4fef46e745b8256e45e5b40abc3f87128916
2013-03-25coverity#704327 Logically dead codeJulien Nabet
Change-Id: Ied464d57c7895fdf1d9e74e7f89d70bac2834d9e
2013-03-25coverity#704321 Logically dead codeJulien Nabet
Change-Id: Ibcae025319e689d917d6c85f6c0a3bed8315672e
2013-03-25coverity#704320 Logically dead codeJulien Nabet
Change-Id: I12a49d9bdc5503facd6a9a00708b22034b173a7e
2013-03-25sal_Bool to boolTakeshi Abe
Change-Id: Ibc63340b3ae431c7cdac78893dbdd1989ebe5ff9
2013-03-25deleting NULL is safeTakeshi Abe
Change-Id: I3748d0034b2c8e9d9122ad2a9001763eb1265e1d
2013-03-24fdo#62617 display groups on multiple layers correctlyDavid Tardon
It is possible to group objects from different layers, so it is an error to rely on layer ID when checking visibility of a group. This problem was partially obscured by the fact that SdrObjGroup::GetLayer() returns 0 if its subobjects are on different layers and 0 is a valid layer ID. Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
2013-03-24avoid possible data inconsistencyDavid Tardon
GetLayer() is virtual, so it might not be always the same as mnLayerID. Change-Id: Idabf02505678a7150a94498be3bc4ffc20ac56af
2013-03-24drop nonsensical warningDavid Tardon
Change-Id: I3f63268535bf8ed13a4728ed3eb3528193712e6e
2013-03-24fix crash after conversion to STLDavid Tardon
Change-Id: I0a49ce4ddf53eede0f940b392aab20afb5dd2cbe
2013-03-23rhbz#876742 speed up table manipulation in ImpressDavid Tardon
It turns out this is not actually a performance problem but an oversight in implementation (or a bug, if you want .-) Every manipulation with a table (e.g., move, resize; actually even a selection of the table) leads to creation of a full copy of the table (SdrObject::getFullDragClone()). One of the actions the table copy impl. does is to call sdr::CellProperties::SetStyleSheet() on every cell of the new table. CellProperties is derived from sdr::properties::TextProperties and CellProperties::SetStyleSheet() just passes the call to TextProperties::SetStyleSheet(). This is where the trouble begins :-) The SDR representation of a table, SdrTableObj, is derived from SdrTextObj. Because of that, SdrTextObj needs to be able to contain more than one SdrText (because a table needs one for every cell). This is handled correctly by TextProperties. But, because there is no SDR representation of a single cell, CellProperties uses the SdrTableObj as the SDR object it works on. Therefore TextProperties::SetStyleSheet() processes all SdrText objects of the _whole table_, not just a single cell. And this is repeated for every other cell... Change-Id: Iab2e2d0e1e8038710645c0bd24666e6032b0a003
2013-03-23drop unused includesDavid Tardon
Change-Id: I819539b372d33cc8982a01d7bb72093cedb6461f
2013-03-23drop unused member varDavid Tardon
Change-Id: I68004a90cbfdf6bf6c5b09998406a5479e5c50d6
2013-03-23broadcast change if removing NULL pageDavid Tardon
Change-Id: Iacf5e9cc509e29aaf5dd1321407c0de9db7677f3
2013-03-22strg is ctrl in englishThomas Arnhold
Change-Id: I569bfa7c9d461a5af0ef6e6f37bf717255936b78
2013-03-21regenerate pchPeter Foley
Change-Id: Idacefb2e89dc2f8bd44e489b43b47847123476e2
2013-03-21sal_Bool to boolTakeshi Abe
Change-Id: I9bdb9db8b38758117a6bad27a014376806841470
2013-03-20i#78247# and i#78029# wrong glue points in iscosceles and in right triangleRegina Henschel
(cherry picked from commit 26e91b07a559692b4f8acdd04f5bd28d0daa68b3) Change-Id: I504ec85fa7b94a4473905b7e2720b2169c53e6cf
2013-03-20Related to coverity#704822 (Explicit null dereference)Julien Nabet
aSlotIds.push_back(0) => aSlotIds can't be empty => pSlotIds can't be null So no 704822 Change-Id: I52237fcd4f160a294c23307c2e33b515372b3c92 Reviewed-on: https://gerrit.libreoffice.org/2872 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-20Replace String with OUString (unotools)Chr. Rossmanith
Change-Id: I9a0677cb36805d0a27514824c937901f73fee1c8 Reviewed-on: https://gerrit.libreoffice.org/2864 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-20Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)Stephan Bergmann
...which is a confusing overload with unexpectedly different semantics from the one-parameter form. In preparation of marking it as deprecated. Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20Assume that this shall check full string equalityStephan Bergmann
...instead of prefix match as the use of compareToAscii(RTL_CONSTASCII_STRINGPARAM(...)) would imply. Change-Id: Iea78d873bf226665998d7ff67e3cdbbae97d9b38
2013-03-20fdo#46808, Convert a bunch of comphelper::ComponentContext stuffNoel Grandin
.. to Reference<XComponentContext> mostly in the dbaccess module, but it also affected some other modules. Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20fdo#46808, convert some getProcessServiceFactory()Noel Grandin
Change-Id: I3722a54ea173f54f8d8f1e0e654137c6f76d8613
2013-03-20fdo#46808, convert drawing::GraphicExportFilter to new styleNoel Grandin
Change-Id: Icd456209406ee8f4dc4ea1f966058f71dce08d58
2013-03-20fdo#46808, convert graphic::PrimitiveFactory2D to new styleNoel Grandin
The service already existed, it just needed an IDL file Change-Id: I40fb28d94253c3c577655bb888ff0d0ee3ba3822
2013-03-20fdo#46808, cleanup some usage of getProcessServiceFactory()Noel Grandin
Change-Id: I2ab4c7c0a19bd436c84e62bfc6aeda1fea079a44
2013-03-19further OUString cleanupThomas Arnhold
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19Simplify equalsIgnoreAsciiCaseAscii[L] callsStephan Bergmann
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19trailing whitespacesThomas Arnhold
Change-Id: I3d0e2015e4c9f0ea6118fd92892022607fe4bde6
2013-03-19sal_Bool to boolTakeshi Abe
Change-Id: I0a8d0f11c45aba1d34a0098e6a371bd616b08b72
2013-03-18fix copypastaDavid Tardon
Change-Id: I0ed143e66d1b7729afbb56b478f409ed34212244
2013-03-18use the std signature for operator=David Tardon
2013-03-18guard against self-assignmentDavid Tardon
2013-03-18Fix crash in fdo#62119Thorsten Behrens
This fixes the crash, not the missing line styles. Change-Id: I762fb58831ac44bdab7f02101acf7ccb58172ee9
2013-03-16Bin more pointless comments and ASCII graphicsTor Lillqvist
Suggested Easy Hack: Replace all instances of // -------- comments including surrounding newlines with a single newline. Another Easy Hack, slightly harder to automate: Remove all the pointless comments that just tell the class name right before the declaration of that class. Change-Id: Ia890ed613b53c5d719988697e20a983d62334123
2013-03-16Get rid of a few pointless commentsTor Lillqvist
No need to refer to some source files in a few random places in headers, using ancient UPPER-CASE file names even. Change-Id: Ia0827be34046f25fd769466c41dab017b4935a37
2013-03-16CONTAINER_APPEND is SAL_ULONG, an unsigned longTor Lillqvist
Fix WaE: implicit conversion from 'unsigned long' to 'sal_uInt32' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295, which definitely sounds like an actual bug-inducing error to me, not "just a warning". So don't try to use it as default value for a parameter of type sal_uInt32. Changing the parameter to sal_uLong. Change-Id: I8ebc7195ba1bf94f4f2d6df7cd7863f779ba3fa6
2013-03-16Resolves: #i119337# wrong get/setPropertyValue calls in SvxShapeTextArmin Le Grand
(and thus in SvxOle2Shape) Conflicts: svx/source/unodraw/unoshap4.cxx Change-Id: I666f9f7cde22c16f44ce0b636313cfa721293c38
generated by cgit (git 2.34.1) at 2025-01-13 05:39:57 +0000