summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2022-11-19Prepare the dialog for cell style editingMaxim Monastirsky
Change-Id: I54ec1486f49f240e1ab88662b9d1b0b741cf8878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142905 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-11-19tdf#147906 Use std::hypot for Pythagorean additionOmkarAcharekar
Change-Id: I19ecfe80e9a927c14db2680188baa54cb4911d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142535 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-18AddWindowToPaintView -> AddDeviceToPaintViewMike Kaganski
... and likewise DeleteWindowFromPaintView -> DeleteDeviceFromPaintView because they add/delete output devices, not windows, ever since commit 53fd4bb47c53cbb62a542c847ed38238e7b3e148 (INTEGRATION: CWS sdwarningsbegone (1.42.34); FILE MERGED, Dec 12 18:19:15 2006) And use references instead of pointers, because they are dereferenced unconditionally. Change-Id: I67d5841babaec040aa5308e95f333948eb0dde2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142945 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-18Simplify a bitMike Kaganski
Change-Id: Ie2cdb0a361376b488d9829c892c9f4c6e9711503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142941 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-18tdf#148999 Add rescan button to PDF a11y check dialogSamuel Mehrbrodt
Change-Id: I772f529ea4bd225701b9864ad9156c573f41484c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142715 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-18sw: add a menu option to enable/disable online a11y checkTomaž Vajngerl
Change-Id: I656037ef4e40e7c79daef5dd73f8f10c9818ac25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142215 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-16tdf#149322 apparent distortion of glyphs on scrollingCaolán McNamara
sometimes there's a 1 pixel difference here vs to the amount seen in Window::Scroll. The little misplaced tails of glyphs are actually in the right place, and it is the large rectangle of copied text above those that is in the wrong place. Subtract these origins while in logic space, before turning that result back to pixels to get consistent results for equal distances. Change-Id: I37e77f38b95456cee32ff44cde2893986d52cde3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-16Use BitmapEx in BitmapPrimitive2DNoel Grandin
we no longer need to wrap it in the framework XBitmap implemenation Change-Id: I0dc56ad63364e2c5a4cedd5e70d4ae7ea7eae563 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-14tdf#148971 Make a11y check dlg non-modalSamuel Mehrbrodt
Change-Id: I56dcb3b09bd00a438a6fb5c442caa11d90723195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142706 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-14Save with latest gladeSamuel Mehrbrodt
Change-Id: I2dee470598695252c3e8f3ae17788571c62dc534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142705 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-14svx: On table style removal, revert to the default styleMaxim Monastirsky
Change-Id: Ie299634c93640a89d9c98b2cd517c5cb83434ea7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142666 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-11-14svx: Update tables on style changesMaxim Monastirsky
After modifying a cell style, it is required to broadcast the SfxHintId::DataChanged hint on that style, to update the table appearance. However, it doesn't work when only text attributes (e.g. font name or color) were changed, unless the table is also moved around a bit. It seems to be the same problem as i#101556, whose fix didn't handle the table case. The problem here is that the change hint is handled by the individual cells properties objects, and nothing updates the table's properties object. Change-Id: I30ebc85c16b20c5354f02a309e6fa3dd4b31f669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142665 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-11-12cid#1516789 Division or modulo by float zeroCaolán McNamara
Change-Id: I191d475df5d1937e80fe6844de618a9ce315aee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142585 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11Resolves: tdf#151898 get hidpi font/highlight color iconsCaolán McNamara
Most of this wouldn't be necessary if we could solve the split alpha problem. In the meantime, let Image take a MetaFile as an arg, record what we want to do in the metafile, and play it back when we need to generate the bitmap for to render the image. That way we don't have alpha to worry about during the recording, and we only have one alpha in the final rendering, as opposed to having two alphas in a source and in destination VirtualDevice, which is problematic in most backends. Change-Id: I5b0d7c498473271f4ab2743f75614b1b93a0e9c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-11move password handling from SwModelTestBase to UnoApiTestXisco Fauli
so other places inheriting from UnoApiTest can also import/export protected documents Change-Id: I0e2716204dbb171c9e17e3939b266977e1b96dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-11Drop counterproductive const'ness of a member functionStephan Bergmann
...introduced in c8d2fa176a15a7ae76d6a4b76aea5f108313c2ec "reduce copying in drawinglayer", but thwarting the use of std::move on a data member. (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I9b32d8762b4cc57875343664642494c7098ffb4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11Revert useless std::move of const objectsStephan Bergmann
...added with 8a843f7e98dfe6bfb04e91e5b16e3a1df18fbf58 "loplugin:moveit". (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I099130acd67de7379992ce394226a7e233d6ca55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142561 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-09UnoApiTest: factor out common codeXisco Fauli
Change-Id: I1d84d8c1e371016a4f4f068af1e9c76635f28cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-09lok: masterpage: don't render text edits from different modeSzymon Kłos
In Impress we can have 2 different EditMode : Page and MasterPage. Don't render text edits from other views in Page mode on Master Page. Change-Id: I62341941215165281d2663af3d3b7cca034762a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138803 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142470 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-08Resolves: tdf#148140 get text auto color right in impress edit modeCaolán McNamara
Change-Id: I2695c86e9b749a4c38920af6d33e8e89f8ea3c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-08UnoApiTest: simplify code by using tempfile memberXisco Fauli
SwModelTestBase does the same. this will help to make SwModelTestBase inherit from UnoApiTest Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-08Update handling of AntiAliasing settings and processor2dArmin Le Grand (allotropia)
Currently SvtOptionsDrawinglayer::IsAntiAliasing() is used in the constructor of the VCL based processor2Ds to decide if AA is to be used or not. Using this inside the constructors makes it currently impossible to use a primitive renderer independent from these settings, except when changing these settings temporarily what may influence other renderings and is a hack. The setting SvtOptionsDrawinglayer::IsAntiAliasing() is intended to decide if LO shall use AA mode from user's perspective, this means for the EditViews of the Apps and some other occasions (previews, exports, conversions to bitmap, ...). This works currently since all visualizations for these purposes use newly constructed primitive renderers. But there is no way to use primitive renderers independent from that setting. For future renderers which might be used for other purposes this is not sufficient, there has to be a method to create a renderer using e.g. AA independent of the global setting. To allow that, move the deciding flag to the already used geometry::ViewInformation2D. To not change anything initially, use the global flag for now to init that default value at ViewInformation2D. I took the opportunity to adapt ViewInformation2D to no longer being read-only and not changeable, it uses internally an impl class based on cow_wrapper already anyways. Extending this would lead to the constructors getting even bigger, when usually only 1-3 values need to be changed and many usages want to copy an existing instance and modify it. Adapted that usages to a much smaller footprint. Up to this point this does not change anything, but move the usage of the SvtOptionsDrawinglayer to the defaults (constructors) of the involved class ViewInformation2D. Using this then in the primitive rederers should be safe and will allow to use a primitive renderer with or without AntiAliasing independent of the user setting, so also for non- EditView usages. Also already added the PixelSnapHairline setting, this will also be needed independent of user settings to have full freedom of usage. Unfortunately I cannot use SvtOptionsDrawinglayer methods ::IsAntiAliasing() or ::IsSnapHorVerLinesToDiscrete inside ViewInformation2D where I would need it. It's now in drawinglayercore and thus not linked against svtools (svt) anymore. Thus I have to do some forwarding mechanisms to get the correct values available in ViewInformation2D. Not nice, caused by creating drawinglayercore... Change-Id: I9f572ce67e5d86a242188bdc6d4ba7c9a12f6a9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142393 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-11-08Resolves: tdf#150007 add suggested-action to "find next"Caolán McNamara
Change-Id: I0a9a37891319d11958859c43b2121283d2ca8b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142399 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-05cid#1516651 Dereference after null checkCaolán McNamara
Change-Id: I0f4586538a672426cbfe60d1e589778741b08dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-04sw: add FN_PARA_1 to MAILPREPAREEXPORT slotHenry Castro
Reuse the code to use the functionality without the UpdateFields calls, otherwise it will reset the data source on the first record and export to pdf will have wrong data. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Iec3b44b91c06861cb22d0a7a7234bee6f6f817a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141519 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-04svg: export embedded videoAshod Nakashian
Change-Id: Ie5dcd1fb4abbaf53f48107e7def0f42daad24596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142145 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-04SplineLine and SplineFill have never been implementedNoel Grandin
Change-Id: I75e01bc8831a9d8e6e1f52fc3a89cd9827e1d6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-03tdf#115007 add NatNum12 number format list items, fix title caseLászló Németh
Add NumberText NatNum12 number formats, e.g. "One Hundred", and currency formats, e.g. "One U.S. Dollar and Twenty Cents" to number formatting dialog windows, i.e. Format Cells->Numbers in Calc and Format Numbers in Writer (Edit Fields->Format-> Additional formats...). Fix also bad English title case: "One Euro *and* *Twenty-Two* cents" (not *And* and *Twenty-two*) Details: – svl: list NatNum12 NumberText currency codes in Currency formats (i.e. after choosing Currency category). – svx: Recognize bank symbol "CURRENCY" in NatNum12 parameters defined in locale resource files. For example, "[NatNum12 CURRENCY]" is converted to "[NatNum12 USD]" in the number format dialog windows, using bank symbol of the current locale settings. Recognize compatible (old) bank symbol "CCC" in NatNum12 parameters defined in locale resource files. For example, "[NatNum12 CCC]" is converted to "[NatNum12 DEM]" in the number format dialog windows, using bank symbol of the compatible currency of the German locale settings. User-defined formats with arbitrary bank codes are recognized as currency formats, e.g. modifying "[NatNum12 USD]" to "[NatNum12 EUR]" in the dialog window results a new currency format item. – i18npool/*en_US.xml: define four Standard NatNum12 formats (lower case, sentence case, title case, upper case) and four Currency NatNum12 formats (title case, title case with digits, upper case, upper case with digits). – cui: use lower sample numbers for spell out formats: – 100 for Standard: One Hundred one hundred One hundred ONE HUNDRED – 1.2 for Currency: One U.S. Dollar ONE U.S. DOLLAR One U.S. Dollar and Twenty Cents ONE U.S. DOLLAR AND TWENTY CENTS – i18npool: fix English title casing of NatNum12 conversions: – Don't apply casing on "and", according to the title case rules, for example: "One Euro and One Cent" instead of "One Euro And One Cent". – Apply casing on the second element of the hyphenated compound words: "Twenty-One" instead of the bad "Twenty-one". – add unit test for extended Number and Currency categories. Note: according to the changes, update user-defined number format id in chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt Change-Id: Ieaf9a8f75a4f197b858eaf67f83484df70295834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141994 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-03UnoApiXmlTest: add new wrapper for XmlTestTools testsXisco Fauli
Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03tdf#151174 Hide transparency widgets when not neededSamuel Mehrbrodt
Regression from adc536e9efc77690df62177aa722f9252bdbf96b Change-Id: I42d64fafe170d08e14bb4fe087a3e628ac862e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142221 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-03optimize text fitting algorithm to correctly calculate the fitTomaž Vajngerl
As we converted the chart stretching variable from int to double this can cause the text fitting algorithm to calculate the fit wrong. This commit changes the text fitting algorithm a bit so that it produces similar result as before the change. Change test testAutofittedTextboxIndent from 691200 to 712800 as the fitting algorithm changed a bit. Visually the document still looks correct. Change-Id: Ib75733360039d80a5aed836f757c3f8e8ec56d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142186 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-03fix rendering of text when "fit to frame" is enabledTomaž Vajngerl
This changes the nStretchX and nStretchY from sal_uInt16 to double so the text in text boxes is rendered correctly (text should be resized to the same size as the textbox). Change-Id: Ic92d03043af0abe86f1b67ae15522d0176ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142064 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-02tdf#54857 elide more dynamic_castNoel Grandin
Change-Id: I42bef355eeef15e3733a5ee57b0569887cfa5e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-02tdf#54857 elide more dynamic_castNoel Grandin
Change-Id: I0cbdb2ee46600559d9a37f09b574d484e72a0e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-01tdf#54857 elide more dynamic_castNoel Grandin
add a helper, following the same style as the ones in sw/ Change-Id: I13c673bba5ff47df6beef9d90c200e5801030cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-01tdf#54857 elide dynamic_castNoel Grandin
shaves 2% off load time of this ppt Change-Id: I025bae9dbc6a01cd193e2a4721f50cf60ac08dc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142112 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-01CppunitTest_svx_styles: inherit from UnoApiTestXisco Fauli
Change-Id: I3edd6e41e12efb4876f632edc66ae198d26ac944 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142095 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01CppunitTest_svx_core: inherit from UnoApiTestXisco Fauli
Change-Id: I4e7cdd1507232d48eba7c4afc599adf8da7a3df7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142094 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01CppunitTest_svx_unit: inherit from UnoApiTestXisco Fauli
Change-Id: I12e6032c178039eb7b87a1ef063a69c63a0f814b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142093 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31Fix typoAndrea Gelmini
Change-Id: I5090a74ff98240821555ce749316df3721da4a9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142067 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-31tdf#143377 Correct maximum Skew for TextOrientation in CalcArmin Le Grand (allotropia)
For zero or 180 degree text orinentation errors can happen in the Border visualization, theoretically also in the Text rendering. Ths has to do with sin(0) and sin(180) being zero and lead internal to numerical problems, e.g. a very huge Skew that when applied show the reported 'errors'. I limit this mechanism now to +/- 1/2 degree from the critical mentioned places, for Border and Text - to not risk to have different points of corrections. The UI only allows angles of 1 degree steps, but UNO API and pdf import may allow more. Change-Id: Idbc68f6a7beab84df0672165c2a813d96eeff84e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141999 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-31tdf#151654 related: dereference after nullptr checkMike Kaganski
pPV nullptr has appeared in commit 6fcee31ed5e1dadcbf9614967592ff188a250007 Date Thu Jul 02 14:28:15 2009 +0000 CWS-TOOLING: integrate CWS aw065 but it was still dereferenced unconditionally after that. Change-Id: I4a9ec2345e4093673eed092f6ddb16ee21b9d00f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-27tdf#146360 use correct data source to access object propertiesArmin Le Grand (allotropia)
For more and detailed info see comment in diff please. Change-Id: I33d6d4fc46af7f6f854a2708e3ab932bbe6712f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141886 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-26lok: support embedded mediaAshod Nakashian
Change-Id: Ie8f3ed188cec0050a10a5d49325756931b902ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141807 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-25Update to ICU 72.1Eike Rathke
https://icu.unicode.org/download/72 Unicode 15 https://blog.unicode.org/2022/09/announcing-unicode-standard-version-150.html CLDR 42 https://blog.unicode.org/2022/10/unicode-cldr-v42-available.html New scripts: USCRIPT_KAWI USCRIPT_NAG_MUNDARI New Unicode blocks: UBLOCK_ARABIC_EXTENDED_C UBLOCK_CJK_UNIFIED_IDEOGRAPHS_EXTENSION_H UBLOCK_CYRILLIC_EXTENDED_D UBLOCK_DEVANAGARI_EXTENDED_A UBLOCK_KAKTOVIK_NUMERALS UBLOCK_KAWI UBLOCK_NAG_MUNDARI Change-Id: I8822791e914e6700358b817a1af94b7dcd16b26d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141788 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-23tdf#151311 don't show editing visualization frame for tablesCaolán McNamara
continue to show it for cases like tdf#94223 but not for table cells like tdf#151311 Change-Id: I73f69b9dc203af86293043743a1101ab129139a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-22Set InstallLOKNotifier handler for CrashReportDialogMike Kaganski
This prevents assertion failure in Window::SetLOKNotifier called from Dialog::ImplStartExecute in gtktiledviewer. Change-Id: I5c67d85728a34e47c36c73dafa616df45afa8092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141589 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-22loplugin:unusedmethodsNoel Grandin
Change-Id: I3c94d68cb85adc2005a5a5e3b03a311732f782c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-20fix assert in debug modeNoel Grandin
not actually a leak, just a deletion ordering problem warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:200: SdrModel::~SdrModel: Not all incarnations of SdrObjects deleted, possible memory leak warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:202: leaked instance of 12E3dSphereObj warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:202: leaked instance of 8E3dScene soffice.bin: /home/noel/libo/svx/source/svdraw/svdmodel.cxx:204: virtual SdrModel::~SdrModel(): Assertion `maAllIncarnatedObjects.empty()' failed. Change-Id: Ia0e6e1387825c0d849904b1bc604eb1252090318 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-20fix regression in "Format - 3D Effects"Noel Grandin
assert at svl/source/items/itemset.cxx:1302: SfxItemSet SfxItemSet::CloneAsValue(bool, SfxItemPool *) const: Assertion `(typeid(*this) == typeid(SfxItemSet)) && "cannot call this on a subclass of SfxItemSet"' failed. This hits in Draw when drawing a rectangle, then "Shape - Convert - To 3D", then "Format - 3D Effects". regression from commit 31e7845339b30a69f06a04619660398fe4267268 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Feb 17 12:19:49 2022 +0200 use more SfxItemSet::CloneAsValue Change-Id: I36af83fc04636aecefc89e2654929112051fb217 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141542 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-24 18:38:42 +0000