summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15Trying to make the Find & Replace dialog a bit more compactAdolfo Jayme Barrientos
Especially with long translations, the removal of homogeneous-width columns make the dialog’s size more manageable. Fixed capitalization, indentation, and made the dialog non-resizable to remove the Maximize button under Compiz/GNOME and the fat border under XP. The expander will still work. Change-Id: I2fb820ac406afe45a3d5339f574c13902ad48753 Reviewed-on: https://gerrit.libreoffice.org/11942 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-14make sure the denominator is not 0David Tardon
Change-Id: Ia618379a8d33048b6716f22ad1e5dcbca0bbf307
2014-10-14make sure the denominator is not 0David Tardon
Change-Id: Ic32e0f354bb290ad77f1d7709bee89858e1889b7
2014-10-14just check if the fraction is < 0David Tardon
Change-Id: I23f631898f29d8285d3da333686da8d3f28a00f8
2014-10-14do not forward-declare templatesDavid Tardon
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14svx: fix another temp file leak, from SdrMediaObj's glTF modelsMichael Stahl
These need a whole directory, apparently a model may have multiple files. Change-Id: I092c1764ddb1ed30947034f299fbb6882658d21b
2014-10-13oox: refactor embedded media importMichael Stahl
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-13coverity#1078470 Unchecked return valueCaolán McNamara
Change-Id: I2dab114efc8c98a17561f1694acf63918e68620d
2014-10-13coverity#1027273 Unchecked return valueCaolán McNamara
Change-Id: I25c6b11fee909559a5f3bac7566fd161851ae14d
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13fdo#82980: Cancel FmXFormView::OnStartControlWizard when breaking creationStephan Bergmann
The problem is that SdrCreateView::EndCreateObj (svx/source/svdraw/svdcrtv.cxx) first calls FmFormObj::EndCreate (svx/source/form/fmobj.cxx) -> FmXFormView::onCreatedFormObject (svx/source/form/fmvwimp.cxx) -> Application::PostUserEvent( LINK( this, FmXFormView, OnStartControlWizard ) ), and only then, upon bPntsEq, calls FmFormObj::BrkCreate (svx/source/form/fmobj.cxx), which does not cancel the posted OnStartControlWizard link. The fix is apparently not perfect, though, as afterwards the text document goes back to text input mode (cursor blinking, mouse pointer has I-beam shape) even though the "List Box" icon is still selected. Change-Id: I3137110a88885b04c8dde5377265b1dee91ed6ac
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10UBSan: SfxBoolItem vs. SfxTemplateItem confusionStephan Bergmann
Change-Id: I277481734ae260109a6a9446b0d7769324a40aaf
2014-10-10coverity#1241199 Unchecked dynamic_castCaolán McNamara
Change-Id: I8522084c4b6036d63b144af70bf25312f897ff7d
2014-10-09-Werror,-Wliteral-conversion (implicit conversion from double to long)Stephan Bergmann
Change-Id: I89095491d67c382a0b3280755d723039f48229f1
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09HAS_IA2 is never definedAndras Timar
Change-Id: Ib71e98d1250e6d077c593801993b88c2963459b7
2014-10-09Improve wording on several actionsSamuel Mehrbrodt
* "More Styles" (Styles dropdown) * "More Fields" (Insert field dropdown and menu) * "More Options" (Table dropdown) Change-Id: I593a1d1dd68e666d05a4ac20ae97308ad45ff18e
2014-10-08Fix thinko. Thanks to vmiklos for noticingTor Lillqvist
Change-Id: Id4e65908cc73978205bc0858a3a809b882864b62
2014-10-08Don't try to create cdefghij.klm inside the app bundle on OS X when sandboxedTor Lillqvist
Actually, we check HAVE_FEATURE_READONLY_INSTALLSET and not HAVE_FEATURE_MACOSX_SANDBOX, but in practice we set the former only for the latter case. We could do this test cross-platform but I didn't bother now. Nobody uses --enable-readonly-installset when building for Linux or Windows anyway, I think. (There must be more places where we could and should check HAVE_FEATURE_READONLY_INSTALLSET.) Change-Id: Ie54f436616a1db3119b0bc0148149784127b156d
2014-10-07Fix fdo#84591 Styles dropdown disappears when clicked on submenuJuergen Funk
This tells the dropdown to not grab the focus. Change-Id: If1b32d1f53c12eb86ab2f92c531385578d82ae59 Reviewed-on: https://gerrit.libreoffice.org/11841 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: I88a106081b7413bff6313d1e07f53e39d8350002
2014-10-05Related: fdo#62081 Add missing ellipsis to Edit Style commandAdolfo Jayme Barrientos
An ellipsis should be present in every menu item that requires further user input to accomplish the action it leads to. Change-Id: Iee1ef65a7c51b68ef47a0a5ffe6f1af5354d14aa Reviewed-on: https://gerrit.libreoffice.org/11805 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-04coverity#704031 Unchecked return valueNorbert Thiebaud
Change-Id: I2db8f517f27ab9c8abe5aa473fad159a1506c06c
2014-10-04coverity#1242737 Result is not floating-pointNorbert Thiebaud
Change-Id: Ic466b5a8e4f5221248c6733fc7fbd0c98c0bd45f
2014-10-03fdo#84605 : fixed style editing from the style drop down menuSzymon Kłos
Change-Id: I52c0df2a66615f0b3f1de6c0ee7432107f703923 Reviewed-on: https://gerrit.libreoffice.org/11800 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-03fdo#84620 : The styles drop down menu in Writer crashes LO.Szymon Kłos
Change-Id: I4fe52a1c9aabae1ad09dd94b75c3605dcb023d42 Reviewed-on: https://gerrit.libreoffice.org/11796 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-03coverity#1242478 Dereference null return valueCaolán McNamara
Change-Id: I037218d5c6afc3df6862b0c0ce2b6379568767cd
2014-10-03styles dropdown: Show only the triangle for the dropdown.Jan Holesovsky
The entire button appears on mouse over. Change-Id: I27e713f75a30ec4a2b271d813fcbcbe8c91a4180
2014-10-02Fix fdo#84512 Background color not shown in Styles-DropdownJuergen Funk
this fix is only for simple color backgrounds; gradient, hatching and bitmap are not implement. Change-Id: I5ec31c0105491c6d27835d63648fedff21998926 Reviewed-on: https://gerrit.libreoffice.org/11762 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-02coverity#1242476 Dereference null return valueCaolán McNamara
Change-Id: I1895537459bca9341d1e97bad7ca38813bdfa2fe
2014-10-02coverity#1242814 Result is not floatingCaolán McNamara
Change-Id: I56f9c9d995880bf328f021930b3fcfcb69f7a4c9
2014-10-02coverity#1242815 Result is not floating-pointCaolán McNamara
Change-Id: Ie50e89862ba4168c05cde385158bf82cf7aede62
2014-10-02coverity#1242909 Unused value and const things upCaolán McNamara
Change-Id: Ib98a81a04f721917ee3c1fdd19d23a37c5d2c481
2014-10-02fdo#84315 quick fixLionel Elie Mamane
In mergedlib case, load ourselves (that is, mergedlib). Fixes bug symptoms, while waiting for fully clean solution, which is killing svx/dbtoolsclient completely. Change-Id: Ib8ad34ee4697f89bdc6bbe64d406053f9e7f7521 Reviewed-on: https://gerrit.libreoffice.org/11738 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2014-10-01coverity#735513 constant guards dead codeCaolán McNamara
Change-Id: Idba65df85e8fc2131d0cfbdd1b3c25470f0dc0ae
2014-10-01svx: little more verbose exception messageMichael Stahl
Change-Id: I93d5d899fa073cd7ed18e9176b50679b0be95f70
2014-10-01fdo#84551 Make 'Insert table' entry dropdown onlySamuel Mehrbrodt
Change-Id: I26a3f2672fa9a849c370a24a5d21162cfb2a91c5
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#62081 Improve split menu on style dropdownSamuel Mehrbrodt
* Remove "Apply style" * Add "Update Style Based on Selection" * A11y: * Context menu key: Open submenu * Return key: Apply style Change-Id: Ib2960baa1412a05ea00b0e214d1af0a3d119e852
2014-09-30SvxShape destructor un-register at broadcaster with SolarMutex lockedMichael Stahl
Change-Id: Ie9bd6d0fc1b221e77c4d37a26c999aa34afbe0ee
2014-09-30Fix fdo#58161 UI: White Paragraph style invisible in Styles Drop-DownJuergen Funk
Use the Color-Class-function "IsDark" and "IsBright" for decision to make a change of the font-color with DecreaseContrast or DecreaseLuminance. The change is only in the Styles Drop-Down Change-Id: I65ac4a0bd2f72ab95e61ce2f70bca009e4f06725 Reviewed-on: https://gerrit.libreoffice.org/11716 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66