summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-17tdf#135843 tdf#146731 Fix the missing border handlingGülşah Köse
Reverts fa5ab8aa5d88e7128015127af75980a65f945cbb inside. And fix the missing border problem with better way. Reason of the problem is using ORIGCELL cell style for bottom and right of merged ranges is wrong. Eg: We have Row X Col 3X3 table. (0,1) and (0,2) merged. The right side of right border style should be same with (0,2). But ORIGCELL points (0,1) instead. In case we should use LASTCELL. Same reason is valid for bottom case. Change-Id: I5282083541f0bd02f3765943da4f34cabe05ef13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128493 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-14use cache value in ViewContactNoel Grandin
Rely on the cached primitives without always rebuilding. But only enable it for calc and draw right now, by adding a flag at the SdrModel level. Change-Id: I295e5a366b1b21d0f1561e6736bac919082afb5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-13gbuild: implement static partial buildJan-Marek Glogowski
This stores all the dependencies collected from the full build, and uses that info to link static binaries in per module. Change-Id: I27bd41c217bf0d2248ee88004038dd6b813f2624 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128129 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-13optimise ensureGeometryNoel Grandin
for complex polygons, return early Change-Id: Id4bb2311f84508d95a71a3f4353872164baabe6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12used cache value in ViewObjectContact::getPrimitive2DSequence (2nd attempt)Noel Grandin
Rely on the cached primitives in VOC. But only enable it for calc and draw right now, by adding a flag at the SdrModel level. This way we can leave it disabled for writer, where it definitely doesn't work. Change-Id: I11ca4836eb773c0f078cdb82056c6e0309d15a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12CppunitTest_svx_unit: simplify code (part 2)Xisco Fauli
Change-Id: Ic98a25f495630517827c1e9f9827e1c45e1401ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128304 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-11do not call broadcast SetStyleSheet from a non-broadcast oneLuboš Luňák
In the document from bsc#1183308, which contains a large number of custom shapes, I get a noticeable time spent in the callchain EnhancedCustomShapeEngine::render() -> SdrObject::NbcSetStyleSheet() -> sdr::properties::GroupProperties::SetStyleSheet() -> SdrObject::SetStyleSheet(), which means that a non-broadcast call ends up in a broadcast one, and the time is spent in SvxShape::Notify(). And it even seems that nobody actually cares about the broadcasts, possibly because the SfxStyleSheet* value is actually the same. I originally tried to make SdrObject::SetStyleSheet() return if the SfxStyleSheet* is the same, but that fails the test from 717dc8e3575a18e1e. I don't quite understand the reasoning for that, but solve it then by changing the code to call the Nbc variant if that's enough. Change-Id: I096a6799a0dc51c31ec3b0ba070c7f99ec96ac5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128048 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-01-11CppunitTest_svx_unit: simplify codeXisco Fauli
Just use CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE or CPPUNIT_ASSERT_EQUAL_MESSAGE Change-Id: Ibf399cc802e31c5265ba1301f38df79958bf9e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128262 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10sd theme: fix applying new colors after theme change for group shapesMiklos Vajna
UpdateSdrObject() is called for both group and non-group shapes, so don't assume that they always have text, otherwise we would crash. Change-Id: I3672673176f0cb462a8b8d61a68466f541e9ce06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128248 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-09implement anyToHash() and use it for SdrCustomShapeGeometryItemLuboš Luňák
Using anyLess() still has quite some cost with bsc#1183308, this makes the cost almost unnoticeable. Since some values of Any are not handled, return empty std::optional for those cases. Change-Id: Ib45a81441e8bb456c4749f9bc53a981f09bbb1a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128109 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-01-09make SdrCustomShapeGeometryItem sortable and fast (bsc#1183308)Luboš Luňák
The document contains a complex graphic consisting of many shapes, and SfxItemPool tries to avoid duplicates by checking for equality. And SdrCustomShapeGeometryItem contains a UNO sequence as data, and comparing those is non-trivial. Make the item sortable, which should make things faster, and use anyLess() for the ordering. Additionally first check the size of the list of property names the class keeps for an easy fast return. Change-Id: I49220e589b6510c6f1f40d584301be83367fb5a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128047 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-01-09make SdrCustomShapeGeometryItem internal data consistentLuboš Luňák
The PutValue() function didn't update the property map properly the same way the constructor and other functions do. Change-Id: I107f7095077d888cd9701d87a6e536339b0257b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128104 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-01-09Slightly optimize code handling anglesMike Kaganski
Change-Id: I8bc10513f6cd704abc7a2bbb17d8d0d8d2628401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-08tdf#146556 feature 'drag-mirror' is brokenNoel Grandin
regression from commit 11e52fe2979b0947814a49b9c17ec373795cbf8e introduce Degree100 strong_int type where I tried to introduce a more efficient NormAngle36000 calculation, but it produces the wrong answer. Change-Id: Iefeb0849984bc59d3ce9191eaf6f064beba94c59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-08reduce cost of Sdr properties for text-derived objectsNoel Grandin
when they have no text in them Change-Id: I70c18898abf21141f3b30b7dee9c931c9b27cffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07make GroupProperties extend BasePropertiesNoel Grandin
it doesn't need any of the logic in DefaultProperties Change-Id: I75d56a29f1edf2819c22a1fd69df464948544aaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07move applyDefaultStyleSheetFromSdrModel from BaseProperties..Noel Grandin
to AttributeProperties, since it only applies to AttributeProperties and its sub-classes. Change-Id: I01527f75815659d1cf2a9859888ef04c561633a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07move some methods BaseProperties->DefaultPropertiesNoel Grandin
These methods are part of the implementation of DefaultProperties, so they do not belong in a superclass Change-Id: I553f5d5b771aa0a408a8ade25f009cc56f829c72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07split PageProperties from EmptyPropertiesNoel Grandin
to make it clearer - PageProperties just ignores stuff, but it is not a logic error to set props on it (or so it seems from its comments) Change-Id: Iba3dbcdffae6165a14e9a2d71e4111fbbd29febb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06-Werror=maybe-uninitializedStephan Bergmann
Change-Id: Icebc6b95596e62628d00cc3c851f56a6a78ee727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128058 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-06tdf#135843 Fix the missing border handlingGülşah Köse
Adding +1 at that stage causes indexoutofbounds. But never throws that exception and tries to pull empty cell style instead. As a result we can not see the border. Actually no idea why +1 used here. Change-Id: Id54ba6445d022540173af3bbf5d679b7edefc55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127990 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-01-06bypass SvxShape when creating rectangles in chart2Noel Grandin
Change-Id: I461449959fffa8948bf4321a6c3114505d87a149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-05Disable epoxy test with --disable-guiJan-Marek Glogowski
Instead of always testing for DISABLE_GUI, just disable the epoxy test and handle !ENABLE_EPOXY in RepositoryExternal.mk. Change-Id: I38213ffa77353bc93f32caa1b4164c5fa88170ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127999 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-05tdf#130076 Fixed flip not working properly from fileDhiraj Holden
Added code to check whether the angles need to be changed when the section is flipped. Change-Id: I9cc3e16db74c6e9616385bc39849e4c73686b56c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-01-04sc export chart as graphic: handle PDFMiklos Vajna
The context menu for Calc charts would call into GraphicFilter::ExportGraphic(), which has explicit code for e.g. SVG, but not for PDF. The graphic exporter to PDF is only meant to work with images backed with PDF data, not with all shapes. Fix the problem by explicitly handling PDF in GraphicHelper::SaveShapeAsGraphic() in svx/, and invoking the normal PDF export in that case. Continue to fall back to XGraphicExportFilter for other formats. This requires passing down the current document from sc/. Change-Id: Ia5f78bffa1d26989bb0ad3ed265b922e609f076f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-04use deque in SdrObjListNoel Grandin
which has much better performance for (a) inserting stuff at the front (b) appending large numbers of items something that happens when constructing large charts - shaves 5% off the load time for large sample bar chart Change-Id: I3ebccbfdc75e4df3ec88eb2dde46acfe0ab0ae7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-03add new SvxShape hierarchy classNoel Grandin
to serve as a shared/common base class, so I can plumb SvxShape types through chart2. Change-Id: I8758fff1599c92a214b334ee44cf7b4e582c1915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-02osl::Mutex->std::mutex in FormScriptListenerNoel Grandin
Change-Id: Ic5a1a9f84374ec41685ee32a69cf7fe43e215d5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-02osl::Mutex->std::mutex in ChineseTranslation_UnoDialogNoel Grandin
Change-Id: Ife56a3d106f64b00b63798d6300e768bbfa81335 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-01use cppu::BaseMutex in FmXFormShellNoel Grandin
because passing a ref of a local member to a parent class means passing uninitialised data Change-Id: Idaa8d3d3c54a14e184c84a0d6df15219b2ec2f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-30tdf#126269 Add clipping to diagonal border linesArmin Le Grand (Allotropia)
See task for in-deep discussion. Needed to do some re-arrangements to add clipping to diagonal border lines. It is necessary to only clip visible geometry but not touch vectors that get added to be able to solve all that dynamic border line style start/end overlapping. Change-Id: I656a5cd63a011140ee1281873e44ab5e60606b67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127713 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-12-29use comphelper::WeakComponentImplHelper in svx::sidebar::SelectionChangeHandlerNoel Grandin
Change-Id: I7f60374710f5768efef07ee993757558a225c111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29tdf#144190 Change _Left Align and _Right Align to Align _Left and Align _RightJeff Huang
Change-Id: Ib864f3fb960db47e0f431df6f0c2f985cb276017 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127540 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-27tdf#126269 Handle diagonal borderline better for merged cellsArmin Le Grand (Allotropia)
Change-Id: I04776bbd237dc1fa881385bfe9be7f034b58e35a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127431 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-12-26use comphelper::WeakComponentImplHelper in SvXMLEmbeddedObjectHelperNoel Grandin
Change-Id: Id574f7a1ff54fae4a76bcafb011b9a80b5f35232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26no need to store 3 different refs to the same objectNoel Grandin
Change-Id: I025719a9682cf0f0a6e3773362fe37d80fddb1ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25use comphelper::WeakComponentImplHelper in TableDesignStyleNoel Grandin
and remove some unnecessary use of SolarMutex, when accessing static data. Change-Id: I4cd489d89be71df09f34602d05feb40855dc1567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25pass unique_lock as param in WeakComponentImplHelperBase::disposingNoel Grandin
so that subclasses can drop the lock while calling listeners Change-Id: I6105438110af08f10b0ed50057b28172c3442b95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25no need to take SolarMutex in TableDesignFamily::createInstanceNoel Grandin
the constructor doesn't actually do anything other than allocate memory Change-Id: Iff437111018a6025d3aa02c350f67983bc64b08e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24use comphelper::WeakComponentImplHelper in SvXMLGraphicImportExportHelperNoel Grandin
Change-Id: Ieb76e57ac8c9e2f456e5d7d2c127668d5f2b8490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24use comphelper::WeakComponentImplHelper in SvXMLGraphicHelperNoel Grandin
and remove unused disposing() override Change-Id: I6423d9c3c418bb07f84e1622c8df6eac8ad762c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127406 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24use comphelper::WeakComponentImplHelper in ChildrenManagerImplNoel Grandin
Change-Id: I24b1f497a77b7ff896060a8f7dacc5d3a5e27ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24use comphelper::WeakComponentImplHelper in PanelFactoryNoel Grandin
Change-Id: I936fd58fdb626d6707cf672f188cd8570269bc44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24use comphelper::WeakComponentImplHelper in PrimitiveFactory2DNoel Grandin
Change-Id: Iead37062710d64705fca2d00404922b3ad3b6f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127409 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24tdf#146132 tdf#146327 tdf#146330Noel Grandin
regression from commit fe6a140a537eda1b6703c44ff5ee49d2ba875b81 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Dec 7 14:55:13 2021 +0200 used cache value in ViewObjectContact::getPrimitive2DSequence Unfortunately various things like scrolling/zooming/moving item to new page do not seem to invalidate the VOC, and I can't track down the right place to do that, so just revert. Change-Id: I8009c99417f634b26adc770b6d6d2eb6969d9629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-23Split BasePrimitive2D UNO interface into separate objectNoel Grandin
Rather than make all the BasePrimitive2D classes bear the cost of being an UNO object, we just wrap the top level BasePrimitive2D in this class when we need to pass them over UNO. This reduces the locking overhead when doing normal drawinglayer operations, and reduces the size of drawinglayer objects and the cost of initialising them, which shaves 5% off the load/display time of a large barchart. Add new drawinglayer::convertPrimitive2DContainerToBitmapEx utility method to avoid needing to convert to Sequence<XPrimitive2D> Change-Id: I553eaa4c16ba016b098cb21f6c55f5008f0d9b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126487 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-22tdf#146363: fix crash when changing width/height of text boxJulien Nabet
Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc tdf#126180: EndTextEdit on all views before delete/cut slide Just declare and initialize nMarkCount later since calls to methods like ResizeMultMarkedObj or RotateMarkedObj may change the result Change-Id: Ic2a07a6f41b8052dcc3c2736205e1b9c6d538233 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127308 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>