summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-07-22split SvxFmAbsRecWin up to make a reusable pieceCaolán McNamara
Change-Id: I3c9992d39f7dd45ac354b8e4087bacfd9715b234 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22let up/down increase/decrease record numberCaolán McNamara
Change-Id: I4d77cf71640922db5865586a0d053a46834f4b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22weld form navigator label item windowsCaolán McNamara
Change-Id: I2e49ffda6dc29746819a61db2848b6bcfe5f4a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22tdf#134564 tdf#134578 Improve hierarchy viewing in InspectorShivam Kumar Singh
Significance of this patch - * Added TreeView Lines in the ui file for Inspector for better hierarchy viewing * Properties and there respective values are divided into separate columns. * Grey out disabled properties * bold PS, CS and DF Change-Id: I825a75dd2c5bc54715fe59f3c639024a5e3ab5cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98990 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-22align label contents to flush leftCaolán McNamara
Change-Id: I75e4887e2b8fbfd94f240af260e0f4eeba53d7ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22merge duplicate GetFocus implementationsCaolán McNamara
Change-Id: Ifc2e3fab6dacb3b0bca74c0584c16170b8b97de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99234 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22make label fill full areaCaolán McNamara
Change-Id: I01cfcb8bbb2fb189220096bdcf917937f5e8fdb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22update svx pchCaolán McNamara
Change-Id: I311f35edbe8c1390fe471883b77c8ce35a1aa0b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22weld PatternControlCaolán McNamara
Change-Id: Ie84778c2f127a6b393edbfa08e61b135ec3bcbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-21can now change base class to use FormattedFieldCellControllerCaolán McNamara
Change-Id: I1ea6a7fd88cfac21e7d6d2a1533db5363ea558c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-21weld DateControlCaolán McNamara
replace SpinButton when WB_SPINBUTTON is set on a date field to always use a popover with a calendar in it to make it possible to integrate this with native widgets Change-Id: I36a26599a154bddf9aec9b50b6570e13477a1f63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-20loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ida7e1fa4bfaa6734dac26705726043e6b9d9204e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-19compact namespace: svxNoel Grandin
Change-Id: I15c64c6cc0ae2a0f1fb9a3e1651dda1d6ced7585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-19cid#1465260 Unchecked return valueCaolán McNamara
and cid#1465257 Unchecked return value Change-Id: Ibf3fe527368314124dc06050f54e16c88004cbed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-17add explicit copy-constructor for SgaObjectTomaž Vajngerl
Change-Id: If833cbd28af2043f71bc1ada4ea7b0f80bebf682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98974 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-17Add UI for blur radius in shadow panelA_GAN
Update shadow property panel with spin button to control blur radius of the shadow. Change-Id: I5856e86a7963682c81d9e53a1bef857aba2f3c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98718 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-17svx: refactoring of GalleryTheme GetModel(), InsertModel()Aditya
Introduce readModel(), readModelStream(), insertModel(), insertModelStream() in Gallery Binary Engine because these deal with file reading stuff. Move ImplGetURL() to galmisc for now because GalleryTheme and GalleryBinaryEngine both use it. Separate InsertModel() into two parts - one dealing with Sot Storage stream, the other adding object to gallery list. Move first part to Gallery Binary Engine, the second stays. Separate InsertObject() into two parts. Move CreateThemeEntry() to Binary Engine. Change-Id: Id3b4091db27b5b88bcf025f9fd94ad86169505d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-16Cleanup: Fix variable names for InspectorShivam Kumar Singh
Fixing of variable names following LO naming conventions and some other minor fixes. Change-Id: Iad58584ecc07a02287193a615c428819363ed0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97810 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-07-16loplugin:unusedmethodsNoel Grandin
Change-Id: Ibc1ec64cba8eb083aaff28848a42337cc597ea19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-15move SVTXDateField to toolkitCaolán McNamara
and svtools CalendarField to vcl Change-Id: I6f3e9a71f21ac7ca70f8172d4f8be4804f3b1c7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-15replace TimeSpinButton with FormattedSpinButtonCaolán McNamara
with a TimeFormatter rather than have duplicate functionality Change-Id: I99f1f2aabee5f81485f97755ba3675870317cfb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-15weld TimeControlCaolán McNamara
Change-Id: Idb19639eb39bc83fb8bdc7c2181bf63e9c522d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98670 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-15rename entry formatter for more consistent namingCaolán McNamara
Change-Id: I0a138015b1db6d00413e4b381f0da0757d56e25c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98667 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-15weld LongCurrencyControlCaolán McNamara
Change-Id: I700329aeee53f8ce91ce22a3b50fe59e3d19c063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-14uitest : Add support for "ToolBox" Objects for example" "bottom find bar"Ahmed ElShreif
This patch will help us in testing any ToolBox Objects by this lines : >> variable_name = MainWindow.getChild(Bar_name) >> variable_name.executeAction("CLICK", mkPropertyValues({"POS": poition_x })) for position_x you just put the id of which entry in the ToolBox do you want to press on it . Also This patch set the ID of the bottom find bar to be "FindBar" to be able to select it in UITests . Change-Id: I360cdbde47be188c49c6d61bf5df4df5caa6a23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98549 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-13move Primitive2dXmlDump from drawinglayer::tools to drawinglayer NSTomaž Vajngerl
drawinglayer::tools causes conflicts with ::tools namespace, so better to move Primitive2dXmlDump out from this namespace as for inspecting purposes it ccan be injected into existing code which could break make it conflict and break compilation. Change-Id: I5f9e594b2b8b1dd24067fa5f5ca3cfc4eefb85cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98627 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-13don't grab focus if focus is already in a subcontrolCaolán McNamara
Change-Id: I3bc377e9d9ee1ad7b6066b7a1c2d27ddd7bb6b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-13tdf#42949 Fix IWYU warnings in include/[a-r]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I7f5c35474b671facbda85a9538462dd4291add91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97655 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-12clarify what WantMouseEvent is forCaolán McNamara
and add tristate machine support that we also need WantMouseEvent is if the first click in a browse cell that activates it should be passed to the control that appears on click as if it was itself clicked on primarily for the the CheckBoxController to toggle it immediately. Rework to explicitly toggle the checkbox in that implementation rather than rely on passing fake mouse click/release/tracking events. seeing as the main dbaccess table design view doesn't auto-launch its listboxes on clicking in a cell, but the sub create index dialog does, drop the auto-launch in the index dialog to match the main table design rathern than add a feature to weld::ComboBox to auto-launch the popup for that one solitary case Change-Id: Ie3d3f2ecf55d3d5b0b02b85ca09a6ca64bb800e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98603 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12weld CheckBoxControlCaolán McNamara
Change-Id: Iea057189ab17c1fdaf6663f1c328b9d288d97a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12center check/radio buttonsCaolán McNamara
Change-Id: Icae25573c09861e44a42c54daaeeebfec706bd37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98595 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12update pchesCaolán McNamara
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465260 Unchecked return valueCaolán McNamara
Change-Id: I0f4a71e4735bd5038b45a259bd5136ebcc4c66a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98572 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465253 Unchecked return valueCaolán McNamara
Change-Id: I796fa775f6447801fa9e5f0eef023cf3b2ce8908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11use an aux modify handler instead of listening for VclEventId::EditModifyCaolán McNamara
Change-Id: Ie35ad08a24b8b0c989806c4739bfe925fd9ab746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11scPrintTwipsMsgs: Use print logical coordinates for draw objectsDennis Francis
as a result LOK_CALLBACK_GRAPHIC(_VIEW)_SELECTION messages will now be in print-twips. For tile-rendering, it needs the pixel-aligned coordinates of each object. The translation of print coordinates to pixel-aligned coordinates can be done behind the scenes by the ViewContact/ObjectContact/ViewObjectContact objects associated with the draw object which uses the cached "grid-offset" for each object (introduced in the patch "Refactor calc non-linear ViewToDevice transform"). For doing this, a subclass of FmFormView with a specialized "createViewSpecificObjectContact" method is used for tile-rendering. The createViewSpecificObjectContact creates a "proxy" object-contact object that delegates the grid-offsets queries to the actual ScDrawView generated ObjectContact. This is needed because currently there is no way to share the ObjectContact/ViewObjectContact instances between different SdrPaintWindow's without making changes ~everywhere. Change-Id: Ifdfb623c8d6dd81700ec4a5dfeeb6b2391a96154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98166 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 345f9480618d0867f6b42a83a7ae1d62c8ef9c0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98161 Tested-by: Jenkins
2020-07-10weld MultiLineTextCellCaolán McNamara
Change-Id: Ib230720371552738a8c6152a98a84d31b900d062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98209 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10svx:Refactoring of GalleryTheme members to GalleryBinaryEngineAditya
Moving of aSvDrawStorageRef into the binary engine and consequent changes Change-Id: I7262c77ec8730fbbe516f9fb205c25c4e1f15ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96764 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-10replace usage of blacklist with excludelist for IWYUThorsten Behrens
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 Change-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98182 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-09cid#1465229 Unchecked return valueCaolán McNamara
Change-Id: I7e12612f1aa2570df8f5b0347f19dcb96532aa26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465234 Unchecked return valueCaolán McNamara
Change-Id: I56d59de5c65144283595b044142ff3f8988a02a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465233 Unchecked return valueCaolán McNamara
Change-Id: I078f20bd607110cd526ce40a6391affd238a14d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09tdf#60684: graphic type content must correspond with graphic type extensionJulien Nabet
Change-Id: I8075b1b44aa400268b4022decb2a56770c81d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-08pdf: add PDFiumPathSegment to the wrapper & use in ImpSdrPdfImportTomaž Vajngerl
A PageObject of type FPDF_PAGEOBJ_PATH can have a path segment, that is common in vector graphic objects. The path segment is wrapped into PDFiumPathSegment which can be used to handle the path and path properties. Change-Id: I990d51ba90fa356a6eca137eb4b71947858289aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98210 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-08svx: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: If6bd80525d398b45c2938e921c183633f173dfae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08tdf#134567 Show all properties in DPSShivam Kumar Singh
Change-Id: If2238a80fbc9fc803fc5e12904964bf4289ba2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98310 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-08Add mobile version of find replace dialogSzymon Kłos
Change-Id: If651f84b97a1ed6b08b9f4eb56ce95fe659cddf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97606 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98229 Tested-by: Jenkins
2020-07-08tdf#134188 tdf#114223 Don't override vertical text button visibilityMaxim Monastirsky
i.e. restore the fix for tdf#33356, which was removed in commit eeb2d19e77d6dc47c68e8ba0920a02cf64a1247b ("Resolves: tdf#130159 hide writedirection unless CTL is enabled"). But do it in a way that doesn't introduce tdf#114223 (a regression of tdf#33356). We can assume that the visibility state of the button at the point of control initialization is the one set with toolbar customization, as any customization triggers clearing of the whole toolbar, and reconstructing from scratch. Change-Id: I2cdf18e144dd6eb99b8c1e1da968beacddbb3728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98317 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-07-08Avoid nullptr dereferenceSzymon Kłos
Change-Id: I5f2bd8206a1339e09f277cdc7f0c6a01a6d85df7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c9ceaeaee923a742d842fbc6174222eaf9667ca6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98270 Tested-by: Jenkins
2020-07-07tdf#100772 sd: add uno:DeleteTable to non-NB menusJustin Luth
Delete Row and Delete Column were there, but no option to delete table, so that major omission was fixed for Draw and Impress. The notebookbar looks very incomplete. Also, I didn't really understand the pop-out menu configuration, and at least in the one case there didn't seem to be a good space to add delete table. So I left the notebookbar completely alone. Change-Id: I5d6c98e3238bc545a02325edfd62f5d937ac6371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97821 Tested-by: Jenkins Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>