summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2019-07-25QRCode Dialog Box featureShubham Goyal
The patch handles the created QR code as a Customized Shape (Graphic Object) Change-Id: I1cee6f0e7fac585de880a9ac34e3bc441a4b7390 Reviewed-on: https://gerrit.libreoffice.org/74167 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-25tdf#47807 Invalidate bindings to Undo RedoJim Raykowski
Change-Id: I71a16e60395003402372202a755b976d37690a27 Reviewed-on: https://gerrit.libreoffice.org/76146 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-24Fix typosAndrea Gelmini
Change-Id: Ib778a6598f3797fe871a25b56b7b4b7761889296 Reviewed-on: https://gerrit.libreoffice.org/76269 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24remove unused accessibility::DescriptionGenerator::PropertyType::FillStyleNoel Grandin
Change-Id: I20005ad23088d41262ff988eac2132918db56ab8 Reviewed-on: https://gerrit.libreoffice.org/76236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1448545 silence Wrapper object use after freeCaolán McNamara
Change-Id: Ia1b3137916ae37ed73ac9923af847aa15978dc86 Reviewed-on: https://gerrit.libreoffice.org/76228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-23dispose() methods should clear their smart pointersNoel Grandin
especiall the ref-counted ones Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7 Reviewed-on: https://gerrit.libreoffice.org/76102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-22tdf#118370 Draw: add option to consolidate multiple textObjsJustin Luth
This gives the user a tool to consolidate multiple textboxes into a single textbox. First the user selects a group of textframes, and then runs the consolidate text function. This will REPLACE the marked textframes with a single textbox combining all of the text. The function inspects the text fragments to see if they end in sentence-ending punctuation. If not, then the next textbox's content is appended to it instead of starting a new pargraph. It is the user's responsibility to afterwards fix up paragraphing, and set paragraph properties. The rational for this patch is to simplify making major text changes on PDFs imported into Draw, since each paragraph is currently broken into tiny character-property textbox fragments. Copy/paste from the PDF itself doesn't keep character attributes, so it is hard for a user to re-create the text. This is related to tdf#32249, but as a comment says, a better solution would be to write an entire text-focused PDF import, rather than just pick up the pieces. And I agree, but considering this simple patch took me a couple of weeks of frustration, I'm obviously not the person to do that. And since the bug has been open for 9 years, likely no one else will either. Thus, this pick-up-the-pieces tool to help the end user. This initial patch works only with textFrames, but can easily be adjusted to consolidate other HasText() SdrObjects. However, that tended to produce unexpected results, so everything other than OBJ_TEXT is explicitly excluded. (Thus general shapes with text, callouts, text-along-path etc are ignored.) Change-Id: I68a9a5b187bf320a8e671414c5cb22b07725fd52 Reviewed-on: https://gerrit.libreoffice.org/75043 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-07-21Fix typoAndrea Gelmini
"an OLE", to complete: https://gerrit.libreoffice.org/#/c/75983/ Change-Id: Idd5b9286348b4fa1e3382983c72b010654a1f4c2 Reviewed-on: https://gerrit.libreoffice.org/76038 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20loplugin:referencecasting in svxNoel Grandin
Change-Id: I2f6bc2467fa7689d186bc2bc45d2071ea0a38e63 Reviewed-on: https://gerrit.libreoffice.org/75998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448484 Unchecked return valueCaolán McNamara
Change-Id: I4e06228665c90820e88c72bfe4e462af9a0074e9 Reviewed-on: https://gerrit.libreoffice.org/75897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448251 Unchecked dynamic_castCaolán McNamara
Change-Id: I96b87d05d6633849d7a32a40e87b9fb4ee48b15d Reviewed-on: https://gerrit.libreoffice.org/75916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19loplugin:constantparamNoel Grandin
and tweak the plugin to handle a crash seen with clang-9 Change-Id: Ie1ccf80c16a20dbca58e5bd081af13f75cf5ac8f Reviewed-on: https://gerrit.libreoffice.org/75850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18svx xml dump: show the SdrObject's properties / item setMiklos Vajna
Shows items usually accessed using GetMergedItemSet(), to help debugging. Change-Id: Id3c20e99c33d5e5762c3b58e2f76ab5686031734 Reviewed-on: https://gerrit.libreoffice.org/75852 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-18tdf#126051 sync MINBODY copies to same valueCaolán McNamara
Change-Id: Id41da7b07dcb25e820e5fd20aed595b1170fa204 Reviewed-on: https://gerrit.libreoffice.org/75807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448253 Use after freeCaolán McNamara
Change-Id: I83f3ef82faafd31f5a1afca9c5ab3f4040c3552b Reviewed-on: https://gerrit.libreoffice.org/75812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17Resolves tdf#115087 and tdf#121437 - Improvements to color barHeiko Tietze
Tooltip for parent with hint on left/right click Position of widget right (ideally it would go below the sidebar) Automatic color moved to the bottom to preserve arrangement Change-Id: Ia3cb1c2c7c20dbc6730c7f003c67b0876514c23f Reviewed-on: https://gerrit.libreoffice.org/75749 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-17external: update pdfium to 3849Miklos Vajna
Change-Id: I616f57bd9de72b078500a290bf9ff89c71773f26 Reviewed-on: https://gerrit.libreoffice.org/75736 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16cid#705480 Dereference null return valueCaolán McNamara
Change-Id: I0ad30d7a2447edbe9d42f0e69470ca850498b798 Reviewed-on: https://gerrit.libreoffice.org/75722 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448424 silence Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie68cb97a092753185cc31c0b590fe75fad79989b Reviewed-on: https://gerrit.libreoffice.org/75668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15tdf#39593 Remove SvxUnoDrawMSFactory::concatServiceNamesArkadiy Illarionov
Replace with comphelper::concatSequences Change-Id: I6b16104fac6ac5fdfcb6f322da4a5b8405d5d999 Reviewed-on: https://gerrit.libreoffice.org/75315 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-15Deduplicate EditHyperlink commandSamuel Mehrbrodt
Change-Id: I23f0c276c5c1229aeb4ea468c6b858e36c120bd9 Reviewed-on: https://gerrit.libreoffice.org/75480 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-09Simplify Sequence iterations in svxArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: If6d190cf72b8653c1c3fbe9a6a6e47f10f1a6765 Reviewed-on: https://gerrit.libreoffice.org/75255 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-08use BitmapEx in SvxRectCtl::PaintNoel Grandin
Change-Id: I149c0f77d907f5b53d2989c46ac9757e73091cd1 Reviewed-on: https://gerrit.libreoffice.org/75216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08no need to use intermediate Bitmap constructor here anymoreNoel Grandin
Change-Id: Idc08d1a6a40313c24eb06ce68579c3e5020d8259 Reviewed-on: https://gerrit.libreoffice.org/75209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08use BitmapEx in ImpCreateShadowObjectCloneNoel Grandin
Change-Id: I7737c8b19dca787eab70b733d07a34a5e5f01c9c Reviewed-on: https://gerrit.libreoffice.org/75208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08use BitmapEx in ImpSdrPdfImport::ImportImageNoel Grandin
Change-Id: I80e197ffcda4ebc5d50e611b7a4a5c3fd84fc839 Reviewed-on: https://gerrit.libreoffice.org/75201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08fix loop variable typeNoel Grandin
it's not a std::vector<Bitmap>, it's a std::vector<BitmapEx> Change-Id: I4a315f98bab4c432d6b136cb7bad75cf29899e66 Reviewed-on: https://gerrit.libreoffice.org/75200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08use BitmapEx in EnhancedCustomShape2d::AdaptObjColorNoel Grandin
instead of Bitmap Change-Id: Ibcdef2a076f29590f1a8a43f90b1cec95e75d413 Reviewed-on: https://gerrit.libreoffice.org/75199 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08tdf#120495 Providing self adapting height to the Area section of SidebarSumit Chauhan
This problem comes when we switch between different fill tabs in area sidebar and this patch solves the issue. Change-Id: I09936e600214394d26a27d26d47be3ef9942b65f Reviewed-on: https://gerrit.libreoffice.org/67577 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-05move the contour-finding code inside vclNoel Grandin
Change-Id: Iac52b72831868a917fc445e970edabc1c2585b55 Reviewed-on: https://gerrit.libreoffice.org/75080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05tdf#83618 Make line spacing values agreeJim Raykowski
Change-Id: I372a673bbad442d28314498248b12ce7f86fce09 Reviewed-on: https://gerrit.libreoffice.org/73737 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-04remove some unneede vcl/bitmap.hxx includesNoel Grandin
Change-Id: Ibdc79538276992193e61f6dc16ddd3fd1ab80b82 Reviewed-on: https://gerrit.libreoffice.org/75069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-04move some Bitmap replace logic inside vclNoel Grandin
i.e. behind BitmapEx Change-Id: Ibe5a20ffe127acf7fb5bcf6341dcd046371aa761 Reviewed-on: https://gerrit.libreoffice.org/75044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-04move "replace transparency" logic inside vclNoel Grandin
Change-Id: I7e6994ec6bf7f0c7380df36c49d0b05a9d27c673 Reviewed-on: https://gerrit.libreoffice.org/75041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-03Change names for groups of shape in Shapes Sidebar section in DrawRoman Kuznetsov
The names should be the same in tool's tooltips on Drawing toolbar, for toolbar's names, in menu Shape->Insert and in Shapes Sidebar section Change-Id: I23619d77525b1c37268f634c54f6672fb3fa14da Reviewed-on: https://gerrit.libreoffice.org/75026 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-07-03tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-03tdf#42949 Fix IWYU warnings in include/svx/x*Gabor Kelemen
New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5b91a82d25601041b73444f602d033ef62484ba8 Reviewed-on: https://gerrit.libreoffice.org/74563 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-03Remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I89c082d62409b40c8472b865cc60b0d10923c9c1 Reviewed-on: https://gerrit.libreoffice.org/75015 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-01tdf#125824 svx: fix crash with view1 and view2 doing texteditXisco Fauli
Similar to 3a874f1c80c37e8b35666e1d73161ff762eb7e4c Change-Id: I51bffa4d33e82bb90b8a42787f55c12746bcd8c2 Reviewed-on: https://gerrit.libreoffice.org/74931 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-27tdf#126137: Do not dereference non-existing ObjectXisco Fauli
Regression from dfefe448c41921f2f1e54d3f69b8b9e89031d055 Use same logic as in c28ec6d9fbb21b363102faac0171de2754ea5d75 Change-Id: Ia489eb61873d38c31729fedb853b11570e562123 Reviewed-on: https://gerrit.libreoffice.org/74811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-26Index on WID+memberID in SvxItemPropertySet::aCombineListStephan Bergmann
...instead of just WID. For example when loading caolan/sdrobject_getmergeditemset_null_ptr_dereference.sample (from the crashtestdata files) under UBSan, > #4 0x00007fffeeacde54 in SvxItemPropertySet::getPropertyValue(SfxItemPropertySimpleEntry const*) const (this=0x607001a356d0, pMap=0x604000ec2e60) at /home/sbergman/lo/core/editeng/source/uno/unoipset.cxx:219 > #5 0x00007fffda713cb9 in SvxShape::_getPropertyValue(rtl::OUString const&) (this=0x6150015d7980, PropertyName="CharUnderlineColor") at /home/sbergman/lo/core/svx/source/unodraw/unoshape.cxx:1775 > #6 0x00007fffda70dbe9 in SvxShape::getPropertyValue(rtl::OUString const&) (this=0x6150015d7980, PropertyName="CharUnderlineColor") at /home/sbergman/lo/core/svx/source/unodraw/unoshape.cxx:1721 > #7 0x00007fffda713f3e in non-virtual thunk to SvxShape::getPropertyValue(rtl::OUString const&) () at /home/sbergman/lo/core/instdir/program/libsvxcorelo.so > #8 0x00007fff19e8cfa6 in SwXShape::_getPropAtAggrObj(rtl::OUString const&) (this=0x610000183540, _rPropertyName="CharUnderlineColor") at /home/sbergman/lo/core/sw/source/core/unocore/unodraw.cxx:1735 > #9 0x00007fff19e8b511 in SwXShape::getPropertyValue(rtl::OUString const&) (this=0x610000183540, rPropertyName="CharUnderlineColor") at /home/sbergman/lo/core/sw/source/core/unocore/unodraw.cxx:1665 [...] would first store an Any with value sal_Int32 -1 (representing an RGBA 255/255/255/255 color) in aCombineList for property CharUnderlineColor with WID = EE_CHAR_UNDERLINE = 4027 and member-ID = MID_TL_COLOR = 2, but then read back out that Any for property CharUnderline with the same WID but member-ID = MID_TL_STYLE = 1 and use it at > include/svl/eitem.hxx:47:20: runtime error: load of value 4294967295, which is not a valid value for type 'FontLineStyle' > #0 in SfxEnumItem<FontLineStyle>::SetValue(FontLineStyle) at include/svl/eitem.hxx:47:20 > #1 in SvxTextLineItem::PutValue(com::sun::star::uno::Any const&, unsigned char) at editeng/source/items/textitem.cxx:1016:13 > #2 in SvxItemPropertySet::setPropertyValue(SfxItemPropertySimpleEntry const*, com::sun::star::uno::Any const&, SfxItemSet&, bool) at editeng/source/uno/unoipset.cxx:178:19 > #3 in SvxItemPropertySet_setPropertyValue(SfxItemPropertySimpleEntry const*, com::sun::star::uno::Any const&, SfxItemSet&) at svx/source/unodraw/unoshape.cxx:4119:5 > #4 in SvxItemPropertySet_ObtainSettingsFromPropertySet(SvxItemPropertySet const&, SfxItemSet&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, SfxItemPropertyMap const*) at svx/source/unodraw/unoshape.cxx:638:29 > #5 in SvxShape::ObtainSettingsFromPropertySet(SvxItemPropertySet const&) at svx/source/unodraw/unoshape.cxx:656:9 > #6 in SvxShape::Create(SdrObject*, SvxDrawPage*) at svx/source/unodraw/unoshape.cxx:413:5 > #7 in SvxShapeText::Create(SdrObject*, SvxDrawPage*) at svx/source/unodraw/unoshape.cxx:3867:15 > #8 in SvxDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at svx/source/unodraw/unopage.cxx:234:13 > #9 in SwXDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at sw/source/core/unocore/unodraw.cxx:597:19 > #10 in SwXShape::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unodraw.cxx:2056:22 [...] Change-Id: Ic0cf34440507c768b13d1b5b957425d6a43271ac Reviewed-on: https://gerrit.libreoffice.org/74635 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-25use common WeldEditViewCaolán McNamara
Change-Id: I873cb64a167027030c9eeef61344e6f6f885a924 Reviewed-on: https://gerrit.libreoffice.org/74705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25weld HyperLink DialogCaolán McNamara
Change-Id: Ic861b0a593505828a900fe2163125d6f5584a956 Reviewed-on: https://gerrit.libreoffice.org/74634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-24don't compile MediaPlaybackPanel if we don't have avmediaTomaž Vajngerl
This sidebar panel causes missing symbols when compiling for ios, where we disable avmedia support. Change-Id: Ib79a6debc27e5d5be4b4c388077ac1a3bf8c97b4 Reviewed-on: https://gerrit.libreoffice.org/74626 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-23Resolves: tdf#126039 erase old content before drawing new contentCaolán McNamara
Change-Id: I0006467f5c172b6a0cb8b9bc4c9a0181fd57a8ac Reviewed-on: https://gerrit.libreoffice.org/74583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21weld SpellDialogCaolán McNamara
a) use EditEngine instead of TextEngine as the former can be hosted in a foreign widget b) use a SfxGrabBagItem to hold the custom spellchecking info inside the EditEngine c) in longer paragraphs the current word is now auto-scrolled into view d) rename Invalidate to InvalidateDialog Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1 Reviewed-on: https://gerrit.libreoffice.org/74119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21Drop INetURLObject::GetName and INetURLObject::GetExtensionMike Kaganski
They are just synonyms for GetLastName and GetFileExtension resp. Change-Id: Ic498c7025cc421b830394ed94d64529fd74fe7dd Reviewed-on: https://gerrit.libreoffice.org/74448 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-18loplugin:passstuffbyrefNoel Grandin
Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb Reviewed-on: https://gerrit.libreoffice.org/74246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18tdf#111707 Add 'Remove Hyperlink' to context menu in ImpressSamuel Mehrbrodt
"Clear formatting" no longer removes the hyperlink, as now there is a dedicated context menu entry for this. Change-Id: Ic47795b9ecb238470f853da527c648f6edb94c09 Reviewed-on: https://gerrit.libreoffice.org/74272 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2025-02-07 05:00:08 +0000