summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2024-06-10svx: prefix members of SdrGrafObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: Icc587c31582fb5fdfbdfe375005b96ea219bf4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168597 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-06tdf#153008 svx: impl crop for stretched bitmap fillAttila Szűcs
The ticket had a pptx with a: <a:blipFill> <a:stretch> <a:fillRect ...> Impress loaded the fillRect as a crop, but never used. Implemented a crop in SdrFillGraphicAttribute::createFillGraphicAttribute because in the case of stretching, it blindly used the whole picture. Cropping data was not available there so it is copied into OffsetPosition, and Size Change-Id: I195cc40a35dc24c708e7c0e3cdbe40d6e47b8ce5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06tdf#161151 finish renaming gradient geometries in sidebarStéphane Guillou
Change-Id: I8ffa123427302cb091c5bb603aede711a32ecdbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168415 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-06-05annot: add {add,remove}Annotation that don't notifyTomaž Vajngerl
Add addAnnotationNoNotify method, that doesn't broadcast that an annotation was added, and change addAnnotation to call the method and in addition call the broadcast bits. Previously all this had happened in the addAnnotation without the choice to not broadcast. Change removeAnnotation in a similar way. Change-Id: Ie15a386a8b8d4493d5b41fcbcb55924a693b46d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168429 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-05Related: tdf#153008 bump XFillBmpPosOffsetXItem to sal_Int32Caolán McNamara
and XFillBmpPosOffsetYItem. To avoid sal_uInt16 overflows on large input values. Lets use sal_Int32 instead of sal_uInt32 given the amount of existing casting to sal_Int32 of XFillBmpPosOffset[X|Y]Item::GetValue() Change-Id: I8329c11b75c9ad01011e10130257963737ffe553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168398 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Attila Szűcs <attila.szucs@collabora.com> Tested-by: Jenkins
2024-06-05annot: prepare SdrObject to represent an annotationTomaž Vajngerl
Change-Id: Iabcc2166ea20cbeac6d2ada7120700a4e8b19303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168428 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-03crashtesting: BrowseBox::GetControlArea crashCaolán McNamara
see with forums/ods/forum-en-11050.ods Change-Id: I2b1dadf51ab8efa1b66f5b7463b05ad4dc52f91d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168386 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-03svx: prefix members of SdrUndoGeoObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ic34b5e1c7a1b73d688cc4dfc87c03417fe8e987b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168357 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-02svx: use SAL_RET_MAYBENULL in GetSfxViewShell()Xisco Fauli
Change-Id: I05e66544c08a1ed55a5571f6061b23346235224e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168293 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-01Advanced Diagram support: Load fill DiagramModelArmin Le Grand (allotropia)
In the case the input file does have a graphical representation of the Diagram as image file, the DiagramModel was not fully loaded. For being able to edit the Diagram in the future it is necessary to re-create the geometry, thus a full model is needed. Needed to know at recreation if this is the first time the geometry gets self-created using the layout/creation mechanism to decide if to apply the style or use the saved/reapplyable data from secure/restoreDataFromShapeToModelAfterDiagramImport mechanism, added that. Change-Id: Icb7590306ab59728e83b800b8637333e0d372de5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168223 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2024-06-01Fix typoAndrea Gelmini
Change-Id: Ifaadd20fd08f1f1c2c74ba9e24f32d41b4ba81b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168331 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-01tdf#161198 tdf#161322 fix selection overlaysNoel Grandin
revert commit 7b1405689d4246e0e37e8759f03e1962af964cec Author: Noel Grandin <noelgrandin@gmail.com> Date: Fri Apr 19 22:56:04 2024 +0200 reduce the number of drawing primitives we create in OverlaySelection Change-Id: I868540aadb3a75582990ae4491807991617215b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-31tdf#161354: drop incorrect assertionMike Kaganski
Change-Id: I49eb5c52ef843f4615f1cf1549cd59c365e5ce1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168277 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-31svx: Reduce number of calls to GetMarkedObjectList()Xisco Fauli
from 447 to 208 Change-Id: I7b289b61a4ec416b9809f1433bb7a824ef488cb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168227 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30AreObjectsMarked -> GetMarkedObjectList().GetMarkCount() != 0Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Ib2eb7c88338e64744f886a338acca65f782f8170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168218 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30GetMarkedObjectByIndex -> GetMarkedObjectList().GetMark()->GetMarkedSdrObj()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I57ab7d2d8edd98da5175bd1066dfab0fa2cc888e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168220 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30svx: GetSdrPageViewOfMarkedByIndex() -> ...Xisco Fauli
... GetMarkedObjectList().GetMark(nNum)->GetPageView() In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: If79125cc13fff7b8944c50202e0564de6bf8302e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168219 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29SortMarkedObjects() -> GetMarkedObjectList().ForceSort()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Ia74949a47308f95607881a7d44c8c26404902745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168217 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29GetDescriptionOfMarkedObjects() -> GetMarkedObjectList().GetMarkDescription()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I2a2c87c2552cfc9002a9afc7d8eefb16a601b784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168216 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29svx: GetDescriptionOfMarkedPoints() -> ...Xisco Fauli
... GetMarkedObjectList().GetPointMarkDescription() In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I5886fd20ffd9df115e12947f4dc7293c98b50bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168215 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29svx: GetDescriptionOfMarkedGluePoints() -> ...Xisco Fauli
... GetMarkedObjectList().GetGluePointMarkDescription() In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I7eb9bd7cfdaa53b9afcae5bc05cc2c014e0ce1e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168214 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29GetMarkedObjectCount() -> GetMarkedObjectList().GetMarkCount()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Id94f66545950f0fdf124ba7b985a5215a01d63fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168213 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29svx: TryToFindMarkedObject -> GetMarkedObjectList().FindObjectXisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: If05f5630e9413c162821370532f36598fc2e0341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168212 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-29svx: GetSdrMarkByIndex -> GetMarkedObjectList().GetMarkXisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Iec0ad9ed33329719116e39232f86d92dbd6e0da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168211 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-28avoid dynamic_cast in SwView::NotifyNoel Grandin
Change-Id: Id2b8f0f85165d442a5e3a54ee2e3b433f53b3613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-27svx: prefix members of FmFormViewMiklos Vajna
See tdf#94879 for motivation. Change-Id: I142e2259e150fd0247193dcb941fb2fe37018486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168083 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-05-26Resolves: tdf#155364 resize buttons and change widget font sizes on zoomCaolán McNamara
Change-Id: Ied951e6c96881bd56a40ae01077cd7f76f9b7853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-26Use Rectangle::expand instead of four Adjust* callsMike Kaganski
Change-Id: I0d1cf1e1609fee235d8df12714d59b408d3193bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-22Handle empty range correctlyMike Kaganski
Otherwise, the translation gets MAX_DBL value, and scaling becomes 0. After commit 690526f95e3ee4fd25bb2c987e093543e4bc435b (Generalize basegfx::fround for templated return type, 2024-04-15) this made some documents (e.g., bugdoc in tdf#85132) fail an assertion in debug builds, which allowed to find and fix this problem. Change-Id: I14cb0afd0c8d884f505efb921907cc8e86418da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167965 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-21svx: prefix members of SdrUndoDelPageMiklos Vajna
See tdf#94879 for motivation. Change-Id: I6ef4ca1df66f22e4fb6a13a7b39ca0152484fd6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-21tdf#69724 Allow to change default bullet symbols in UITibor Nagy
Change-Id: Ife700096fb55ebc752ae289398a36ee78b3e5ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167660 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-19Resolves: tdf#157453 support FM_PROP_LINECOUNT for combobox dropdow rowsCaolán McNamara
Change-Id: I3d18ed505c2eea7305903f9a476c332db0148113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-17WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I4bb077ea634d9ca3e238981cfcc307a1b6caf7c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-16WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: If4ca47bc4d8203ed7d20e1bbf1c3ebe2587c403f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167709 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-16tdf#161056 Show bullets used in document in bullets dropdownSamuel Mehrbrodt
Change-Id: I40cfc39501006146f7c6c04a1f3c7cf877c6f1c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167186 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-16tdf#146619 Drop unused 'using namespace com::sun::star'Gabor Kelemen
now that find-unused-includes was expanded with detecting these Change-Id: I9f21ad1a85c1e3178cad98464b2ba407d909b62d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167638 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-05-16Fix typo in codeAndrea Gelmini
Change-Id: I2529fd2bf9e79b704fbe594bd6b7399cba5c3a25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167443 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-05-14tdf#161019 tdf#159846 spreadsheet border renderingNoel Grandin
regression from commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Jun 19 12:23:55 2023 +0200 tdf#150534 reduce the memory consumption of cells when calculating Change-Id: Id8b52a3a0880bbb6a7aff28f55bcd57cb1cae048 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-14annot: move TextAPI to svx and adapt the codeTomaž Vajngerl
TextApiObject is derived from SvxUnoText and holds and handles the text in the annotation. This functionality is changed to get rid of sd module specifics and moved to svx module. This now allows to move the most improtant parts of the Annotation object to svx. Change-Id: I34e238616e7fac973e75e79bb60a8d093c493258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166497 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2024-05-14tdf#84507 move contour text to correct place in rotated...Regina Henschel
...path objects. I first tried to change the UnitPolyPolygon in ViewContactOfSdrPathObj::createViewIndependentPrimitive2DSequence(). But it is needed in that way to draw the geometry of the object. Now the change is made in SdrTextObj::impDecomposeContourTextPrimitive(). The basic idea is to recover the original PolyPolygon and transform it so, that the transformed text is placed into the transformed PolyPolygon. The ObjectMatrix gets a translation then, which moves the transformed text to the correct position in the PolyPolygon. For East Asian writingmode tb-rl, the text start needs to be top-right. Added that, which resolves bug 128433. If the shape has a fat stroke the text reaches into the stroke currently. I have changed the code so that now a reduced area for the text is used. The polypolygon behaves now same as the legacy rectangle. Sometimes not all text is drawn although the rotated PolyPolygon would have enought place for it. Or in other cases the text spills out of the PolyPolygon. But I don't know a solution yet. As the other changes are an improvement, this problem can be solved later. Change-Id: I951024bf0d6d992587ec9cf2ed37665f322b66fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167299 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-05-13createFromAscii -> OUString literals in ControlLayouterNoel Grandin
Change-Id: Ie26d310540944bd17cf25e1521878964f3026562 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167593 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-13createFromAscii -> OUString literals in FmSearchConfigItemNoel Grandin
Change-Id: Ic4c2e2825c50e3977ac5773b3eb8ae0de2c86ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-13Update to ICU 74.1Taichi Haradaguchi
https://icu.unicode.org/download/74 Unicode 15.1 https://blog.unicode.org/2023/09/announcing-unicode-standard-version-151.html CLDR 44 https://cldr.unicode.org/index/downloads/cldr-44 New Unicode blocks: UBLOCK_CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I Change-Id: Ic9196e10138663d07235f5ebd9cc4bf3a9750824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158749 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2024-05-13createFromAscii -> OUString literals in StylesPreviewToolBoxControlNoel Grandin
Change-Id: Ica3c79facee725effcfb160738305c599c5de1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167575 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-13svx: prefix members of SdrUndoAttrObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: Icecf1b75055c9f487d35ae72589ccb6197cfeaff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167566 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-05-12cid#1597307 silence Unchecked return valueCaolán McNamara
and cid#1597304 Unchecked return value cid#1597303 Unchecked return value cid#1597306 Unchecked return value cid#1597305 Unchecked return value Change-Id: I2fa1c467751405d3b69f1d9b552232e4d52b610e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12replace createFromAscii with OUString literals in OConfigurationValueContainerNoel Grandin
Change-Id: Ib94018bfc542c91c01894006076eb16023d104ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12replace createFromAscii with OUString literals in SvxStyleToolBoxControlNoel Grandin
Change-Id: Ibdf5f7b0100cafbecc263a038b2234012da10fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12replace createFromAscii with OUString literals in EnhancedCustomShapeTypeNamesNoel Grandin
Change-Id: I69b89d7ee86c1d0b2dbdc4553cc12c01bdd76d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167530 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-09 14:08:31 +0000