summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-11-30tdf#111773 tdf#111780 Fix selection after merge cells in an Impress tableDaniel
Change-Id: I800c4fb8c37c07fb771f4310b207e459119a8e60 Reviewed-on: https://gerrit.libreoffice.org/45451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30coverity#1424325 Uninitialized scalar fieldCaolán McNamara
and coverity#1424323 Uninitialized scalar field Change-Id: I00855321a4099720b903553a46f45f6919f71880
2017-11-29loplugin:unusedmethodsNoel Grandin
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1 Reviewed-on: https://gerrit.libreoffice.org/45386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28ofz#4461 Integer-overflowCaolán McNamara
Change-Id: Iae41823164c09352ef8ffa97dc3361476c03add8 Reviewed-on: https://gerrit.libreoffice.org/45396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28tdf#109202: Convert images to desired format in (f)odt filterKatarina Behrens
Pass down mimetype to SvXMLGraphicHelper Change-Id: I9c81c06d2a1d6168704440094081e99d0bcbbff9 Reviewed-on: https://gerrit.libreoffice.org/41893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28loplugin:countusersofdefaultparams in sfx2..svtoolsNoel Grandin
Change-Id: I65ae5305f9cec14069fd7aef6613e981dbbed846 Reviewed-on: https://gerrit.libreoffice.org/45382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28tdf#83877 OOXML Roundtrip of SignatureLine propertiesSamuel Mehrbrodt
Change-Id: I521e5f35663c5ab3c2702f1416fcec872f2f5e3f Reviewed-on: https://gerrit.libreoffice.org/44683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28loplugin:countusersofdefaultparams in svxNoel Grandin
Change-Id: I2c9ea6c38b75dcafeb36931b6c2e94489819144f Reviewed-on: https://gerrit.libreoffice.org/45336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27tdf#114078 Missing gettext markup on Numbering format stringsCaolán McNamara
Change-Id: I8ac705dc964d23984cba00f51ec25ad07243554e Reviewed-on: https://gerrit.libreoffice.org/45329 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27TSCP: don't put a non-existing name into doc. propsTomaž Vajngerl
We combined the abbr. name with the name and put that as a value into doc. properties. This is not correct as such a name doesn't exist in the BAPolicy and con't be identified anymore, so removing this. Also use the values that were put into the ClassificationField instead of the extracted text. Change-Id: I3037bc90a7a394d430f7c0cca4d326473eff3147 Reviewed-on: https://gerrit.libreoffice.org/45316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-27ofz#4441: Divide-by-zeroCaolán McNamara
Change-Id: If83e6bb22239d0fd82f40836601447cbba2f1df4 Reviewed-on: https://gerrit.libreoffice.org/45297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-25ofz#4422 Integer-overflowCaolán McNamara
Change-Id: I1f3a09e34253de7f7a221e2c88d61c293cb69d03 Reviewed-on: https://gerrit.libreoffice.org/45271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24TSCP: fix oversizing of ListBox-es by defining max lines & charsTomaž Vajngerl
Change-Id: I47e8018c5f2c0ea890b5a11ac7cc03fafb7d1eed Reviewed-on: https://gerrit.libreoffice.org/45205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-24TSCP: Advanced dialog UI improvementsTomaž Vajngerl
- Change the height of TextEdit to ~5 lines (100px) - IPPart: single to double-click to add - IPPartNumber: change to ListBox, same behavior as IPPart - Markings: add on focus change - Category: remove messagebox when the category changed Change-Id: I9e695abc7caa702b2150a96ae15e6ce19fc2458a Reviewed-on: https://gerrit.libreoffice.org/45149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-24TSCP: remove character limitation of recently used pop-upTomaž Vajngerl
Change-Id: I886fe180e73aea9685e647aaa3283f707344f69f Reviewed-on: https://gerrit.libreoffice.org/44947 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-23svx: loplugin:staticmethodsMichael Stahl
Change-Id: I8786baa0a5142397c157e01d5b99aa2c482bb468
2017-11-23tdf#113657: fix crash when trying to format empty paragraphJulien Nabet
by creating a function to clean line feeds and returns if it's empty or not Change-Id: I3a744c52bdb457c92f38595463099e1cbf17a37e Reviewed-on: https://gerrit.libreoffice.org/44513 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22loplugin:flatten in svxNoel Grandin
Change-Id: Idc4d0186ecc6f0722c2b1358486a2430f037ae29 Reviewed-on: https://gerrit.libreoffice.org/45036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21UNO: Emit warning when trying to set an unknown propertySamuel Mehrbrodt
Change-Id: I51afd43c1fd52c7be521f8884dd41cecde312981 Reviewed-on: https://gerrit.libreoffice.org/44872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-21Avoid bad static type in dynamic_castStephan Bergmann
...when the casted object is already in destruction, beyond the static type stated in the dynamic_cast. Happens e.g. during 'make CppunitTest_sw_ooxmlexport2' (with a backtrace as per below). With <https://reviews.llvm.org/D40295> "-fsanitize=vptr warnings on bad static types in dynamic_cast and typeid" this will be found by Clang's -fsanitize=vptr. (On macOS with Apple's libcxxabi with _LIBCXX_DYNAMIC_FALLBACK enabled, this caused---somewhat misleading---messages like > dynamic_cast error 2: One or more of the following type_info's has hidden visibility. They should all have public visibility. 7SdrView, 12SdrPaintView, 10FmFormView. in /var/log/system.log during e.g. 'make CppunitTest_sw_ooxmlexport2', where libcxxabi's __dynamic_cast does not expect to be called with such invalid data.) > #0: libsystem_asl.dylib`syslog > #1: libc++abi.dylib`__dynamic_cast + 339 > #2: libsvxcorelo.dylib`SdrPageWindow::~SdrPageWindow(this=0x00000001b3a86aa0) + 289 at svx/source/svdraw/sdrpagewindow.cxx:139 > #3: libsvxcorelo.dylib`SdrPageWindow::~SdrPageWindow(this=0x00000001b3a86aa0) + 21 at svx/source/svdraw/sdrpagewindow.cxx:130 > #4: libsvxcorelo.dylib`SdrPageView::ClearPageWindows(this=0x0000000208635180) + 543 at svx/source/svdraw/svdpagv.cxx:112 > #5: libsvxcorelo.dylib`SdrPageView::~SdrPageView(this=0x0000000208635180) + 25 at svx/source/svdraw/svdpagv.cxx:167 > #6: libsvxcorelo.dylib`SdrPageView::~SdrPageView(this=0x0000000208635180) + 21 at svx/source/svdraw/svdpagv.cxx:164 > #7: libsvxcorelo.dylib`SdrPaintView::ClearPageView(this=0x0000000101112000) + 81 at svx/source/svdraw/svdpntv.cxx:401 > #8: libsvxcorelo.dylib`SdrPaintView::~SdrPaintView(this=0x0000000101112000) + 514 at svx/source/svdraw/svdpntv.cxx:213 > #9: libsvxcorelo.dylib`SdrSnapView::~SdrSnapView(this=0x0000000101112000) + 135 at svx/source/svdraw/svdsnpv.cxx:199 > #10: libsvxcorelo.dylib`SdrMarkView::~SdrMarkView(this=0x0000000101112000) + 149 at svx/source/svdraw/svdmrkv.cxx:165 > #11: libsvxcorelo.dylib`SdrEditView::~SdrEditView(this=0x0000000101112000) + 21 at svx/source/svdraw/svdedtv.cxx:99 > #12: libsvxcorelo.dylib`SdrPolyEditView::~SdrPolyEditView(this=0x0000000101112000) + 49 at svx/source/svdraw/svdpoev.cxx:55 > #13: libsvxcorelo.dylib`SdrGlueEditView::~SdrGlueEditView(this=0x0000000101112000) + 21 at svx/source/svdraw/svdglev.cxx:40 > #14: libsvxcorelo.dylib`SdrObjEditView::~SdrObjEditView(this=0x0000000101112000) + 673 at svx/source/svdraw/svdedxv.cxx:106 > #15: libsvxcorelo.dylib`SdrExchangeView::~SdrExchangeView(this=0x0000000101112000) + 21 at include/svx/svdxcgv.hxx:28 > #16: libsvxcorelo.dylib`SdrDragView::~SdrDragView(this=0x0000000101112000) + 139 at svx/source/svdraw/svddrgv.cxx:84 > #17: libsvxcorelo.dylib`SdrCreateView::~SdrCreateView(this=0x0000000101112000) + 179 at svx/source/svdraw/svdcrtv.cxx:213 > #18: libsvxcorelo.dylib`SdrView::~SdrView(this=0x0000000101112000) + 172 at svx/source/svdraw/svdview.cxx:164 > #19: libsvxcorelo.dylib`E3dView::~E3dView(this=0x0000000101112000) + 21 at svx/source/engine3d/view3d.cxx:1500 > #20: libsvxcorelo.dylib`FmFormView::~FmFormView(this=0x0000000101112000) + 269 at svx/source/form/fmview.cxx:139 > #21: libsvxcorelo.dylib`FmFormView::~FmFormView(this=0x0000000101112000) + 21 at svx/source/form/fmview.cxx:134 > #22: libsvxcorelo.dylib`FmFormView::~FmFormView(this=0x0000000101112000) + 25 at svx/source/form/fmview.cxx:134 > #23: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::default_delete<FmFormView>::operator(this=0x00007ffeefbe3650, __ptr=0x0000000101112000)(FmFormView*) const + 6894 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2397 > #24: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::unique_ptr<FmFormView, std::__1::default_delete<FmFormView> >::reset(this=0x00007ffeefbe3650, __p=0x0000000000000000) + 125 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2603 > #25: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::unique_ptr<FmFormView, std::__1::default_delete<FmFormView> >::~unique_ptr(this=0x00007ffeefbe3650) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2571 > #26: libsclo.dylib`ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) [inlined] std::__1::unique_ptr<FmFormView, std::__1::default_delete<FmFormView> >::~unique_ptr(this=0x00007ffeefbe3650) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2571 > #27: libsclo.dylib`ScPrintFunc::DrawToDev(pDoc=0x0000000102b34460, pDev=0x0000000208603810, (null)=1, rBound=0x00007ffeefbe38e8, pViewData=0x00007ffeefbe3928, bMetaFile=true) + 6729 at sc/source/ui/view/printfun.cxx:601 > #28: libsclo.dylib`ScDocShell::Draw(this=0x0000000102b34400, pDev=0x0000000208603810, (null)=0x00007ffeefbe4068, nAspect=1) + 631 at sc/source/ui/docshell/docsh4.cxx:2007 > #29: libsfxlo.dylib`SfxObjectShell::DoDraw_Impl(this=0x0000000102b34400, pDev=0x0000000208603810, rViewPos=0x00007ffeefbe4070, rScaleX=0x00007ffeefbe3eb0, rScaleY=0x00007ffeefbe3ea8, rSetup=0x00007ffeefbe4068, nAspect=1) + 1314 at sfx2/source/doc/objembed.cxx:231 > #30: libsfxlo.dylib`SfxObjectShell::DoDraw(this=0x0000000102b34400, pDev=0x0000000208603810, rObjPos=0x00007ffeefbe4070, rSize=0x00007ffeefbe4118, rSetup=0x00007ffeefbe4068, nAspect=1) + 578 at sfx2/source/doc/objembed.cxx:178 > #31: libsfxlo.dylib`SfxObjectShell::CreatePreviewMetaFile_Impl(this=0x0000000102b34400, bFullContent=true) const + 1666 at sfx2/source/doc/objcont.cxx:169 > #32: libsfxlo.dylib`SfxObjectShell::GetPreviewMetaFile(this=0x0000000102b34400, bFullContent=true) const + 43 at sfx2/source/doc/objcont.cxx:116 > #33: libsfxlo.dylib`SfxBaseModel::getTransferData(this=0x0000000152f7d228, aFlavor=0x00007ffeefbe4c40) + 2917 at sfx2/source/doc/sfxbasemodel.cxx:1933 > #34: libsfxlo.dylib`SfxBaseModel::getPreferredVisualRepresentation(this=0x0000000152f7d228, (null)=1) + 245 at sfx2/source/doc/sfxbasemodel.cxx:3544 > #35: libsfxlo.dylib`non-virtual thunk to SfxBaseModel::getPreferredVisualRepresentation(this=0x0000000152f7d228, (null)=1) + 54 at sfx2/source/doc/sfxbasemodel.cxx:0 > #36: libembobj.dylib`OCommonEmbeddedObject::getPreferredVisualRepresentation(this=0x0000000152f7db28, nAspect=1) + 1775 at embeddedobj/source/commonembedding/visobj.cxx:185 > #37: libcomphelper.dylib`comphelper::EmbeddedObjectContainer::GetGraphicReplacementStream(nViewAspect=1, xObj=0x0000000208630470, pMediaType=0x0000000208630488) + 147 at comphelper/source/container/embeddedobjectcontainer.cxx:1504 > #38: libsvtlo.dylib`svt::EmbeddedObjectRef::GetGraphicReplacementStream(nViewAspect=1, xObj=0x0000000208630470, pMediaType=0x0000000208630488) + 44 at svtools/source/misc/embedhlp.cxx:777 > #39: libsvtlo.dylib`svt::EmbeddedObjectRef::GetGraphicStream(this=0x0000000208643c58, bUpdate=true) const + 3482 at svtools/source/misc/embedhlp.cxx:601 > #40: libsvtlo.dylib`svt::EmbeddedObjectRef::GetReplacement(this=0x0000000208643c58, bUpdate=true) + 1501 at svtools/source/misc/embedhlp.cxx:419 > #41: libsvtlo.dylib`svt::EmbeddedObjectRef::UpdateReplacement(this=0x0000000208643c58) + 26 at svtools/source/misc/embedhlp.cxx:808 > #42: libsvtlo.dylib`svt::EmbedEventListener_Impl::modified(this=0x0000000150a04d28, (null)=0x00007ffeefbe5d10) + 211 at svtools/source/misc/embedhlp.cxx:170 > #43: libsvtlo.dylib`non-virtual thunk to svt::EmbedEventListener_Impl::modified(this=0x0000000150a04d28, (null)=0x00007ffeefbe5d10) + 44 at svtools/source/misc/embedhlp.cxx:0 > #44: libsfxlo.dylib`cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::util::XModifyListener, com::sun::star::lang::EventObject>::operator(this=0x00007ffeefbe5c50, listener=0x00007ffeefbe5bc0)(com::sun::star::uno::Reference<com::sun::star::util::XModifyListener> const&) const + 126 at include/cppuhelper/interfacecontainer.h:274 > #45: libsfxlo.dylib`void cppu::OInterfaceContainerHelper::forEach<com::sun::star::util::XModifyListener, cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::util::XModifyListener, com::sun::star::lang::EventObject> >(this=0x00000001eec5fcc8, func=0x00007ffeefbe5c50) + 163 at include/cppuhelper/interfacecontainer.h:287 > #46: libsfxlo.dylib`void cppu::OInterfaceContainerHelper::notifyEach<com::sun::star::util::XModifyListener, com::sun::star::lang::EventObject>(this=0x00000001eec5fcc8, NotificationMethod=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, Event=0x00007ffeefbe5d10)(com::sun::star::lang::EventObject const&), com::sun::star::lang::EventObject const&) + 126 at include/cppuhelper/interfacecontainer.h:300 > #47: libsfxlo.dylib`SfxBaseModel::NotifyModifyListeners_Impl(this=0x0000000152f7d228) const + 258 at sfx2/source/doc/sfxbasemodel.cxx:2747 > #48: libsfxlo.dylib`SfxBaseModel::changing(this=0x0000000152f7d228) + 262 at sfx2/source/doc/sfxbasemodel.cxx:2763 > #49: libsfxlo.dylib`SfxBaseModel::Notify(this=0x0000000152f7d228, rBC=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 261 at sfx2/source/doc/sfxbasemodel.cxx:2651 > #50: libsclo.dylib`ScModelObj::Notify(this=0x0000000152f7d228, rBC=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 573 at sc/source/ui/unoobj/docuno.cxx:1312 > #51: libsclo.dylib`non-virtual thunk to ScModelObj::Notify(this=0x0000000152f7d228, rBC=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 55 at sc/source/ui/unoobj/docuno.cxx:0 > #52: libsvllo.dylib`SfxBroadcaster::Broadcast(this=0x0000000102b34400, rHint=0x00007ffeefbe62e8) + 211 at svl/source/notify/SfxBroadcaster.cxx:49 > #53: libsclo.dylib`ScDocShell::SetModified(this=0x0000000102b34400, bModified=true) + 112 at sc/source/ui/docshell/docsh.cxx:2789 > #54: libsclo.dylib`ScDocShell::SetDrawModified(this=0x0000000102b34400) + 63 at sc/source/ui/docshell/docsh.cxx:2855 > #55: libsclo.dylib`ScDocShell::SetDocumentModified(this=0x0000000102b34400) + 337 at sc/source/ui/docshell/docsh.cxx:2811 > #56: libsclo.dylib`ScDocShell::UnlockPaint_Impl(this=0x0000000102b34400, bDoc=false) + 747 at sc/source/ui/docshell/docsh3.cxx:265 > #57: libsclo.dylib`ScDocShell::UnlockPaint(this=0x0000000102b34400) + 23 at sc/source/ui/docshell/docsh3.cxx:322 > #58: libsclo.dylib`ScModelObj::unlockControllers(this=0x0000000152f7d228) + 137 at sc/source/ui/unoobj/docuno.cxx:2111 > #59: libsclo.dylib`non-virtual thunk to ScModelObj::unlockControllers(this=0x0000000152f7d228) + 28 at sc/source/ui/unoobj/docuno.cxx:0 > #60: libooxlo.dylib`oox::core::FilterBase::filter(this=0x000000015317b5b0, rMediaDescSeq=0x00007ffeefbe6d90) + 2756 at oox/source/core/filterbase.cxx:499 > #61: libscfiltlo.dylib`oox::xls::ExcelFilter::filter(this=0x000000015317b5b0, rDescriptor=0x00007ffeefbe6d90) + 64 at sc/source/filter/oox/excelfilter.cxx:154 > #62: libscfiltlo.dylib`non-virtual thunk to oox::xls::ExcelFilter::filter(this=0x000000015317b5b0, rDescriptor=0x00007ffeefbe6d90) + 44 at sc/source/filter/oox/excelfilter.cxx:0 > #63: libwriterfilterlo.dylib`writerfilter::dmapper::OLEHandler::importStream(this=0x00000001ef171f80, xComponentContext=0x0000000102ad0830, xTextDocument=0x0000000102ad0818, xOLE=0x00007ffeefbe7378) + 2778 at writerfilter/source/dmapper/OLEHandler.cxx:221 > #64: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper_Impl::appendOLE(this=0x0000000102ad0800, rStreamName=0x00007ffeefbeaad0, pOLEHandler=std::__1::shared_ptr<writerfilter::dmapper::OLEHandler>::element_type @ 0x00000001ef171f80 strong=1 weak=1) + 4050 at writerfilter/source/dmapper/DomainMapper_Impl.cxx:1504 > #65: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper::sprmWithProps(this=0x00000001ef10bd30, rSprm=0x00000001ef139eb0, rContext=std::__1::shared_ptr<writerfilter::dmapper::PropertyMap>::element_type @ 0x00000001ef164750 strong=2 weak=1) + 50245 at writerfilter/source/dmapper/DomainMapper.cxx:2432 > #66: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper::lcl_sprm(this=0x00000001ef10bd30, rSprm=0x00000001ef139eb0) + 212 at writerfilter/source/dmapper/DomainMapper.cxx:1164 > #67: libwriterfilterlo.dylib`writerfilter::LoggedProperties::sprm(this=0x00000001ef10bd30, rSprm=0x00000001ef139eb0) + 688 at writerfilter/source/dmapper/LoggedResources.cxx:366 > #68: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLProperty::resolve(this=0x00000001ef139eb0, rProperties=0x00000001ef10bd30) + 147 at writerfilter/source/ooxml/OOXMLPropertySet.cxx:118 > #69: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLPropertySet::resolve(this=0x00000001ef16b130, rHandler=0x00000001ef10bd30) + 273 at writerfilter/source/ooxml/OOXMLPropertySet.cxx:351 > #70: libwriterfilterlo.dylib`writerfilter::dmapper::DomainMapper::lcl_props(this=0x00000001ef10bd30, ref=<unavailable>) + 46 at writerfilter/source/dmapper/DomainMapper.cxx:3477 > #71: libwriterfilterlo.dylib`non-virtual thunk to writerfilter::dmapper::DomainMapper::lcl_props(this=0x00000001ef10bd30, ref=<unavailable>) + 25 at writerfilter/source/dmapper/DomainMapper.cxx:0 > #72: libwriterfilterlo.dylib`writerfilter::LoggedStream::props(this=0x00000001ef10bd30, ref=std::__1::shared_ptr<writerfilter::Reference<writerfilter::Properties> >::element_type @ 0x00000001ef16b130 strong=3 weak=1) + 396 at writerfilter/source/dmapper/LoggedResources.cxx:255 > #73: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandler::sendPropertiesWithId(this=0x00000001c6ae9190, nId=90005) + 534 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:733 > #74: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFactory_wml::endAction(this=0x000000015401b540, pHandler=0x00000001c6ae9190) + 1915 at workdir/CustomTarget/writerfilter/source/ooxml/OOXMLFactory_wml.cxx:7295 > #75: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFactory::endAction(pHandler=0x00000001c6ae9190) + 103 at writerfilter/source/ooxml/OOXMLFactory.cxx:190 > #76: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandler::endAction(this=0x00000001c6ae9190) + 21 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:269 > #77: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandlerProperties::lcl_endFastElement(this=0x00000001c6ae9190, (null)=921159) + 51 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:980 > #78: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(this=0x00000001c6ae9190, Element=921159) + 113 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1693 > #79: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(this=0x00000001c6ae9190, Element=921159) + 888 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:175 > #80: libwriterfilterlo.dylib`non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(this=0x00000001c6ae9190, Element=921159) + 31 at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:0 > #81: libexpwraplo.dylib`(anonymous namespace)::Entity::endElement(this=0x00000001049a4e00) + 362 at sax/source/fastparser/fastparser.cxx:500 > #82: libexpwraplo.dylib`sax_fastparser::FastSaxParserImpl::callbackEndElement(this=0x00000001dcee9480) + 744 at sax/source/fastparser/fastparser.cxx:1237 > #83: libexpwraplo.dylib`(anonymous namespace)::call_callbackEndElement(userData=0x00000001dcee9480, (null)="object", (null)="w", (null)="http://schemas.openxmlformats.org/wordprocessingml/2006/main") + 41 at sax/source/fastparser/fastparser.cxx:311 > #84: libxml2.2.dylib`xmlParseEndTag2 + 893 > #85: libxml2.2.dylib`xmlParseTryOrFinish + 3522 > #86: libxml2.2.dylib`xmlParseChunk + 1068 > #87: libexpwraplo.dylib`sax_fastparser::FastSaxParserImpl::parse(this=0x00000001dcee9480) + 300 at sax/source/fastparser/fastparser.cxx:1027 > #88: libexpwraplo.dylib`sax_fastparser::FastSaxParserImpl::parseStream(this=0x00000001dcee9480, maStructSource=0x00007ffeefbeda50) + 4739 at sax/source/fastparser/fastparser.cxx:825 > #89: libexpwraplo.dylib`sax_fastparser::FastSaxParser::parseStream(this=0x00000001ef4bd178, aInputSource=0x00007ffeefbeda50) + 60 at sax/source/fastparser/fastparser.cxx:1308 > #90: libexpwraplo.dylib`non-virtual thunk to sax_fastparser::FastSaxParser::parseStream(this=0x00000001ef4bd178, aInputSource=0x00007ffeefbeda50) + 44 at sax/source/fastparser/fastparser.cxx:0 > #91: libwriterfilterlo.dylib`writerfilter::ooxml::OOXMLDocumentImpl::resolve(this=0x00000001dcee9090, rStream=0x00000001ef10bd30) + 2735 at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:490 > #92: libwriterfilterlo.dylib`WriterFilter::filter(this=0x00000001c2a99b08, rDescriptor=0x00007ffeefbeec00) + 3407 at writerfilter/source/filter/WriterFilter.cxx:190 > #93: libwriterfilterlo.dylib`non-virtual thunk to WriterFilter::filter(this=0x00000001c2a99b08, rDescriptor=0x00007ffeefbeec00) + 44 at writerfilter/source/filter/WriterFilter.cxx:0 > #94: libsfxlo.dylib`SfxObjectShell::ImportFrom(this=0x00000001ef5f7550, rMedium=0x00000001ef51d370, xInsertPosition=0x00007ffeefbef328) + 3537 at sfx2/source/doc/objstor.cxx:2217 > #95: libsfxlo.dylib`SfxObjectShell::DoLoad(this=0x00000001ef5f7550, pMed=0x00000001ef51d370) + 5854 at sfx2/source/doc/objstor.cxx:757 > #96: libsfxlo.dylib`SfxBaseModel::load(this=0x00000001ef0eb420, seqArguments=0x00007ffeefbefda0) + 2185 at sfx2/source/doc/sfxbasemodel.cxx:1787 > #97: libsfxlo.dylib`non-virtual thunk to SfxBaseModel::load(this=0x00000001ef0eb420, seqArguments=0x00007ffeefbefda0) + 47 at sfx2/source/doc/sfxbasemodel.cxx:0 > #98: libsfxlo.dylib`(anonymous namespace)::SfxFrameLoader_Impl::load(this=0x0000000150a03f88, rArgs=0x00007ffeefbf0158, _rTargetFrame=0x00007ffeefbf01b0) + 2855 at sfx2/source/view/frmload.cxx:693 > #99: libsfxlo.dylib`non-virtual thunk to (anonymous namespace)::SfxFrameLoader_Impl::load(this=0x0000000150a03f88, rArgs=0x00007ffeefbf0158, _rTargetFrame=0x00007ffeefbf01b0) + 52 at sfx2/source/view/frmload.cxx:0 > #100: libfwklo.dylib`framework::LoadEnv::impl_loadContent(this=0x00007ffeefbf0878) + 4564 at framework/source/loadenv/loadenv.cxx:1098 > #101: libfwklo.dylib`framework::LoadEnv::startLoading(this=0x00007ffeefbf0878) + 860 at framework/source/loadenv/loadenv.cxx:372 > #102: libfwklo.dylib`framework::LoadEnv::loadComponentFromURL(xLoader=0x00007ffeefbf09f0, xContext=0x000000010b9a6198, sURL=0x000000010c9d2430, sTarget=0x00007ffeefbf12a0, nFlags=0, lArgs=0x00007ffeefbf1298) + 292 at framework/source/loadenv/loadenv.cxx:158 > #103: libfwklo.dylib`framework::Desktop::loadComponentFromURL(this=0x000000010b9a6078, sURL=0x000000010c9d2430, sTargetFrameName=0x00007ffeefbf12a0, nSearchFlags=0, lArguments=0x00007ffeefbf1298) + 337 at framework/source/services/desktop.cxx:618 > #104: libfwklo.dylib`non-virtual thunk to framework::Desktop::loadComponentFromURL(this=0x000000010b9a6078, sURL=0x000000010c9d2430, sTargetFrameName=0x00007ffeefbf12a0, nSearchFlags=0, lArguments=0x00007ffeefbf1298) + 75 at framework/source/services/desktop.cxx:0 > #105: libunotest.dylib`unotest::MacrosTest::loadFromDesktop(this=0x000000010c9d23e8, rURL=0x000000010c9d2430, rDocService=0x00007ffeefbf1b00, rExtraArgs=0x00007ffeefbf1af8) + 4485 at unotest/source/cpp/macros_test.cxx:50 > #106: libtest_sw_ooxmlexport2.dylib`SwModelTestBase::reload(this=0x000000010c9d23a0, pFilter="Office Open XML Text", filename="fdo51550.odt", pPassword=0x0000000000000000) + 2004 at sw/qa/extras/inc/swmodeltestbase.hxx:706 > #107: libtest_sw_ooxmlexport2.dylib`SwModelTestBase::executeImportExportImportTest(this=0x000000010c9d23a0, filename="fdo51550.odt", pPassword=0x0000000000000000) + 269 at sw/qa/extras/inc/swmodeltestbase.hxx:243 > #108: libtest_sw_ooxmlexport2.dylib`testFdo51550::Import_Export_Import(this=0x000000010c9d23a0) + 32 at sw/qa/extras/ooxmlexport/ooxmlexport2.cxx:434 > #109: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] decltype(__f=0x000000010c9d2378, __a0=0x000000010c9d2388)).*fp(std::__1::forward<>(fp1))) std::__1::__invoke<void (testFdo51550::*&)(), testFdo51550*&, void>(void (testFdo51550::*&&&)(), testFdo51550*&&&) + 127 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:4232 > #110: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] std::__1::__bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<>, __is_valid_bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (__f=0x000000010c9d2378, __bound_args=0x000000010c9d2388, __args=0x00007ffeefbf1e60)(), std::__1::tuple<testFdo51550*>, 0ul, std::__1::tuple<> >(void (testFdo51550::*&)(), std::__1::tuple<testFdo51550*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) + 48 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2214 > #111: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] std::__1::__bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<>, __is_valid_bind_return<void (testFdo51550::*)(), std::__1::tuple<testFdo51550*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (this=0x000000010c9d2378)(), testFdo51550*&>::operator()<>() + 35 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2247 > #112: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) [inlined] decltype(__f=0x000000010c9d2378)(), testFdo51550*&>&>(fp)(std::__1::forward<>(fp0))) std::__1::__invoke<std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), testFdo51550*&>&&&) + 23 at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:4291 > #113: libtest_sw_ooxmlexport2.dylib`void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (__args=0x000000010c9d2378)(), testFdo51550*&>&>(std::__1::__bind<void (testFdo51550::*&)(), frame #119: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e46b24d0)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #120: unobootstrapprotector.dylib`(anonymous namespace)::Prot::protect(this=0x00000001003025f0, functor=0x00000001e46b24d0, (null)=0x00007ffeefbf2758) + 33 at unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 > #121: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e4690140)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #122: unoexceptionprotector.dylib`(anonymous namespace)::Prot::protect(this=0x0000000103000370, functor=0x00000001e4690140, context=0x00007ffeefbf2758) + 79 at unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 > #123: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e466b8f0)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #124: libcppunit-1.14.0.dylib`CppUnit::DefaultProtector::protect(this=0x0000000100300120, functor=0x00000001e466b8f0, context=0x00007ffeefbf2758) + 79 at workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 > #125: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::ProtectFunctor::operator(this=0x00000001e46a78d0)() const + 40 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 > #126: libcppunit-1.14.0.dylib`CppUnit::ProtectorChain::protect(this=0x0000000100304410, functor=0x00007ffeefbf28e8, context=0x00007ffeefbf2758) + 1307 at workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 > #127: libcppunit-1.14.0.dylib`CppUnit::TestResult::protect(this=0x00007ffeefbf3a58, functor=0x00007ffeefbf28e8, test=0x000000010c9d2330, shortDescription="") + 110 at workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 > #128: libcppunit-1.14.0.dylib`CppUnit::TestCase::run(this=0x000000010c9d2330, result=0x00007ffeefbf3a58) + 777 at workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 > #129: libcppunit-1.14.0.dylib`CppUnit::TestComposite::doRunChildTests(this=0x000000010c9b4bd0, controller=0x00007ffeefbf3a58) + 125 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 > #130: libcppunit-1.14.0.dylib`CppUnit::TestComposite::run(this=0x000000010c9b4bd0, result=0x00007ffeefbf3a58) + 90 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 > #131: libcppunit-1.14.0.dylib`CppUnit::TestComposite::doRunChildTests(this=0x000000010bfa05b0, controller=0x00007ffeefbf3a58) + 125 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 > #132: libcppunit-1.14.0.dylib`CppUnit::TestComposite::run(this=0x000000010bfa05b0, result=0x00007ffeefbf3a58) + 90 at workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 > #133: libcppunit-1.14.0.dylib`CppUnit::TestRunner::WrappingSuite::run(this=0x000000010bfa0570, result=0x00007ffeefbf3a58) + 78 at workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 > #134: libcppunit-1.14.0.dylib`CppUnit::TestResult::runTest(this=0x00007ffeefbf3a58, test=0x000000010bfa0570) + 82 at workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 > #135: libcppunit-1.14.0.dylib`CppUnit::TestRunner::run(this=0x00007ffeefbf3058, controller=0x00007ffeefbf3a58, testPath="") + 126 at workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 > #136: cppunittester`(anonymous namespace)::ProtectedFixtureFunctor::run(this=0x00007ffeefbf3840) const + 3030 at sal/cppunittester/cppunittester.cxx:319 > #137: cppunittester`sal_main() + 3856 at sal/cppunittester/cppunittester.cxx:469 > #138: cppunittester`main(argc=23, argv=0x00007ffeefbf3b00) + 39 at sal/cppunittester/cppunittester.cxx:376 > #139: libdyld.dylib`start + 1 Change-Id: I332421e1ab4e7cc5937d9d73d3a001c2f6744dcb
2017-11-21clang-format fixesMiklos Vajna
Hopefully the last such commit, now that the in-gerrit verification is in place and also a warning is printed locally for those who push directly. Change-Id: Ib80cbca0b29dc7f71cbb182a38ad6839a659ff41 Reviewed-on: https://gerrit.libreoffice.org/45002 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-21TypedWhichId for SDRATTR* constants (2)Noel Grandin
Change-Id: I9926d55568f8b5bbc67f448bbf7fb660e74505fd Reviewed-on: https://gerrit.libreoffice.org/44964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20ofz#4338 Integer-overflowCaolán McNamara
Change-Id: I6019da51dced0ef560490b7e7cf303b8193f17ce Reviewed-on: https://gerrit.libreoffice.org/44971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20Upgrade to ICU 60.1Eike Rathke
Change-Id: I6d90f51ee88c4e1005edbaa93d23cfb94cb2acfb Reviewed-on: https://gerrit.libreoffice.org/44871 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for SDRATTR* constants (1)Noel Grandin
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d Reviewed-on: https://gerrit.libreoffice.org/44943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18RotateFlyFrame3: Corrected interactive CropArmin Le Grand
To correct interactive Crop in transformed states, I had to rework some stuff involved that anyways was in a non optimal state. Added functionality to translate the object to make Crop seem to work more seamlessly. Some mapping was needed to make the Cropped, transformed object to be in the correct relative position to the uncropped, untransfomed one. Restructured TransformableSwFrame to directly re-create last non-transformed SwFrame(s) from the SwFrameAreaDefinition from the current Transformations, offering the untransformed SwRect(s) now for usage. Identified and corrected error when FlyFrame was translated using keyboard, the accessing method needed to adapt position in the transformed case. Started to look at Contour stuff, adapted a set contour to be correctly used by adapting it as needed in the transformed case. Change-Id: I0d5f14958bcd6f826b9abd53f1f47b7d0bc5a0e2
2017-11-18tdf#113855 Assertion while customizing Bullets and NumberingNoel Grandin
can't find an easy way of removing the duplication, even though that BeginLocking() stuff looks ripe for simplification. Change-Id: I97b580b3668381c12b62136ea09772d91ab11eac Reviewed-on: https://gerrit.libreoffice.org/44884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18TSCP: remember the state of IP section expander stateTomaž Vajngerl
Change-Id: I899c05a4260324fa4c5648d7164821eddb1ead08 Reviewed-on: https://gerrit.libreoffice.org/44879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-18TSCP: allow to add multiple markings in the documentTomaž Vajngerl
Change-Id: Iae8fd98b678acdd3667eeb35b110b4e405c1167b Reviewed-on: https://gerrit.libreoffice.org/44878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: change bold button to a toolbox button as bold iconTomaž Vajngerl
Change-Id: Ic1a96544c4b3a1f8d631535c8a5f43b6680539f4 Reviewed-on: https://gerrit.libreoffice.org/44860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TypedWhichId for EE_CHAR* constantsNoel Grandin
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28 Reviewed-on: https://gerrit.libreoffice.org/44829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TypedWhichId for EE_PARA* constantsNoel Grandin
Change-Id: I64d1765336f39c3e3ded4d58ebdee80e97624276 Reviewed-on: https://gerrit.libreoffice.org/44799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TSCP: disable toolbar pop-up if category was set with dialogTomaž Vajngerl
In addition move reading of origin to classificationhelper as we need to read it there. Change-Id: I472b073587e68e6896f915477603a25db9b310d3 Reviewed-on: https://gerrit.libreoffice.org/44848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: also store the identifier into the recently used XMLTomaž Vajngerl
Change-Id: I19ccfb8f5118d73535d0e94bf32818d82670d093 Reviewed-on: https://gerrit.libreoffice.org/44847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: resolve identifier to name, abbr. name is for category onlyTomaž Vajngerl
In paragraph classification we store only the identifier and not the name, but for the ClassificationDialog we use the name as an identifier, so we need to resovle the identifier to the name when reading in the input classification results. It might make sense to switch to identifiers in the dialog also as they are language independent. Abbreviated name is only for the classification category and has no effect for other classefication elementslike markers and IP parts, so always fill them with the full name directly. Change-Id: I23bd0e8e92b16807a5b4d3162e503b799aa40718 Reviewed-on: https://gerrit.libreoffice.org/44845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17Revert "Upgrade to ICU 60.1"Eike Rathke
This reverts commit f643e1f687e27e7f46c53d7298772d4dddb3e660. Failing in firebird, back to the drawing board.. Change-Id: I087d2fa6e81cf713458b1c9645edc7c1facf148c Reviewed-on: https://gerrit.libreoffice.org/44843 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-17Upgrade to ICU 60.1David Tardon
Change-Id: I07837be7faac0b2238b0cba8fb981e4c4d24c498
2017-11-16coverity#1421065 Uncaught exceptionCaolán McNamara
Change-Id: I68e798a4e7a90bb0cf7709ac84915e7f14f00c1d Reviewed-on: https://gerrit.libreoffice.org/44778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16silence coverity#1421123 Copy-paste errorCaolán McNamara
Change-Id: If340824c749dda0668fabba9d417f4a2c2acc3ff Reviewed-on: https://gerrit.libreoffice.org/44774 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15coverity#1421071 Uninitializer scalar fieldCaolán McNamara
Change-Id: I6b52c62574013ba242922227c2cbd7bfceea0e29
2017-11-15TypedWhichIdNoel Grandin
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-14 05:46:29 +0000