summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2025-02-07Introduce loplugin:mustoverrideStephan Bergmann
...to find derived classes that do not directly override SfxPoolItem::ItemType. Most of the cases that the plugin flagged were classes that are apparently not meant to be instantiated themselves (so I added pure virtual overrides there), but SdrMeasureFormatStringItem appears to genuinely have missed it DECLARE_ITEM_TYPE_FUNCTION stanza. Change-Id: Iec40080377f26cc4fa2c8cff735d5f0d3bd60509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181211 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-02-07a11y: Move AccessibleBrowseBox* headers to global vcl include dirMichael Weghorn
AccessibleBrowseBox and related classes are the a11y implementations for both, SvHeaderTabListBox (see SvHeaderTabListBox::CreateAccessible) and BrowseBox (see BrowseBox::CreateAccessible). The former is in the vcl module, but the latter is in svtools. Move the headers to include/vcl/accessibility to be able to use the classes directly from both modules in upcoming commits instead of having to use the AccessibleFactory to create the accessible objects. Change-Id: Idfd5cf2d605f8413f4fa4091ae7c5e4df8cc0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181202 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-07browsebox: Convert dispatch ID defines to enum classMichael Weghorn
Convert the `BROWSER_*` defines in include/svtools/brwbox.hxx to a new enum class BrowserDispatchId. The specific integer values that were used don't seem to have any particular meaning, so just drop them. Add default case that does nothing in BrowseBox::Dispatch to address /home/michi/development/git/libreoffice/svtools/source/brwbox/brwbox2.cxx:1779:13: error: 5 enumeration values not handled in switch: 'NONE', 'CURSORENDOFSCREEN', 'CURSORTOPOFSCREEN'... [-Werror,-Wswitch] 1779 | switch (eId) | ^~~ 1 error generated. Change-Id: Ibb023ec13ee2c10a0fc0ef7abe1371dbd856e735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181167 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-05Drop EOF commentsMichael Weghorn
No need to add a comment that the end of the (source) file is near, it's sufficiently obvious... Change-Id: Iac8885cf67fce45a81de387a31f8b726d615dff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181140 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-04[API CHANGE] sd pdfium: add page number when saving/loading pdf pages as imagesJaume Pujantell
When a pdf file is opened with pdfium and then saved as odg, each page is saved as a draw:image of the pdf. But since no page number info was given, when opening the odg file, all the pages are shown as the first one. This adds a loext:page-number to the saved odg and the logic to load a specific page from an embedded pdf. Added loadGraphicAtPage to XGraphicStorageHandler. Change-Id: I398b7ad7f03cc7fb930a4e7b7620c6f238b41c0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181066 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-02-04no need to mess with x87Noel Grandin
this is tryly ancient cruft Change-Id: I285d81375644bba061586a9f601fe7db54f08af3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-03svx: prefix members of GalleryMiklos Vajna
See tdf#94879 for motivation. Change-Id: I58c8c02342085eca1d08c80fb9fae58c84a47e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181027 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-31Simplify SfxBindings::ExecuteSynchronMike Kaganski
... by making SfxBindings::Execute return SfxPoolItemHolder. Change-Id: Idd62a5eae791a6a4fec283c0c80fdac19c3526d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180982 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-29tdf#164900 table text in different columns no longer lined upNoel Grandin
Revert "tdf#161846 use unordered_map in SfxItemPropertyMap" This reverts commit c39978f41dccbeb2e973c919a67d9b1d974f8f3c. Change-Id: I26cadb32b426fd3b48179b67c677213a78b4999c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-27Resolves: cool#10952 use existing ComponentContextCaolán McNamara
instead of unnecessarily bootstrapping an entirely new one See: https://github.com/CollaboraOnline/online/issues/10952 Change-Id: I625c539eb7272e152ee84a568f235751128bd96a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180776 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-27svx: prefix members of SvxClipboardFormatItemMiklos Vajna
See tdf#94879 for motivation. Change-Id: I2b968e01db03871dbe0748a5bbbde4f7dcf566cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180772 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-25Mark some visible strings in ui files as translatableGabor Kelemen
found with bin/ui-translatable.sh Change-Id: Ibe74635abc54a898c6040d4e62427f749f842474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180722 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-23ofz#391709141 Abrt __cxxabiv1::failed_throwCaolán McNamara
Change-Id: I2c1f59707e24d0de9ab65704ee659355090a32f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-23docthemes: Save themes def. to a file when added to ColorSetsTomaž Vajngerl
Color themes will be written to the user folder. Change-Id: I58e650550044bd35a5054a303ce41789d3d51d32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180542 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-22docthemes: Load document themes def. files into ColorSetsTomaž Vajngerl
This is then used in Theme dialog to show which themes are available. Also add the existing hardcoded themes as theme def. files. Change-Id: I230bc84ae70f22b558aa31053339d602d04885bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180541 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-21tdf#105083 Support status of numbering and bullet listOliver Specht
Shows the status of bullet/numbering in the current text selection in the toolbar buttons ToggleUnorder/OrderedList. Change-Id: I458896293c502da8142ad9cb43b5ea62a9f3b558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180238 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-21tdf#160084 Simplify comparison with zero when using basegfx::fTools::lessbruh
Change-Id: Ide5fff5ad3ad7322fc5955eb06ad14da83451abf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180482 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-20tdf#164685 Cleanup SfxItemSetFixedrafaelhlima
Cleanup of class SfxItemSetFixed as described in the bug ticket. Change-Id: I0704ab45624217a8d00a942e0e8d6d6276934306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180255 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2025-01-20svx: prefix members of SdrVirtObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: I58815855425a02c18fbc59b4c002b9bc128955e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180495 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-20doctheme: add LibreOffice theme file to LO share folderTomaž Vajngerl
Change-Id: Ifa38b69739d82d1f2efdfca58a2e0d6f9ff69008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180416 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-16cool#10630 doc electronic sign: move signature line tracking to the viewMiklos Vajna
No functional changes intended: - Replace SfxObjectShell::GetSignPDFCertificate() and SfxObjectShell::ResetSignPDFCertificate() with SfxViewShell::SetSignPDFCertificate() and SfxViewShell::GetSignPDFCertificate(), because information about shape selection belongs to the view. - Change svx::SignatureLineHelper::setShapeCertificate() to use SfxViewShell::SetSignPDFCertificate() to avoid duplication. - Change GetSignatureLineShape() in xmlsecurity/ to use SfxViewShell::GetSignPDFCertificate(), again to avoid duplication. With this, all setters/getters of the inserted signature line go via SfxViewShell and the amount of getCurrentSelection() calls on the model is reduced. Change-Id: I021bc41262b2a16d1014fbf1431a0eb6e1e86c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180355 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-16defer creating std::locale until it is neededCaolán McNamara
(if ever, seeing as it's only required if there is an error) Change-Id: Id8ba5ff495dfd2048401231023a09abba9bbf785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-16loplugin:unusedmethodsNoel Grandin
Change-Id: I8041b975ee8e1cb0a75c43c6332f315627847033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180343 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-01-16svx: avoid emptying sidebar propertiesPranam Lashkari
these properties are either updated or reformatted based on *Blanked variables so no need to do an extra update problem: emptying these properties causes to lose measurement units in LOK. It happens due to second time this sidebar is not completly initialised but just updated the value of the fields so units are lost for LOK. Change-Id: Id32638686578652ab4ffa25a638b5308c46eea2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179583 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180288 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-16Resolves tdf#164185 & tdf#89420 - Show text boundaries in DrawHeiko Tietze
Show margins by default and hide per expert setting Draw::Misc::TextObject::ShowBoundary This patch reverts/improves I3e31bec65ab34772bd2f8137be7e5e5258758184 Change-Id: I177ab0491e85aea327a512ab9d336949ddfa6e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179995 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-15cool#10630 doc electronic sign: fix no graphic selection for the signature lineMiklos Vajna
Insert a signature line in "extern" mode, the shape gets selected but there is no graphic selection at a LOK API level. This is because GetSignPDFCertificate() returned an XCertificate, which is empty in the external signing case, so we can't differentiate between no signing and external signing. Fix this by changing the return type to svl::crypto::CertificateOrName, this way SdrMarkView::SetMarkHandlesForLOKit() can annotate the signature line correctly even in the external signing case. The tracking of the signature line selection is still in the model (not in the view), that's not yet fixed here. Change-Id: I4ef9c1fa0a88af0c0fcd55156b973a3705f985c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180296 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-15tdf#34837 sc: Use border from correct cell for merged cells in RTLJonathan Clark
This change fixes a bug causing borders to fail to render for merged cells in RTL spreadsheets. The root cause for this bug was framelinkarray utility code using the top-left cell as the source for border styles of merged cells. This use was correct for LTR spreadsheets. However, this framelinkarray data is mirrored for RTL documents. After mirroring, the correct cell containing border styles is the top-right one. This change also reverts and reimplements a prior fix for tdf#135843 (commit 586a0f149f332c0b0e53c0bb30568d4bd411b0e3), which violated the framelinkarray contract that edge styles for merged cells must be added to the top-left underlying cell of a merged cell. Change-Id: I27eec416d54f9f99cd5df1151a12c758f350c789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180256 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2025-01-13cool#10630 doc electronic sign: fix insertion of the signature lineMiklos Vajna
Have electronic signing configured in the LOK client, try to insert a signature line, you'll get a certificate picker, while we don't have a cert during esign. What's in fact needed for creating the signature line is just a name (previously extracted from the certificate), we can survive the lack of actual certificate. Fix the problem by adding a new External parameter to .uno:InsertSignatureLine to hint that the certificate chooser should not be opened, instead the editor name (used for comments already) should be used. Add a new CertificateOrName in svl/ and use that in all places where previously we wanted a certificate but in fact it's enough to have a certificate or a name to create the signature line. The name on the signature line is just visual feedback, the actual name on the crypto signature is still not based on untrusted used input. Change-Id: Ib7008112a8e28a9e7d9649745e6021dd6b6b9c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180193 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-13svx: prefix members of SvxOle2ShapeMiklos Vajna
See tdf#94879 for motivation. No problem with _ suffixes, but parent SvxShape uses m_ prefixes, so switch to that here as well for consistency. Change-Id: I7a1f8630c5281c629a5b02ffe51fd9df208602dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180153 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-11pdf: change StructElement to enum class, move out of PDFWriterTomaž Vajngerl
Moves the StructElement out of PDFWriter and changes it to enum class. This makes it mroe type safe, easier to search and more clear what type we are using. Change-Id: Icf469319a01f58397b131c3517bc75fba4072500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179977 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-11fix import BGRx image from PDFNoel Grandin
bug introduced in commit 45c753aff6468b9761e68bc0bf48ab161cd0cba6 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Fri Sep 28 12:30:01 2018 +0200 svx: pdfium's FPDFImageObj_GetBitmapBgra() is not needed after all Although the confusion was understandable, since the previous commit which had introduced FPDFImageObj_GetBitmapBgra, which, despite its name, actually returned RGB* data Change-Id: I762f1e963d64b4243e21e26cab31c05f4903af49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-10ITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2025-01-10cool#10630 lok doc sign: allow setting the size of the Impress sign lineMiklos Vajna
Insert a signature line in LOK mode when PEM certs are configured, moving the just inserted shape works (even in the read-only PDF view), but you can't resize the shape. This is because moving goes via .uno:TransformDialog, while resizing uses .uno:MoveShapeHandle. Fix this similar to moving, by allowing the operation when the shape is a just inserted signature line. Allowing the command in read-only mode is meant to be safe, since the command implementation again checks if the resize is allowed, and there we allow this only for signature lines. Also expose the "is signature line" info on the LOK API, so it can show the graphic selection handles conditionally (only when resize will be allowed). Change-Id: Ie85aa1211564758dc24ff83b4241de78a8e69ffc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180065 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-10tdf#146947 - UI: Ability to show/reveal characters being typed intoBalazs Varga
password prompt to decrypt a document. Add toggle buttons for showing and hiding password characters in password textbox entries. Change-Id: Iba69d303431c2f9f2c987c67fcbd3f36b42dc057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179889 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2025-01-10cool#10630 lok doc sign: allow setting the pos of the Impress sign lineMiklos Vajna
Open a PDF in LOK mode, insert a signature line, try to drag the selected signature widget/shape, nothing happens. Given that the inserted shape has a default position at page center, you typically want to adjust that default position, but that requires adding a few exceptions, since PDFs are normally read-only. Desktop Impress gets around this since commit 5d296183072dc7cfe7a9985c38388b56f37d873c (sd signature line: allow move / resize of shape before signing, 2020-06-26), but LOK clients want to rather dispatch an UNO command (instead of handling this in the mouse event handler), so this requires additional work. A first problem is in isCommandAllowed() in desktop/ that explicitly rejects the UNO command for read-only documents: allow this when a signature widget is selected. A second problem is in SdrEditView::SetGeoAttrToMarked(), check for the signature widget there as well. Given that the implementation of .uno:TransformDialog already has a set of flags to prevent doing anything for read-only documents, it looks safe to allow the execution of the command itself. The size of the widget should be also possible to modify, that's not yet done here. Change-Id: I92a60717e98ac33f7a1eb9770cd0c7903f60759c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-09tdf#164183 Add hyperlink entries to context menu of tablesOliver Specht
Table objects in Draw/Impress now have Open/Edit/Copy/Remove hyperlink entries in context menu of text in table objects. Change-Id: Id3a5346eb3227871a06d2ea7fdb3ed38c07654c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177849 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2025-01-09Fix typoAndrea Gelmini
Change-Id: I8c3c0b8f1bf41e64b89d6e2819f81dc861766c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179969 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-08In dark mode, configuration of master page is checked for auto color.Gökay Şatır
This works for standart pages. But notes pages don't have a style property in their master pages. This commit, when libreofficeKit is active, uses corresponding standart page's master page properties for notes pages. Used only for background colors. Change-Id: Ib1115a4fbc87ecd94f9bb44b43268b9578734950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179929 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-06cool#10630 lok doc sign: fix Impress sign line when picking a certificateMiklos Vajna
Once .uno:InsertSignatureLine gets dispatched, a visual signature placeholder gets inserted, then a certificate picker shows up, but no certificates are visible in the list. The first problem is that .uno:InsertSignatureLine needs to take sign key/cert parameters in DrawViewShell::FuPermanent() (similar to .uno:Signature), so it can learn what certificate to use for signing. The second problem is that once that sign cert is attached to the view, the cert chooser for signature lines were not taking the sign cert from the view in DocumentDigitalSignatures::chooseCertificatesImpl() -- this needs routing the info about the current view from sd/ (where we still have that info) to xmlsecurity/. With this, a LOK client dispatching .uno:InsertSignatureLine with the 2 new parameters set can insert a signature line, it'll show up, but the subsequent .uno:Signature dispatch still needs fixing up. (Currently it wants to "save" the modified PDF, while it should just sign.) Change-Id: Ie536842152ef097aa6959c67916f2beb6d356e4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179819 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-06svx: prefix members of SvxMediaShapeMiklos Vajna
See tdf#94879 for motivation. No problem with _ suffixes, but parent SvxShape uses m_ prefixes, so switch to that here as well for consistency. Change-Id: I938598829924ba5bb7ee22e16a1337e354c3411e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179816 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-03tdf#162695 decrease the text margins to smallerTomaž Vajngerl
This decreases the text margins so the comment is overall smaller, which should make the situation better, but the main issue might be that the comments previously did not change size with zoom, but now do. This is probably nto so simple to change. Change-Id: I5c83b787f58324431e110ee095f61135b67588e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179662 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-02lok: jsdialog: enable font size box after saveSzymon Kłos
This is followup for commit cbe229ec219e56ce1bb5dd9598f9052a98504249 lok: jsdialog: enable font name box after save We need to use weld:: api to inform JSDialogs about sensitivity change. Happens in lok after shape resize - we cannot open font size dropdown. Change-Id: I1897502948c90e3bd1e5e3e347429fa9729d87a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177512 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179612 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins
2025-01-02tdf#160084 Simplify comparison for basegfx::fToolsBogdan Buzea
Change-Id: I5db5200f59f32e428963a2c5bd6f70da42ec078f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176780 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-02tdf#146619 Remove unused #includes from C/C++ filesManish Bera
Change-Id: Ic6a6f9a8462a128ab8f61dfa6dbbecb8c707e57f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179595 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2025-01-01tdf#140226: use StaticWhichCastManish Bera
Change-Id: I461471e5b2e9cd3d94896d9ba6ac315f7237bec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179510 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-12-30Improve loop a little bitIlmari Lauhakangas
Change-Id: I6a88935103f1de210f1286c9f7863ebf96aa4b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179562 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-29Resolves: tdf#154683 select the saved page after loading the ModelCaolán McNamara
The default Instance page needs to be selected at LoadModel time in order to get its tab text updated automatically. Easiest thing to do here is to load with the default page selected and restore the user's saved page afterwards. Change-Id: I4ac5231894834f258d33108e4ebcb2f0af062922 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-27tdf#158237: Use C++20 contains() instead of find() and end()Johann
Change-Id: I0528229042aa62d3d99e8dbaad68a86d41cf369a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178659 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-12-26tdf#145538 use range based for loop in svxkkasliwal
Change-Id: Ie9d9db48aff66b7f425b9a42708682f850e490bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179266 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-26no need to allocate AnnotationData for every SdrObjectNoel Grandin
SdrObject is performance sensitive, because we allocate a boatload of them when drawing charts. Avoiding an extra allocation that only a tiny handful of SdrObjects need is worthwhile. Change-Id: I4974bc1eacfe8abcce45ea659d9edaa8694135d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-24 14:53:20 +0000