summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2018-05-22tdf#83877 Add valid/invalid images to signaturesSamuel Mehrbrodt
Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35 Reviewed-on: https://gerrit.libreoffice.org/54513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Fix svg to base64 conversionSamuel Mehrbrodt
This reverts part of ab14a9708d2937bc767c14542610ce91b56dda1e which had a questionable fix by unconditionally removing the first 8 bytes of the svg which led to svgs starting with rsion="1.0" encoding="utf-8"?> instead of <?xml version="1.0" encoding="utf-8"?> Change-Id: I8c4d78db1794473d20ddd77019ae81b88be0bb03 Reviewed-on: https://gerrit.libreoffice.org/54550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-21tdf#98544 Other Options remain expanded if any checkbox is checked.manujvashist
Change-Id: I2de79da0f0a6295d4d3c294d7cf6c123fca914bc Reviewed-on: https://gerrit.libreoffice.org/51190 Reviewed-by: Manuj Vashist <manujvashist@gmail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#117581 impress: fix selection overlay after moving tableDaniel
Change-Id: Ie5afa4fbddf86c6692a7ed68af9ef990c2f9f487 Reviewed-on: https://gerrit.libreoffice.org/54493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-20coverity#1435686 silence Copy-paste errorCaolán McNamara
Change-Id: I017307e9b125dd0fe970736c6ebe482f08d54e90 Reviewed-on: https://gerrit.libreoffice.org/54586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-20Fix typosAndrea Gelmini
Change-Id: Id225be0ecc357d6864a32d59291e402d98592d81 Reviewed-on: https://gerrit.libreoffice.org/54575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-20Fix typosAndrea Gelmini
Change-Id: I65300af850f5c6f6795fa88e9e33616e38c7657c Reviewed-on: https://gerrit.libreoffice.org/54571 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-20svx: Avoid looking up system clock twice for current datetimeTakeshi Abe
Change-Id: I636ddfdaeac211ddc9de6b5dfe36cbdc32c7f7f2 Reviewed-on: https://gerrit.libreoffice.org/54509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-05-19tdf#117506: Add using correct StyleSheet on ::CloneArmin Le Grand
There was an error/missing implementation on Cloning SdrPage(s)/SdrObject(s) to a new target-SdrModel. See comments in the code-change and in the tdf-task for more info. Change-Id: Ibe673a4b14e1c44102f80f05ebbeae5b6a1bae8f Reviewed-on: https://gerrit.libreoffice.org/54555 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-19loplugin:useuniqueptr in SdrDragViewNoel Grandin
and fix potential leak on early return in SdrDragView::BegDragObj Change-Id: I707be6e2c7dc2c251f37447fe3cd98c4b50b59d1 Reviewed-on: https://gerrit.libreoffice.org/53751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-19tdf#117614 svx: make drawing.GraphicExportFilter work with sw imagesMiklos Vajna
A Writer image has an underlying SdrObject, but GetSdrObjectFromXShape() won't work for it, also we can't an sw SdrObject into an XShape because SvxDrawPage::CreateShape() has no idea how to handle sw's SdrInventor::Swg inventor. Fix the problem by just getting the Graphic of the Writer image and improve GraphicExportFilter to be able to work with just a Graphic as well. Change-Id: I3c9b3005366fcc87815597a27df3cb8a99a8876c Reviewed-on: https://gerrit.libreoffice.org/54527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-19tdf#116979 Fixed 3D operator= to correct copy/pasteArmin Le Grand
Change-Id: I81483a4d23523650cd9098794dd6101253b88e1c Reviewed-on: https://gerrit.libreoffice.org/54546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-18Replace SVGFilter using SVGIOArmin Le Grand
Target of this change is to get rid of the SVGFilter in current LO which is based on the standard-ODF importer using it's functionality by passing in/handing over temporary created XML-Stream-Data. First step is to alternatively import the given SVG file to a newly created Document and to strip the existing Filter-Code. Adding the first prototype of the changed import. It is capable of importing the given SVG to the created Draw/Impress document. It adds the SVG which gets imported by SVGIO as GraphicObject. It adapts sizes and positions of Page and GraphicObject to have a smooth import. Adding stripping of SVGFilter and used ressources. Done as deep as possible, hopefully all places found. Adapted now to create an Impress document. Also added needed adaptions to PageSize(s), including layout and PresObj stuff to make all MasterPages/LayoutPages work correctly. Added reaction on empty SVG. This is needed since the PageSize is adapted to the Graphic. With empty Graphic a Size(0,0) results and this goes wrong. Change-Id: Ia364a5783bee7dadcbe91e700efbabc121cf98f9 Reviewed-on: https://gerrit.libreoffice.org/54096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-18simplify FmXFilterCell constructorNoel Grandin
if it wants a DbFilterControl, just take a DbFilterControl Change-Id: I43f08062be1c6c7c052c43de912a81afe409c928 Reviewed-on: https://gerrit.libreoffice.org/54523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-18use OWN_ATTR_REPLACEMENT_GRAPHIC for "ReplacementGraphic"Tomaž Vajngerl
For table shape we used OWN_ATTR_BITMAP as the identifier for the "RepalcementGraphic" property, but that is not really correct. More correct would be to use OWN_ATTR_REPLACEMENT_GRAPHIC, which name reflects exactly what the property is for and doesn't conflict with OWN_ATTR_BITMAP which is used for the "Bitmap" property. Change-Id: Ic76318addf8f53391f41251fe9d99dba57308165 Reviewed-on: https://gerrit.libreoffice.org/54466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-17loplugin:unusedfields in svxNoel Grandin
Change-Id: I2e34b3819c576072beaacb87cb99d73457667dc3 Reviewed-on: https://gerrit.libreoffice.org/54449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-17Further loplugin:redundantcast improvements for floating-integer conversionsStephan Bergmann
The code in svx/source/customshapes/EnhancedCustomShape2d.cxx started out as > aStart.X() = (sal_Int32)( ( (double)( aStart.X() - aCenter.X() ) / fXScale ) ) + aCenter.X(); > aStart.Y() = (sal_Int32)( ( (double)( aStart.Y() - aCenter.Y() ) / fYScale ) ) + aCenter.Y(); > aEnd.X() = (sal_Int32)( ( (double)( aEnd.X() - aCenter.X() ) / fXScale ) ) + aCenter.X(); > aEnd.Y() = (sal_Int32)( ( (double)( aEnd.Y() - aCenter.Y() ) / fYScale ) ) + aCenter.Y(); in afd1cf255d9cb4c78633e668376a09bd309be7ef "INTEGRATION: CWS sj05", then the floating-point scaling factors got gradually removed first with 101559f88022162ede229fe14366d394700816fe "INTEGRATION: CWS bm3" and then completely with d9f21c90bd61d15fd78a8df9115bf2e9ededbd1b "Fixes Circular arrow distortion, Bug #46272". Change-Id: I337d7893e513738c986d0e85efabcbf7bab912e5 Reviewed-on: https://gerrit.libreoffice.org/54434 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-16ofz#7469 leak of SdrObject owned by SvxShapeCaolán McNamara
SvxShape::InvalidateSdrObject is called and mpSdrObjectWeakReference is reset. HasSdrObjectOwnership is only true if HasSdrObject is true and HasSdrObject is true only if mpSdrObjectWeakReference is set. So if mpSdrObjectWeakReference is reset in Invalidate when HasSdrObjectOwnership is true, the shape becomes inconsistent Change-Id: I0031c0dac33923367a2f73fcb8fe2eeb88a08db9 Reviewed-on: https://gerrit.libreoffice.org/54368 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16loplugin:unusedmethodsNoel Grandin
Change-Id: I10c291788061ec8467126a0dc719e20fb3cf47ec Reviewed-on: https://gerrit.libreoffice.org/54386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16loplugin:constantparamNoel Grandin
Change-Id: I0110e0c662004456e4bc8f8082e2e2fea59e0148 Reviewed-on: https://gerrit.libreoffice.org/54385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-15tdf#117186 - Sidebar: Shapes deck should fill the whole sidebarheiko tietze
Change-Id: Ib4ddab03b3b001523f3e819e5bdac7fbefc17f24 Reviewed-on: https://gerrit.libreoffice.org/54339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-14weld GalleryIdDialogCaolán McNamara
Change-Id: I214afef7668eaf5082683f1c77b08aa0c5107619 Reviewed-on: https://gerrit.libreoffice.org/54317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld TitleDialogCaolán McNamara
Change-Id: I009da829e2b866844e67f976582e2a9d99bd22c0 Reviewed-on: https://gerrit.libreoffice.org/54316 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld ProfileExportedDialogCaolán McNamara
Change-Id: Ie360699c167cbee0be6d890ad686d351d64707cd Reviewed-on: https://gerrit.libreoffice.org/54315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld AddModelDialogCaolán McNamara
Change-Id: Ia12069f966c93ad7700b7a068dd7660284a40130 Reviewed-on: https://gerrit.libreoffice.org/54314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld AddInstanceDialogCaolán McNamara
Change-Id: I69bcb7fb9c18922a5de03e6f2dedd915a5851712 Reviewed-on: https://gerrit.libreoffice.org/54313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld ManageNamespaceDialogCaolán McNamara
Change-Id: Ieb5605fcab285de26e4fab64b8178d4d7818eb2d Reviewed-on: https://gerrit.libreoffice.org/54311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld ExtrusionDepthDialogCaolán McNamara
Change-Id: I5905fea310a7f29574d94eaf61c80b6ca09a7467 Reviewed-on: https://gerrit.libreoffice.org/54310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld FmInputRecordNoDialogCaolán McNamara
Change-Id: I87f3dc3a576e30fe50871c14a67a5b777c21d3ba Reviewed-on: https://gerrit.libreoffice.org/54308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14tdf#113688: Pattern fill can be set from sidebar nowKatarina Behrens
Change-Id: I877dd2610aadd1b0118cdb6928a8473af1dc4c73 Reviewed-on: https://gerrit.libreoffice.org/54020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-05-13Translate German commentsJohnny_M
Change-Id: I6a03e921b28da5ac26235f32f547f36e00a47e46 Reviewed-on: https://gerrit.libreoffice.org/54079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-12make Bitmap/BitmapEx constructors explicitNoel Grandin
and add BitmapEx::operator=(Bitmap const &) Image::Image(Bitmap const &) to lessen the fallout Change-Id: Iff5fab88d167a7be739c370c9933d36c297bc61c Reviewed-on: https://gerrit.libreoffice.org/54162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-11weld SdPhotoAlbumDialogCaolán McNamara
Change-Id: I46cca94bb43e1b1cd9757b22baad9bb3f61bc15d Reviewed-on: https://gerrit.libreoffice.org/54132 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-11tdf#116993 corrected FontWork to use correct SdrModelArmin Le Grand
Had to adapt FontWorkGalleryDialog::insertSelectedFontwork() to use the correct target-SdrModel when cloning the FontWork SdrObject. This is due to FontWorkGalleryDialog being used differently from Calc - it calls SetSdrObjectRef to set an exceptional SdrModel as target which I took as the always to-be-used target SdrModel - due to it's name 'mpDestModel'. Change-Id: Ia4860283082f041711b8c31952fd2c398eeac30e Reviewed-on: https://gerrit.libreoffice.org/54045 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-10weld SdVectorizeDlgCaolán McNamara
Change-Id: I15469be36807bcfca9882d04dd5d55933692abf7 Reviewed-on: https://gerrit.libreoffice.org/54092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10store Color using boost::optional in EditCharAttribFieldNoel Grandin
Change-Id: If4af5991be51cdb035c0bc0fb7668844df703073 Reviewed-on: https://gerrit.libreoffice.org/54022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-09Typos in change 53934heiko tietze
Change-Id: I7d2dd64beb70d44113c3c548ff6e13ff1d766614 Reviewed-on: https://gerrit.libreoffice.org/54017 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-09tdf#116977 Correctly handle copy-construct of SdrTableObjArmin Le Grand
The new central CloneSdrObject in the case of SdrTableObj has to do some more stuff due to the UNO API TableModel in- volved and stuff. This is done in ::operator= now and thus will work uniformly now (multi-select and copy). At the same time there is functionality to clone/copy only a partial Table in Draw/Impress when e.g some Cells are selected. To reflect this code is needed to 'crop' the just cloned SdrTableObj to the current selection. This again was pretty hard due to side-effects in the implementation using a mix of UNO API and SdrModel-stuff. Change-Id: I9816e1caf34e29021d46d6dd9bb935c634f5ba2e Reviewed-on: https://gerrit.libreoffice.org/53975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-09tdf#114006 - New default set of gradient presetsheiko tietze
New set of gradients incl. l10n and ui test Change-Id: Iee303a39ad721b5a4e8b9adb78ee5a82227b84f4 Reviewed-on: https://gerrit.libreoffice.org/53934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-09vcl: get rid of Bitmap{Ex}::Filter() and Animation::Filter()Chris Sherlock
Change-Id: I510d7b286df732712aa9206b0a7c7910af34c83f Reviewed-on: https://gerrit.libreoffice.org/53206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-08Resolves: tdf#117470 reuse parent window of colorwindow...Caolán McNamara
as parent of color selector window Change-Id: Id96c9eed21c4e99b9e48ab44bab862fea9fd380a Reviewed-on: https://gerrit.libreoffice.org/53972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08loplugin:useuniqueptr in FmGridListenerNoel Grandin
Change-Id: I774aaf10dd9701f40a098280b68557d8b8045b34 Reviewed-on: https://gerrit.libreoffice.org/53884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-08tdf#116977 secured ::Clone methodsArmin Le Grand
Renamed SdrPage::Clone -> SdrPage::CloneSdrPage Renamed SdrObject::Clone -> SdrObject::CloneSdrObject Giving SdrModel is no longer an option, but a must (as reference). This makes future changes more safe by force usage to think about it. Also equals the constructors which already require a target SdrModel. Done the same for ::CloneSdrPage. Change-Id: I06f0129e15140bd8693db27a445037d7e2f7f652 Reviewed-on: https://gerrit.libreoffice.org/53933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-07[API CHANGE] revert and deprecate *BackGraphicURL add *BackGraphicTomaž Vajngerl
*BackGraphicURL include the following properties: - BackGraphicURL - FooterBackGraphicURL - HeaderBackGraphicURL - ParaBackGraphicURL This were removed, but for backwards compatibility this commit adds them back again and depreactes them in the UNO API. The behaviour also changes as internal vnd.sun.star.GraphicObject scheme URLs aren't supported so this properties can only be set and only if a external URL is provided. If getting such a property then a RuntimeException will be thrown. [ Miklos Vajna: fixed up sw/qa and writerfilter bits. ] Change-Id: If60011837da96197b576bfe2671ecafccad736c7 Reviewed-on: https://gerrit.libreoffice.org/53511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-07loplugin:useuniqueptr in FmXGridPeerNoel Grandin
Change-Id: I05d6fd36bb92e88016ac9cb062c4443ec8796b97 Reviewed-on: https://gerrit.libreoffice.org/53882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in FmGridControlNoel Grandin
Change-Id: I2fc39692bfb42bfff667908d73b3074d5cc04a28 Reviewed-on: https://gerrit.libreoffice.org/53881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SvxTextEditSourceImplNoel Grandin
Change-Id: I69b3fcbdb8a41ed227acdc65232ca013e63bc82d Reviewed-on: https://gerrit.libreoffice.org/53880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SvxTableControllerNoel Grandin
Change-Id: I505f0fe1626e6b935c4194cceaa0f4d0f8756656 Reviewed-on: https://gerrit.libreoffice.org/53879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SdrObjEditViewNoel Grandin
Change-Id: Ie980c0f50483235663e9560fbcf61cf284663228 Reviewed-on: https://gerrit.libreoffice.org/53878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-06coverity#1435443 Arguments in wrong orderCaolán McNamara
and coverity#1435439 Arguments in wrong order coverity#1435437 Arguments in wrong order Change-Id: I8dc4166640613ce25c9d01624d607568e42edac9 Reviewed-on: https://gerrit.libreoffice.org/53915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-06 17:01:41 +0000