summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-12-10Resolves: tdf#138789 disable widgets on 'none' when status changesCaolán McNamara
instead of when chage is dispatched, the chart case has its own dispatcher that disables the base class one. This fixes the reported problem, and the related problem of updating when moving focus from one line that has style 'none' to one that doesn't, and vice-versa, where no change is dispached on received on context change Change-Id: I6afb396e75ba93c13fcae71c52618cfce7f9cecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10pdfium: no need to use FPDFPageObj_GetBounds() directlyMiklos Vajna
Change-Id: I74f968e0b76a2992d5f07524a29a7c8600983d3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107509 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-09split WeldEditView::Paint so a subclass can render a specific bgCaolán McNamara
Change-Id: Id502b98c6754db9dd6314c4bd960ca8065a0fa42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107473 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-09restructure WeldEditView for reuse in SwAnnotationWinCaolán McNamara
Change-Id: I9474553e595780fa61bac955d2d5ebf691408ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-09Resolves tdf#138127 - Use document color for border widgetHeiko Tietze
Change-Id: I57fdbd37c23f3bd2c20ac04ef598cd8a182aac6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105577 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-08Very early work-in-progress commit for the "DevTools" dockable toolbarTor Lillqvist
This commit mostly just adds the plumbing to officecfg to display the DevTools toolbar. The code for it does not yet implement any specific functionality. The name "DevTools" is likely not what this will actually be called in the end. The DevTools toolbar just contains two unrelated combo boxes. (See https://blog.documentfoundation.org/blog/2020/07/27/tender-for-implementing-support-for-a-dedicated-built-in-uno-object-inspection-tool-in-libreoffice-202007-02/ ) Change-Id: I23cb129b48fde64ae39de5db5811cdf61c8993e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107432 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-07move various notebookbar widgets into vclCaolán McNamara
and we can drop their factories then Change-Id: I1e261886dd7700710ba628da4bbeeba65efa1531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07tdf#42949 Fix new IWYU warnings in sd/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I360874fb66c9359abf46a00116d73f87ad122168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106083 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-04update pchesCaolán McNamara
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-03tdf#34828 sd navigator: make unnamed shape select select shape objectJim Raykowski
Change-Id: I4685d7db802767553018d08d23d8b33bca7efff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106958 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-12-02tdf#129961 svx: add rendering for table shadow as direct formatMiklos Vajna
There was already shadow support in ViewContactOfTableObj::createViewIndependentPrimitive2DSequence(), but the UNO API and UI could only set the shadow properties on a shape style, so shadow-as-direct-format is new. One difference between the PowerPoint shadow and our shadow is that we draw shadow for table text as well, while PowerPoint only does it for the borders / cell fill style. This means we're either backwards-compatible or compatible with PowerPoint. Solve this problem by leaving the style case unchanged, but render direct formatting like PowerPoint. Change-Id: I2bc64fea8062f9d8162b95d1eaccb49c3466b5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107073 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-02pdfium: add width/height/format wrappers for bitmapMiklos Vajna
Change-Id: Ic8c85c4224b89d1e7bb8ded1a11c5fd8139f5701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107044 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-02Partially resolve: tdf#113286 Add https:// to URL in Crash ReportSeth Chaiklin
Also: "Don't" --> "Do Not" in another button label Change-Id: I320a2f3fbe1ad1d2ac3efff94c0195be15335a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107018 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-02pdfium: introduce an enum class for path segment typesMiklos Vajna
Towards not including fpdf_edit.h in PDFiumLibrary client code. Change-Id: Iffdd11b0613399f31a3ed383c22b7a91059b83de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107011 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-01tdf#129961 svx: add UNO API for table shadow as direct formatMiklos Vajna
Adding it via a style was working already. Change-Id: I122c359716a404159d3521d63d44ef8bfe35c214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106987 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-01do not unnecessarily explicitly force gradient step count (tdf#138581)Luboš Luňák
Toolkits usually do not provide the ability to specify gradient steps, which means VCL falls back to its algorithm, which at least with Skia sometimes causes poor results. Change-Id: I35dbf87e77d5ed36d8f257db877135a2a0be2ffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106971 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-01Resolves: tdf#138549 use GetSpecialTextBoxShadow to identify ScPostItCaolán McNamara
instead of a 'special' name which causes undo-related causes side effects Change-Id: Id36b0b5360ddde3469721a7c837fe3942af08209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTIONNoel
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30tdf#129961 svx: add doc model xml dump for shadow-related pool itemsMiklos Vajna
It seems that sdr::table::SdrTableObj is already capable of storing shadow properties, but this is not easy to inspect, extend the xml dumper to improve the situation. Change-Id: Ideef43dfd6b844e0227632ec2cb6ab5d16171d8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106902 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-27tdf#138307 Chart import: fix lost custom shape textBalazs Varga
Do not set empty text to SdrOutliner, if it is already set. Note: Also fix the missing custom shape problem in tdf#72776 and tdf#93641. The wrong position (X:0, Y:0) of these shapes is another problem. Regression from commit 6f62a5c4ee2c1b7654c7fcaa618fb495e0d32f0a (tdf#128985: ODP: Style text directions revert to RTL on save and re-open) Change-Id: I07d8cb12836daf15db347f6bb19c17ed9373189e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104909 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-26factor out as a standalone "ButtonPressRepeater" classCaolán McNamara
Change-Id: Id89d5655c2428cecdaf9faa224133302c6448a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-25tdf#42949 Fix new IWYU warnings in directory svxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If578c5119b85f991825e91df37c42e28f16e9de5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100555 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24tdf#138430 scrolled windows need to have auto scrolling disabledCaolán McNamara
Change-Id: I8a622f00238d3d20d21d2439d6fc4fb13358f0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24static_cast after dynamic_castNoel Grandin
Change-Id: I196d4e9065961d6f4e3fef4475dd5f406e998447 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23tdf#138430 toolbar bullet dropdown should have a scrolledwindowCaolán McNamara
as should the matching dialog pages Change-Id: Ib327d3c02d1bc5ae11a6a76d52c9e17803f05534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23dynamic_cast followed by static_castCaolán McNamara
Change-Id: I3f121c2981c3dbec237b11babc91af80309ec356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106400 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19Resolves: tdf#114956 skip broadcast optimization for ScPostItsCaolán McNamara
so we can resize the ScPostIt as was the case before commit f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 Date: Fri Aug 4 18:56:43 2017 +0200 editviewoverlay: Allow EditView to run in Overlay Change-Id: Idd92716a9b38058f6f275769d4f2523eddac500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-18tdf#137397 Faulty Height value in Position and Size content panelCaolán McNamara
Change-Id: Ie7439371cb2d216ca1d95f21db44d203cccd9ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-18Remove unused GraphicObject::SetGraphic pCopyObj and rLink parametersStephan Bergmann
The defaulted pCopyObj parameter of the first SetGraphic overload became unused with ea3d755ac949c1b6dada5c341e018f8c23f5d395 "vcl: detach usage and remove GraphicManager and GraphicCache", and then the rLink parameter of the second overload became unused with e4eb416c3ef81d098ed61caabd2077cbbb2418bc "remove swapping and link from GraphicObject and Graphic" (removing the need to have two different overloads). Change-Id: I15a648845ed474ee302e2a9836776ba74b9c44a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18Remove unused SdrGrafObj::SetGraphicLink rReferer, rFilterName parametersStephan Bergmann
unused since 9fb7aaf570c03c8a26d763f1205fb8c890e8211a "Make linked graphic register into LinkedManager again", and remove further function parameters and class members that turn out to be unused now, too Change-Id: I3dd2b138fd8787d12b89547526da751ea5954845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106041 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18Clarify signature of some opertor() that must match ColorSelectFunctionStephan Bergmann
Change-Id: Ibb71d1e993bbb0fa453c59f48ab5f7c79e1d8025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106036 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18tdf#137836 Change the label from "_Comments" to "Comme_nts"diwanshu885
Change-Id: Ia624f6be5f0d9bb8613475104e901457cc814eb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105307 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-17Reuse ColorSelectFunction from colorwindow.hxx in PaletteManager.hxxStephan Bergmann
Change-Id: I86b9bf57cbb5ee7e2b0d189d6ff78a3fbc9145fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106021 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-17loplugin:stringviewparam check methods tooNoel
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17tdf#137980 sw textbox: fix automatic size of shapes with rotated textMiklos Vajna
If a shape+fly pair has automatic size for the fly frame, then only the sw layout knows the necessary size, this is then sent to the shape and SdrObjCustomShape::AdjustTextFrameWidthAndHeight() is meant to respect those "suggestion", instead of sizing the shape based on the contained editeng text, which is always empty for shape+fly pairs. Improve this mechanism so it works better when the writing direction of the fly frame is tbrl ("rotate to the right"): make sure we always grow to the left and to the bottom, so the shape and the fly geometry matches. Also improve the testTextBoxSizeAtBottomOfPage "change detector" test which had a hardcoded height, but which did not clearly derive from any in-bugdoc value. Rather just test that the shape wider than taller, which was probably the intention. Change-Id: Ic6a77a1125bbf31b198aaf9048dc4812c87b4d9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105960 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-16Instead of labs, use overloaded absStephan Bergmann
...more likely to pick an appropriate version for the involved integer types, esp. after the recent long -> tools::Long changes Change-Id: Ia91259ca35aaf74b0e907de6831fc926f30057f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-16tdf#138232 don't grab focus if we already have itCaolán McNamara
Change-Id: I6fe852c87937ea4353822474ae1b7e20c9436f94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16replace std::min(std::max()) with std::clampNoel
Change-Id: I76e34e8020d98292e8ffde387542b7029f85a42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16tdf#123936 Formatting files in module svx with clang-formatPhilipp Hofer
Change-Id: I482a00c9f65fd08be03f101c0e18f044c9323137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105716 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-11-16replace std::max(std::min()) with std::clampNoel
Change-Id: I890d19f5e2177294dc1175c90c98b964347f9e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15Dialog update: docking 3d effectsandreas kainz
Change-Id: I258911b4e4ecf401723f4f7f424129bf0b9f430c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105772 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-13Revert "remove BigInt::operator tools::Long()"Noel Grandin
This reverts commit 1397a1c8e4995b0dd336478e564880fe8ad91d1d. Reason for revert: Some discussion required Change-Id: Id39ee8260790e0722c5bf8338b0b76ca34da83d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105539 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13Fix (some of) fallouts from tools::Long change to 64 bit on _WIN64Mike Kaganski
Change-Id: I297d43c594c5d8c3378e8b7f29ad798e89e4ebaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105776 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-13Make Split Table Cell dialog asyncSzymon Kłos
Change-Id: I4efbb24f721aa50cc4dbbe78ae1e7e6087f8c876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105594 Tested-by: Jenkins
2020-11-12New loplugin:stringviewparamStephan Bergmann
...to "Find functions that take rtl::O[U]String parameters that can be generalized to take std::[u16]string_view instead." (Which in turn can avoid costly O[U]String constructions, see e.g. loplugin:stringview and subView.) Some of those functions' call sites, passing plain char string literals, needed to be adapted when converting them. Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-12Revert "remove Fraction::operator tools::Long()"Noel Grandin
This reverts commit 48b667a7e7d25f835f95df89162a7849d6972531. Reason for revert: some discussion required Change-Id: Ia0990d280837fb68b7ddc9f472ec78b1467b4311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12Use translated standard styles for styles listboxSzymon Kłos
In online we can have users with multiple languages. Select style in sidebar depending on translated name and also universal/English. Change-Id: Ia33df29526e5fd8de5c7e0f7f6f74e0b0f559477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103000 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105592 Tested-by: Jenkins