summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-04-21weld sidebar text panelCaolán McNamara
includes weld SvxFontNameToolBoxControl Change-Id: Ie48338243600c07f9f8c609701c137175133f8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92585 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21don't add maUserItemSize to text width, just use it as-isCaolán McNamara
which means we don't need the reverse calculation in the style dropdown to force that result Change-Id: I3c8421e964af4339abfacb455b75db5ad75456fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21weld FontNameBoxCaolán McNamara
with custom row rendering Change-Id: Ia909b5b9ad56b6ea4611e9ea0a1e2cb0064a8cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20effectively unused mnStyle memberCaolán McNamara
Change-Id: Ieb579c9440810a937c7da0f9dd8e3b79a2e0e5b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20weld SvxFontSizeBox_ImplCaolán McNamara
Change-Id: Ied8ef61226a720acac74db78ae5852cd4e624d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20set popup for a welded TextCharacterSpacingPopupCaolán McNamara
Change-Id: Ic21e1fa8c3c384987856a185c000bc9d846deecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20add tools::Rectangle::JustifyNoel Grandin
so rectangles can be constructed already valid Change-Id: I3ae5e24add3c81f79dcdf863f855dca439876f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20set popup for a welded TextUnderlinePopupCaolán McNamara
Change-Id: I5388be71e102065e89f0d5489fbb1af34fa1a2ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-17Revert "[API CHANGE] remove some primitives rendering settings"Noel Grandin
This reverts commit c71656f51a09e88ecae4f3423c96fee84778647d. Reason for revert: I give up Change-Id: I2a09c36c1f0d731f4d3f7d809364de7efa8d8a58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16[API CHANGE] remove some primitives rendering settingsNoel Grandin
Remove the following settings: QuadraticFormControlRenderLimit Quadratic3DRenderLimit RenderSimpleTextDirect RenderDecoratedTextDirect SnapHorVerLinesToDiscrete which have no way to be set from the user interface. Change-Id: Ie96531425f5ba6021ade4f247b18b99092fd7e5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16tdf#122444 Use fontwork name for object nameJim Raykowski
Change-Id: Icdbde958f2e89e669a9399479e0059095a6d8a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16Resolves: tdf#122491 ClassificationDialog::run() is not calledCaolán McNamara
when using DialogController::runAsync so the custom override isn't called so the special setup and save-on-ok aren't called. move the setup into the ctor seeing as the dialog is only run once after ctoring and add a OK handling that does the on-ok setting save and have setupValues call readIn on "m_aInitialValues" because that gets called after the ctor Change-Id: I8183fc4b0f5de2844562c971c86d655f2d4920ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16loplugin:buriedassign in svtools..svxNoel Grandin
Change-Id: I04bc97effddb213e9c1ac613b61d3a0bc38522ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15Gallery sidebar: shape section get more vertical spaceandreas kainz
Change-Id: I37409b991d3f111d257a69721c8cdf443126e75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92233 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-15Add Area fill bitmap presetsandreas kainz
Change-Id: I3093f03d4d43008563fa038c1e49c33009eba289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92232 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-14lok: add tabstop changing and callback to send tabstop updatesTomaž Vajngerl
This adds callback LOK_CALLBACK_TAB_STOP_LIST to send the tabstops for the current paragraph. In addition it adds .uno:ChangeTabStop action, with which it is possible to change just one tabstop identified by the index. Change-Id: I7762ead12e47288cbb0b0a1c8ffb8e9872cee8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92147 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-12replace and remove VectorGraphicDataPtr typedef for the real typeTomaž Vajngerl
There is no need to hide std::shared_ptr<VectorGraphicData> type under an alias name. It doesn't make the code more understandble and it usually is the exact opposite because we know with what type we are dealing with. Change-Id: Iec80ee99697ff2fe3a8275fc2787b5370510ebe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92069 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-10Make BitmapPrimitive2D vcl-independentArmin Le Grand
as preparation to have drawinglayer module independent from vcl in the future Change-Id: Iaa01370f27b51cba5114a54f37d1ec73d0719918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92048 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-04-10tdf#130074 untranslated Arrow style stringsandreas kainz
Change-Id: I451082d34c236f90013749798745f01bf03d971a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91998 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-09tdf#96760 Don't assert on presentation with video for non-desktopMichael Weghorn
Since the OBJ_MEDIA case was only handled '#if HAVE_FEATURE_DESKTOP', a non-desktop debug build would run into the assert in the default case and complain about a "Not implemented Starone-Shape". The corresponding HAVE_FEATURE_DESKTOP switch had been added with commit c0b3d5be8fcec28190b1f25c9c0fd99916299249 ("Try harder to bypass avmedia on non-desktop for now", 2014-04-17). However, at a quick glance, SvxMediaShape now properly handles the case where avmedia is not available itself (presumably since commit 54982d5fea21d9e81e1561a74fd341ddb0570c91, "svx, check HAVE_FEATURE_AVMEDIA", 2018-01-07). For an Android Viewer debug build, a placeholder is now shown instead of the video (just as was the case for a non-debug build already without this patch), rather than aborting. Change-Id: I49864a3742d0435cd5346f561dea9f2f804ace70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91921 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-04-08svx: Drop duplicate fix for unused parameterMichael Weghorn
It looks like the two commits c468b6910bf77e332647725da70e3cb248a9de0e ("-Werror,-Wunused-parameter (Android)") and bfaae016b225e775264008935cddef1564b07e66 ("svx, compile error with !HAVE_FEATURE_DESKTOP") were submitted independently on 2019-03-09 with just a few hours in between, and thus this has been added twice... Change-Id: Ic930eaba65adda9c210a1d3e376136095ee062db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91885 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-04-08run svx animations at POST_PAINT priority (tdf#131753)Luboš Luňák
Skia VCL drawing (and GL too) set first drawing to POST_PAINT, so that the contents aren't drawn prematurely the first time, but only after the first paint has been finished. But animations constantly running at a normal priority will starve that. It doesn't make sense to run animations at REPAINT or higher priorities anyway, if LO is busy painting then animating more will just make it even busier. Change-Id: I6ee3356c9ef9acb577f8d81976aa3df968ca2155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91836 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-07use "To Background" and "To Foreground" only in writer sidebarPranam Lashkari
Change-Id: Ib7ccac192721b663c9655417fc3d639766d0424d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91604 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-07new loplugin:unusedvariableplusNoel Grandin
a particularly aggressive checker, which is why it is off by default Change-Id: Id5a0faa50b3ecc75e01f4aedc6579c5209e585da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-07tdf#131125: Fix improperly used ampersandJulien Nabet
"Find & Replace" => "Find and Replace" Change-Id: I055fb74d8c6ac0fbe3b11ca8ce9b6f0cc4ad80fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91785 Tested-by: Jenkins Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-06remove newly unused stuffCaolán McNamara
Change-Id: Idce9955294372817c0dd1f40ebd38f16fc90eab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06LOk: notify the state values of the position and size property panelHenry Castro
Notify to client side when the UNO commands (TransformPosX, TransformPosY, TransformWidth,TransformHeight) have changed only valid for mobile devices. The state values are obtained from "position and a size" property panel of the sidebar and they have a converted units formatted text and simplify client side not to convert the units again. Change-Id: I0d37a9746d550e09bf2a5b182530ef7c2a0dee37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91238 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91578 Tested-by: Jenkins
2020-04-06lok: introduce QueryControlState functionHenry Castro
The sidebar usually executes UNO commands to the core framework, however the controls already have formatted the text that is useful in Online client side. For example the units conversion. The QueryControlState method will retrieve the current formatted text of the sidebar control to be used in Client Side. Change-Id: I0b3e3a1462d4391ac911352f35808a5e5d9f9ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91237 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91577 Tested-by: Jenkins
2020-04-05lok: update the measure units if changedHenry Castro
Change-Id: If793e5e678277e27d66e7bcfbf3fbec999e46c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90937 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91576 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-04-04rhbz#1820868 deref of null xLayoutManagerCaolán McNamara
Change-Id: Ib396ef9f5b019b08a181eeb5a8eb983bdb401db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91693 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-03split up polypolygonprimitive2d.hxx into separate filesTomaž Vajngerl
This patch splits the polypolygonprimitive2d.hxx into: - PolyPolygonColorPrimitive2D.hxx - PolyPolygonGradientPrimitive2D.hxx - PolyPolygonGraphicPrimitive2D.hxx - PolyPolygonHairlinePrimitive2D.hxx - PolyPolygonHatchPrimitive2D.hxx - PolyPolygonMarkerPrimitive2D.hxx - PolyPolygonSelectionPrimitive2D.hxx - PolyPolygonStrokePrimitive2D.hxx ... and fixes the include files and pre-compiled headers Change-Id: I23982e0c81e8992f69e14cbac8e86858266b9999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-03loplugin:unusedfieldsNoel Grandin
Change-Id: I4abf2df75c54936e02a8a3d8fa26f2b249e69780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02cid#1461094 Unchecked return valueCaolán McNamara
Rectangle::IsOver is only useful for its ignored return, so remove it and thus aMouseRect2 Change-Id: I6b93de4d0d62dd56abe52cc0b65c7d905f4c847e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-31added Clear Direct Formatting button to sidebarMert Tumer
Change-Id: I8d723f50cdc9bb768c082b7b5d9eafe1a6d7f9f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91398 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-30tdf#101181 related: fix SdrShadowTextAttribute::operator==Mike Kaganski
This fixes rendering of glow after its radius becomes 0 once. Change-Id: I7cb13989496bb113689f56ccdb53190d9b5d4ac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91372 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-30Use dynamic_cast resultMike Kaganski
Change-Id: I7f91935e2b0230c17456a810c6e7553a103c04f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91299 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-30FrameLineColor - add Color parameter, and share code for color params.Michael Meeks
Change-Id: I50483228221e817eb1a1d049d3c1ddf55a9c91d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91354 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-30Simplify SdrObjList::GetObj (svx/svdpage)Julien Nabet
Change-Id: Ia6f8398a7b4045d4b06558c51f2c815e78fbc1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91346 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-30Replace OSL_ASSERT by assert in GetObj (svx/svdpage)Julien Nabet
Change-Id: Ia985773b0021f3b7f225790e691436db196fac61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-30replace usage of Matrix for B2DHomMatrix in ImpSdrPdfImportTomaž Vajngerl
Change-Id: I366ee435ddf217c7c078d58f882610df12bec276 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91341 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29tdf#131532:Blurry thumbnails when small shapes added to gallery themeAditya
When small shape is added to gallery theme using drag and drop method, their thumbnail is rendered improperly and as a result they are blurry. This change renders the thumbnails normally without getting blurred. Change-Id: Ibba7e93ba09a42b0d1bf4a1a833f3fe17c8557f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91319 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-28svdpdf: move Matrix to basegfx just to get it separatedTomaž Vajngerl
Change-Id: I9d887dc7a2836b90151ef352b47a9b9ad3b6f12b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91280 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-27pdfium: make breaking of PDF graphic work againTomaž Vajngerl
Changing PDF to use VectorGraphicData deleted the calls which triggered the breaking of the PDF. This change makes breaking work again. Change-Id: I1d817f1556e37fcbcc3d2850b690eb0810676fa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91234 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-26tdf#130074: add missing translations (line styles part)Julien Nabet
+resorting to follow extras/source/palettes/standard.sod order Change-Id: I3246490578fb4b1af46bfe99b59bbb1e8a36ea8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87792 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-26Resolves: tdf#131582 center image, don't stretch itCaolán McNamara
Change-Id: Ic46e4ee2136973826604cf16c447393498e09e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-25SdrGrafObj: don't check the primitive sequence for PDF to get metadataTomaž Vajngerl
For a PDF we create a BitmapPrimitive2D only, so it doesn't have any metadata in the primitive sequence itself, but a call to the getVectorGraphicData() method will render the PDF in order to create the BitmapPrimitive2D. This is a problem when we have multiple pages as we want them to be rendered on demand and not right away on load. This change short-circuits the gathering of metadata for PDF to prevent unnecessary early rendering of PDF pages. Change-Id: If5c286e88e72c4c0ba5083a98c7db707d207b6cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91034 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-10 09:03:15 +0000