summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2020-05-05tdf#118655:Move Wildcard/Comments option above Regular expressionsAditya
Place "Wildcard/Comments" option in find and replace dialog above "Regular expressions" option and the "sounds like (Japanese)" option in place of the older location of "Wildcard/Comments". Change-Id: I83dffb0689f128ad31b9223bc98ecc5914e4bf41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93410 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05sw from-bottom relative orientation: add UIMiklos Vajna
And fix the value of LAST: it seems this went wrong in commit c2fc91664f71c447209d2cd29c0df1d7faba4927 (Convert LB flags to scoped enum, 2016-05-14), where the upper limit went from 0x80000000 to 0x080000, which means it started to matter if we allow equality or not. Other places compare LAST without allowing equality, so leave that unchanged and instead give LAST its own value. Change-Id: I0ceac18475f5f50b792c7a8442648c9ba2a25236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93477 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05SdrPdfImport: add a test class to sd and write a simple testTomaž Vajngerl
Open a simple PDF document, run the "break" action, check that we get the expected text as a text object. Change-Id: Iadb458f06b437689202eb013cb900edaabf17673 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93395 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-05drop SfxStyleSheetBasePool::CountCaolán McNamara
and use CreateIterator to make it explicit what is being counted Change-Id: I8d76aef601533960a23c056b83a48c4f130bbe75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93446 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04SdrPdfImport: use convertPointToMm100 for all unit conversionTomaž Vajngerl
Change-Id: I78b3512cc0b9aea1fa4e9a810ec71eadd00b7635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93391 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04Fix typosAndrea Gelmini
Change-Id: I63ae6adec1967bcf888538437e5e88f0acdea66e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93392 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-05-03SdrPdfImport: rename ImportText to InsertTextObjectTomaž Vajngerl
There are two ImportText methods, so rename one to something else to avoid confusion. Change-Id: I1ccc491fca47b2d72ba1f7bd5a75d325819ec041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93333 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03SdrPdfImport: fix garbled text at breaking the PDF graphicTomaž Vajngerl
The text size of OUString expects no. of characters, but we give the number of bytes as that is what we get from PDFium. Best to just not give the text size at all and let OUString determine that as the text shouldbe terminated correctly. Change-Id: Icc5cd6e851a9d2920faa9ca2eb6d827465483e72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03SdrPdfImport: rename some variables to non-abbreviated namesTomaž Vajngerl
Change-Id: I1cb004a8e426f8ea26bb930d4897db3763433b31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93329 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02Resolves: tdf#132604 GtkToolButtons that should be GtkToggleToolButtonsCaolán McNamara
Change-Id: Ie481fd0599e0cbd22ea1be7e353016f951837a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01improve loplugin:makesharedNoel Grandin
to find places where we are converting stuff to unique_ptr instead of using std::make_shared. As a bonus, this tends to find places where we are using shared_ptr where we can instead be using unique_ptr avoiding the locking overhead. Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-30svx:unit tests for galleryAditya
Tests for creation of renaming, deletion of gallery theme Change-Id: I2bfb602342f5d6b4ed45ff2f2fb9df7601e0e6b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92679 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-29tdf#132338 better match the original width of the font name comboboxCaolán McNamara
using entry_width_chars to specify how much characters in the Entry to use to show the font name makes the most logical sense. Doing that would make the widget wider under gtk that is currently is, which is arguably too narrow, but being wider would probably mean some toolbar contents wouldn't fit on small screens generating complaint churn. So, match the original width using LogicToPixel rather than get_approximate_digit_width where the latter uses the width of the widest digit in the font, and the former uses 1/8th the width of "aemnnxEM" Change-Id: I1bb6970faa6fc34830681902640fe1f61e3cc55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-29Remove tango icon theme, tdf#132022Rizal Muttaqin
Change-Id: Ifd1d3999d1c6eb9aba7919850859e6b7cb652e3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-29simplify handling of comparing XML_NAMESPACE valuesNoel Grandin
Change-Id: I18bbf1ee206285842250891ce556d523489855b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-28move the castToFastAttributeList functionNoel Grandin
to the slightly higher namespace, to make it easy and more readable to use directly in a for-loop-range expression. And make it return a reference rather than a pointer, since it is never allowed to be nullptr. Change-Id: I15d0b32493ef65cfc601b247c272b318f1eadfd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-28resolved clashing of two idsPranam Lashkari
Multiple SvxFillAttrBox objects having the same ID 'fillattr' caused the problem in online making it hard to distinguish for different function Change-Id: Ic5a29ea75fb442d7e495761faf4a10d6ab212829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92977 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-27drop unused usingCaolán McNamara
Change-Id: I89c6892b51d651a25aff9c36c02c93374138635f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26move PanelLayout to sfx2Caolán McNamara
Change-Id: If29ccb67835adba3ff6cf2eb53f348bbe71d6463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26update pchesCaolán McNamara
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26all ItemWindows are now weldedCaolán McNamara
where native widgetery is hostable in a vcl toolbar or a native one Change-Id: I942ada335bb4bd6ced0f3352f632e25787f68597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25rename SvtValueSet back to ValueSetCaolán McNamara
Change-Id: I51ab96ffef7acc0d416d13ac8e380e49381f4d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25rename ColorValueSet back to SvxColorValueSetCaolán McNamara
Change-Id: I2036a8986d2d53fc97f1c7724e4e0ab837edc1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25remove newly unused ValueSetCaolán McNamara
Change-Id: Ia2c587af9846129278caf66ab504d1a1a1ac6256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92897 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25remove newly unused SvxColorValueSetCaolán McNamara
Change-Id: Iaf7243430e50df4db84f7032eaf52728cc779c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25weld SvxColorDockingWindowCaolán McNamara
Change-Id: Iabefa16f850d3d76017adfd77fb6be30ed467887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25loplugin:constantparamNoel Grandin
Change-Id: Id6197d72ae136da04dfb22c847623004b797d75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-25loplugin:unusedmethodsNoel Grandin
Change-Id: I7ba901c7d6e1e88d9d2821df4a37ebbea3b63084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-24all PanelLayout are layout awareCaolán McNamara
Change-Id: I11609c3b4e0783bc7dfc64467ba675761886859b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24final ctor arg of PanelLayout ctor is always true nowCaolán McNamara
Change-Id: I40cb888c13cb49aa0e20b5be5ceb1c15cf7a346c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24don't need to include combobox.hxxCaolán McNamara
Change-Id: I3cc0fe1be7e7bc28a398c04a6702a6cd4d7d6b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24weld StylesPropertyPanelCaolán McNamara
and SvxStyleToolBoxControl, etc. use a GtkOverlay to support the submenu hackery in the Style wysiwyg combobox dropdown Change-Id: I17baa56f382243070ee49e6d707e97324e4f4d67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24loplugin:unusedmethodsNoel Grandin
Change-Id: Ieec5099a8ce9fa3f07e36be244071efc1b101cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23cid#1462476 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic545f41cfd466fc25bb7121b97d42d26a6a998e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23Don't call default ctor only to reassign laterMike Kaganski
Change-Id: Ia725652f5124a2288bcca319a35d549c0bc3e351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92793 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-23pass SvxBrushItem around by unique_ptrNoel Grandin
we never create an object that is actually shared, so this is wasted Note1: in IMPL_LINK_NOARG(SwEditRegionDlg, OkHdl, weld::Button&, void) there was a comparison if( aBrush != pRepr->GetBackground() || ... which I removed Note2: In bool SwDoc::GetBoxAttr( const SwCursor& rCursor, std::shared_ptr<SfxPoolItem>& rToFill ) which had a condition else if( rToFill != xBack ) I changed to compare contents Change-Id: Idd769f44917c5ccc7e9f4bfbaddf12f9cd4151cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23Resolves: tdf#132338 combobox 1 character narrower than it used to beCaolán McNamara
Change-Id: I9b24c654a9d209c5d52eebf852b6dca436a782b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92742 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23Added parameter to FillPageGradient commandPranam Lashkari
Change-Id: Ife435fc25e8e3114e66461af22ac9e0ef8c9d011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92235 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-23Added parameter to FillPageColor commandPranam Lashkari
Change-Id: I22943815b69eeb7628eb243e0dbc6c8e0ea3487e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92213 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-23resolved: Impress mobile Choosing a different type of shape fill crashesPranam Lashkari
Change-Id: Idd8dbba866b64089055880ffad9b5cbd9b12ca85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92688 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-23Sidebar line alignment updateandreas kainz
Change-Id: Icfe5a6337ca4510ea6aaa44823ef623ce6860c18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92663 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-23tdf#130058 Import shadow size.Gülşah Köse
Change-Id: Ie1cee377a33567088fb76ea47f0e6fc51d47f0fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92188 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-04-22move InterimItemWindow to svtoolsCaolán McNamara
Change-Id: I058b1d96a3ddfaa1aa96f66d0ebc6fa68900a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22tdf#130156 add alignment commands to the sidebarandreas kainz
Change-Id: I302acc25b65ef20a0338401e763d400076f6e36d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92634 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22some of these need to be GtkToggleToolButtonCaolán McNamara
Change-Id: I1ebfac22b006de560c5208906b4d2a1efc011f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92654 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-10 03:21:15 +0000