summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2023-04-27tdf#154818 - Find bar: remember and reuse last search stringAndreas Heinisch
If there exists no last search string in the view options and there exists a search history, preselect the last search item. Change-Id: Ic6056e02eaf6c0ee7e266e47ba961dff11e9f9da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151072 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-25svx: rework the theme dialog to allow editing theme colorsTomaž Vajngerl
In addition to editing of theme colors, this also changes the way how theme colors are represented in the theme dialog and the behaviour when changing applying a theme color change. Previously a theme colors were applied with double-click, now a double-click still applies, but automatically exits the dialog. The selected theme is applied also when OK button is pressed. Change-Id: Ic0f8399ede180d6ab0001a7f8b5dda0e7c49fa3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150975 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25loplugin:unnecessarygetstrStephan Bergmann
Change-Id: I36eaac02a9779ee8e1f69930ffeafedc8641301f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150961 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-25Add script to find unused using declarationsGabor Kelemen
As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls" Pros: - simple, fast! - finds some more unused declarations, somehow - works on non-linux specific parts of the code - clang-tidy (for me) trips on files with external headers, this does not Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-24oox: extend ThemeExport to export font and format scheme of a themeTomaž Vajngerl
Also use the ThemeExport when exporting PPTX documents and remove all the hard-coded theme bits. Change-Id: I03791e23d6ac4023748b5a553e4824b72ed63a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-24loplugin:unnecessarygetstr extend to more std::string checkingNoel Grandin
suggested by mike kaganski Change-Id: I5f5f254142767aca45a6101abdd84a0163ca6a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-23cid#1524676 try to convince coverity of the error of its waysCaolán McNamara
and cid#1524745 Explicit null dereferenced Change-Id: Id2fb9cf6d0a71712533e14981a33490c578db597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-23use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more complete information when something goes wrong Change-Id: Ia73623f748b0779cf80b0086bd8258791590e9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-23Run clang-tidy with misc-unused-using-decls on modules [s-t]*Gabor Kelemen
To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: I596299084471b2904548d23875866f1583b00b2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150610 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-04-21loplugin:unnecessarygetstr extend to checking std::string::c_strNoel Grandin
Change-Id: I17398e2a6a31a2c98ba8e54b5c8045f22aee8759 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-21Resolves: tdf#154535 create the OXFormsDescriptor on-demandCaolán McNamara
so we don't cause an unwanted Binding to be created unless we are forced to. Change-Id: Id78cbbb72ebd4e78b82a1ba614bbcb6488d04ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-21MCGR: Reduce diverse GradientStyle enums to single UNO API oneArmin Le Grand (allotropia)
Change-Id: Ie0cd26a308a75ddead9451c53e874a39cc6eeb63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150705 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-20tdf#154732: Fix zoom bar in DrawBaole Fang
Oringally, the zoom bar in both Draw and Impress show "Fit slide to current window." Now, the zoom bar in Draw is modified into "Fit page to current window.", while Impress still uses "slide". Change-Id: Iba25215d437b128f581bc5a8e6767f6b1f382be4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150650 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-20MCGR: Correct creation for Gradient-PreviewsArmin Le Grand (allotropia)
Change-Id: Iafadcaa93660317d65c8f45940653273b562f37e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150651 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-20tdf#153190 Compressing tool calculates compression rate wrong on large imagesNoel Grandin
calculation used sal_Int32, which overflowed on large values, rather use floating point to do the calculation Change-Id: I15974c5bf785a800a8f71711acfa9895361bad7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-20tdf#142978 Add quick fix action for missing alt textSamuel Mehrbrodt
Change-Id: I09234e50def6b52b9a70081f31bb45b8d7e2cdd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150003 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-04-19MCGR: 2nd corrections/adaptions to MCGRArmin Le Grand (allotropia)
Adapted handling of 'border' argument from our gradients for oox export, so that it looks the same. Also added quite some cases to peserve in-between GradientStops for current UI implementations to be able to edit the gradients as usual without losing the in-between GradientStops. While we will not be able to modify these, we are at least able to modify all the other gradient attributes, including start/endColor. Done this for TransparencyGradients, too. Also moved more stuff to the gradient tooling in basegfx. Change-Id: I6e94011bbf3715baa1401ab97e5b59811298342f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150577 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-19tdf#150020: pass transform and scale matrix for the table shadow primitiveSarper Akdemir
Shadow scaling related bits in createEmbeddedShadowPrimitive, requires the ObjectMatrix with scale and translate. Pass these in for table shadow creation too. Change-Id: I28c30fe49d3c90e3ca03fb5294ca97eb5ba22773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150639 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-04-19tdf#154818 - Find bar: remember and reuse last search stringAndreas Heinisch
In addition, the search items are rearranged to their usage order. Change-Id: I4f4bdfd869a981726ef84060e93c178502eaefef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150485 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-19loplugin:finalclasses in swNoel Grandin
Change-Id: I0b68920bb82bb9c096f4ee2e3532e4588302dc8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150605 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-19add a route to get calc Floating Frame links under 'manage links'Caolán McNamara
much harder than writer because the organization and ordering of properties and object activation etc is different. This ended up ugly, but functions. We set FrameURL before AddShape, we have to do it again later because it gets cleared when the SdrOle2Obj is attached to the XShape. But we want FrameURL to exist when AddShape triggers SetPersistName which itself triggers SdrOle2Obj::CheckFileLink_Impl and at that point we want to know what URL will end up being used. So bodge this by setting FrameURL to the temp pre-SdrOle2Obj attached properties and we can smuggle it eventually into SdrOle2Obj::SetPersistName at the right point after PersistName is set but before SdrOle2Obj::CheckFileLink_Impl is called in order to inform the link manager that this is an IFrame that links to a URL Change-Id: I67fc199fef9e67fa12ca7873f0fe12137aa16d8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-18allow SvxOle2Shape::resetModifiedState to survive having no SdrObjectCaolán McNamara
Change-Id: Iea059262c124e3f44249e49b4189732310d28156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-18tdf#150020 pptx import: handle algn for outerShdwSarper Akdemir
Introduces RectangleAlignmentItem that holds a value of the enum model::RectangleAlignment. Introduces SDRATTR_SHADOWALIGNMENT that holds alignment for a shadow. Implements import of algn for outerShdw. Makes the alignment considered while the shadow is being scaled. Also adds a unit test that covers this. Change-Id: I8f4eaed5f0d9428a7f405c65f19237f9e70ca151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148934 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-04-18reduce copy and paste a bitCaolán McNamara
Change-Id: I65cb71d44828e0c0d738c4192c39a697513bc6e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-18Resolves: tdf#154870 label grayed out when it should not beCaolán McNamara
Change-Id: I1d84434622f09e6e91bea550f5dc0321cb7d89ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150548 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-18sc drawstyles: Comment shadow should depends on shadow attributeMaxim Monastirsky
The shadow of comments differs from the shadow of normal callout shapes, as it shows only for the text rectangle. However the way it's implemented is weird: The shadow attribute is set to false, which turns off the "normal" shadow, and then the special shadow is drawn unconditionally. There is also a code that forces the shadow attribute to false on import, to handle some old files that used to have the shadow on. The confusion begins when one shows the comment, and looks at right click > Area... > Shadow, which (rightfully) shows the shadow as off, but doesn't align with what is visible on the document canvas. Moreover, the other shadow settings on this page do affect the comment shadow, but in order to change them it is needed to check the "Use shadow" checkbox first. But leaving that checkbox as checked will result with a double shadow being drawn for the text rectangle, and an unnecessary shadow drawn for the arrow part. The problem becomes now more visible, as there is a Note style listed in the sidebar. One possible approach could be to draw the special shadow only when the shadow attribute is on, and patch existing files on import to "shadow on" instead of "shadow off". But this will cause the "double shadow" problem when opened in older versions (unless the comment is hidden, in which case we used to override the shadow attribute). But now there's an opportunity for a better solution: As we assign the default comment style to imported comments, we can just clear the shadow attribute DF, instead of forcing it to some value. As a result, the "shadow on" attribute of the style will be in effect in newer versions, while in older versions it will fallback to the "shadow off" pool default. Change-Id: I4b35bc1e8e2e12ed35a82b0c2e9aabcf28b46270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150353 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-17oox: tcPr vert roundtrip, introduce interopability grab bag for table cellSarper Akdemir
To properly roundtrip all possible values of <a:tcPr vert="..."> + Introduce grab bag for table cell + on import: Store the unsupported values in the grab bag: + (e.g. wordArtVert, mongolianVert, wordArtVertRtl) + on export: if nothing is being exported from the doc model, export the value from the grabbag Also adds a unit test covering this behavior. Change-Id: I791ed2d992b0a554ef6da37200f027cffd8c5f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149737 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-04-17tdf#154473 remove assertNoel Grandin
so the commit that caused this: commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject did its job - we have far fewer crashes due to accessing dead SdrObjects - but the wide variety of other, smaller leaks, means that sometimes we have leaks of SdrObjects too. So just remove this assert for now (but leave the warning in DBG_UTIL mode in) Change-Id: I2123ba0f28a0cb4356eab3cbf34c8b67d785c516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-16remove dead codeNoel Grandin
it is easier to see that is dead if you look at the code prior to eec42f0dbcc79a4c9f456ce97fa1066b8031ea28, when we were using unique_ptr, which means that the pointer comparisons could never be true. Change-Id: I2e8608e468868a1f6b657a90b3db580334ec0490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-15tdf#154269 - Respect FindReplaceRememberedSearches expert option in quick findAndreas Heinisch
Change-Id: I88c1bed647bf6f77953ccd9921e515c1246fa96f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150273 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-14Resolves: tdf#113286 make Crash report link clickableCaolán McNamara
Change-Id: Ife9f152e7945d40307e1f8b974e08167981acc6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-14resave with latest gladeCaolán McNamara
Change-Id: Id516d979c803a7a3631f95df220bd430fac0bb0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150413 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-14lok: draw textboxes under editSzymon Kłos
This fixes bug in impress: - open in 2 views - start editing textbox in 2. view on 2. slide - start editing textbox in 1. view on 1. slide Result: slide 2 textbox was dissapearing We need to allow drawing textboxes edited by other views so if we select non-editor for rendering we will see the full content. It was regression from commit e496b55a592caf0ca07f5477285a72d50cee6501 lok: masterpage: don't render text edits from different mode Change-Id: I7645496aec77d11d16621129dd6644d3b54a6010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146999 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150096 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150348 Tested-by: Jenkins
2023-04-14loplugin:stringviewparam improvementsNoel Grandin
improve the check by checking for methods that exclude using string_view, rather than checking for methods that __can__ use string_view, which leads to exposing some holes in our o3tl/string_view.hxx coverage. Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-14tdf#154501 - Fileopen PPTX: Table with rotated text wrongNoel Grandin
regression from commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value where some of code I converted needed to be mutating the OutlinerParaObject that something else held, rather than mutating a local copy. Change-Id: Ib91dddb3fc0d4190868f9fd59becb0d366af5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13tdf#154451 uitest: use more oneprocess modeMiklos Vajna
Execution time changes: - UITest_writerperfect_epubexport: 20,023 -> 6,083s - UITest_svx_table: 15,214s -> 14,378s - UITest_cui_tabpages: 13,561s -> 12,503s - UITest_math_demo: 19,737s -> 13,578s Change-Id: Ide03d5d9cb884297291a5ed1351de5a7602fcba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150346 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 6de8d3109dffa7d4d0cc06f319cca70134f0a8f3 "tdf#103474 handle edge cases in ARCANGLETO". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I40342955feedad25435c03f16a31b9585281c1f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150306 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-12tdf#140730 a11y: Focus form control property dlg when it startsMichael Weghorn
Make sure the dialog gets focus again when it starts after having been welded in commit 1efeb17837c22499f00299c033ae59ba3910f7d7 Date: Mon Nov 4 13:06:04 2019 +0000 weld Property Browser (Tested with gen, kf5 and on Windows.) Change-Id: Ie5d28a60b459735d1f1fa4c2d5d679f3d5a27cec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150284 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-12loplugin:stringview whitelist getLength and isEmptyNoel Grandin
Change-Id: I38f3410c0b25ff579879b9de1f266af4d8fd51e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-10Drop SvStream::WriteCharPtrMike Kaganski
WriteOString is a better replacement Change-Id: Ic431b9aeb98d19fe61cff71360eee555105cc2bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150192 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-10pptx import/export: consider TextClipVerticalOverflow for vertOverflowSarper Akdemir
Also adds a unit test that tests TextClipVerticalOverflow on 4 different scenarios. Change-Id: I6232935765641c796046d90fe2207d67ae4b3eb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150107 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-10editeng, svx: introduce ability to clip vertical text overflowSarper Akdemir
Introduces editeng text property TextClipVerticalOverflow. Which when set causes vertical text that is overflown out of a frame/shape truncated. (Only when text isn't being edited) This is implemented as two steps: (if text overflows) 1 - Vertical adjust is forced to top. (Forcing vert adjust to top isn't the desired behavior normally, but good enough for a first cut I'd say.) -> The desired behavior would be after the overflown text is truncated, doing a vertical adjust (of center/bottom/top) on that piece of text. 2 - ClipRange is set to the height of the frame/shape. This appears to work with different text directions too (vertical etc.). Change-Id: I697715a7d28bde94a6650609b16505ffab92173f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150106 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-09new loplugin:unnecessarygetstrNoel Grandin
which prevents constructing unnecessary temporaries via getStr() Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-09use more OStringToOUStringNoel Grandin
both because it is more obvious to read, and it takes a string_view, which is handy Change-Id: Ic201cfa0434446f51436d23c33d3f1a919ed65be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150167 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-09use more OUStringToOStringNoel Grandin
which makes it easier to pass around string_view in a few places. Change-Id: Icbbb7f56494986582f1c3272404775bd98031240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-08use shared_ptr for model::Theme instead of unique_ptrTomaž Vajngerl
Also change other cases to use the shared_ptr so there is no need to do copies and replace some of docmodel/theme/Theme.hxximports with forward declarations. Change-Id: I4588cb25e05e5f3e535011fffb68a8075b05aecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147691 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-07Resolves: tdf#154680 don't mark an empty fontname as italic for "unknown"Caolán McNamara
its used for 'ambigious' rather than 'unknown' Change-Id: I1aeb2f825c5e611e0a943a6ce5f3ab58658701bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-07sc drawstyles: Keep style assignment for commentsMaxim Monastirsky
Need to handle 3 cases: - Import of hidden comments (not too much useful by itself, as we still force the default comment formatting as DF). - Copying cells with comments. - The comment popup that is shown when hovering over a comment marker. Change-Id: Ibf2e22f1432745fe46f89da624ed3586b5d9fb55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149943 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-06Fix iOS build failure in commit a5225ba82e94a549f44420f56a7cb9d7906561ccPatrick Luby
Change-Id: I5f4fe093c77f2faf91c6512ed5c294a4f2389757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150111 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-04-05avmedia,*: guess the mime type of media files based on file nameMichael Stahl
.. at least for the most popular types, and do it automatically in MediaItem::setURL(). This should work in practice in most cases and is much simpler than adding some type detection or calling into platform dependent avmedia backends. Remove the parameter that was only ever set to "application/vnd.sun.star.media" anyway, the same value that would be used if it's missing. Stop using that silly type for everything, only use it when guessing fails. In case an ODF document is loaded, it will use the mime type loaded from the file (see setting of MediaMimeType in SdXMLPluginShapeContext) and not guess it because that would require updating the entry in manifest.xml as well. Change-Id: I8ce29cf7425678ae11dda1d8c875be818f8623af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150049 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-01 07:01:52 +0000