summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2019-06-04Resolves tdf#125333 - Crash with FindReplaceRememberedSearches=0heiko tietze
Zero remembered searches crash the app when no result is found minimum set to 1 Change-Id: Ib2b4b195d018f0f11238699458066f4d128f8997 Reviewed-on: https://gerrit.libreoffice.org/72459 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03Resolves: tdf#125589 we are initially unsortedCaolán McNamara
so turn on sorting on first sort request Change-Id: I897f64c0695be8cca6d93e234a7d7c4718c94f78 Reviewed-on: https://gerrit.libreoffice.org/73344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-03tdf#125640 correct Beziercurve control points in doublewave shapesRegina Henschel
To follow the way doublewave shapes are drawn in MS Office binary format and specified for DrawingML, it is necessary, that the paths for the two wave parts are equal. That was not the case. Change-Id: Ieeb3f7cf9feca7dd3263f813a074821ea84ef902 Reviewed-on: https://gerrit.libreoffice.org/73358 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-02drop some unneeded includesCaolán McNamara
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-01move SvxStandardDialog to last consumerCaolán McNamara
Change-Id: I02638b5a1a3c7a27c19320fedd291bbcb17bb9dc Reviewed-on: https://gerrit.libreoffice.org/73283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-31drop unneeded includesCaolán McNamara
Change-Id: Ie0f52bb1d6866075d0b664bfc3ddc47c02e4f81b Reviewed-on: https://gerrit.libreoffice.org/73169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop some unneeded includesCaolán McNamara
Change-Id: I42b2ccbb4484ab2acb8208ad88c6f22e4af09f7d Reviewed-on: https://gerrit.libreoffice.org/73114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28tdf#120905 Remove temporary uno command.Gülşah Köse
Change-Id: Id12838cf08a2e5b74b53bd0036804b886b41098f Reviewed-on: https://gerrit.libreoffice.org/73041 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-05-28Fix domain in ui files (cui, dbaccess, svx)Julien Nabet
Change-Id: I6c09bf2af4b902fdc215ec31bf2dad490e41384e Reviewed-on: https://gerrit.libreoffice.org/73066 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-27drop some unneeded includesCaolán McNamara
Change-Id: Icf19ae9811f6f4ee315869a7edd50e94dce4e6ae Reviewed-on: https://gerrit.libreoffice.org/73004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-25tdf#125181 Update comment in unit test for added shapesRegina Henschel
I have recently added shapes star24 and star32 to the unit test, but forgotten to update the comment in the test accordingly. Change-Id: I712c652100cadedc06a0b16c8dd27dc078cdbbeb Reviewed-on: https://gerrit.libreoffice.org/72954 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-24Add a parameter to insert a text box directly.Jan Holesovsky
This is useful for the Online, where we want to insert the text box directly into the document so that it is visible right away. Change-Id: I09ab2efba758aac077fa37ddfd20b1486b35b3ef Reviewed-on: https://gerrit.libreoffice.org/72912 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-05-24Wrong downcast from svx::a11y::AccFrameSelectorChildStephan Bergmann
...to svx::a11y::AccFrameSelector (which are unrelated final classes). UBSan Calc "Format - Cells... - Borders - Line Arrangement - User-defined:" and clicking into the top-right corner of the widget caused > svx/source/dialog/frmsel.cxx:972:50: runtime error: downcast of address 0x60f0003dfa80 which does not point to an object of type 'a11y::AccFrameSelector' > 0x60f0003dfa80: note: object is of type 'svx::a11y::AccFrameSelectorChild' > e1 03 80 0d 90 4f c2 88 ce 7f 00 00 02 00 00 00 be be be be 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'svx::a11y::AccFrameSelectorChild' > #0 in svx::FrameSelector::SelectBorder(svx::FrameBorderType) at svx/source/dialog/frmsel.cxx:972:50 > #1 in svx::FrameSelector::MouseButtonDown(MouseEvent const&) at svx/source/dialog/frmsel.cxx:1114:21 [...] The code was like that ever since 60f11adb950e4f9645cc9ecb0f5af8235cc97366 "Integrate branch of IAccessible2", which had presumably confused AccFrameSelector and AccFrameSelectorChild here (while there'd apparently not been a deeper need for the static_casts anyway). Change-Id: I1f52629143dcfc84e57e9539a428fb0f51fdc72e Reviewed-on: https://gerrit.libreoffice.org/72910 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-24tdf#125445 Add methods for handles in gear6 and gear9 shapesRegina Henschel
The shapes 'gear6' and 'gear9' need very special methods to calculate the adjustment value from the handle position. Inserting these methods shifts the other cases one level down, therefore the patch looks large. The gear6 and gear9 shapes do not fit to the common test pattern, so they are not included in the unit test. Change-Id: I809e92d87118303332be87512062c431f235d859 Reviewed-on: https://gerrit.libreoffice.org/72796 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-23rename SvxGraphCtrl back to GraphCtrlCaolán McNamara
Change-Id: I340b1695588bea0f1ce15685731c522907fdb7ee Reviewed-on: https://gerrit.libreoffice.org/72806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrlView back to GraphCtrlViewCaolán McNamara
Change-Id: I658773f4fc0409a73de56301f5457fa1fb9e4a28 Reviewed-on: https://gerrit.libreoffice.org/72805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrlUserCall back to GraphCtrlUserCallCaolán McNamara
Change-Id: I9c348e34a07ab269217f35633cb3a54ea4f7cf68 Reviewed-on: https://gerrit.libreoffice.org/72804 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23remove now unused GraphCtrlCaolán McNamara
Change-Id: I6d4aca59d5f9e24521876c36853b663b65a2d200 Reviewed-on: https://gerrit.libreoffice.org/72803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23weld FloatingContourCaolán McNamara
Change-Id: I055f01d2ce462009986801d4a603b0b72b1a621c Reviewed-on: https://gerrit.libreoffice.org/72787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23Add new customize and position merged dialogGülşah Köse
Change-Id: I898fb0830a9f53da4a7917cb5900f082e3a9d6b7 Reviewed-on: https://gerrit.libreoffice.org/71944 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-22New loplugin:dataStephan Bergmann
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22tdf#42949 Fix IWYU warnings in include/svx/[h-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9 Reviewed-on: https://gerrit.libreoffice.org/72534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-21turn off OutputToWindow during dtorCaolán McNamara
Change-Id: I46d45c2487b7d4ac99d48ce0fc49bed120291f3c Reviewed-on: https://gerrit.libreoffice.org/72668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-21Fix typoAndrea Gelmini
Change-Id: I2279c3e3bb8f0e3d8ac0fe02b83d7f659fc00a02 Reviewed-on: https://gerrit.libreoffice.org/72622 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21tdf#119775 Make keyboard use work for TableWindow popup windowJim Raykowski
This patch restores the ability to use the keyboard for the TableWindow popup window by not including the 'More Options...' button when activated by keyboard from a toolbox. It also limits handling of key input to SPACE, RETURN, and ESCAPE key input when mouse activated. Change-Id: I306bcb844a829ca7067b8496f37cb68f35fa754d Reviewed-on: https://gerrit.libreoffice.org/71813 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-20tdf#125181 Add shapes star24 and star32 to unit testRegina Henschel
The commit 500a70ba19d9c1207fd9121531950e55a70fd940 has fixed the error in the definition of shapes star24 and star32. They can now be included in the test file for unit test of preset shape handles. Change-Id: I94f63d37a7faaec4006104127fcc0443304ae0b8 Reviewed-on: https://gerrit.libreoffice.org/72612 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20Resolves: tdf#125375 add mouse events to maskCaolán McNamara
Change-Id: Ied64222c9996f83673a65f858ca351d72483e53a Reviewed-on: https://gerrit.libreoffice.org/72586 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20svx lok: fix crash on select all when there is no mpMarkedObj yetMiklos Vajna
Fixes the online.git HTTPWSTest::testRenderShapeSelectionImpress() testcase by reverting one hunk of commit 3fb298f673db169a38c1258d66ec24821386eb40 (lok: writer: svg export transformed images, 2019-03-26). This was probably meant to be a cleanup, but getting the sdr mark, followed by getting the sdr object of the mark always gives us a shape, while directly accessing mpMarkedObj does not. Change-Id: Id733ba5c6fdf6fc86a3e9f7de62b4bdcbf9b06db Reviewed-on: https://gerrit.libreoffice.org/72039 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/72566 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: chart: constrained dragging of pie segmentsMarco Cecchetti
The extra information for the graphic selection is now formatted according to JSON syntax so that is easier to parse. Information for allowing the client to performa constrained dragging of a pie segment is appended when needed to the graphic selection message. A polygon approximation of the pie segment in svg format is attached too to the graphic selection message. Core now is able to handle a specific msg from the client with data about the new pie segment offset computed by the client on drag end. This information is dispatched by the chart controller to a specific method: executeDispatch_LOKPieSegmentDragging. Change-Id: I42e7742508fa3a453383bf7b95e47df169f24834 Reviewed-on: https://gerrit.libreoffice.org/70568 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: chart: informing the client about selection handling propertiesMarco Cecchetti
We hijack the chart CID protocol (CID:/classification/ObjectID) by inserting information about selection handling properties (draggable, resizable, rotatable) btw the classification section and the ObjectID section. This new section has the form: /Draggable=?:Resizable=?:Rotatable=? where in place of '?' there is 0 or 1. The hijacking occurs at the ChartController.getSelection method which is available through the XSelectionSupplier interface. Change-Id: Iaf920fe68e59c2595000e43d3fc1f976632cef18 Reviewed-on: https://gerrit.libreoffice.org/70567 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: writer: svg export transformed imagesMarco Cecchetti
Change-Id: I908a6e01573c35c0641519f4995730af0b033c33 Reviewed-on: https://gerrit.libreoffice.org/70565 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: shape selection: perform the needed unit conversion in a clever wayMarco Cecchetti
Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5 Reviewed-on: https://gerrit.libreoffice.org/70563 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-18Resolves: tdf#125104 crash on getting text desc of numberingCaolán McNamara
this seems to have been wrong for a very long time, but we used to get away with it back in the .src era with presumably amusingly random strings from other parts of the ui shown in the summary of changes are of the organizer page of the dialog Change-Id: If223182170ba8519d7899f8044f01c2a12f4e391 Reviewed-on: https://gerrit.libreoffice.org/72490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18remove remaining '0' responsesCaolán McNamara
Change-Id: I3134c8dcc92b82ab2c6008b3e39443a360f576eb Reviewed-on: https://gerrit.libreoffice.org/72499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18Adapt AutoFormatHelper to std::unique_ptrArmin Le Grand
Change-Id: I3087a7e95e73dbcda798ca62705f7941a6466ccb Reviewed-on: https://gerrit.libreoffice.org/72401 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-05-17tdf#115813 unit test for handle position of OOXML shapesRegina Henschel
The patch contains some additions to tdf#115813 and a unit test. The test covers nearly all OOXML preset shapes with handles. Only some shapes do not fit to the test pattern: swooshArrow and polar handle shapes arc, blockArc, chord, circularArror, mathNotEqual, pie, leftCircularArrow, leftRightCicularArrow. The shapes star24 and star32 are excluded because of tdf#125181. The shapes gear6 and gear9 are excluded because a correct handle movement is not yet implemented. Connector shapes are inserted as ordinary shapes to prevent converting. The error string is designed to identify the affected shape. Change-Id: Icd3358f3701ac2db2cc61eb045ae10bc4b72b9ca Reviewed-on: https://gerrit.libreoffice.org/72229 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-17there's already a way to customize the invalidationCaolán McNamara
Change-Id: I486494de730b8665e56cfc664b62830fb0b8b8ee Reviewed-on: https://gerrit.libreoffice.org/72415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17weld SvxIMapDlgCaolán McNamara
Change-Id: I5418176a015e61ef8eee4c2acd8e84b008f76f82 Reviewed-on: https://gerrit.libreoffice.org/72249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17allow a OutputDevice parent where that is sufficientCaolán McNamara
Change-Id: I2920ea1a82de5eacbfeceafbb3c63693dd4365db Reviewed-on: https://gerrit.libreoffice.org/72414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17recipients just need OutputDevicesCaolán McNamara
Change-Id: Ia4b2fae44a873323444faf558d831b31635a8ee1 Reviewed-on: https://gerrit.libreoffice.org/72411 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17split out toplevel window area invalidateCaolán McNamara
Change-Id: I840ed6cbb3f7950230b1f7169ae3245a4a669249 Reviewed-on: https://gerrit.libreoffice.org/72410 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17allow overruling treatment as not-WindowCaolán McNamara
Change-Id: I26f987b1c2993f50cb67d89a68daf4ec82641700 Reviewed-on: https://gerrit.libreoffice.org/72383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16tdf#42949 Fix IWYU warnings in include/svx/[e-g]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16split methods upCaolán McNamara
Change-Id: Ib6f27574b8a45b29d6887d268f2e291314c796bf Reviewed-on: https://gerrit.libreoffice.org/72382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16refactor to move overlay creation to SdrPaintViewCaolán McNamara
Change-Id: Idbb734a44289d7ecead84f3c4ac2bc1ebc44ef40 Reviewed-on: https://gerrit.libreoffice.org/72381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13drop some unneeded includesCaolán McNamara
Change-Id: I3c9a3b73c099b70bdbd6b16688e83ee01231a27e Reviewed-on: https://gerrit.libreoffice.org/72204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-27 22:22:45 +0000