summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2023-07-21tdf#154955 svx: PDF/UA export: tag SdrObjGroup properlyMichael Stahl
ISO 14289-1:2014, 7.3 Graphics Graphics that possess semantic value only in combination with other graphics shall be tagged with a single Figure tag for each group. Also produce the missing alt-text. Change-Id: I78e802d8e17a29c2d19fcf3a7ec9961f8f04e391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154684 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-21tdf#50725: sd: add new configuration option DragThresholdPixelsSarper Akdemir
Adds new expert configuration option DragThresholdPixels for Impress and Draw under Misc/DragThresholdPixels. Also bumps up the previous hardcoded default value from 2 to 6. Assuming this value was set when 640x480 resolution was the most common resolution, currently scaling the hardcoded default by 3 makes sense. (eg. GTK uses 8 pixels as the default) Change-Id: I35c0eed3ce477685c759f517471ce0bdc8315864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154379 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-21Removed executable bits on xml fileAndrea Gelmini
Change-Id: I594bcf47eedcb2ee6964ea48f3a4bdffdb0734c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154682 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-21tdf#152992: for Impress/Draw add horizontal hit tolerance for quick text editSarper Akdemir
Implements horizontal hit tolerance for quick text edit in Impress & Draw making it more forgiving. Previously it was required to click exactly on the glyph to get a direct text cursor. Refactors hittestprocessor2d so that it now supports pseudo per axis hit tolerance. i.e. underlying isInEpsilonRange hit check is still the same utilizing the larger tolerance of the two per axis tolerance, but the preliminary check that uses aPolygonRange.grow() and later aPolygonRange.isInside() now filters hit misses out with respect to the per axis hit tolerance. Utilizes hittestprocessor2d's new per axis tolerance to introduce hit tolerance for quick text edit, making it similar to TextEdit mode hit tolerance which only has horizontal tolerance. Fixes wrong use of BoundRect hit to determine text frame border hits. Which previously only made sense for TextFrame borders, and was mostly useless for shapes with text inside. Change-Id: I749e63752da05b01270bfcab2632c41879a848ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154640 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-20tdf#150302 Fix FontworkSameLetterHeights button in DrawMatt K
This change fixes the Font Work Bar SameLetterHeights button at the bottom of Draw when opening a file without a FontWorkSameLetterHeights property initialied in the XML of the file. The change now applies a default property value which allows the button to properly work and switch the boolean value of property which can then be saved in the XML of the file. Also added a unit test which checks for the correct property value after toggling the button 2 times. The command to run the new unit test is: make CppunitTest_svx_unit CPPUNIT_TEST_NAME=testTdf150302 Change-Id: Id55eaedb625139f0071cdca5f628a0766afab0fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154402 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-07-18tdf#136905 NBB: use label font in ValueSetWithTextControlJustin Luth
The label font is taken from the system settings, and doing this matched the "more options" button font as well as the nearby "margins" and "columns" as well as pretty much everything else in the notebookbar. I tested this by changing "Font Selection" in my Ubuntu Cinnamon to a flowery font. Prior to the patch it was a normalish font, but after the change it was using the flowery font. Change-Id: I2585e6aec31aa4195a2354337eb243e63c719ec0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154555 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-18tdf#136905 NBB: let ValueSetWithTextControl set optimal heightJustin Luth
There was no way to specify a "good font size" to use for .uno:AttributePageSize in the notebookbar. The font "resized to match to size of the box" which is hard-coded to aSize(250, 300). (Even if ValueSet::SetOptimalSize worked, it would set an inadequate height.) So it seems like the best thing to do is simply add a function that allows the box height to be modified. Using the fontsize from GetDefaultFont is not correct. Use the OS-defined label font size instead, which seems to be the most common choice - GetPushButtonFont would has also worked. I verified that the label font size is controled by the OS' font preference. The ability to define the box's optimal height is still (somewhat) necessary. It isn't good enough to just "use the system font size". I tested with an OS font size of 48 (instead of 11), and in that case the box height was too small (but with the font only using 4/9's of a 12pt space, even a 24pt font looked OK without adjusting optimal height). Change-Id: I0a0774dea9c2a6c21a8e84439318a94f39783413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154286 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-17Prevent to open multiple Theme Color Edit dialogGülşah Köse
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: Ibf4db096b44ce941140a12d003b89b636f5e7224 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154514 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-17svx: prefix members of SdrCustomShapeGeometryItem and SdrFormatterMiklos Vajna
See tdf#94879 for motivation. Change-Id: If7ca1e0117943f82c9ea46d6a6eb9ba9f67b1b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154507 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-07-14tdf#154982 drawinglayer,svx,sw,vcl: PDF export: hell flys and shapes...Michael Stahl
... should be below their anchor paragraph in the structure tree. Refactor SwEnhancedPDFExportHelper (etc.) to use the new EnsureStructureElement()/InitStructureElement() functions instead of SetCurrentStructureElement() for the frames, and allow it for flys that don't have their anchor paragraphs created yet because the hell layer is exported before the document body. Change-Id: I1be3b54002e8196772e6f9d81dd0fd0c85b6e34b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154399 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-13tdf#142808: use SvxLRSpaceItem::GetTextLeft instead of GetLeftMike Kaganski
Because we need the value without the negative (hanging) indent. Change-Id: I65f779476be5e8a57b723c289c6c3a9c75875bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154398 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-13ImageMap::GetHitIMapObject can be constNoel Grandin
which removes an unnecessary const_cast Change-Id: I9ef2e7c8b87e15ebd04e8864bfdd322991d9af00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-13remove very dodgy const_cast in SvxIMapInfo::GetHitIMapObjectNoel Grandin
This code has been here since commit 8a6861a404c082226b52df335e3b0046164e6432 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 23:16:46 2000 +0000 initial import but it really does not seem likely that it actually wants to update the internal LogicRect of the svx object. Change-Id: If0523c1e353faf96ca70c6afb3c0125472ca256d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-13jsdialog: enable Manage Changes dialogSzymon Kłos
Change-Id: Ibc501dc595eba93adde7b635a5de1122b22c9651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153190 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154331 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-12tdf#125504 SvxStyleBox: don't use disposed DispatchProviderJustin Luth
.uno:StyleApply in the notebookbar was doing nothing because the view switching from print preview caused the saved XDispatchProvider to become disposed. Thanks to Maxim, my patch is completely re-written. Change-Id: I655c393def75f966a97ac7a04395aee19befd132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154196 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-12tdf#125504 SvxFontNameBox: don't use disposed DispatchProviderJustin Luth
.uno:CharFontName in the notebookbar was doing nothing because the view switching from print preview caused the saved XDispatchProvider to become disposed. Thanks to Maxim, my patch is completely re-written. Change-Id: I5ac1aa870de2f4ac922f076a5401f1264d6b085f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154195 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-12tdf#105362 better support for transparency in PNG & GIF exportArmin Le Grand (allotropia)
The granularity to decide at the SdrView what to paint was not fine enough, so I added code to get what we need: Do avoid page decorations (including PageBackgrund aka 'wiese'), but do include/process MasterPage content. Change-Id: I49df05abc89b4bcebc973c37d30be0a0c72e59ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154301 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-07-12simplifyNoel Grandin
Change-Id: I276ba7809b08a359b377ea56259140675c5e00a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-12tdf#125504 StylesPreviewWindow: don't use disposed DispatchProviderJustin Luth
.uno:StylesPreview in the notebookbar was doing nothing because the view switching from print preview caused the saved XDispatchProvider to become disposed. Thanks to Maxim, my patch is completely re-written. I think I have implemented the method he has suggested. Change-Id: Iae01116c742bc27ed2c14d983e7347d39c9acaf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154148 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-10svx: prefix members of GeoStatMiklos Vajna
See tdf#94879 for motivation. Change-Id: Id8d116bfa375f7dd30ca8dcdec0ee02df8105030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154234 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-07-08make SID_ATTR_TRANSFORM_POS_* and SID_ATTR_TRANSFORM_ROT_* SfxInt32Item tooCaolán McNamara
to be consistent with findings from: commit c64828a1cf55e9252e7acd236e3331f2635ae249 (origin/master, origin/HEAD) Date: Fri Jul 7 17:05:10 2023 +0100 ubsan: SID_ATTR_TRANSFORM_POS_X is SfxInt32Item not SfxUInt32Item Change-Id: I6c50e4d5363ff9d79b459abb6192f2cedb39709e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-07ubsan: SID_ATTR_TRANSFORM_POS_X is SfxInt32Item not SfxUInt32ItemCaolán McNamara
in online, insert smiley face in to calc and drag it around the spreadsheet include/svl/itemset.hxx:162:20: runtime error: downcast of address 0x603001c19b30 which does not point to an object of type 'const SfxInt32Item' 0x603001c19b30: note: object is of type 'SfxUInt32Item' 00 00 00 00 68 3c 7a e8 56 7f 00 00 01 00 00 00 68 27 00 be 9e 2e 00 00 be be be be 2b cd bc 9c ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'SfxUInt32Item' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior include/svl/itemset.hxx:162:20 in Change-Id: Icb4f86104e804d697d1b71822ee224fa08f7519a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-06make tools::Poly*gon single-arg constructors explicitNoel Grandin
which will help avoid ambiguity in method calls in an upcoming patch Change-Id: Ic7607ac7d95559e0942a84fb3226cfdd6ade22bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-06tdf#122735 get the correct ActiveViewContactArmin Le Grand (allotropia)
In ObjectContactOfPageView::getActiveViewContact() the decision which ViewContact is to be returned depends on if the SdrObjList fetched from the SdrPageView is a SdrObject or a SdrPage. Both are derived from SdrObjList, so to decide that the helpers getSdrObjectFromSdrObjList and getSdrPageFromSdrObjList are used. For SdrObject the 1st will return ptr, 2nd nullptr. For SdrPage the 1st and 2nd will return ptr due to 1st trying to return something useful by getting up the hierarchy and return the SdrPage the SdrObjList/SdrObject is inserted (as the name says). This means that here the test for SdrObject *has* to be used 1st to correctly decide of what nature SdrObjList is. NOTE: Here it would also be possible to use dynamic_cast(s) to the classes to test for, but tooling is virtual/faster. Change-Id: I113afceddd3210aa63960d248f7c7356f82cf413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154065 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-07-06loplugin:unusedfields all-can-be-privateNoel Grandin
these fields can be private Change-Id: I74423a9ae2ef0263a28c8a716ab1c55861e453d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-06tdf#126382 Correct check for transparencyMaxim Monastirsky
Change-Id: I0664abae6f83736678108fab31dd119fae811054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154082 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-05simplify SvxUnoDrawPool initialisationNoel Grandin
Change-Id: Iaca5eec19935c50cc7cade4f3dab139a5232473a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-05loplugin:finalclassesNoel Grandin
Change-Id: I62b094a3bd9a4f630cebdf538c04391e2920ff2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-05tdf#138504 svx,etc.: decorative flag on SdrObject shapesMichael Stahl
* SdrObject new member m_IsDecorative * new Undo SdrUndoObjDecorative * surprising amount of changes in sw including additional SwUndoFlyDecorative * svx API SvxShape property "Decorative" * UI checkbox "Decorative" * ODF import/export as loext:decorative on style:graphic-properties * PDF/UA export: ViewObjectContcat tag shapes with this flag as Artifact Change-Id: I37f7a0597eab92c6c6aff94fad6c16c59b231c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-05Swap .uno:FontColor for .uno:ColorMaxim Monastirsky
Following tdf#105293, which left some UI elements unchanged. This also simplifies the sidebar, as .uno:Color is universal while .uno:FontColor works only with Writer text. It also benefits tdf#154270, as using the same command in the toolbar and the sidebar will keep their color in sync. Change-Id: Ia6e1ffef4012b6f8db4c9079d0b0c99a59887670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154012 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-04tdf#154270 Sync toolbar button recent colorsMaxim Monastirsky
As the last used color is stored per button instance, these will go out of sync with several buttons being visible (e.g. a toolbar and a sidebar, or a toolbar overflow popup), and will reset whenever the toolbar resets (e.g. change in selection, switch from print preview, or customization). Fix that by storing the last colors per-document, and notifying other buttons on changes. Keep the last color also stored per-button for now, as a fallback for reportdesign (which isn't sfx2 based). Change-Id: I866f1de5c8ff6f56c47dc4b6b5acf52957d4e6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153943 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-04loplugin:constantparamNoel Grandin
Change-Id: Iee554baae7239c9bf0ac35cab6ff235a88dc29a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153973 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-04tdf#153487 First color item needs mnId = 1Regina Henschel
The SvxColorValueSet for the other color palettes is build so that the first item gets value 1 in its mnId component. But for the new theme color palette it was 0. That results in the error, that the first color (top-left in the dialog) could not be selected. An Id of value 0 is handled as 'fail' in various places. Thus use starting mnId = 1 for theme color palette too. Change-Id: Ic0b63fee641d4424cabaf25a7f803acd734cbfa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153860 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-04svx: PaletteManager - remove printfTomaž Vajngerl
Change-Id: I7d631352d423b6465d8bea4b09561f33d2ad98f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153936 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-03tdf#155630 Use common getPolygon for sdDr. David Alan Gilbert
Unfortunately the SetLineEnds in sw is different enough from sw and sc to make sharing it a pain. However we can share the GetPolygon function we already moved into svx. Expose the svx function into the header and use it in sd. Change-Id: I05b0f820286c8ce848fa0d6c69603d3625c2b4d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-03tdf#155630 Move sc's SetLineEnds into svxDr. David Alan Gilbert
SetLineEnds is duped in sc,sd and sw. Swing SetLineEnds into svx where we'll share it. Note: a) We also move it's helper function getPolygon b) sc, sd and sw use different values for the magic nWidth value so parameterise Change-Id: I6011b41d9db7b7fab364038227e1866fb9d64b02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153826 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-02pAttr is always dereferenced, use a reference instead of a pointerCaolán McNamara
Change-Id: I76ebce9085b9e47a6c571ddbcafa44d0d3a0f97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-02loplugin:singlevalfieldsNoel Grandin
Change-Id: I091fac5ed41b2fb58dee5e3e1b8dd805c8dc4966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-02Fix typoAndrea Gelmini
Change-Id: I0fd7f5aaa51e58ec88daad30f003bf5c853385b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153853 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-01cid#1532376 Big parameter passed by valueCaolán McNamara
Change-Id: I6e0717ce5b035c1a4f4ec3abbd23ae60c98c8181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-30MCGR: tdf#155913 Non-supported attributes for TransparenceGradientArmin Le Grand (allotropia)
In ODF spec there is no - MID_GRADIENT_STARTINTENSITY - MID_GRADIENT_ENDINTENSITY - MID_GRADIENT_STEPCOUNT so these should not be used in the core data, too. The last one leads to this error. I experimentally added to hanle these 'harder' in the UNO API implementation, too, to reflect that these are not supported and produce UNO API access errors. This is not urgently necessary, but let's see if that triggers problems. That these attributes were initially supported is due to the Item hosting those values for transparency gradient is directly derived from gradient and the implementations usually use the fallback to call the parent implementation(s). Change-Id: I982c4047d82bfe306dbcef9d1b64b8d212bf8d59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153799 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-06-29Use getXWeak in svxMike Kaganski
Change-Id: I7e5c029a79b8437ae5f803df5ad20217c240d1d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150874 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29loplugin:unusedfields make it a little smarterNoel Grandin
around dealing with operator[] on map data-types Change-Id: Idd6654948ae2d03d634fcf30a8d98530a78ab4ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27lok: only publish MEDIA_SHAPE to selecting viewAshod Nakashian
We now publish the url for the media shape in the LOK_CALLBACK_GRAPHIC_SELECTION message. This has many advantages, most notably that it only sends the URL to the view selecting the media. Also, it is now easier to handle the message as there is no need for both a LOK_CALLBACK_GRAPHIC_SELECTION and a LOK_CALLBACK_MEDIA_SHAPE. However, the latter is still defined as we might still use it at some point. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I8d4b8794d8e590628630f2b0bfbfb5debe02515f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146848 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153009 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153369 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-26tdf#156050: Fix how misspelling line is calculated for RTL textKhaled Hosny
Partially revert: commit 74b6c5ea3c333de7c5e7ef8636732edadd9083f2 Author: Khaled Hosny <khaled@libreoffice.org> Date: Thu Jun 8 16:41:18 2023 +0300 tdf#151968: Fix vertical position of RTL spelling wavy line Instead of changing how fStart and fEnd are calculated, calculate them like before then swap them. This seems to be more reliable, and matches what we do in Writer. Change-Id: Ia15408881666a86151a12fcf016cc81c1568f7e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153572 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-25cid#1532451 silence Iterator container mismatchCaolán McNamara
Change-Id: I8560f3e5c7820fef8e27433321c97fc3a0b29746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-24CID several. Use ctor 'from other' instead 'first..last'Regina Henschel
This covers CID#1532461, CID#1532462, CID#1532464, CID#1532467, CID#1532479. Now solutions without iterator are used. In all cases constructions like maColorStops = basegfx::BColorStops(rGradient.GetColorStops().begin(), rGradient.GetColorStops().end()); are replaced with solutions like maColorStops = rGradient.GetColorStops(); And instead of constructions like aColorStops.emplace_back(maColorStops.front().getStopOffset(), aStartBColor); aColorStops.insert(aColorStops.begin(), maColorStops.begin() + 1, maColorStops.end() - 1); aColorStops.emplace_back(maColorStops.back().getStopOffset(), aEndBColor); now it is like aColorStops = maColorStops; aColorStops.front() = basegfx::BColorStop(maColorStops.front().getStopOffset(), aStartBColor); aColorStops.back() = basegfx::BColorStop(maColorStops.back().getStopOffset(), aEndBColor); Change-Id: I66662d2286e7707b205c58977bc3f850b2a49dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-23MCGR: Some exemplary multi-color gradientsHeiko Tietze
* "Rainbow, Sunrise, Sunset" added * "Preset, Spotted Grey, Teal To Blue" removed to keep items inside scrolled window Change-Id: I3be6c8596accc769df92a8610260ed38a6c29602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153166 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2024-12-25 13:54:44 +0000