summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2017-03-31use actual UNO enums in svxNoel Grandin
Change-Id: I00f53260667861ca2595892b5605479da3401adb Reviewed-on: https://gerrit.libreoffice.org/35913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30Related: tdf#106080 support a 'none' color in search by formatCaolán McNamara
so we can show the initial no-color selected state differently than the automatic color default color Change-Id: Ib3020e507b1555cb446c2b501f60b67222dc115c Reviewed-on: https://gerrit.libreoffice.org/35863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29Resolves: tdf#106079 automatic color described as 'white'Caolán McNamara
move RID_SVXSTR_AUTOMATIC from svx to editeng for this Change-Id: Icc3fbb15e627ed54770d11bce7aadf30a0d12aa7
2017-03-29LOK: Calc - images are not painted below row 1000Marco Cecchetti
The problem was not due to some missing tile invalidation: it was at the painting stage. There was no overlap btw the view range and the object range. Now images and shape are painted correctly. There is still problems with control forms and charts. Change-Id: Ib74e3bb79b444df21844086ae666fc206aa48906 Reviewed-on: https://gerrit.libreoffice.org/35215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-29split ImportState enum into RtfImportState and HtmlImportStateNoel Grandin
and convert to scoped enum Change-Id: I23e44e78ce96ed5fc19374e3e069e1cdc2166a35 Reviewed-on: https://gerrit.libreoffice.org/35840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Resolves: tdf#106841 RID_SVXSW_FRAMEPOSITIONS is in wrong orderCaolán McNamara
since... commit 1c48275a28fa3bccdeb6bc12e4f0bcea6c05a81b Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Feb 6 11:51:27 2017 +0000 convert resources containing strings to stringarray resources cause the original defines weren't in numerical order and I missed that Change-Id: Ic81c9bad2432c3ffa49c56812924965017a05220
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29convert EViewType to scoped enumNoel Grandin
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617 Reviewed-on: https://gerrit.libreoffice.org/35822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29nCnt calculation is overwritten anywayCaolán McNamara
Change-Id: Idf2693aaf31fc06e16df4b15766d29f029df896a
2017-03-29expand vis to visible; fix typosdennisroczek
* translate German source code comments * remove bogus surce code comments * remove ascii art * removed old StarOffice/Sun internal bug tracker references * remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad Reviewed-on: https://gerrit.libreoffice.org/35404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29tdf#106792: Fix "Geometry" property of changed-to-bezier SvxShapePolyPolygonStephan Bergmann
After "Convert to Curve" as described in the issue, the shape apparently is still an SvxShapePolyPolygon shape but with getShapeKind() of OBJ_PATHLINE instead of OBJ_PLIN (and same for OBJ_PATHFILL). That causes XMLShapeExport::ImpExportPolygonShape (xmloff/source/draw/shapeexport.cxx) to determine bBezier == true and thus expect the obtained "Geometry" property to be of type css::drawing::PolyPolygonBezierCoords, not merely css::drawing::PointSequenceSequence. Smells like this issue had always been present, and would have caused bad memory access when accessing the non-css::drawing::PolyPolygonBezierCoords object in XMLShapeExport::ImpExportPolygonShape, and only now throws an exception since 0d7c5823124696f80583ac2a5f0e28f329f6f786 "New o3tl::try/doGet to obtain value from Any". Change-Id: Ica31a114e5beac97bac2a1c509eb1a85f8354d5e Reviewed-on: https://gerrit.libreoffice.org/35825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28std::unique_ptr<sal_uInt16[]> -> std::vectorCaolán McNamara
Change-Id: I708e1f24e14bc21f40cf4d5a2d3e6f849b6f7762
2017-03-28remove some more unused SID constants and commandsNoel Grandin
Change-Id: Ibf2bb58ca687c18798328ed86cd549d64f3621b4 Reviewed-on: https://gerrit.libreoffice.org/35792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28tdf#42949: clean up includes in include/svx/[a-c]* with iwyuJorenz Paragas
Change-Id: I7768f4dbe9892c4264cb16eed87497894aa7494e Reviewed-on: https://gerrit.libreoffice.org/26582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28remove enum slot code from sfx2Noel Grandin
since we only used it for the pseudo-slot stuff, which is now gone Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a Reviewed-on: https://gerrit.libreoffice.org/35759 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from svxNoel Grandin
In this case, also remove those unhandled commands which are present in a *Commands.xcu file, but not in any other kind of .xcu file. Change-Id: I8b42df7357349872e28d3ee60ec2c0505358cff6 Reviewed-on: https://gerrit.libreoffice.org/35648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27ofz#946 NbcAdjustTextFrameWidthAndHeight calling itselfCaolán McNamara
Change-Id: Ibebe76332d25af87841c3b7761a5583347dfbf34 Reviewed-on: https://gerrit.libreoffice.org/35756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-27document mnIndex doesn't changeCaolán McNamara
Change-Id: Ia000682774cee4c58811325f6ab40859502da79f
2017-03-27remove unhandled SID commands in scNoel Grandin
checked to make sure none of the related .uno commands are present in any .xcu files. Change-Id: I026eec90351f525be7417f697debe2444756193b Reviewed-on: https://gerrit.libreoffice.org/35622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Kill remaining PseudoSlots usageMaxim Monastirsky
Change-Id: I14a820b7c0baba8d8b17d07715bf17c42c73c8fb TODO: Remove support code from idl and sfx2 modules Reviewed-on: https://gerrit.libreoffice.org/35718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I77cf7fe3a57c031877facf5252b5a900526db48b Reviewed-on: https://gerrit.libreoffice.org/35646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Make loplugin:loopvartoosmall find more suspicious casesStephan Bergmann
...where the "controlling expression" of any sort of loop contains a sub- expression of the form var < val where the type of var is smaller than that of val. Theoretically, this could turn up lots of false positives, but practically it didn't run into any. Most findings have been cleaned up over the last weeks. There's just a handful remaining places that are hard to clean up, so I flagged them here with (deliberately awkward) sal::static_int_cast for later clean-up. Change-Id: I0f735d46dda15b9b336150095df65cf247e9d6d3 Reviewed-on: https://gerrit.libreoffice.org/35682 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Typo: boder->borderJulien Nabet
Change-Id: I46940c5b584f93b478b1dfca9aa66e036fe951c2 Reviewed-on: https://gerrit.libreoffice.org/35547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-22ofz: stack-overflow with infinite parse recursionCaolán McNamara
Change-Id: I4973875797446e146cbda6db84958c9e4962aa8b Reviewed-on: https://gerrit.libreoffice.org/35545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-22Calc: safer life cycle handling for OutputDevice in SdrPaintWindowMarco Cecchetti
Change-Id: I5469332c4ef98bce8cd9c2caff5bf61dbf102b23 Reviewed-on: https://gerrit.libreoffice.org/33220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22create SfxDisableFlags enumNoel Grandin
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-21tdf#106382 - Fix incorrectly shown change tracking comments in dialogPranav Kant
First item in the array is treated as the number of fields followed by their widths. There are only 4 such fields in case of writer, not 5. Change-Id: Iff6f21b54b73d4395d64d83f2acf1de2a19a251e Reviewed-on: https://gerrit.libreoffice.org/35484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-20remove unused defines from HRC files in svx(1)Noel Grandin
Change-Id: I2f4c3158123892f1c059c3794f106e883d78a1ed Reviewed-on: https://gerrit.libreoffice.org/35326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-20remove unused defines from HRC files in svx(2)Noel Grandin
Change-Id: I5361faaaf7fcfc1992919b1fb687b436470ed6a8 Reviewed-on: https://gerrit.libreoffice.org/35334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19TyposJulien Nabet
Change-Id: Id1b96b56b16ebf2d8a99dd6fb64c73906dfd598f Reviewed-on: https://gerrit.libreoffice.org/35435 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18tdf#104722: Align text correctly also during editingTamás Zolnai
Change-Id: Icd21aa5be70adf6637bc20f7f511ff26d2955fc2 Reviewed-on: https://gerrit.libreoffice.org/35415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-18remove EE_RESSTR preprocessor abuseBjoern Michaelsen
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58 Reviewed-on: https://gerrit.libreoffice.org/35370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-17loplugin:staticaccessStephan Bergmann
Change-Id: I255a5c3139f97dbef63dd4d3b0f47d64e6946bd5
2017-03-17tdf#106458 Color widget should have same number of rowsMaxim Monastirsky
... across different platforms/themes, so the standard palette will always fit without a scrollbar. For this, we must not hardcode some arbitrary fixed size, but calculate the size based on the number of rows of the standard palette. Change-Id: Ica1d615b43b350aece6b2c29a73337439dd05ac6
2017-03-17cleanup itempool includesJochen Nitschke
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10 Reviewed-on: https://gerrit.libreoffice.org/35313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17remove unused defines from HRC files in svtoolsNoel Grandin
Change-Id: I5d8a6a4fd232ef10644ae45174a07b30af789205 Reviewed-on: https://gerrit.libreoffice.org/35277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16use forward declaration for SfxItemSetJochen Nitschke
Change-Id: I81f5d1ca22868d278662a55443e2038581dd3246 Reviewed-on: https://gerrit.libreoffice.org/35280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15remove useless castsJochen Nitschke
Change-Id: I900b72372a56d341d18091b0d4721d31002d147f Reviewed-on: https://gerrit.libreoffice.org/35223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14tdf#100462 inject language tags provided by spell-checkers to language listEike Rathke
... so they are available already at the first instanciation without having to be added manually, depending on which listing is requested. Change-Id: Idcb8f7fcbc82c757a2b06b8f04b81e88197a0a5b
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-22 19:13:47 +0000