summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2022-06-29ChildrenManagerImpl::GetChildShape was clearly written very late at nightNoel Grandin
Because it takes something that could be looked up by index, and instead looks it up by scanning an entire vector. been this way since commit 60f11adb950e4f9645cc9ecb0f5af8235cc97366 Date: Wed Nov 27 13:03:45 2013 +0000 Integrate branch of IAccessible2 Change-Id: I32d06a98a6fa074c8f6385611e12e1a64d5b7f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136632 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-28tdf#134328 improve SdrObjList::RecalcObjOrdNumsNoel Grandin
rather iterate directly over the data structure, cheaper than repeatedly using operator[] Change-Id: Ib688ba76e9af01dbaad8ce7fc22d53fa8886f97d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-28Fix typosAndrea Gelmini
Change-Id: I05271bd76574c09683740204534ff8a6907fc784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136522 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-27tdf#149651 Correct the MasterPageBackgroundFill modeArmin Le Grand (allotropia)
Had to massively adapt to what others do in this issue, moving from ViewContact(s) as main data source to FillStyle directly Change-Id: If48666212e2f0afac4fbfab9af4908a5d2b4c047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136487 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-06-27tdf#149690 fix shapespanel bar width of impressxuenhua
Change-Id: I18afc90943e38bc79f0515d60f06f81b0eb5dd28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-24Fix typosAndrea Gelmini
Change-Id: I48d173ab697425bcff663f7f7d0bbc404a950bb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136402 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-24tdf#148522 svx: fix undo of cell border changes text alignment in other cellsMiklos Vajna
The Impress table properties dialog has multiple purposes: normally it only affects the properties of the currently active cell, but shadow is applied on the whole shape. Regression from commit fdeb04f7c59cf8032fe17072ed779e70505cc6ab (tdf#129961 svx: finish UI for table shadow as direct format, 2020-12-15), we started to apply properties to the current cell, and then to the whole shape as well, unconditionally. This affects undo/redo, as there is a separate undo manager while the text edit of a table cell is active and when the text edit is ended. Fix the problem by only applying properties on the shape when there we actually have some properties: this way the text edit is typically not ended, bringing back the old undo/redo behavior. Note that we still need to end the text edit if the user explicitly sets some shadow properties, that part is unchanged with this commit. Change-Id: I78e28bd326a2c12c3775b33957adca4cd95ac582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136357 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-06-24loplugin:moveitNoel Grandin
Change-Id: If1e6428285bdc5631cebc1acfcb850ac0df6d94d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-24tdf#128150 Properly show/hide widgets when "use slide background" is selectedSamuel Mehrbrodt
And cleanup the logic a bit Change-Id: I9d866fd63ea622ac5eb706185b3277c21f40d7cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136301 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-23ofz#48264 TimeoutCaolán McNamara
Change-Id: I5028fd192cda7741a51d5d4ff8913214e8c56a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-23tdf#149655 Crash: "Helplines while moving" crashes debug-buildNoel Grandin
regression from commit a447b5b6d1114111c92e5e3e3f3ae83d4c2f3bca Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Jun 13 18:46:45 2022 +0200 loplugin:moveit calling std::move() on an otl::cow_wrapper apparently leaves it in a state where calling anything else on it will SIGSEGV. Change-Id: I00d53a6283f360e3d64c81f5e79075c8ac5a99e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-23tdf#149650 avoid potential recursion with SdrPage content hierarchyArmin Le Grand (Allotropia)
Change-Id: I27e064eeedfb45a2fe96892f1d31da94b9976c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136303 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-06-23Fix typoAndrea Gelmini
Change-Id: I0482fc4379beb51495e1450a51a0e28f9b324299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136150 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-23CopypastaMike Kaganski
Change-Id: I9bf9b042c885a2546dc7a1425e49e6171711c0aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136299 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-23tdf#128150 Disable UseSlideBackground item when setting style back to NoneSamuel Mehrbrodt
from Sidebar Change-Id: I883330ac7323c4758ca8cbd46f4567a2ea780fc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136290 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-22tdf#128150 Adapt sidebar to new "use slide background" propertySamuel Mehrbrodt
Change-Id: Idce049a7498f98b0079c708236cfeff7fddd6e95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135963 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-22crashreporting: apparent null derefs of SfxViewFrame::Current()Caolán McNamara
Change-Id: I0e2c07a7eaa0a13be0a44c7cd187feec8ed4c2c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136277 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-20sd theme: consider accent1 color when inserting shape with solid fillMiklos Vajna
Once a theme is defined for the master page of the current slide, PowerPoint inserts a shapes with their fill color & line color set based on that theme (so this color is master-page-specific), while Impress sets the fill & line color based on the default shape style. The Impress behavior has the benefit of doing the usual style-based formatting, but now a document-level style overwrites a (master-)slide-specific theme, which is inconsistent. Fix the problem by extending sd::FuConstruct::SetStyleSheet(): if we construct a shape with fill, then not only apply the style sheet, but also set the fill & line color based on the theme (if there is any). Note that this works both in case the shape is instantly created on click (LOK case) or when the user first draws a top-left -> bottom-right point pair to define the position / size of the shape. At the same time line colors don't support themes yet, so that color is just a plain value for now. Change-Id: Ic6ae8f91bd719bd80f2b56f12b001d29b0961e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136138 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-06-20tdf#128150 Implement/add SlideBackgroundFill visualizationArmin Le Grand (Allotropia)
React/interpret new SlideBackgroundFill mode for SdrObjects/ XShapes, defined by drawing::FillStyle_NONE and usage of XFillUseSlideBackgroundItem as (true). Do so by adding a detection, a mode to SdrFillAttribute, reacting on it by creating a new implemented B2DPrimitive: SlideBackgroundFillPrimitive2D provides a Primitive2D for the SlideBackgroundFill mode. It is capable of expressing that state of fill and it's decomposition implements all needed preparation/creation/collecting of the geometry in an isolated and controllable space and way - the B2DPrimitive way. It does so based on the given ViewInformation2D, reacing out for all needed data/ geometry from this. It clips & transforms/combines as needed, providing the necessary visualization of the MasterPage content *over* other objects on the Page/Slide. It is currently simple buffered (due to being derived from BufferedDecompositionPrimitive2D) and detects if MasterPage changes. Still, more may be needed. Change-Id: Ie11403c0b705fc2ecdfd7eb2fa5ae1a93a21b460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135971 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-19tdf#68335 Increase default para spacing before/after to 56 cmGabor Kelemen
and fixed line spacing as well. These may be set to 1584 pt in Word, but the UI incorrectly showed even the correctly imported values as 10 cm. Turns out this is only a UI limitation, so lift it for UX interop. Save/reload already works fine to odt, docx, doc, rtf formats. Change-Id: I69a772e860ad24a1b317dc041b0c55f0a9d461de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136102 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-06-19ofz#48122 TimeoutCaolán McNamara
Change-Id: Ia00a8ced550a5d4c84899e6cfb293779216898e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136093 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-19factor out body as UpdateScalingModeCaolán McNamara
Change-Id: Ib65856e4573bbd0a4ac08aac9ef6e26b86678f46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136092 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-18-Werror=maybe-uninitializedStephan Bergmann
Change-Id: Ife1958a39a7cf673b745a7724ee963e868b21432 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136064 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-16tdf#128150 Add OOXML import/export for "use background fill"Samuel Mehrbrodt
and allow editing this fill property in area dlg Change-Id: Ic63ba11e9d499d4a0fb22f6739587e3e25140b8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134406 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-16Related: tdf#147844 fix warning about negative extra space in manage changesCaolán McNamara
Change-Id: I20c98578e2e96bc06e3c90c12eeda81ab06c988d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-16Add property name to IllegalArgumentException in SvxShape::setPropertyValueImplSamuel Mehrbrodt
Change-Id: I5e10f2c35568449a99f1972db614199a6336e6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135962 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-16loplugin:moveitNoel Grandin
Change-Id: Ic593974a44d9e327e0385c7ffaaa6d42576ae01a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-15Advanced Diagram support: make UI visualization experimental onlyXisco Fauli
In 391cb44d415e2126f668ecf62387d5e98ffa6f5c "Advanced Diagram support: UI visualization & simple interactions" added a UI visualization to advanced diagrams. However, the feature is incomplete at the moment, specially towards LibreOffice 7.4, thus, make it experimental for now. This can be reverted later on Change-Id: Ibf21d11899460ab9ef1ddf91cffb851171119618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135912 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2022-06-15Fix EnglishOlivier Hallot
Change-Id: I45615f217120d90cb255ce1a3e9e1f710603770e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135663 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-15Fix definitionOlivier Hallot
Change-Id: I4dbe6fcd04aebc25a17263f160b7683cbf01ac30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135671 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-15Bump optgridpage.ui to latest GladeOlivier Hallot
Change-Id: I4b862e1f5c8ceb3adfe5009cf13b32073c3ebb5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135670 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-15Bump datanavigator.ui to latest GladeOlivier Hallot
Change-Id: Ieebec25767282248a77b0c28a69afc2fa39348af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135662 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-14Bump addconditiondialog.ui to latest GladeOlivier Hallot
Change-Id: Ibd271a67456169837991fe16fd4cc35c240d5a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135624 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-14Remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I157b331195cc8262e6bd1dcc536cb653587fc45f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135775 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-13Fix commentSamuel Mehrbrodt
No need to mention gerrit URLs in code comments Change-Id: I445f94211a3e660aa6e3482352f56ded7465e008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135692 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-13Add XFillBackgroundItem::dumpAsXmlSamuel Mehrbrodt
Change-Id: I21aa5ded0c9c114199c9d503b48437ec1a6171eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135691 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-12Bump docking3deffects.ui to latest GladeOlivier Hallot
Change-Id: I94fdc2d594f217a727e10fe69f5d7fcc746107bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135664 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-12Improve extended tip contentsOlivier Hallot
Change-Id: Ie95d20bb1f5c8e153b3a9f9a088c835d5254880f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135665 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-11Add precision to extended tipOlivier Hallot
Change-Id: I9723896a84df297d245e78f582f23d33c8a6dc4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135625 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-10loplugin:constantparamNoel Grandin
Change-Id: I8134744b6c1279c497d4763eddf614bb840f7f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10Drop unused text column from IconView's modelMike Kaganski
... and also the hardcoded column count and width. This allows to make the elements position themselves better in the dialog, and to avoid the unused space below the icon in GTK, similar to non-GTK as implemented in commit 54725f6e5f06b074d1c08d8efbd16518b96882d5 Author Mike Kaganski <mike.kaganski@collabora.com> Date Tue May 03 09:49:07 2022 +0100 Don't add empty labels to fontwork's icon view Change-Id: I19fa4e2002856322266b21873b383bc887cf1029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135584 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-10new loplugin:moveitNoel Grandin
look for local variables that can be std::move'd to parameters off by default, since it doesn't do proper data flow analysis Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10Add asserts to those places where I fixed a EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli
I found those crashes scraping https://crashreport.libreoffice.org/stats/ so those are blind fixes basically. Add these asserts, hoping one day someone will hit them so we can find the root cause. See 7c8b9fa98f4c5f7f5620e797dbbe24081e252548 fae937b6859517bd9fe8e400cad3c84561ff98ab ce39195e533336ce1482e2be6b1bec2b7f992125 23e3bff528ab38c8d5c6d401b672a0033cef2bd4 ea4cd397300120a0f825752182eb3b943eb8a1b2 Change-Id: I175f47361e07961417c87cc8f3d7d4d1fb50fb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135448 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-09loplugin:unusedmethodsNoel Grandin
Change-Id: Ib89ab59f7ad7e90b2a44ddd122176cde904fba4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-06improve field nameNoel Grandin
Change-Id: I78c1670589c21c047ba7a2eede86e46643e88f69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-05no need to allocate this separatelyNoel Grandin
Change-Id: I30df477cd708d021fc5b6fcfa9925e1c99be6650 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135429 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-04tdf#149304 Stylist does not show upper/lower case font effectsNoel Grandin
SvxFont has code to handle these extra features, we just need to call that Change-Id: I45691efeeead3ea60ab838eeb081fa5f19a76b90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135428 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-04elide some makeStringAndClear() callsNoel Grandin
when we are passing the result to a string_view, it is pointless. Change-Id: If2532f998343b49a2966e0c704f6f789af936e1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-04tdf#149242 more precise labels for left and right of paragraph text areaSeth Chaiklin
The existing labels refer to paragraph border, which is ambiguous about where the border is located. Meanwhile these labels refer to an area that is to the left and right of the paragraph text area, which is well-defined (and explained in help). The change is to indicate that these options position in relation to the regions that are to the left and right of the paragraph text area. Change-Id: Ica033f8f48d47fb3f65a26f93ebede26b9cf80fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135161 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-04tdf#148491 make Imagemap dialog consistent with DescriptionSeth Chaiklin
This patch is part of a general effort to use "Text Alternative" consistently in the UI. The control names in the Description dialog for Imagemap and the Imagemap dialog were both changed to "Text Alternative". Tooltips were also added for "Text Alternative" and "Description." No change was made to the extended tooltip for "Description", because this field is not exported to HTML at present (tdf#149013) Change-Id: I2c5931efec93cff6b1ff1bf905de770d939b9b93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135155 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
generated by cgit (git 2.34.1) at 2025-02-01 04:41:20 +0000