summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2022-10-20fix assert in debug modeNoel Grandin
not actually a leak, just a deletion ordering problem warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:200: SdrModel::~SdrModel: Not all incarnations of SdrObjects deleted, possible memory leak warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:202: leaked instance of 12E3dSphereObj warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:202: leaked instance of 8E3dScene soffice.bin: /home/noel/libo/svx/source/svdraw/svdmodel.cxx:204: virtual SdrModel::~SdrModel(): Assertion `maAllIncarnatedObjects.empty()' failed. Change-Id: Ia0e6e1387825c0d849904b1bc604eb1252090318 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-20fix regression in "Format - 3D Effects"Noel Grandin
assert at svl/source/items/itemset.cxx:1302: SfxItemSet SfxItemSet::CloneAsValue(bool, SfxItemPool *) const: Assertion `(typeid(*this) == typeid(SfxItemSet)) && "cannot call this on a subclass of SfxItemSet"' failed. This hits in Draw when drawing a rectangle, then "Shape - Convert - To 3D", then "Format - 3D Effects". regression from commit 31e7845339b30a69f06a04619660398fe4267268 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Feb 17 12:19:49 2022 +0200 use more SfxItemSet::CloneAsValue Change-Id: I36af83fc04636aecefc89e2654929112051fb217 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141542 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-18lok: impress: clear selection when exited the textboxSzymon Kłos
it was sill visible in other views Change-Id: I75ce566a17fa1080d6e3008b964e367825225a09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140086 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141478 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-10-17tdf#148017 harmonize sidebar .ui filesandreas kainz
Change-Id: Ia5139f7255ba0e78f7089a4313a41d583ae62961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141275 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-15tdf#136921 Fix color of Insert - Section control in dark modeRafael Lima
Change-Id: I907d39048cfd963d91643bdff7de3d10310217d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141176 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-14WASM add Calc as optional build result, make it build & runBalazs Varga
Adding new config option: --with-main-module=<writer/calc> With this switcher we can build only WASM writer module or calc module. The default value is 'writer'. This commit also reverts: 26603bc9ef0116ed31c510dab82b69d3666447b5 (WASM fix orcus native exception handling (NEH)) Because Calc import is using liborcus for loading styles.xml. Change-Id: I4c330ef8eea7d08214bf357531ee0bf7383ab788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137946 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2022-10-13tdf#150622 use high contrast selection fg/bg colors for text selectionCaolán McNamara
with SettingsForSelection SettingsText -> HighlightTextColor SettingsFill -> HighlightColor SettingsLine -> HighlightColor Change-Id: Iaac5834ce0f8b3f1b89376711b564773cfd0bfe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13tdf#150622 allow use of selection color for frame in HighContrast modeCaolán McNamara
Change-Id: I0a45051c9ba8bbfe785689103c6af6285a282345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13split frame into a separate overlay objectCaolán McNamara
Change-Id: If07591ba27cb8ebfdf9c737e7a2416702e4feb1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141260 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-12new uno command uno:Translate with deepl apiMert Tumer
New Uno command added for translation right now it is only using deepl translation api There's a section in the options > language settings for setting up the api url and auth key uno:Translate is a menu button under Format tab which will bring up Language Selection dialog for translation. DeepL can accept html as the input for translation, this new feature leverages that by exporting paragraphs/selections to html and paste them back without losing the formatting (in theory) This works good in general but we may lose formatting in very complex styled sentences. Translation works in two ways; 1) Whole document when there is no selection, it assumes that we want to translate whole document. Each paragraphs is sent one by one so that the output timeout can be minimum for each paragraph. 2) Selection Change-Id: Ia2d3ab2f6757faf565b939e1d670a7dedac33390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140624 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-12tdf#150622 use a solid border instead of a hatch for high contrastCaolán McNamara
to do less work for smoother scrolling, etc. Change-Id: I6584bbb18247420d9926bfa90acfbd6afe536c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-11tdf#151060 sw PDF export: don't paint off-page part of drawing objectMiklos Vajna
Reported to be a regression from c12358166a9bd88fe10feabca45a6ad3f65dff8e (DOCX import: fix lost objects anchored to an empty linked header, 2020-01-10), the 3rd page of the PDF export result contains an unexpected line shape. This was "working" before as all objects anchored to the empty header were lost. Fix the problem by clipping the rendering to the page frame when handling shapes, similar to what 689cead9e0837dc932e3a4cd765f7d319b529018 (tdf#91260 svx, sw: don't paint off-page part of drawing object, 2016-12-06) did to fix the normal rendering of the document. The testcase document just has 2 pages, so there the unexpected shape was on the 2nd page. Change-Id: Ica24cd15717a1ee97dff448d385a10536671103e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141167 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-09tdf#151417 crash in draw, activating Form controlsNoel Grandin
regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject Change-Id: I1798cead8ed72ad59799c40d0e99f3424f9e382b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-07svx: Destroy unused table stylesMaxim Monastirsky
Loading sd document with a table, replaces the built in table style with the one loaded from the document. But the old one used to not be destroyed, because it set as a listener of its cell styles. Change-Id: I8ae0a553207df20233886656307bb4ad371993f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141043 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-10-06Resolves: tdf#150501 borders and lines should be tearableCaolán McNamara
Change-Id: I683dcf5cdf2289fde28be4990c10525fd60b88e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141031 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-06Resolves: tdf#151053 Body text with dark bg not visible in Notes viewCaolán McNamara
this is a similar case to: commit 76a0b3170664b19c3eb66edc8fccb04dc5485387 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 10 16:49:19 2014 +0000 Resolves: fdo#35779 set the bg color of the editeng from the text shape Change-Id: Ib7ca42426397346e5d7473b93e60f853e646a423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140995 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-05I suspect the sizes are not enragedCaolán McNamara
Change-Id: I2e03b49d3eb9e4123ecd75783d7b585ef9faab3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140993 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-10-05Add on-the-fly language tag to proper language list Western/Asian/ComplexEike Rathke
In which combobox wherever it was added, the correct SfxItem will be updated and at least when switching to another dialog tab and back it will appear in the correct list. (shouldn't tabbing out of the combobox already trigger that?) Change-Id: I5aa78797dc24527c753c97d0357c3058271fa4d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140991 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-05tdf#151232 Fix lines in Special Characters dialog in dark modeRafael Lima
This patch makes the lines in the Special Characters dialog visible in dark mode. The Insert Symbols widget is also fixed with this patch. Tested in gen, gtk3 and kf5. Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759 Tested-by: Jenkins Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-04tdf#150786 use a 'standard' theme for form controlsCaolán McNamara
i.e. ignore system theme so we get the same results on export to pdf regardless of the theme (esp dark) and don't follow the system theme when hosted with a writer/calc/impress document (do continue to use system theme for StarBasic dialogs as seen in BasicIDE) Didn't reuse 'NativeWidgetLook' for this because is currently defaults off, while we currently do use the colors derived from the system theme even when this is off, its really the NWF flag to render using the platform theming engine Change-Id: I816d7ebaf793e5eac7bd937d44c1db0371145199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-01tdf#151114: Improve styles preview alignmentKhaled Hosny
Change-Id: Iefe265584d710bd6cfc9e7ed0a656dd83d91c84c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140811 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-10-01tdf#136919 Fix table size label in dark modeRafael Lima
Change-Id: Ifd4d67fa8211cf703c5d5d6ea99a0f41bd427e1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140612 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-29split utl::TempFile into fast and named variantsNoel Grandin
which makes it easier to know what each variant requires to stay on it's happy path Change-Id: I3275a2543573367714bc78092e882f6535507285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27cid#1500540 use check_after_deref instead of reverse_inullCaolán McNamara
Change-Id: I9f33d2681865b4a8200549b962d76f5babedfa3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-26tdf#119788 tdf#117173 add accessibility NOTIFICATION roleJim Raykowski
and use it to make screen readers announce notifications from the 'Find and Replace' dialog Change-Id: Ifcf9304883e2e824ea1b7998d7767e474b87c8b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139709 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-25tdf#150409 CJK&CTL properties shouldn't be hidden in Style InspectorLiu Hao
Change-Id: I577e4c90eb000e3f55f5be9e14132a4c1d16fe9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138755 Tested-by: خالد حسني <khaled@aliftype.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-24tdf#151114: Fix swapped width and heightKhaled Hosny
Regression from: commit 0483fbd1d05d74c394d9274bdee77b3b2aebb495 Author: Khaled Hosny <khaled@aliftype.com> Date: Sun Aug 21 01:49:57 2022 +0200 tdf#87535: Preview styles using CTL/CJK fonts in the sidebar Change-Id: I9108e2efa75eafe56c3ccc8ec2fff81b8cf7dc4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140551 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-22use more string_view in svxNoel Grandin
Change-Id: I672f6cc93f3f00c54eb2be7fa490d656bb5f0b02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19tdf#150650 Fix changing fill style to None via SidebarSamuel Mehrbrodt
Regression from 5491a82854e3e6dd2dbb4b0012cb4bbeb4ee22e0 Change-Id: I17cfb037f2064a508317090e6b66f20e253a9436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140150 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19tdf#150802 Fix setting gradient from SidebarSamuel Mehrbrodt
Regression from adc536e9efc77690df62177aa722f9252bdbf96b Change-Id: I37db76373a3b9b4a1084e830233561abc4b1e6d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140151 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19Rename MouseNotifyEvent to NotifyEventTypeSamuel Mehrbrodt
Also contains keyboard and focus events, not only mouse events Change-Id: Iec1d6c341b01a489ba80fe9634ea3579afb02ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19no need to allocate these separatelyNoel Grandin
Change-Id: I5e61c783806d78df94fa08840f7d3f37f1a743ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19simplify usage of TempFile in Graphic(In/Out)putStreamNoel Grandin
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: Icdfcb96b002c489dee51c03b69127c21be5c85ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-16Related: tdf#144092 improve wordingSarper Akdemir
Attempts to address concerns pointed out by Justin in: https://gerrit.libreoffice.org/c/core/+/138652/#message-6dd69691fbaabf26424b4c3fb85f42e550b53ee2 Change-Id: I1af4d316fae73626ce734ca60c6539502eb80f14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140067 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-16tdf#150987 calc crash pasting contentNoel Grandin
regression from commit d0119ff7f2c68aa05286bd303128f3a69c6bbd6a improve tools::Rectangle->basegfx::B2?Rectangle conversion which resulted in Fraction throwing an exception because of divide-by-zero Change-Id: I90a92a644c5fb40e9b93237c79f6760d4bb73d0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-16vcl: AnimationBitmap -> AnimationFrameChris Sherlock
The emphasis is not quite right. An animation is made up a sequence of *frames*, not bitmaps. A frame includes such things as position, size, timeout till the next frame *as well as* a bitmap. Note: had to regenerate a bunch of precompiled headers Change-Id: Ib1959452653857555f41e01ac0151d08c41a3b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76460 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-14Fix typoAndrea Gelmini
Change-Id: Ib41626ba675ced889bbc6fe4047e68a1d2ad529d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139918 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-14new loplugin refcountingbaseNoel Grandin
Look for classes that have more than one ref-counting base class. A situation which is going to cause trouble. Which reveals that sdr::table::Cell has two different ref-counting bases, so rather make SdrText extends OWeakObject, which means that Cell can just have one ref-counting base, Change-Id: I8d968270f7b449cff2f29da0bd48fa17181c68c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139807 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-14move ErrCode to comphelper and improve debug output stringNoel Grandin
need to move it, because modules "below" vcl want to use the debug output method Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-14tdf#149551 use 'WritingMode' instead of TextPreRotateAngleRegina Henschel
Commit 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 changed the code so, that TextPreRotateAngle is used to track ooxml vert attribute. This patch changes it so, that the style attribute WritingMode is used. Now text direction can be written in 'writing-mode' attribute in the graphic properties in ODF, same for shapes as for frames. The needed conversion from WritingMode BT-LR and TB_LR90 to TextPreRotateAngle for rendering of text in custom shapes is now in one place in class SdrObjectCustomshape. The shape edit engine cannot yet render it itself. Some unit tests are adapted to use WritingMode property instead of TextPreRotateAngle. The value text::WritingMode2::TB_RL90 is introduced, corresponding to vert='vert' and textDirection='tbRl' or ='rl' in OOXML. It is used for frames too, so that the original text direction is preserved and vert='eaVert' can be distinguished from vert='vert'. TextPreRotateAngle is currently still used in SmartArt import for 'upr' and 'grav' and in emulating 'upright' but no longer to emulate text direction. Change-Id: Idc4339bbfc3592fe90b154d75e2c404a1fa30856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138813 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-13ofz#50767 docxfuzzer: Indirect-leak in rtl_allocateMemoryNoel Grandin
Two fixes required here (1) the unnecessary use of aggregation in SwXDrawPage, which leads to a very confusing cycle that I don't fully follow. No indication why this is necessary in the git history, has been this way since initial commit (2) a ref-counting cycle through SvxShapeGroup and SvxDrawPage, use a weak reference here to break the ref-counting cycle. Change-Id: Ie7ec583960ed0864a073ad8489fb65964bd83080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-11basegfx: replace typedef with a class B2DSize based on Size2DTomaž Vajngerl
Change-Id: Id8b3c2bcf0bf4be5aba2812b0edda479bc20c6a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139683 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-10unique_ptr->optional for GraphicNoel Grandin
Graphic is just a wrapper around shared_ptr, so no need to allocate this separately Change-Id: I30de73ac8a7e29adbc5ffe681f3ce88cd700b68c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-09tdf#150732 ReportBuilder: Moving fields from one section to another crashesNoel Grandin
regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject Fixes 2 issues (1) where I removed some code that we need (2) where the OUnoObject constructor was deleting the object is was constructing Note that this only fixes the crash that Julien saw, not the underlying problem that this tdf bug reports. That bug appears to predate my commit. Change-Id: I3878ef460dedc3c2a6c86b88fce9d155e79bc0b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139714 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08tdf#150845 fix crash in writer Form->TextObjectNoel Grandin
regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject Change-Id: I66370566562a1275c21c24523a505704508d3d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139703 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08tdf#150832: Revert "tdf#150034 very slow opening pathological chart"Xisco Fauli
This reverts commit 613f6e75fbfcc024fc9c3732261cbf2cda6f4ad8. Reason for revert: it seems all charts in XLS files are affected. At least I could reproduce it with all the XLS files I tested it with. Change-Id: I68d13d6f609521ce6af759cf25249656176b66cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-08tdf#150102 Correct PrefSize for UNO API Metafile exporterArmin Le Grand (allotropia)
Checked that in aBound is indeed the size - 1 (probably due to old integer stuff using Size()/Rectangle() and getWidth()/GetWidth() with the old one-less paradigm somewhere), so just correct to the correct size. Be aware that checking of tdf#126319 is needed, but looks good in my tests. Still: Changing the central UNO API Metafile export is always a risky thing, so it will have to show if this will not influence something else. Adapted a unit test to take into account that the exported object as PNG no longer has an empty column at the right and lo longer an empty row at the bottom. That test testTdf126319 uses now the same test-indexing as the test testTdf105998 already used. This shows a more correct PNG conversion, it was curious anyways that two identical exports of objects with a light-red border from dfferent apps had that difference at all. Change-Id: I8513688dc062025c5d931b75602f4fdbd924a32a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139596 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-07apply ui-rulesCaolán McNamara
Change-Id: I5acc6cfe5488f8aa92ecaafa0ebdc50f2ad9758e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06svx: set vars to initial values in constructor init for SdrTextObjTomaž Vajngerl
Change-Id: Id3fb342a4273b617ac2975bff3dd79159ab8df75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139531 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-01 15:48:52 +0000