summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2015-04-17Fix SfxTabPage creation to use VclPtr.Michael Meeks
Change-Id: Ia0e8b666daec7b5eaba119c758b9ca1ec8276128
2015-04-17svx: convert new to ::Create.Noel Grandin
Change-Id: Idbcc64e883b79081c7a6399e1aed8a6b20035f69
2015-04-17fdo#71797 strange font selection bug with font previewNoel Power
The dialog seems to be automatically in preview mode from the start (which seems wrong) That bogus mode of operation (which I failed to fix from the begining) is somewhat responsible for the behaviour we see. Adding here a further ugly hack to ensure we use GetText when not in drop down mode (this is when clicking on a cell or cycling through the font list with up/down keys) In dropdown mode sweeping with the mouse highlights fonts (and we preview the highlighted ones) Note: in this case the selected font and the highlighted font are different, we need to pick up the correct one. Change-Id: Id2ba96a57d2f8cfc9657bce8de3ac27588868eaf Signed-off-by: Noel Power <noel.power@suse.com>
2015-04-17svx: convert new to ::Create.Noel Grandin
Change-Id: I52f589dabdedb538a4a5d0eadfa42b0d10de9b80
2015-04-17Revert "WaE: unused variables"Tor Lillqvist
See 3ac1584549364c573d4d4e3baed9ad39ad6ce8e4. This reverts commit 7bcf9131032cbcdb162f33d03230e43d4f1db2aa. This reverts commit 063aec33f029f1fbdd1b1ee274e94a00f256465e.
2015-04-17SvStream: WriteUChar -> WriteBoolStephan Bergmann
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
2015-04-17sw: convert new to ::Create.Noel Grandin
Change-Id: Iab0fc73540b3c7a60c64296dce86b70c1e02cf09
2015-04-17WaE: unused variablesTor Lillqvist
Change-Id: I3b0ed8a6c8e5d13b9236ee1a1337820c3cbce9ac
2015-04-17Use VclPtr for OGenericUnoDialog::createDialog.Michael Meeks
Change-Id: I0c2040889931a4700735339c5252f8d5fee234ff
2015-04-17svx: nPntAnz -> nPointCountMiklos Vajna
Change-Id: I2a4c7ef9d33db1c34a4ab338f70f800b30083f4f
2015-04-17convert SCRIPTTYPE_ constants to scoped enumNoel Grandin
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-16make CreateItemWindow return a VclPtr<>.Michael Meeks
Change-Id: Id15ff8900376aaee4343d7ee08ae062e1c462ce4
2015-04-16svx: can avoid comphelper/implbase_var.hxx in formcontrollerMiklos Vajna
Change-Id: I37a1d16f76cad6b8ff5727ecd09d718e15519de9
2015-04-15DBTOOLS_DLL_NAME not used anymoreMatúš Kukan
Change-Id: Ieb9a373e4d59bfe72a7709bd7822617f9877054a
2015-04-15Unregister sidebar ControllerItems at the right time.Michael Meeks
Otherwise they linger post-dispose, wreaking havoc. Change-Id: I6d0981ee15e82111bc825c75d28b703e5a5d266b
2015-04-15and SvxContourDlgItem is also unused nowCaolán McNamara
Change-Id: I9696123d8ce9cd69520921cd19cf26e3f60bc61a
2015-04-15and now SvxBmpMaskSelectItem is unusedCaolán McNamara
Change-Id: I76993ffb0dd347afe4f114431e8c12922d5c6882
2015-04-15-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I90cb42aff1d57a92f371d339b0be7c71b1a15ff8
2015-04-15convert SFX_ITEM constants to scoped enumNoel Grandin
Change-Id: Ief8c30c356ba947727c5ab70092042816a0db99e Reviewed-on: https://gerrit.libreoffice.org/15302 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-15convert SIGNATURESTATE_ constants to scoped enumNoel Grandin
Change-Id: I715e39599464a199a8b78ec274bfe47b90fc4bb7 Reviewed-on: https://gerrit.libreoffice.org/15301 Tested-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-14tdf#89750: svx: fix ExternalToolEdit on WindowsMichael Stahl
While adding check that the temp file move succeeds, overlooked that the file handle is actually leaked, which means the move will fail on WNT because the file is already open. (regression from ef490df2119523e1761f99b5fdbb387c2c71608d) Change-Id: I779ccde79871930fef3bad7e17b633fb62e36a46
2015-04-14tdf#89478: svx: ODF import: SvxBrushItem Graphics should override ColorMichael Stahl
The bugdoc has: <style:page-layout-properties fo:background-color="#007f7f" > <style:background-image xlink:href="Pictures/2000003900002FA3000055F455EC9F63.svm"/> </style:page-layout-properties> In this case it's clearly better to prefer the Graphics. The old code could actually store both in the model but the UI only allows setting either Color or Graphic, so this should be good enough. (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: Id33231ad90815d9791f90289fb0b55455d334c14
2015-04-14svx: hack around LogicToPixel assert in SvxRuler::UpdateTabsMichael Stahl
Somehow this gets called in a different order than in 4.3; with the bugdoc from tdf#89478 i get this assert on master because of the uninitizlized / LONG_MAX. Change-Id: Iacce21571246c96276bd3c126f982282df7fc491
2015-04-14tdf#88710 Kill svx dbtoolsclientMatthew Nicholls
Removes dynamic loading logic described in tdf#84315, similar thing removed in swdbtoolsclient. Change-Id: I8762102a7263e6933354c2ff6f9978929b760f6e Reviewed-on: https://gerrit.libreoffice.org/15147 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-04-13Re-work sidebar factory to use VclPtr.Michael Meeks
Change-Id: Iccbf4166419eee9f78f036d1abe07bba028d09e6
2015-04-13Resolves: tdf#90583 3D pie-chart missing guide handlesCaolán McNamara
partial revert of commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 Author: Armin Le Grand <alg@apache.org> Date: Tue Feb 18 21:18:13 2014 +0000 Resolves: #i123539# some optimizations for 3D chart... geometry creation using UNO API (cherry picked from commit bbe35be767d76d08891c4f3d3600d80e0e6805f2) Change-Id: If35f05fb62230e90cfc43a0beac053e8a87820d4
2015-04-13More lifecycle correction.Michael Meeks
Another (complete) audit of delete usage in: "vclwidget: change all vcl::window fields to be wrapped in VclPtr" Change-Id: I828212ded66ecc5cc30c75a4de626c7b386cb77a
2015-04-13loplugin:redundantcast: redundant const_cast followed by implicit upcastStephan Bergmann
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-13loplugin:staticmethodsNoel Grandin
Change-Id: I332d3b3158b46cf130540c6e1479dd01cb457d03
2015-04-11disposeAndClear in place of DELETEZ.Michael Meeks
Audit of DELETEZ usage in: "vclwidget: change all vcl::window fields to be wrapped in VclPtr" Change-Id: Ib65096a9edb09ce9381ab4a8297d9391d2603651
2015-04-11Calm down TBsJulien Nabet
Of course, I suppose there should be a better fix than this one Change-Id: I65505d52b0a161ebea2e4bda5d1b32934e74906b
2015-04-10svx: add an assertion to this fixed-size thingMichael Stahl
Change-Id: I3d496f78fd60a3a47cc62d4237f31e5e131a9692
2015-04-10VclPtr: unfortunate includes needed for inlining ref/unref.Michael Meeks
Something of a compile time vs. run-time choice. Change-Id: I7e9db3a6f14d352e0b78abd5f22ccc593aceb001
2015-04-10Lost more cleanup and fixing post re-basing.Michael Meeks
Change-Id: Ia5317b93484d31af978a5276bc6697848130225d
2015-04-10Lots more small re-basing issues fixed.Michael Meeks
Change-Id: I621567c4596e01092c55d868403910386fa14058
2015-04-10convert ScopedVclPtr to ScopedVclPtrInstanceNoel Grandin
Change-Id: I22a9d9c313a81ccee885b9c8785d4b008a6f2058
2015-04-10Manual cleanup of misc. issues.Michael Meeks
Change-Id: Ib0b9b17010f7c1b0814b48f6fb0144e5296418df
2015-04-10Automated conversion of VclPtr construction to use Instance template.Michael Meeks
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10second half of non-scriptable, Instance constructor conversion.Michael Meeks
Change-Id: I616c8c28255e0d90ae90033a128bd34d7570530c
2015-04-10re-insert erroneously converted delete calls.Michael Meeks
Change-Id: Iebdf2af3866d884289f6913646106fe3f2d4dde5
2015-04-10vclwidget: fixup locally allocated vcl::Window objectsNoel Grandin
They need to be wrapped in ScopedVclPtr in order to be disposed properly. Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
2015-04-10vclptr: various mistakes fixed, and more ptr types converted.Michael Meeks
Change-Id: Iba04ec828f7ce37fc6ede28a64f1c286d81ff705
2015-04-10Move OutputDevice members to VclPtr: starmath, svx.Michael Meeks
Change-Id: I1a5174334f41bc319e0806b9d324be64ba6d0135
2015-04-10Fix OutputDevice members / stack allocation: svx.Michael Meeks
Change-Id: Id28aeb44b4c48fec944e21fed7a9acf9f7f8b68a
2015-04-10Fix OutputDevice members / stack allocation.Michael Meeks
Change-Id: Ie57434607b61085a882af40b63d6a4b7aac0d4d3
2015-04-10vclwidget: check for calling delete on subclasses of vcl::WindowNoel Grandin
Change-Id: I7fb7cf919e3f46dd03a18b1cb95fa881915f9642
2015-04-10vclwidget: fix more places that should be wrapping in VclPtrNoel Grandin
Change-Id: I31c9115662da2f81e1b22be91ee58e2862076b8e
2015-04-10basctl, forms, svx: cleanup for new VclPtr API.Michael Meeks
Change-Id: I3bfd7933d2cddf707662d10e9366e0c82f33d276
2015-04-10cleanup Printer VclRef pieces.Michael Meeks
Change-Id: Ib47b2ec3cb54e374675981ad929856f43987418f