summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)Author
2019-01-18tdf#42949 Fix remaining IWYU warnings in include/vcl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some new headers were added since I begun the cleanup here Also blacklist the header from commit 403e3c04420c4d20c77427c43df52d554d7329ff Change-Id: Ie2358d5e27297f873aeb4a4dfb2778e6fb95dfa5 Reviewed-on: https://gerrit.libreoffice.org/66255 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-16Resolves: tdf#122509 we have a second list with generated currency formatsEike Rathke
... which kicks in if SvxNumberFormatShell::FindEntry() determined a format index of NUMBERFORMAT_ENTRY_NEW_CURRENCY instead of a real existing index. Regression from commit e607f1da329a2d4dd91904053d7ff86ac05c77bf CommitDate: Thu Oct 4 15:02:13 2018 +0200 Select the current format if multiple instead of first matching format code The old (now removed as unused) SvxNumberFormatShell::GetListPos4Entry(const OUString&) used before took care of that, add the functionality back but combine into the existing GetListPos4Entry() function, the additional FindEntry() call wasn't necessary anyway because it was just called before in the caller. The actual crash happened elsewhere in SvNumberFormatter::GenerateFormat() because no format exists for the then determined entry, which should be changed independently to prevent such abuses. Change-Id: Id42efa152693119fbde82b234f367679f818cfab Reviewed-on: https://gerrit.libreoffice.org/66472 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-16pass RedlinData around by unique_ptrNoel Grandin
Change-Id: Ibe709e64b89e5e036e741203a14242f27df8c637 Reviewed-on: https://gerrit.libreoffice.org/66416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15tdf#38328: allow Find&Replace key combinations in FindTextFieldControlMike Kaganski
... using svt::AcceleratorExecute to detect user-configurable key combinations. Change-Id: Iad4f6d3e0becfb896d4b4342c819c98e04789a1c Reviewed-on: https://gerrit.libreoffice.org/66377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-15Resolves: tdf#122700 cannot change shadow colorCaolán McNamara
Change-Id: Iee42beb96ff4d059c685173fdde453981b300b3c Reviewed-on: https://gerrit.libreoffice.org/66360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-15tdf#42949 Fix IWYU warnings in include/toolkit/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icebcf1a6ab073dce935a74ce79ee0f302b62e8a8 Reviewed-on: https://gerrit.libreoffice.org/65947 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-15Resolves: tdf#35152 select first fontwork if any are availableCaolán McNamara
Change-Id: I29ab070f9664939d1e10d1cccb2a62cfdc0570e7 Reviewed-on: https://gerrit.libreoffice.org/66337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-14Resolves: tdf#122695 Content Type selector tooltip missingCaolán McNamara
Change-Id: I0ffe6448d865f569fb59d9facbb1582d2152a9ba Reviewed-on: https://gerrit.libreoffice.org/66291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11Drop o3tl/clamp.hxx, use C++17 std::clamp insteadStephan Bergmann
Change-Id: I5043c787dcc3b78bc7fdff130564801194e39f46 Reviewed-on: https://gerrit.libreoffice.org/66177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10Removed executable permission on source filesAndrea Gelmini
Change-Id: I1853e7a82078c9bc7149098bf9acc0ddf65109c8 Reviewed-on: https://gerrit.libreoffice.org/66040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-09Removed duplicated includeAndrea Gelmini
Change-Id: Iea1d992fb7b7e0d60ee3432a20b74cb8d312fc08 Reviewed-on: https://gerrit.libreoffice.org/65991 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-09tdf#120086: Patch for TAB-ing order of Gallery sidebar panelAditya
The current TAB-ing order of Gallery sidebar panel is not sequential and the order needed to be changed. This patch fixes the TAB-ing order of the gallery sidebar panel to a more sequential and convenient one. It also fixes the reverse TAB-ing order (Shift+TAB). Change-Id: Ib0b22ccef1fa4676e535f42a794fb7c836741d0b Reviewed-on: https://gerrit.libreoffice.org/65907 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-06tdf#82504 writer table cell background color SvxColorItem uno functionJim Raykowski
Current background color function only sets table cell background when multiple table cells are selected. Paragraph background is otherwise set. This gives expected results for use in sidebar Paragraph panel when multiple table cells are not selected but unexpected results when multiple table cells are selected. For background setting from the table tool bar unexpected paragraph background color is set when multiple cells are not selected. This fix creates a table cell background color uno command specific for setting table cell background color. Change-Id: Ic56723b635252415d932c5499f996c3e46eee13b Reviewed-on: https://gerrit.libreoffice.org/65591 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-01tdf#105225 Add palette selection to options charts default colorsJim Raykowski
Change-Id: I42d1f155238213e41b8a57ce47b70cfeb2408b26 Reviewed-on: https://gerrit.libreoffice.org/64980 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-23tdf#121761, tdf#121952 Accurate ellipsequadrant in custom shapeRegina Henschel
The current solution uses one, bad valued Bezier curve and does not toggle direction. The patch uses the more accurate solution from basegfx and simplifies the decision tree. In addition it extracts the calculation in double from GetPoint, so they can be used directly instead of double->long->double conversion. Change-Id: I298f49415d1b7624b36ca561647f2e58af5eb5c6 Reviewed-on: https://gerrit.libreoffice.org/65203 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-12-21Resolves: tdf#120885 Crash on choosing 'more styles'Caolán McNamara
switching to the sidebar destroys the control currently active, just post the event to happen on the next event loop Change-Id: I3e9b629821fa43d8f29e419e72f66ed46d72fdbb Reviewed-on: https://gerrit.libreoffice.org/65541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-21pass OSQLParseNode around by unique_ptrNoel Grandin
Change-Id: I8ffb9e04614472c3645d24bebdc88f91059d12ad Reviewed-on: https://gerrit.libreoffice.org/65436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20tdf#119180 Use 100th_mm in UNO API implementationArmin Le Grand
Since SvxShape::GetBitmap is UNO API implementation the results have to be in 100th_mm, that is how UNO API is defined. Adapted Bitmap creation common case to do so using primitve embedding if source is not 100_th_mm. Also added a shortcut if object in question already is a SdrGrafObj and contains a Bitmap. Needed to update the checksum of a graphic for testN777345. Change-Id: I995100406a262e2872597dc64e943271e92eb4cb Reviewed-on: https://gerrit.libreoffice.org/65505 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20use unique_ptr in svxNoel Grandin
Change-Id: Ib0dd1edf05470783da41f08767020a9009f356ad Reviewed-on: https://gerrit.libreoffice.org/65444 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20use unique_ptr in SdrPaintViewNoel Grandin
Change-Id: If4ae6eb38351a9d7dec547d02bbb5a700af5ec64 Reviewed-on: https://gerrit.libreoffice.org/65397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19tdf#122127 Crash in FORM EDIT using drag drop to move control in dataformNoel Grandin
regression from commit 2629aac31142449312f77c5843ea209cc810acb4 Date: Tue Oct 23 09:47:10 2018 +0200 clang-tidy performance-unnecessary-copy-init in svx Change-Id: I4210c328145d062d8b72f09dcff3280e11c6bc36 Reviewed-on: https://gerrit.libreoffice.org/65394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19simplify DistributeMarkedObjectsNoel Grandin
no need to store small objects separately on the heap Change-Id: If51b936eb0c2a4b721a1b2e5ccdf785f7e2b762b Reviewed-on: https://gerrit.libreoffice.org/65346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19use unique_ptr in RemoveWhichRangeNoel Grandin
Change-Id: I6c0f07f0dc4a7f6bfa15c0ea720f349894559429 Reviewed-on: https://gerrit.libreoffice.org/65340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-17Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-16tdf#121638 , Different angle shown between sidebar & size and position dialogSumit Chauhan
Bug solved , Changed the nTmp = 360+nTmp ,if nTmp <0. Change-Id: I855e634540c55ab91e8bbe5824014d304d87c8e9 Reviewed-on: https://gerrit.libreoffice.org/65211 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-14coverity#1441522 bSdrViewInsertMode is always trueCaolán McNamara
Change-Id: I5fcab474b517a0482bd04dedd0fcee6a817dd3b0 Reviewed-on: https://gerrit.libreoffice.org/65164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14coverity#1441522 FontWorkGalleryDialog mpSdrView member is never nullCaolán McNamara
Change-Id: If17d2984831b0881d39101648206accdadde12aa Reviewed-on: https://gerrit.libreoffice.org/65163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14Removed executable permission on .cxx fileAndrea Gelmini
Change-Id: I09775c92f7c5b5e0f554a2822d243a230a06f626 Reviewed-on: https://gerrit.libreoffice.org/65136 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-13tdf#121890 ODF custom shapes use left and top from viewBoxRegina Henschel
MS custom shapes use always zero for identifier left and top in the formulas of the shape geometry. But custom shapes in ODF use the left and top value from the svg:viewBox attribute, see table 11 in section 19.171 draw:formula; part 1 of the spec. Change-Id: Ief4b9d9b8797e165a494d049f32c5a46880044c2 Reviewed-on: https://gerrit.libreoffice.org/64704 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-12-13use unique_ptr in checkForUniqueItemNoel Grandin
fixing a memory leak in chart2 Change-Id: Idddb6a46b1bde5c1a11148c03bbdaac20ac78e13 Reviewed-on: https://gerrit.libreoffice.org/65031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13loplugin:mergeclasses merge LineLB into SvxLineBoxNoel Grandin
Change-Id: I76bab66b09ae809c069f586ccb1c4ce13fa30234 Reviewed-on: https://gerrit.libreoffice.org/65025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use unique_ptr in createTransformedCloneNoel Grandin
Change-Id: I224f2ab64188d0df8f4a587af65f6bf80359a9de Reviewed-on: https://gerrit.libreoffice.org/65006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use std::<some_container>::swap, instead of copy and clearNoel Grandin
Change-Id: If49c33e271426ff5c2d0c6cc4010670f797bdd38 Reviewed-on: https://gerrit.libreoffice.org/65001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10Resolves: tdf#121946 first time draw uses gray bgCaolán McNamara
Change-Id: Ia0491eebe8fa7ea2c2377ca96c758c681da5470a Reviewed-on: https://gerrit.libreoffice.org/64875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-10Resolves: tdf#121520 duplicate languages in dropdownCaolán McNamara
Change-Id: I5bbde305bf06ac1f754f24eb93e89cb3d9cf6058 Reviewed-on: https://gerrit.libreoffice.org/64866 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-10lok: shape scaling reworkMarco Cecchetti
Now shape scaling is handled through the transform dialog instead of simulating a drag and drop event in core. For Impress the unit used for length is '100th mm' instead of twips, so we need to transform positions and size from twips to '100th mm'. Anyway since we don't know in SetGeoAttrToMarked if the new data is due to a mouse event or by entering a new value in the transormation dialog or in the side pane, for Impress we need to convert the new values sent by the dialogs from '100th mm' to twips which are converted back in SetGeoAttrToMarked. For performing a uniform scaling when the shape/image is rotated we need to inform the client about the rotation angle for the selected graphic object that has been achieved but appending an angle argument to the graphic selection callback. Now it is also possible to reverse shapes/images through negative scaling. Change-Id: I8a32f3e4b28f36e884a59c59b7e1351e85ef4489 Reviewed-on: https://gerrit.libreoffice.org/64696 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-12-09Fix typos in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I8cfe93e58bb5a006d69ea7420b5f2aa07a0864c2 Reviewed-on: https://gerrit.libreoffice.org/64739 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-08Translate German variable namesJohnny_M
Change-Id: Ic7d194bd256cc573c4081bb82619e42abf2dda90 Reviewed-on: https://gerrit.libreoffice.org/62842 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Translate German variable namesJohnny_M
Change-Id: I141c003bead8eda9bdfa8a7fd286f76390cf77ac Reviewed-on: https://gerrit.libreoffice.org/62843 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-08Translate German variable namesJohnny_M
Change-Id: I53951eee14e028365967615c0eb017ca43dfd891 Reviewed-on: https://gerrit.libreoffice.org/62845 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07HAVE_CPP_INLINE_VARIABLES is always true nowStephan Bergmann
...but for safety, leave the configure.ac check in for some longer. Also remove now-redundant SAL_INLINE_VARIABLE again (which was LIBO_INTERNAL_ONLY). Change-Id: Id049e0cb84b4f97f5859f1b16b867b39b448dec0 Reviewed-on: https://gerrit.libreoffice.org/64772 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07lok: Right rotation calculation in case of delta angleTamás Zolnai
Change-Id: Ia7d0a573c1902fba3fc1e69f425bbf2dc93a1c82
2018-12-07Avoid moving the shape by rotationTamás Zolnai
The difference between Impress and Writer is the used unit. We can assume that SID_ATTR_TRANSFORM_ROT_X and SID_ATTR_TRANSFORM_ROT_Y contains the values in twips. Change-Id: I44ba9532348200742b2c7c369b89eb2545295684
2018-12-07lok: get correct handlers for a single rotated shapeMarco Cecchetti
Change-Id: I74668ca8079d8d56b8c3f2c4513e2a2ec95872c6
generated by cgit (git 2.34.1) at 2025-01-07 20:59:15 +0000