Age | Commit message (Collapse) | Author |
|
Printing a brochure in Writer that has A5 pages would set the page size
to 10 times the size of an A4 page instead of the expected A4 page size
and would sometimes print the content at 90 degrees relative to the
paper.
This bug ended up being caused by several paper matching bugs:
- The page size and rotation would fail to be set if the printer was
nil. A printer is not needed to use the native macOS print dialog so
if the printer is nil, use the native default printer instead.
- Expand page size match range to 1/10th of an inch. The A4 page size in
Apple's "no printer installed" printer can differ from LibreOffice's
A4 page size by more than a millimeter so increase the match range to
1/10th of an inch since an A4 match would fail when using the previous
0.5 millimeter match range.
- When brochure printing in Writer, set the printer's page size to match
the preferred page size. Unlike most other platforms, the native print
dialog is always displayed on macOS and it displays a preview of the
print output which the user can make layout changes to. The user can
also change the printer or even send the print output to PDF instead
of a printer from within the native print dialog so set the printer's
paper to the preferred size so that the initial preview more closely
matches the page size and rotation that LibreOffice expects.
Lastly, the fix for this bug includes fixes for the following bugs in
the "print selection only" checkbox:
- The "print selection only" checkbox would remain unchecked after
checking it had restarted the print job so load the checkbox state
from where it was updated in
ControllerProperties::changePropertyWithBoolValue(). This fix was
copied from the following NeoOffice source code file which is licensed
under the Mozilla Public License, v. 2.0:
https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/osx/printaccessoryview.mm
- If the "print selection only" checkbox is changed when the content is
only a single page, calling
-[AquaPrintPanelAccessoryController updatePrintOperation:] won't
restart the print job so force the print job to restart.
- If the the "print selection only" checkbox is changed and then the
restarted print dialog is cancelled, idling will have already been
unblocked so check if it is blocked before unblocking it.
Change-Id: I99e9b3f73e3d3d860762c168573d2bb520934df3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179096
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
|
|
Change-Id: I7a491038d1b8532385e70294872d209dcdc63ce9
Signed-off-by: Rasenkai <rasenkai99@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146300
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: I6243bc95129bf81a124d006ce0fc1aa1b5f618bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105718
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
|
|
Starting the SwDocIdle in StartIdeling() just reintroduces the
bug fixed in commit 401cba4c20fb ("tdf#116370 cleanup Writer idle
job handing"), so trading one bug for the other.
For the real solution we have to handle two states:
1. The SwDocIdle being active
2. The SwDocIdle being blocked
For the first state we can just use the active state of the Idle
itself. Since it's not a AutoIdle, it will be turned of, if
invoked. Either some Idle handler will want to be run it again or
some other thread might start it again, if needed.
Since we're now tracking the wanted Idle state via the active task
flag, we can drop the explicit mbStartIdleTimer handling.
As a result of the first change, we can't stop the Idle anymore
when blocking it. But the Idle itself checks its ready state via
IsDocIdle() in its UpdateMinPeriod function, so we have to add
the blocking state to IsDocIdle().
Change-Id: I33017a8e07208a6a3bce761cc899ac3ca944cd61
Reviewed-on: https://gerrit.libreoffice.org/59586
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
This prevents the start of the idle job, while processing itself,
so the fixed WinSalInstance::AnyInput of commit 3bf6c97029d2
("tdf#112975 WIN correctly handle VclInputFlags::OTHER") won't
report the timer events of the re-started idle job to process.
Fixes the early abort of the background job, which resulted in
the busy loop of the reported bug and this strange printing
behaviour.
P.S. I'm not sure, why this was just broken on Windows.
Change-Id: I6503dcd925c9a0ed843e794a31eea32a4a4b2889
Reviewed-on: https://gerrit.libreoffice.org/59279
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
This refactors DocumentTimerManager to export the busy status
independent of the Idle function. This way it can be ignored in
the Scheduler while the document is busy,
Change-Id: Icec2075d3338ad8dd4440678eb0570d7fe887778
Reviewed-on: https://gerrit.libreoffice.org/43197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Translates leftovers found using a custom regex.
Additionally translated:
- One randomly found comment in /reportdesign
- Test strings in /stoc/test (let's see if it works)
Change-Id: I5f893c194c4b56b5365700928a3b8b63936d03e2
Reviewed-on: https://gerrit.libreoffice.org/41583
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Added header guards to files in directory sw/
Change-Id: I5859f986c6f954d41a7940dc9ae8febaa714d34f
Reviewed-on: https://gerrit.libreoffice.org/9587
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I8e0889200d1a1c36e53022a74792728efd66c2fc
|
|
Change-Id: I36c6c56d7277b9b3853b846c86c1f4dd47ebdb08
Signed-off-by: Luboš Luňák <l.lunak@suse.cz>
|
|
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
|
|
Fixes #fdo30794 Based on bin/add-modelines script (originally posted
in mail 1286706307.1871.1399280959@webmail.messagingengine.com)
Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
|
|
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
|
|
2008/03/31 16:52:32 rt 1.4.436.1: #i87441# Change license header to LPGL v3.
|
|
2007/04/25 17:53:12 pjanik 1.2.238.1: #i76688#: Remove deprecated SISSL.
|
|
2007/01/25 11:03:21 ama 1.2.132.1: Fix #i73752#: Remove SISSL
|
|
2006/09/01 12:14:19 ama 1.1.2.1: #i68827#: CleanUp for timer access
|