summaryrefslogtreecommitdiff
path: root/sw/inc/PostItMgr.hxx
AgeCommit message (Collapse)Author
2024-10-08RegisterAnswer is never passed nullCaolán McNamara
Change-Id: I3d724c5ea77865de9850a655aaa23c9633b68d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174643 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-27tdf#162855 Draw a guide line while resizing the comment sidebarRafael Lima
This patch draws a guide line while the user is dragging the comment sidebar edge, to provide a better feedback of the size that will be applied. Thanks to Jim Raykowski for his comments and contributions. It should be noted that he authored much of this patch. Change-Id: I08d4761a25c021c3ddda563a70fc0324000e4e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173017 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-09-25sw: add new command to make a response comment rootJaume Pujantell
Adds the option to convert a reply comment into a new top comment while preserving the parent-child realtions of the other comments in the thread. Change-Id: I3cd5e5466fadc2226651d7c244b5139ec2d1f949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173051 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173870 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Tested-by: Jenkins
2024-09-17tdf#162937 Set default comment position to the rightRafael Lima
Change-Id: Ibd665ca861efcf60d382d018b71a6b470792e01b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173387 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-09-13sw: add Comments Panel in sidebarMohit Marathe
This commit adds a sidebar deck for comments. It has all the functionalities of the old comments shown via annotation window. Change-Id: Ibab0e21a54c097d0f42bddb1d07da74319970135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167840 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-08-11Resolves tdf#61242 - Customization of comment background colorHeiko Tietze
* COL_AUTHOR<1..>_DARK/LIGHT/NORMAL removed Author1..9 added * dark variants calculated from light with 50% brightness * light does In/DecreaseLuminance(30) and dark (sd) resp. anchor (sw) In/DecreaseLuminance(80) depending on GetUseDarkMode() * sw: font color depends on outline background, which now picks up DOCCOLOR; this does not work for dark colors in light mode, for example * sd does not update on changes and requires a restart Change-Id: I773793de8cfbdc0d23124db790604b93030375c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171523 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-06-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ia216da9bd7764f2d21aaee761a02eafda88d892e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169257 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-29create comment reply synchronouslyPranam Lashkari
so we can bundle the creation of the comment and the insertion of its "reply" characteristics together as a single Undo group. wrap the new combination with a single undo operation showing "Insert Comment" using Rewriter Change-Id: I5927fa5501da0c49cc1182c60e23be290b8c37c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-22split a piece of code out as a standalone GetOrCreateAnnotationWindowCaolán McNamara
Change-Id: I674d96976f265eeac719ed06a657af07aaae2325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-22tdf#159145 Allow changing width of comment column on right borderSamuel Mehrbrodt
not only on the ruler as implemented in ac2720dcbe4e51e7f6733a385b5f7b571c6431e9 Change-Id: Ib3709e97be312a7e20302ffa703e847f9efa3110 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162365 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-01-11Use officecfg instead of utl::ConfigItemSamuel Mehrbrodt
Change-Id: If6fa84bcdb56873df288d216b157ad669c45bca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161622 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-01-11tdf#73953 sw: Allow resizing the comment sectionSamuel Mehrbrodt
Change-Id: If2920b31a82b3f3d42038e75f3637be9802711fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161616 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-01-30tdf#119229 docx: Set paraIdParent upon FN_REPLYParis Oplopoios
Set the paraIdParent SwPostItField attribute when replying on an existing comment in Writer Change-Id: I33d89688d5a36a91b26a64cf4b0f605d7bf33b1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-05use more DECL_DLLPRIVATE_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I6855894d0166c300ced169e36861f38811baa48d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-04Resolves: tdf#143643 ensure relayout on undo of insert commentCaolán McNamara
Change-Id: I732e23b8ff7c17abf4b5b9b7c7964fca6069543c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124685 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30loplugin:constparams improve handling of pointer paramsNoel Grandin
Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19use std::optional<OutlinerParaObject> in SwPostItMgrNoel Grandin
it is a COW object, no need to allocate separately on heap Change-Id: I9388d2a850a39a8645071dfb2907a4fe7785ac21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11convert more long -> tools::LongNoel
found by grepping and changed by hand. Change-Id: I3c720859dba430fde3abc76c6c5cb58269efaf4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20use tools::Long in swNoel
Change-Id: I44be72b3a9b14823ec37a3c799cffb4fb4d6e1de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-23Added new command to delete the comment threadPranam Lashkari
Change-Id: I16d46787a6972afb0c3ab2e56482888082af1d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102894 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-05-09compact namespace in swNoel Grandin
Change-Id: Ie2c3e3f95a687b12b89bcfc5cad44fb7a1d4568f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04loplugin:finalclasses in sw/incNoel Grandin
Change-Id: I084502d8c5607f103ef987b54252ef95341f0bef Reviewed-on: https://gerrit.libreoffice.org/81981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in swNoel Grandin
Change-Id: I73c3c6d2165287d2d581a04b23b1d3b48166a488 Reviewed-on: https://gerrit.libreoffice.org/79780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-08tdf#119228 Add 'Resolved Comments' option to the View menu.Scott Clarke
Change-Id: Ib4554b77857992959a386c71e99e424579196ded Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75862 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06tdf#119228 Add accessors for resolved stateScott Clarke
Change-Id: Ic4051f4e7fda11eade1e50ce70bed11f70f0742d Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75859 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-04Use hasElements to check Sequence emptiness in swArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: If44f20a7aa678915e32d12101e1af71476f4b590 Reviewed-on: https://gerrit.libreoffice.org/71679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...Stephan Bergmann
...with latest Clang trunk towards Clang 9. All the no-longer necessary hacks are made conditional on new NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is still set for UBSan builds with older Clang on Linux (but which should eventually be purged). Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, as building with UBSan instrumentation can generate references to RTTI symbols from additional places like outside a dynamic library that used to hide those symbols by default (but used to not hide them for old UBSan builds thanks to the -fvisibility-ms-compat hack). The odr-violation suppressions in solenv/sanitizers/asan-suppressions (which is not referenced from anywhere in the code base, but meant to be included in an ASan/UBSan build's ASAN_OPTIONS env var) are also no longer needed when NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false. Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a Reviewed-on: https://gerrit.libreoffice.org/70829 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-15use unique_ptr in SwPostItMgrNoel Grandin
Change-Id: Icc946b986f62d986e979e6a3f3ba0d2c28cb9adf Reviewed-on: https://gerrit.libreoffice.org/66312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-17sw: Replace std::list with std::vector for simplicityTakeshi Abe
Change-Id: I239df7b0009711eeaf025221bec9c95887681c8d Reviewed-on: https://gerrit.libreoffice.org/58918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwPostItMgrNoel Grandin
Change-Id: I63dd541ac975648083d75fe5ce1ef86e99016faa Reviewed-on: https://gerrit.libreoffice.org/57936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-25sw: fix remaining IWYU warnings in inc/*.hxxMiklos Vajna
Also check for not needed forward declarations. Change-Id: I92759f3f40d9458fd192665b39b87a78d8b97e5a Reviewed-on: https://gerrit.libreoffice.org/53418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-15loplugin:useuniqueptr in SwPostItPageItemNoel Grandin
since we're unconditionally allocating this list, just declare it inline. And make it a std::vector instead of a std::list, it very inefficient storing pointers in a linked list Change-Id: I715868265f9f2e633395f474267e84ee87356726 Reviewed-on: https://gerrit.libreoffice.org/51317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26use less RGB_COLORDATANoel Grandin
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-31Fix some IWYU warningsMiklos Vajna
Change-Id: I85a096505b0de98fd1de6179b9239318622fc34a Reviewed-on: https://gerrit.libreoffice.org/48933 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04Replace list by vector for mvPostItFields (sw)Julien Nabet
Change-Id: I22009cd051a990cbc6e5f67a01958da889437840 Reviewed-on: https://gerrit.libreoffice.org/45759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-17loplugin:useuniqueptr in SwPostItMgrNoel Grandin
Change-Id: I567ec14112ee8d5224c19c7616fd8ed06619c228 Reviewed-on: https://gerrit.libreoffice.org/44822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17Use auto/for range loops in PostItMgr (second pass)Julien Nabet
Change-Id: Ib827968c6194173e107b6b9e72c6545f5de673d2 Reviewed-on: https://gerrit.libreoffice.org/44791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-23loplugin:includeform: swStephan Bergmann
Change-Id: Ifc3c4c31a31ee7189eeab6f1af30b94d64f2f92a
2017-08-06loplugin:constparams in sw part6Noel Grandin
Change-Id: Ic82946cf9be50d9d9c43338b86dfb700ce5b354c Reviewed-on: https://gerrit.libreoffice.org/40786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18Typo: existance->existanceJulien Nabet
Change-Id: If6927f3b9e983d41ec957997a26d235b8be378a5 Reviewed-on: https://gerrit.libreoffice.org/38934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-12sw: prefix members of SwNotePropsMiklos Vajna
Change-Id: If1d50504d9d7efcb0f6b1b5ddf570d3016f40be5 Reviewed-on: https://gerrit.libreoffice.org/38686 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-09loplugin:checkunusedparams in sw(part5)Noel Grandin
Change-Id: Iee48e6c77f1eb57cd8a3a245e5415051b85f4cc1 Reviewed-on: https://gerrit.libreoffice.org/37387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21tdf#68604: Commit the data from the postit to the model before docx save.Jan Holesovsky
Change-Id: I74f4adad5f142b35ff8819577b1dbd6e5c45db96 Reviewed-on: https://gerrit.libreoffice.org/36757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-11loplugin:mergeclasses merge SwAnnotationWin and SwSidebarWinNoel Grandin
Change-Id: Idaf7d7e8e4da37e0ba423dca3e22dc6711ba806a Reviewed-on: https://gerrit.libreoffice.org/36380 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-16Clean up integers representing "redline authors"Stephan Bergmann
Unlinke in previous such clean-up commits, there appears to be no sufficiently exposed container type whose size_type could be used throughout, so resorting to the generic std::size_t in this case. Change-Id: I3cfbcbe5cce1bfcff2efbb4f8a509fe80ab12151
2017-03-01typesafe wrappers for css::i18nutil::TransliterationModulesNoel Grandin
and related css::util::SearchOptions2 The TransliterationModules enum has it's constants spread over multiple UNO enum/constant-collections - TransliterationModules and TransliterationModulesExtra, which means that most code simply uses sal_Int32. Wrap them up into a better bundle so that only the lowest layer needs to deal directly with the UNO constants. Change-Id: I1edeab79fcc7817a4a97c933ef84ab7015bb849b Reviewed-on: https://gerrit.libreoffice.org/34582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-04 06:24:30 +0000