summaryrefslogtreecommitdiff
path: root/sw/inc/docstyle.hxx
AgeCommit message (Collapse)Author
2018-07-19return SfxStyleSheetIterator by std::unique_ptrNoel Grandin
std::shared_ptr overkill here Change-Id: I9bd6ee5b92f9c04e0ca48d25eba99e5c232643c7 Reviewed-on: https://gerrit.libreoffice.org/57570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19convert SFXSTYLEBIT to scoped enumNoel Grandin
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values, it's used an extra bit in SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018 Reviewed-on: https://gerrit.libreoffice.org/53089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-10-12convert GET_POOLID constants to scoped enumNoel Grandin
Change-Id: Ifc54789d12d0b024ed28f13ec78b5c10afa902de
2016-10-04loplugin:countusersofdefaultparams in swNoel Grandin
Change-Id: I65beb17816641cff6a07379b7ba234afe26806b3 Reviewed-on: https://gerrit.libreoffice.org/29488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-08loplugin:constantparam in swNoel Grandin
Change-Id: Ibae4cac28e6ff52298c804519f683017729c07a5
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-10GSoC Writer Table Styles; Create by example; fix undoJakub Trzebiatowski
- Create style by example, tracked by undo; - Fixed delete style, now is tracked by undo Change-Id: Ic39b549b0b970b1b15001d527a82fb26e4a630aa Reviewed-on: https://gerrit.libreoffice.org/27990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-16Remove the :: prefix in ::std for swMark Page
This patch was created using a script Variable name textual alignment is preserved to the same level Change-Id: I6b4858f8059b8cf71fc253e87d6df634362d62e9 Reviewed-on: https://gerrit.libreoffice.org/26306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-07sw UNO Cell Style family, SwXTextCellStyleJakub Trzebiatowski
Cell Family :: getByName Cell Family :: getElementNames Cell Family :: getCount Change-Id: I37d567ee284054f847c704d9fce370d174a0c48c Reviewed-on: https://gerrit.libreoffice.org/25896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-06fdo47267 fix import crashJakub Trzebiatowski
fixed import crash introduced in d4188f643db050c962a937547d19a9a08bd2235d Change-Id: I0bf76fd345438e3cd303ee85c770aa0515c056df Reviewed-on: https://gerrit.libreoffice.org/25887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-04tdf#96099 Remove sfx std::shared_ptr typedefsMark Page
Removed SfxItemSet_Pointer_t and SfxStyleSheetIteratorPtr Change-Id: Ibfa6a79809fdbbe2648dacc02625e620ceaf9bf0 Reviewed-on: https://gerrit.libreoffice.org/25851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01loplugin:constantparam in swNoel Grandin
Change-Id: I68f1594ca3f647d055f5087def74452452f86910 Reviewed-on: https://gerrit.libreoffice.org/23718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06com::sun::star->css in sw/incNoel Grandin
Change-Id: I6ffdb1deaa32156c65f997a1a1056928b7cd863d Reviewed-on: https://gerrit.libreoffice.org/19803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-09-07tdf#91383: sw: prevent style preview from actually creating stylesMichael Stahl
The dialog/sidebar should not actually create styles that don't exist yet, because it messes up Undo and the (unused) styles are then unnecessarily exported to documents. Due to Writer's ... unusual SwDocStyleSheet class this is a bit tricky. Add a new function GetItemSetForPreview() and use it from the style preview code. The implementation does not use FillPhysical so will temporarily create and then delete any non-existing styles. Skip page and numbering styles for now since they don't have a useful preview. (regression from ca95307638207db5d662059aa61594151a13e927) Change-Id: Id6ee30ea467fc24c991547a4c23a9ce14fdd86c7
2015-07-22loplugin:unusedmethods sw(part2)Noel Grandin
Change-Id: Ib95638267c5a7df73ccdd179dd62ac7c9a53a5e4 Reviewed-on: https://gerrit.libreoffice.org/17262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06loplugin:unusedmethods svlNoel Grandin
Change-Id: Ic136cce6abef44291b7236a6d709f0eee391f311 Reviewed-on: https://gerrit.libreoffice.org/16784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Ia2b137e0167966a3d0b60f3c642a106834da8f1c
2015-01-03boost::unordered_map->std::unordered_mapCaolán McNamara
Change-Id: I2c65709cda6f10810452dfb8aa1a247cb3a5564f
2014-11-16Remove sal_True/sal_False from code and comments in sw includesMatteo Casalin
Change-Id: Icfbbae898749196e27199802ec728417d5205bc5
2014-07-02fdo#76260 - switch O(N^2) lookup in SwStyleSheetIterator to O(N)Michael Meeks
The SwStyleSheetIterator is called a lot on import of DOCX; potentially another N times - so this change saves 15%+ of load time, 81bn cycles of 457bn to startup and load the document. Change-Id: I70ef0f1ebd3f4e05519be68c8a67f65b00f54719
2014-06-30sw: better encapsulate StyleSheet iterator's list.Michael Meeks
Change-Id: I4fc06c739009a4754282854c4a0fce633213e50f
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-27Remove ASCII art and useless comments from sw moduleChris Laplante
Change-Id: I3ba4ac78fd4810e006b1034bbe7c28b1803895d2 Reviewed-on: https://gerrit.libreoffice.org/9494 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-04-30sw: sal_Bool->boolNoel Grandin
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-04svl/style.hxx: sal_Bool->boolNoel Grandin
looks like I missed a couple of methods in my earlier conversion Change-Id: I07871a451bb5954feab57de0af4f7d0678f9a7b3
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-02-27Remove visual noise from swAlexander Wilms
Conflicts: sw/inc/unodraw.hxx sw/inc/unoframe.hxx sw/sdi/swriter.sdi sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unoparagraph.cxx sw/source/filter/ww8/rtfexportfilter.cxx sw/source/ui/inc/unotxvw.hxx sw/source/ui/lingu/hyp.cxx sw/source/ui/lingu/sdrhhcwrap.cxx sw/source/ui/uno/swdetect.hxx Change-Id: Ic0a3fb2392187c277c9b36915ffb10dcf0317908 Reviewed-on: https://gerrit.libreoffice.org/8322 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-03Remove SW_DLLPRIVATE -> SAL_DLLPRIVATE indirectionStephan Bergmann
Change-Id: I5498266e5496f196d420a2897b804da8599917b5
2013-11-06SwDocStyleSheet: add getter / setter for InteropGrabBagMiklos Vajna
Change-Id: I4163633f11c75cf9f12485212f563c8f53af38f7
2013-11-05fixincludeguards.sh: swThomas Arnhold
Change-Id: I8e0889200d1a1c36e53022a74792728efd66c2fc
2013-08-21String to OUStringMatteo Casalin
Change-Id: Ibbd6cfd969dd5ba3f839f48ff557d6c850ea3ab2 Reviewed-on: https://gerrit.libreoffice.org/5557 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-08-08boost::ptr_vector<OUString> considered sillyMichael Stahl
Change-Id: I85c3d8a0e6b64c7a8dcf66a3dfde25151718c4d9
2013-08-08sw: convert rest of SwStyleNameMapper to OUStringMichael Stahl
Change-Id: I54d1a31b86e60ceb9070f502df305d75bcfa23d9
2013-07-27Revert "SfxStyleSheetBasePool: remove internal iterator"Michael Stahl
This reverts commit 3a46d91f8de420f38dd763028e91229c846dff52. This breaks the Stylist, not sure why (does it depend on something setting the search flags before?) so revert for now. Change-Id: Ia50feeebae8bf852c827e4f270e81e9f08d2b1ac
2013-07-27SfxStyleSheetBasePool: remove internal iteratorMichael Stahl
The clients always start with First() anyway so they might as well use external iterators, which makes calling First() in certain situations just so the internal iterator is invalidated unnecessary. Change-Id: I0948576c20410136448e8b85311c21a257469bc7
2013-07-27SfxStyleSheetBasePool::Make: remove nPos parameterMichael Stahl
The only caller who could have used a non-default value was SfxObjectShell::Insert(). Change-Id: I18174a54a9c0246850dc6347d0147e8640ad101d
2013-07-27fdo#67303: sw: speed up setting IsHidden property on stylesMichael Stahl
Importing an ODF document with 4089 styles is ridiculously slow, spending most of the time in SwStyleSheetIterator::First() to reset an existing iterator. Since the SwStyleSheetIterator can handle the case when First() has not been called anyway, just add a new method that resets the bFirstCalled flag, which takes next to no time. (regression from a0dcf961879ab644a52f801f65466756cb144b72) Change-Id: I8741b4c0cd51f8c244462ce28a754abc427d0df3
2013-07-07module svl: all String and some bool and related clean-upNorbert Thiebaud
Change-Id: I36eb559fa58dbe75384b7119c788af0048813aed Reviewed-on: https://gerrit.libreoffice.org/4733 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-04-10Resolves: #i120077# Memory leak fixed in ScXMLFontAutoStylePool_ImplArmin Le Grand
also checked and fixed memory leaks caused by not deleting SfxStyleSheetIterator instances. Found by: Chao Huang Patch by: Chao Huang Review by: alg (cherry picked from commit aee8221b3fbe64d8e88aa3a1b630214807cd86f0) Conflicts: sc/source/core/data/stlsheet.cxx sc/source/filter/xml/xmlfonte.cxx sfx2/source/doc/objcont.cxx svl/source/items/style.cxx sw/source/core/unocore/unostyle.cxx Resolves: #120077# ALG: Reverted r1354011, adapted all usages of SfxStyleSheetIterator and CreateIterator to use boost::shared_ptr (cherry picked from commit ec1819f218b94bed1556653e1b2b816a65da61ef) Conflicts: sc/source/core/data/stlsheet.cxx sc/source/filter/xml/xmlfonte.cxx sfx2/source/doc/objcont.cxx svl/inc/svl/style.hxx svl/source/items/style.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unostyle.cxx 26937d4d65562b14de0aea59a7b01cc4334f73c1 Change-Id: If99bf3ee399292ec269d68b36ee78ed63f033215
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
generated by cgit (git 2.34.1) at 2024-08-13 09:48:30 +0000