summaryrefslogtreecommitdiff
path: root/sw/inc/docufld.hxx
AgeCommit message (Collapse)Author
2023-01-18tdf#119229 docx: Preserve w15:paraIdParent attribute in commentsExtendedParis Oplopoios
w15:paraIdParent attribute indicates that the comment is a reply to the value id Change-Id: I9e6eca6a656594c956629c1434b8e5c3aa573c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145314 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-11use more string_view in swNoel Grandin
Change-Id: Ibefb8549834ba5011286e3221f1ae276e2c0c0bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-04clang-tidy modernize-pass-by-value in swNoel Grandin
Change-Id: Ie5c250c64f95e649d33d3f3da7b54e81a4b81d0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137781 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-24comments: reassign ID when copy commentPranam Lashkari
reassigning new ID will make all the comments have unique IDs this will also ensure there is no mixup when working with comments ID Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I94b433130c68354ab94d4d6e9b86751038b31af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134686 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 0d3bba5c383ef8b9f62c121a26fed4445c813949) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134792 Tested-by: Jenkins
2022-04-16use more string_view in swNoel Grandin
Change-Id: Iaf4db41d913dde13ea1ceb3fbbb3dafc21f90d24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-08tdf#147861 sw ms export: DI_SUB_MASK must exclude FIXED nowJustin Luth
This is a follow-up to 7.4 commit daef39352b008fc1f903fd8c09288ff5e772fa42 There is only one place in which DI_SUB_MASK is used, so I'm just changing it to what it could have always been, since it never was actually used to mask out DI_SUB_FIXED. Otherwise, I might have made this a MASK2 or whatever. The issue here is that AUTHOR was not being recognized when it was paired with FIXED, so every FIXEDFLD was ended up being considered as a date/time. In practice, this didn't really change anything because bWriteExpand already ignored any of these areas of the code. It is only when I turn off bWriteExpand as I implement fixes that I am seeing the wrong field type being created. And regardless, since the field is FIXED, the visible content remains the same anyway (until someone in MS Word refreshes the field with F9). Both Author and date have the same field name ":Created" so I couldn't super easily test this. Change-Id: Icd2d0be2d3fbe24dc4763e0e25801569bcca471b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132660 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-29use virtual function call for dynamic dispatchBjoern Michaelsen
... as it is around since the dawn of C++ and should be stable -- certainly more stable and less errorprone that manual typetagging. Change-Id: I5dfe2ce40c2334dc8fe60705d358779fa4bf1586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124131 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-08-16pass OutlinerParaObject around by valueNoel Grandin
since it uses o3tl::cow_wrapper, so it is really just a wrapper around a pointer, no point in allocating it on the heap Remove assert in SdrText::SetOutlinerParaObject, which was bogus anyhow, because it was comparing pointers, not deep equality. And since we are now being more efficient and avoiding copying of the internal data in OutlinerParaObject, we hit this assert. Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-07SwRefPageSetFieldType: Modify no moreBjoern Michaelsen
Change-Id: I313237069eeafd5913468e18e2eb34e9ef185302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107320 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-10-05Evaluate family never passed a null SwDoc*Caolán McNamara
ditto: SwTemplNameFieldType ctor lcl_RestoreRedlines never passed a null SwDoc* lcl_InsAttr SwFileNameFieldType ctor SwRefPageGetFieldType ctor SwJumpEditFieldType ctor SwPostItFieldType ctor SwScriptFieldType ctor SwMacroFieldType ctor Change-Id: I61fa1b0e5fba16f9d1be1880dde6c487dca88374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-21sw: prefix members of SwGlblDocContent, SwIntrnlRefLink, SwPostItField ...Miklos Vajna
... and SwTextAPIEditSource See tdf#94879 for motivation. Change-Id: If9af8e5fb5d750547a1be9229f69bb79ae4bb0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103080 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-13Revert "loplugin:constfields in sw"Noel Grandin
This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea. Change-Id: I527e9366b05e8a20633720e334395b285991c524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11tdf#39674 Translate German variable namesJohnny_M
Titel -> Title Thema -> Subject In "strings.hrc", translated the defines, but kept the their NC_(...) translation references to prevent a need to update translations. Change-Id: Ie8b4a94376495d5e148bc50dcc9902e805deff0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-04loplugin:finalclasses in sw/incNoel Grandin
Change-Id: I084502d8c5607f103ef987b54252ef95341f0bef Reviewed-on: https://gerrit.libreoffice.org/81981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-20convert SwFieldTypesEnum to scoped enumNoel Grandin
clamp it to sal_uInt16 since we convert it that type when passing it via SfxItemSet Change-Id: I4b7bd4ba5e19015af357d5a81a629239451d71e4 Reviewed-on: https://gerrit.libreoffice.org/79289 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-24loplugin:returnconstval in swNoel Grandin
Change-Id: I15d8553bff7528f690ff92bee75d6a67037c0adf Reviewed-on: https://gerrit.libreoffice.org/78062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25tdf#119228 Add storage and serialisation for the Resolved flagScott Clarke
Change-Id: I0278588dc533378104e544d05b60583c85271f6a Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75858 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...Stephan Bergmann
...with latest Clang trunk towards Clang 9. All the no-longer necessary hacks are made conditional on new NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is still set for UBSan builds with older Clang on Linux (but which should eventually be purged). Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, as building with UBSan instrumentation can generate references to RTTI symbols from additional places like outside a dynamic library that used to hide those symbols by default (but used to not hide them for old UBSan builds thanks to the -fvisibility-ms-compat hack). The odr-violation suppressions in solenv/sanitizers/asan-suppressions (which is not referenced from anywhere in the code base, but meant to be included in an ASan/UBSan build's ASAN_OPTIONS env var) are also no longer needed when NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false. Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a Reviewed-on: https://gerrit.libreoffice.org/70829 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-28return by unique_ptr from SwFieldType::CopyNoel Grandin
Change-Id: I145b55c9cd62a5853c0dd26cc9b805b9f3a0e436 Reviewed-on: https://gerrit.libreoffice.org/69854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28use the xmlTextWriterPtr typedef consistentlyNoel Grandin
this is the single biggest chunk of stuff my upcoming paramtypedef loplugin will warn about, so do it separately Change-Id: I412e69e76406d6d947101885d4cd92c65e021508 Reviewed-on: https://gerrit.libreoffice.org/68486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15sw_redlinehide_3: add second result to SwRefPageGetFieldMichael Stahl
With the old Hide implementation this actually would take the last set-field in the redline nodes array section to set the value at the start of the document, because there was no check for that; surely that was wrong... Change-Id: I63fb89ccf0067f1fe375226d6d04cafb6485c5d6
2018-11-15sw_redlinehide_3: transport layout from ExpandField() to Expand()Michael Stahl
While at it, rename that to ExpandImpl() so it's unique. Change-Id: I217deb72b4dfdca777e28e18ff56e49863e66640
2018-11-14tdf#42949 Fix IWYU warnings in include/svl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ide75232858599c275e023c2300201090acd22307 Reviewed-on: https://gerrit.libreoffice.org/63237 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-10-03loplugin:constfields in swNoel Grandin
Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f Reviewed-on: https://gerrit.libreoffice.org/61177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28Fix DI_TITEL -> DI_TITLEAndrea Gelmini
It passed "make check" on Linux. Change-Id: I3239622286c07914f88727ffdbb0be8d2ca724ea Reviewed-on: https://gerrit.libreoffice.org/61084 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-10pass SwField around by std::unique_ptrNoel Grandin
Fix leak in SwFieldPage::InsertField, where it interacts badly with SwFieldMgr::UpdateCurField The awkward return std::unique_ptr<SwField>(pTmp.release()); code is because clang 3.8.0 doesn't seem able to do auto-upcast of std::unique_ptr. Change-Id: I05b748e9cda145fd972a01bfa343239df32368b9 Reviewed-on: https://gerrit.libreoffice.org/57197 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwPostItFieldNoel Grandin
Change-Id: I1d048ac400d6a929a840bcb8f0df52be528c0a5b Reviewed-on: https://gerrit.libreoffice.org/56623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-22tdf#117171 support localized page number numbering stylesLászló Németh
in ordinal and cardinal number names and ordinal indicators. Change-Id: I35fa9c5c31b31f112ac0bb7feb5d310daca819e1 Reviewed-on: https://gerrit.libreoffice.org/54553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-04-28loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I84868b3115c534a8240394283cc3beedf8cb3a80 Reviewed-on: https://gerrit.libreoffice.org/53543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-11use sw::WriterMultiListener instead of SwDepend in SwJumpEditFieldTypeBjoern Michaelsen
Change-Id: I93f6dbf4eda561d68146be714e633576394d5a75 Reviewed-on: https://gerrit.libreoffice.org/49566 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Tested-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-02-27sw: prefix members of SwScriptField, SwTemplNameField and SwWrongListMiklos Vajna
Change-Id: Ia82df7c6c8260c90f76d77355b70b8589978b9c2 Reviewed-on: https://gerrit.libreoffice.org/50341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-19sw: prefix members of SwPostItField, SwRefPageGetField and SwRefPageSetFieldMiklos Vajna
Change-Id: I37f72fd65ff7d9e6c992f92e770f0897f80aaf7b Reviewed-on: https://gerrit.libreoffice.org/49961 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-15Fix some IWYU warningsMiklos Vajna
Change-Id: I49b5e3a9e8b91baace9f3b3d4f0ac9d8531d5abe Reviewed-on: https://gerrit.libreoffice.org/49782 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-12sw: prefix members of SwJumpEditFieldType, SwMacroField and SwPageNumberFieldMiklos Vajna
Change-Id: Ib02b05dfa1f39c43c69bcb968806dec67d02082b Reviewed-on: https://gerrit.libreoffice.org/49576 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-05sw: prefix members of SwHiddenParaField, SwHiddenTextField and SwJumpEditFieldMiklos Vajna
Change-Id: I23a5ea2d85f5f22f48a2c069d84929b4d70f62a0 Reviewed-on: https://gerrit.libreoffice.org/49225 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-29sw: prefix members of SwExtUserField, SwFileNameField and SwFileNameFieldTypeMiklos Vajna
Change-Id: I0722417149c9fbcd2aee3491c841c036a5677c8d Reviewed-on: https://gerrit.libreoffice.org/48807 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22sw: prefix members of SwDocInfoField, SwDocStatField and SwDocStatFieldTypeMiklos Vajna
Change-Id: I8c6e618266f56148df385eb140668730d9b06ed3 Reviewed-on: https://gerrit.libreoffice.org/48293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-15sw: prefix members of SwAuthorField, SwBreakIt and SwCombinedCharFieldMiklos Vajna
Change-Id: Ic277b91a75602b0997ff68feb46a9cad9dae4e46 Reviewed-on: https://gerrit.libreoffice.org/47891 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19loplugin:unusedmethodsNoel Grandin
Change-Id: I3ffd9142fed98e4df75c2c28f8a025be3e8eb803 Reviewed-on: https://gerrit.libreoffice.org/46687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14tdf#43569 DOC input: insert ConditionalText field instead of field marksSerge Krot
In case of IF field input inside DOC document the ConditionalText field should be created instead of the two field marks that leads to handling of unsupported field routine. Added unit tests. Change-Id: I31875d8e6be7f536766ef640a366b843f7e0532c Reviewed-on: https://gerrit.libreoffice.org/46022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-27loplugin:countusersofdefaultparams in sw (3)Noel Grandin
Change-Id: I2657c1146bc377135e13116f32dbf518f8815417 Reviewed-on: https://gerrit.libreoffice.org/45318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04loplugin:constparams in sw part3Noel Grandin
Change-Id: I05ad3204af4e6ec3c832b185a1b35fdb75a229b2 Reviewed-on: https://gerrit.libreoffice.org/40760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02loplugin:checkunusedparams in swNoel Grandin
Change-Id: I8a6b2647375a54720cd9fd765cc51c9ff43c8190 Reviewed-on: https://gerrit.libreoffice.org/40682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24sw: non-functional minor cleanupAshod Nakashian
Change-Id: I94e34214e49de02e0922f85d5e799926a000d8e3 Reviewed-on: https://gerrit.libreoffice.org/40344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-21Eliminate DateTime::operator+=() and -=() with POD typesEike Rathke
And make some tools::Time conversion ctors explicit to catch more oddities like automatic conversion from sal_Int64 that might be unintentional. Change-Id: If275297d86d6657544c056a712b862523e310e44 Reviewed-on: https://gerrit.libreoffice.org/40275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03use SvxExtNumType in SvxNumberTypeNoel Grandin
and follow the rabbit trail, fixing various other types in the process Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d Reviewed-on: https://gerrit.libreoffice.org/34814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-17 09:44:14 +0000