summaryrefslogtreecommitdiff
path: root/sw/inc/shellio.hxx
AgeCommit message (Collapse)Author
2023-10-03replace ErrorInfo with simpler mechanismNoel Grandin
Instead of returning ErrCode class everywhere, return a new class ErrrCodeMsg, which combines an ErrCode with the other parameters that are used to control the error reporting. I do not change everything that uses ErrCode here, I started from SfxBaseController/SfxMedium and worked outwards. This change serves two purposes (1) Replace the extremely whacky ErrorInfo mechanism we were using to smuggle information into the error handler reporting mechanism with a very straightforward approach of just combining it into the error class. (2) Allow us to capture the source location that produced the error, which makes debugging the source of a problem soooo much easier. Change-Id: I978b8f00c9851b41a216c7ebdef2ef94251d5519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-11Drop Writer::OutLongMike Kaganski
... and use SvStream::WriteNumberAsString, replacing Write[U]Int32AsString Change-Id: I10e56c532494239ed40ec01b6184dd06db463a0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150193 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-06tdf#154000 tdf#70423 sw: fix crash/freezing with huge text filesLászló Németh
It was not possible to load or edit text files with very long lines any more, because removed wrapping of the lines resulted freezing and crash. This reverts commit 745898eb2af2686ffbdfdc0e44984db67b172a59 "tdf#70423 Remove txtimport break in 10k chars line", keeping only its unit test. Fix also tdf#70423 by increasing the wrap limit from 10000 to 250000 characters, which still permit to load e.g. 50 MB character or longer text lines, and to edit 5 MB or longer text lines without crash or freezing. Details: trying to load a relatively short 76 MB character length text line shows a non-linear slowing down during the load, resulting program crash after freezing 10 minutes. Now this file is opened within seconds again, allowing to modify, select and copy of the text before the full load of the document (with linear speed). Loading a much shorter 5 MB character length text line resulted an unusably slow editing previously: waiting half minutes for changing, selecting or copying text parts. Manual test Create a text file with a 76 MB character long line, and open it: $ seq 10000000 | tr '\n' ' ' >numbers.txt $ soffice numbers.txt Note: the reverted commit had also a paragraph limit exceeded error using unlimited paragraph length, because that is limited in 4 GiB characters since version 4.3, see tdf#30668 and commit ba27366f3d6bc6b209ecd5c5cb79a9ee5315316a "Resolves: #i17171# Writer paragraph cannot be longer than 65534 characters". Change-Id: If91e340a8aac4d4ebc4097b19cfa854b5659da3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148169 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-02tdf#70423 Remove txtimport break in 10k chars lineRadhey Parekh
This patch fixes the tdf#70423 which is an unexpected line break for ~10k characters. The fix consists of removing part of the code that creates a new paragraph when reaching ~10k characters. The limit was not exactly 10k characters, because the code tried to break at space character when reaching around 10k-100 characters. A test is also created, which can be checked by invoking: make CPPUNIT_TEST_NAME="testTdf70423" -sr CppunitTest_sw_txtimport The test checks that there should be exactly 1 paragraph with 30k characters inside it. Change-Id: Ic37c2b6eb89b52b533e34dd117b9635b9608bab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121548 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-28Resolves: tdf#147203 allow dnd between autotext categoriesCaolán McNamara
restores various methods removed as unused since original regression at commit 4830a1bae89a8ed60696503e315ffd42c70dff74 Date: Thu May 30 16:12:23 2019 +0100 weld SwGlossaryDlg Change-Id: I5c6186b9f45f3c0957926de2861eb6bc76dda73d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-14tdf#151605 Add option to not include hidden text in ASCII filterSamuel Mehrbrodt
When setting this option, hidden text will not get exported/copied to clipboard. Change-Id: Id31aafc28ffb61a81bdc1412892f9e7997512f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141551 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-10-11use more string_view in swNoel Grandin
Change-Id: Ibefb8549834ba5011286e3221f1ae276e2c0c0bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-04clang-tidy modernize-pass-by-value in swNoel Grandin
Change-Id: Ie5c250c64f95e649d33d3f3da7b54e81a4b81d0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137781 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-13loplugin:stringviewparam whitelist some more functionsNoel Grandin
for which we have o3tl:: equivalents Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-04use string_view in comphelper::string::splitNoel Grandin
Change-Id: I4afe8aee85905ee35ba195b00b454aefa0ba38af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-21introduce SwNodeOffset strong typedefNoel Grandin
for indexing into node children. Replaces various usage of sal_uLong, tools::Long, sal_uInt32 with an underlying type of sal_Int32. Also add a NODE_OFFSET_MAX constant to replace usage of ULONG_MAX Change-Id: I2f466922e1ebc19029bb2883d2b29aa4c0614170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18loplugin:passstuffbyrefNoel Grandin
Change-Id: I4f01eb3842ef198f02af274f54afb2760c820a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21tdf#137469 Add option to disable hidden text in text filterOleg Shchelykalnov
Adds sixth filter option to text filter. If true (default) filter save hidden text to output file. Change-Id: I71202653b3cc4e50ddd06a665f5a718f875f6d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20use tools::Long in swNoel
Change-Id: I44be72b3a9b14823ec37a3c799cffb4fb4d6e1de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: I3c8ca72b2b41a4f82ee20cbe025b41425f32e715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104028 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-19compact namespace: swNoel Grandin
Change-Id: Ib1303380e6b55b3b3f8a3d513956f9e77ae5961e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07Typo: pargraph->paragraphJulien Nabet
Change-Id: I7749951d829eb8aaeacdca0fd66d41cf9d6a1613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98251 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-09compact namespace in swNoel Grandin
Change-Id: Ie2c3e3f95a687b12b89bcfc5cad44fb7a1d4568f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in sw"Noel Grandin
This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea. Change-Id: I527e9366b05e8a20633720e334395b285991c524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-10sw: prefix members of SwExtTextInput, SwLineNumberInfo, SwWriter and ...Miklos Vajna
... SwgReaderOption See tdf#94879 for motivation. Change-Id: Ib44eaa1adbc731499d22b0bf538380b8bc0cc4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88357 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-03sw: prefix members of StgWriter, SwAsciiOptions, SwReader and SwTextBlocksMiklos Vajna
See tdf#94879 for motivation. Change-Id: I5e77069f678f39d52b3ece825bd2c0444fa40584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87843 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-27sw: prefix members of StgReader, SwAuthEntry, ...Miklos Vajna
... SwChartLockController_Helper and SwInterHyphInfo See tdf#94879 for motivation. Change-Id: I76b5380eefef63c2c02635ac31eca171906125b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87486 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-12-23XStyleLoader::loadStylesFromURL Allow loading from streamSamuel Mehrbrodt
Change-Id: Iab0c301096118203466dd91c724c25f1283a0488 Reviewed-on: https://gerrit.libreoffice.org/85392 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-07ofz#18563 test case for assert/crashCaolán McNamara
Change-Id: Idb98b7fae03bc31fc050519a7b0720208adeb843 Reviewed-on: https://gerrit.libreoffice.org/84556 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-04loplugin:finalclasses in sw/incNoel Grandin
Change-Id: I084502d8c5607f103ef987b54252ef95341f0bef Reviewed-on: https://gerrit.libreoffice.org/81981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in swNoel Grandin
Change-Id: I73c3c6d2165287d2d581a04b23b1d3b48166a488 Reviewed-on: https://gerrit.libreoffice.org/79780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26loplugin:virtualdead in sw(2)Noel Grandin
Change-Id: Ib948148fa21d595faa8a4a86d4f47243755885ee Reviewed-on: https://gerrit.libreoffice.org/79588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-10sw: fix ~SwIndexReg asserts on ODF export of ooo83072-1.odtMichael Stahl
It is now possible that the stupid redline-moving code deletes the first node in the document, and there are 2 SwPaM that point to it, Writer::m_pCurrentPam and local pPam in SwWriter::Write(). So i thought it should be quite trivial to just use SwUnoCursors in these cases, but it required a bit more keyboard bashing than expected. (regression from beec1594587d0bf1ea2268f9a435c948b5580278, which i didn't really intend to push and am not sure if it's really a good idea but whatever...) Change-Id: Ia5c18d67af8760664517a4b7ee62ef3e4a417686 Reviewed-on: https://gerrit.libreoffice.org/77225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12loplugin:unusedmethodsNoel Grandin
Change-Id: I42667e8483d2cb4363227344faca3899bd95d424 Reviewed-on: https://gerrit.libreoffice.org/73824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04expand out SwRead typedefNoel Grandin
not adding any value Change-Id: I8e7bc1150b4bf7e9431e522be3807007a52f65c4 Reviewed-on: https://gerrit.libreoffice.org/68667 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-13Fix tdf#44291. Allow saving text without byte-order mark.Martin van Zijl
Change-Id: Ib16a4f37adcb2cfb3d2af9b6af21a4b32e4ae54c Reviewed-on: https://gerrit.libreoffice.org/50388 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-03loplugin:constfields in swNoel Grandin
Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f Reviewed-on: https://gerrit.libreoffice.org/61177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-23coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: Id6dad66b3c55e5b3049f57e65c857db5abce50b1 Reviewed-on: https://gerrit.libreoffice.org/60901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19sw_redlinehide_2: hide redlines in ascii filter tooMichael Stahl
It's called from SwEditShell::GetSelectedText() :-/ Change-Id: Ie26c7abd1bc0714bb4c1d49eecb7c869d947c276
2018-07-21Fix typosAndrea Gelmini
Change-Id: Ifc804e33afa160943d7b5634f8ccf4e3af4d26e5 Reviewed-on: https://gerrit.libreoffice.org/57806 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-16convert SW*READER constants to scoped enumNoel Grandin
Change-Id: I7cf635e238a16e7ec96e585e6eb5e2e9c39b545a Reviewed-on: https://gerrit.libreoffice.org/57497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23sw: prefix members of ReaderMiklos Vajna
Change-Id: Ia4210410047ce3b37113cfe0d4dff5bb7122baf2 Reviewed-on: https://gerrit.libreoffice.org/53307 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18sw: fix some IWYU warningsMiklos Vajna
Change-Id: Idff219e1c8f18adaa0f445a5469650c7793cae3a Reviewed-on: https://gerrit.libreoffice.org/53066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-16sw: prefix members of WriterMiklos Vajna
Change-Id: Iee39219eb9de089ded9658eb75fcf258c3bd951d Reviewed-on: https://gerrit.libreoffice.org/52931 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-09sw: fix some IWYU warningsMiklos Vajna
Change-Id: Idb8ad6cda75b7112280ae71b4340d0187a602794 Reviewed-on: https://gerrit.libreoffice.org/50974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-08sw HTML import: avoid loading the Writer/Web template for the Writer filterMiklos Vajna
The share/template/common/internal/html.stw template we have is for Writer/Web, loading that into Writer is questionable at best. Also it means that the outline numbering of the heading styles is not set, which is a problem, as the sw HTML import only sets the style, not the outline numbering. Change-Id: I86d11d8a5744c3c2ca71b03fd41a24d3f88ea333 Reviewed-on: https://gerrit.libreoffice.org/49381 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-02loplugin:passstuffbyref improved return in swNoel Grandin
Change-Id: I4484ac461761e4c46364b4f473c7e62f8ec72103 Reviewed-on: https://gerrit.libreoffice.org/47243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04add html to fftesterCaolán McNamara
Change-Id: I85c2ce10ff6142d04310f834b16b2ded474e7a34 Reviewed-on: https://gerrit.libreoffice.org/45814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30sw: std::vector<OUString*> considered sillyMichael Stahl
Change-Id: Ie5141a01b1a63c083d5fce1842a35a9a4b0d36e3
2017-10-23loplugin:includeform: swStephan Bergmann
Change-Id: Ifc3c4c31a31ee7189eeab6f1af30b94d64f2f92a
2017-09-13Actually no need to make GetASCWriter public.Jan Holesovsky
Change-Id: I6f0f18629c6a61b6a4c52c2b16cc7b45525a5259
2017-09-13tdf#112191: Don't export bullets when only one paragraph is selected.Jan Holesovsky
Change-Id: Ibea54f857e78a850ea05643743884ae2157dae57 Reviewed-on: https://gerrit.libreoffice.org/42202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-08-04loplugin:constparams in sw part5Noel Grandin
Change-Id: I6c33709aa407ccb3eee7026ab9b40dc4257de209 Reviewed-on: https://gerrit.libreoffice.org/40769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04loplugin:constparams in sw part4Noel Grandin
Change-Id: Ic42b2691869b61ba906222db893e284d8b9c39c1 Reviewed-on: https://gerrit.libreoffice.org/40767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-14 15:45:46 +0000