summaryrefslogtreecommitdiff
path: root/sw/inc
AgeCommit message (Collapse)Author
2017-02-22loplugin:unusedfieldsNoel Grandin
Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21convert writer changes menu to .uiCaolán McNamara
Change-Id: I30a957f91c3faca5e16a70efce08579ac3368bdf
2017-02-16replace SwFootnoteAdj with css::text::HorizontalAdjustCaolán McNamara
to ensure the retention of the values the code depends on Change-Id: I3baafc1ee66481518aec5928585464c8a214be16
2017-02-16crashtesting: enum values need to not changeCaolán McNamara
in SwPageFootnoteInfoItem::PutValue (sw/source/uibase/utlui/uiitems.cxx) aFootnoteInfo.SetAdj((SwFootnoteAdj)nSet); │ MID_LINE_ADJUST takes a sal_Int16 and casts it to SwFootnoteAdj so the implicit 0 and 2 for Left and Right needs to be retained Change-Id: I87725550cd698df8155508c9976d6d2304af05be
2017-02-14Revert commits that caused instability on the Linux debug tinderboxBjoern Michaelsen
Revert "DYING_FLYFRAMEFORMAT not needed anymore" This reverts commit 837545feb63f31095d69d006aeda520637c3bc8c. Revert "give SwFlyDrawContact a clear owner: SwFlyFrameFormat" This reverts commit 4ae93f7d3b063d13ff757884444a468212227ef9.
2017-02-14DYING_FLYFRAMEFORMAT not needed anymoreBjoern Michaelsen
Change-Id: Id9ded246752903f692c0f8254a258fada299d9bf Reviewed-on: https://gerrit.libreoffice.org/34142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-14give SwFlyDrawContact a clear owner: SwFlyFrameFormatBjoern Michaelsen
Change-Id: Ida24ef9ae65ae8658645496369673d886e0935cc Reviewed-on: https://gerrit.libreoffice.org/34141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-13convert SwCalcError to scoped enumNoel Grandin
and drop unused CALC_VARNFND and CALC_WRONGTIME enumerators Change-Id: I415960180b074ee4c54c47e69962fe2ca1be42e0 Reviewed-on: https://gerrit.libreoffice.org/34195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-13Fix typosAndrea Gelmini
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-13Revert "convert DBConnURIType to scoped enum"Noel Grandin
This reverts commit f0c57266709509ae24cfb1615d136263fb1e8d60. Missed the WIN32 only code where the JET and ACE enumerators were being used.
2017-02-13convert CharCompressType to scoped enumNoel Grandin
and move it to svl, where it belongs Change-Id: Ic4d846419dfe2dd85de5ade8ed1a041867bbf1dc
2017-02-13convert IsAttrAtPos to scoped o3tl::typed_flagsNoel Grandin
Change-Id: Ie3a361a96201cb1a0ab446bcf77b7c0e79e05e89
2017-02-13convert DBConnURIType to scoped enumNoel Grandin
and drop unused enumerators DBCONN_MSJET DBCONN_MSACE Change-Id: I4036b8f98488bac8e38094320281aa41f42e9787
2017-02-13convert CurRectType to scoped enumNoel Grandin
and drop read-only enumerators RECT_OUTTABSECTION_PRT RECT_HEADERFOOTER_PRT Change-Id: I2d7d159cf5f1a2022c015e37df4aa71cae1e266c
2017-02-13convert Master_CollConditions to scoped enumNoel Grandin
And drop read-only enumerator USRFLD_EXPRESSION. And drop the bitfield values, this enum is never used as a combination of flags. Change-Id: Iaae1b30439a7d1bb5d3526d9aee52dbc78e635dc
2017-02-13convert SwFootnoteAdj to scoped enumNoel Grandin
and drop read-only FTNADJ_CENTER enumerator Change-Id: Id059a8e84aed703a86f0ef4d66c24e9401dfc3a9
2017-02-13convert SectionSort to scoped enumNoel Grandin
and drop read-only SORTSECT_NAME enumerator Change-Id: Ibb192b0857161560a666e6ffdc2125bc6fc552c5
2017-02-13convert SplitTable_HeadlineOption to scoped enumNoel Grandin
Change-Id: I5a9ea036b8827a84e646488b2b57012ebadd4d0a
2017-02-13convert ShellModes to scoped enumNoel Grandin
and drop read-only SHELL_MODE_DRAW_CTRL enumerator Change-Id: I2ccaeb492912c876b89ff9b5dccaa99e28a268b7
2017-02-12Typo: NUMBULET->NUMBULLETJulien Nabet
Change-Id: Ib8d874d77e1a1bb9ef6630f3f2f62c8c8c92e82b Reviewed-on: https://gerrit.libreoffice.org/34157 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-10tdf#105288 MM wait until all emails are sendJan-Marek Glogowski
Seems mail merge is now much faster then the sending of the merged documents via email. This is why the attached workaround patch to the tdf#103919 bug report, which simply sleeps after queuing a new message, helped solving the problem. It slows down the mail merge and gives time to the mail dispatcher thread. But we actually want to wait until all mails are send, so we have to add a listener and wait for the mail thread to become idle. This listener also allows us to cancel further mail merge when an SMTP error has occured. Change-Id: I9d13bcd8f0d0ff084b20d72ab96f70afa3a764ba Reviewed-on: https://gerrit.libreoffice.org/33989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-02-09use proper message passingBjoern Michaelsen
Change-Id: Ic41c7acc73c2d275dfdb6b2ffcbb24fba5f8be72 Reviewed-on: https://gerrit.libreoffice.org/33980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-08remove unused constants from RES_MSGNoel Grandin
Change-Id: I3eaa1f051440a91c8c5b4996e28dea4e0d3933e5 Reviewed-on: https://gerrit.libreoffice.org/33994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07flatten ShellResource resourceCaolán McNamara
Change-Id: Ib071a21778289f4dc68273cb305d38bf260a31a7
2017-02-07revert unready stuffCaolán McNamara
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
2017-02-07flatten ShellResource resourceCaolán McNamara
Change-Id: I6094f86eb7da89ba5e21be909417b23f9f375351
2017-02-07convert CursorType to scoped enumNoel Grandin
and drop unused CURSOR_INVALID constant Change-Id: I190908a03317f93d247c0a9c806c70bb286b8ecb Reviewed-on: https://gerrit.libreoffice.org/33964 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06lok: Emit modify comment callback when anchor changesPranav Kant
Change-Id: Ibe4a66b93768eb446a04cab8cfdd4bdebee13d1f Reviewed-on: https://gerrit.libreoffice.org/33878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-06lok: comments: emit add callback after layout finishesPranav Kant
Change-Id: Ie6eba244dd5eb78813185f8c7aceed841d05d48b Reviewed-on: https://gerrit.libreoffice.org/33877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-05lok: Send complete anchor rectanglePranav Kant
... instead of just sending the X, Y coordinates Change-Id: Ie87b252ebfd64e806e1e5f66cfc27e77282cbaab Reviewed-on: https://gerrit.libreoffice.org/33875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-05tdf#103258 Add contextual edit footnote endnote command.Gulsah Kose
Change-Id: I68126d2ec8b8dfb12c45ce577d110be2b94a4e33 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/33803 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01use message passingBjoern Michaelsen
Change-Id: Idc5fbdcd6d1a11b7607995c1d492ffc829879566 Reviewed-on: https://gerrit.libreoffice.org/33718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30tdf#102132 Add contextual edit region uno command.Gulsah Kose
Change-Id: I2b95457ba2f074a13059c9f5ce87589f925d3eda Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/33455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-30lok: Allow to edit comment by postit idPranav Kant
Change-Id: Ice1d40b7813226fe99c423047392b3416d763dd4 Reviewed-on: https://gerrit.libreoffice.org/33614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Allow to delete comment by post it idPranav Kant
Change-Id: I61971dfe3a2630ba33c029ce7865bd7077e235cc Reviewed-on: https://gerrit.libreoffice.org/33613 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Allow to reply to comments using postit idPranav Kant
Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c Reviewed-on: https://gerrit.libreoffice.org/33612 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Calculate and return parent comment idPranav Kant
... instead of just checking if its a root comment or reply one. Change-Id: I2539e6893ee69bfe12911807504df49edf422be2 Reviewed-on: https://gerrit.libreoffice.org/33470 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Implement new callbacks for comment notificationsPranav Kant
Change-Id: I298183b295c68c4a39cb1f6fffe4b89b4eaee0f3 Reviewed-on: https://gerrit.libreoffice.org/33469 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: New commandvalues command - .uno:ViewAnnotationsPranav Kant
Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c Reviewed-on: https://gerrit.libreoffice.org/33468 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Unique annotation Ids to SwPostItFieldsPranav Kant
Change-Id: I6dd5186eb18ca99a75a5cb73263cc6bfcc7ff345 Reviewed-on: https://gerrit.libreoffice.org/33467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26loplugin: unnecessary destructor swNoel Grandin
Change-Id: I27dcd289177bd6a63f07d75fb3cfd5c14fa2ee9d Reviewed-on: https://gerrit.libreoffice.org/33572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25sw: revert ToX hyperlinks to LO 4.3 behaviourMichael Stahl
Commit 94b296d5416dd71d721ad16216b50bce79e3dc04 changed this to potentially insert multiple overlapping hyperlink items. Unfortunately Writer can only have one RES_TXTATR_INETFMT on any given position in the paragraph, so the hyperlink hints inevitably overwrite each other. Revert this to do it the same way as the old code in LO 4.3 did: match the last unmatched link-start with the first link-end, and ignore all the link-start before the matching one, as well as the link-end after the matching one. This should prevent surprising formatting changes on index update, including entries spontaneously turning green, and there is no reason why the result of the new way is objectively better than the old one. Change-Id: I55be9c212c473908428fa8bd6487d136343fe852
2017-01-25sw: stop swapping start and end position of links in ToXMichael Stahl
This causes: sw/source/core/txtnode/thints.cxx:3198: +SwpHints::Insert: invalid hint, end < start Change-Id: I933c790127ab1469bb57c4d288dbb49be16ace19
2017-01-25sw: config item "OutlineLevelYieldsNumbering" has no effectMichael Stahl
... since CWS swqbf90 in 2005, so remove it, except for the entry in the property set. Change-Id: I5f82d1957a15bf5141108ac9821b813dd36f1995
2017-01-25use rtl::Reference in SwXTextDocumentNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I94746e7fafcc7d2206ac0c1a6481e6006421529b
2017-01-25use rtl::Reference in SwChartDataSequenceNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I828ad411c989f14a9175ab173f1a4fe75fed535f