summaryrefslogtreecommitdiff
path: root/sw/inc
AgeCommit message (Collapse)Author
2021-03-13tdf#128469 add extended tooltip for "Reset to Parent"Seth Chaiklin
Change-Id: If5aabfc5b677cbeb375745d5c1902848cf48c13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112414 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-13Drop duplicate methodMike Kaganski
Change-Id: Ib9401c695a48673545d0adeac2bad24c7579e424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112419 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-13update pchesJulien Nabet
Change-Id: Id6dfae9fb97fbe3fc89b9f2e083d7a3d5c1d36d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-12sw bibliography, refer to a page: make the biblio field clickableMiklos Vajna
- add support for this in SwWrtShell::ClickToField() - restrict this to ctrl-click by default (similar to hyperlinks) - ignore empty URLs - extend the tooltip to hint the URL - change pointer to hint that the field is clickable - downgrade the assert to SAL_WARN in SwAuthorityFieldType::RemoveField(), that currently fires every time a biblio field is de-selected Change-Id: I3b4a12d8a7661f7d8d41804f104505c7594debd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112400 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-12we just use the OutputDevice api for SwViewOption::InitCaolán McNamara
Change-Id: I36a52d0e02d6a2fa900abc579d7d1018fc5381f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12tdf#128469 rename "Standard" to "Reset to Parent" plus tooltipSeth Chaiklin
Change-Id: I73ad5450450c328911d8464924a163faaba9b70c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112301 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-11tdf#140845 labelling improvements for List Styles in ContainsSeth Chaiklin
move hard-coded formatting of liststyle out of sw/source/uibase/utlui/attrdesc.cxx and into sw/inc/strings.hrc, so that translators can customize as needed. In sw/inc/strings.hrc: * "Numbering" -> "List Style: (%LISTSTYLENAME)" * "no numbering" -> "List Style: (None)" (to be consistent with setting in "List Style" control and to keep consistent appearance in Contains) Thanks to Mike Kaganski for assistance. Change-Id: I9d2b6507082fea06665d0d8a3465c314a5d894c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112213 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-11tdf#140934 update annotation menubutton bg when comment color changesCaolán McNamara
Change-Id: Ia4d10a8f19c039655dbe28c5f612061ce3755afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112278 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use strong_int for item ids in vcl::ToolBoxNoel
(*) fix bug in SfxToolBoxControl::StateChanged where it was using the slot id instead of the toolbox item id (*) I left the logic in SbaTableQueryBrowser alone, but it looks suspicious, casting slot ids to toolbox ids Change-Id: Ied229164c27fb4456b0515c6fdcbd1682766a1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-09tdf#128469 add "Apply" tooltip for all style dialogsSeth Chaiklin
Change-Id: I37c6ffe85da6d68fff89480a589a358624c047fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112091 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-09Related tdf#140849: "Apply and Edit changes" from AutoCorrect crashes LO writerJulien Nabet
This patch only fixes the assertion here: 3 0x00007f4d0ae82662 in __GI___assert_fail (assertion=0x7f4cef73d9d1 "SAL_N_ELEMENTS(RID_SHELLRES_AUTOFMTSTRS) == STR_AUTOFMTREDL_END", file=0x7f4cef73d961 "/home/julien/lo/libreoffice/sw/source/uibase/utlui/initui.cxx", line=186, function=0x7f4cef73d99f "void ShellResource::GetAutoFormatNameLst_() const") at assert.c:101 4 0x00007f4cef2514b8 in ShellResource::GetAutoFormatNameLst_() const (this=0x747f430) at sw/source/uibase/utlui/initui.cxx:186 Regression from da64ec8c8a91db6a6ec9657898f081d5ee67e739 author László Németh <nemeth@numbertext.org> 2020-06-01 19:31:38 +0200 committer László Németh <nemeth@numbertext.org> 2020-06-02 18:40:06 +0200 commit da64ec8c8a91db6a6ec9657898f081d5ee67e739 (patch) tree 2bd7d3ddf24ce6c5adeb3c29dd46ead2e1215c0a parent 2d6395b87218cbf3512aa9b54807a859205006f0 (diff) tdf#133589 AutoCorrect: transliterate to Old Hungarian Change-Id: Ib606ffcf5f0d6921c41dcb256af12ff54017a590 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112118 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-09let SwMultiTOXTabDialog have a Widget parent instead of a WindowCaolán McNamara
Change-Id: I7a7ae6cd5240257a0f2e33e89d20a1799b29013d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09fontwork: insert in the center of LOK viewSzymon Kłos
Change-Id: Iabde4ee927546b0e396c4fbd6d0099fa82240166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109968 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112163 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09tdf#128469 add extended tooltip for "Reset" to style dialogsSeth Chaiklin
Change-Id: I6dbb37b9b5ed77cbc918a9158c1be90bf4127b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112086 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-08(related: tdf#133487) sw: fix ordering of virtual SdrObjects for textboxesMichael Stahl
Calling XShapes3::sort() on export of the testTdf130314 fails because of 2 consecutive textboxes; the function requires a textbox to immediately follow its shape in the list (i.e. textbox has OrdNum of shape + 1). This is because for shapes in header/footer, one virtual SdrVirtObj is created per page where the header/footer is shown, and the SwFlyDrawContact::GetOrdNumForNewRef() does not take textbox ordering into account. It's not clear if the assumption that the shape's SdrVirtObj is created before the textbox's always holds, but let's try this for now. Change-Id: I860896471211bf6c142ab825f298f4d4c0eec148 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112029 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-08tdf#140796: Wrong English string for U+2060 characterJulien Nabet
Rename "No-width No ~Break" to "Word ~Joiner" + replace pattern "ZWNBSP" variable names by "WJ" Change-Id: I95a874a9d2d20a30d2c4c3add6041adbe72d872c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-08tdf#128469 add "Reset" tooltip to style dialogsSeth Chaiklin
Change-Id: Ie97836467967d469ac37b7720a7b6dcc661702a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112081 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-07ref-count SdrPageNoel
which simplifies ownership handling, particularly with regard to undo/redo Change-Id: Ie8f300ebfdae6db3c06f78a87e35a07497d6b825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06update pchesJulien Nabet
I just used ./bin/update_pch.sh Change-Id: I06a7f36eb4c511b8d6c6477fd87e57f0d9702457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06allow a widget as a parent, not just a windowCaolán McNamara
Change-Id: I83c3c5a69c0badac7998dfb88107978eee7cdcd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112032 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-06Related tdf#128469 - Customization of tab dialog buttonsHeiko Tietze
Change-Id: Ib7d4bbc6d78ac93510835e061640bfcd99248195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111987 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-05sw: document the difference between SwDrawVirtObj and SwVirtFlyDrawObjMiklos Vajna
It confused me that SwVirtFlyDrawObj is used even with single-page documents, while SwDrawVirtObj is only used with multi-page documents. Change-Id: I22110d1dd7bf87631c1690f2aa212ded688300c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112022 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-05tdf#93441: Revert "Fix fdo#38884 Improve Up/Down movement in writer"Xisco Fauli
This reverts commit d58bea0ffa2a2fe79103ab7aa743aea63e27a0fd it's really unclear to me what the original commit tries to fix. https://bugs.documentfoundation.org/show_bug.cgi?id=38884#c6 gives some information but the behaviour described there is the same with or without the commit applied. The discussion in https://gerrit.libreoffice.org/c/core/+/11500 doesn't give much information either. Change-Id: Iadd8cb6e869fd26654bb0301fbc30ea4f2d39fdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111932 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-03update pchesCaolán McNamara
Change-Id: Ide49c48738ecd537d4eb69390d22807561d3b4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-02tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapseJim Raykowski
Provides parent child expand/collapse for Headings in the Hyperlink- Target in Document dialog target treeview Change-Id: I8cc57b4cbf3830cec76d64a0ef587e199c39e360 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109930 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-02loplugin:refcounting in swNoel
Change-Id: I5d3768503effa002c4a308bfad30d9b56d5365f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02Related tdf#128469 - Change label of Standard buttonHeiko Tietze
Change-Id: I1bfc7cbfa71cf76d1cd76db83d8a7f951535e47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111821 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-03-02tdf#140117 sw UI: keep headers/footers when inactiveDaniel Arato (NISZ)
Custom left page and first headers (and footers) used to disappear forever if hidden temporarily by checking the "Same content on left and right pages" or "Same content on first page" options, respectively. This commit stashes the endangered headers (footers) in SwPageDesc and restores them on demand. Change-Id: I1f6b605e2bd19af18726de1b825721487d29b4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110398 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-01tdf#124176 Use pragma once in sw/inc/ndtxt.hxxheet-2312
Change-Id: I75b6788e21ac010daea1cac5661887a0812d1773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111729 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-01sw doc model xml dump: show SwAuthEntryMiklos Vajna
To see the author/title/etc of bibliography fields. Change-Id: Ia466c96d3d17b52b94a85070edd023a0579e970a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111732 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-27tdf#140528 Crash in writer when switching from Numbering to PositionNoel Grandin
regression from commit e5ecb998fd78137aec32ad2cc996eaa4bb3e499d Date: Mon Dec 5 09:52:43 2016 +0000 avoid coverity#1371269 Missing move assignment operator rather write this code in a more obvious fashion, and bypass the use of the very weird operator= method, which barely copies anything at all. Change-Id: I548d8f73224c2625ed6389861551038b18396b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-26sw doc model xml dump: show SwAuthorityFieldMiklos Vajna
Towards seeing the actual contents of these bibliography references. Change-Id: I9f7b623a551adf9fd3f3a5ba4e376676c891bc04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111630 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-26loplugin:refcounting in svlNoel
Change-Id: I0009464121faf6dd36793b031d892f492b56187c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-25allow use of FloatWinPopupFlags without including complete floatwin.hxxCaolán McNamara
Change-Id: Ica412938ead6f213668b3aa876bff81d8f512f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111526 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25tdf#115815 sw: fix lost annotation ranges of redlinesLászló Németh
Annotations of tracked deletions lost their ranges during ODF export, according to the limitation of ODF or its recent implementation. As a workaround, save and restore the start of the annotation ranges using temporary bookmarks (which can be part of text:deletion). Note: maybe it's possible to split redline ranges regarding to the start of the annotation ranges, mixing tracked deletions with normal text or tracked insertions, but this would be a not backward compatible solution, because the ODF import of this file inserts extra (not tracked) spaces around the annotation, losing the original text content. Change-Id: I786993a05ee1683076e213374a92969d1856cf8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111489 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-23loplugin:unusedmethodsNoel
Change-Id: Ie0534244cc7a30ad006e65baf125c59757c90d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23tdf#140226: use StaticWhichCastBjoern Michaelsen
Change-Id: I7f1345da0e67bfe14b119b92f32faa926b2ab603 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111356 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-02-23update pchesCaolán McNamara
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23tdf#135774, tdf#114799 Char highlight: apply to numberingJustin Luth
This is a partial revert of LO 7.0's commit 315d56582f8a56d8f2d3ea6cda63ea4832249608 The character background is exported as either w:highlight or w:shd, based on a user setting. w:shd does not affect numbering in MS Word, only the 16 color w:highlight does. (tools - options - Load/Save - Microsoft Office - Character highlighting export as: Highlight or Shading) I replaced tdf114799.docx with a version that uses w:highlight instead of w:shd. The test was doing it backwards - MS Word was NOT highlighting the numbering in the original unit test. I added another test using the original unit test to ensure that the numbering was not affected by the paragraph's char shading. There are many other "Char highlight:" patches in 7.2 that are not going to be backported. See http://wiki.documentfoundation.org/Documentation/CharHighlight for more details about this topic. Change-Id: I38b6f700895e29f634f07430f6c7a13722ffa4f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111201 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-02-20loplugin:refcounting in swNoel
Change-Id: I56f2f5aa4d9105e93f28701b8352d1fb97829ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20loplugin:refcounting in svlNoel
Change-Id: Iae192caa9d05f71ce02aae966ef1d71232d1a7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19update pchesCaolán McNamara
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19Related: tdf#140409 scale the menubutton like the other widgetsCaolán McNamara
Change-Id: I6b42ef958dd1625cfef5e48e45c932aef9a5960f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111211 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18sw bibliography: make URLs in the bibliography table clickableMiklos Vajna
- Don't reuse the <text:index-entry-link-start> / <text:index-entry-link-end> mechianism from <text:table-of-content-entry-template>, because <text:bibliography-entry-template> doesn't allow this - Use STR_POOLCHR_INET_NORMAL as a char style, so the URL looks clickable - Allow absolute URLs for ToxAuthorityField::AUTH_FIELD_URL (other URLs like ToC are always relative) - Track the new text added by FillText() between the StartNewLink() and CloseLink() to figure out what is the URL to be launched on click Change-Id: I126fa06aecfff783e62b65a548228ff781b62c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111117 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-11sw tooltip on bibliography fields: add the actual tooltip functionalityMiklos Vajna
- Similar to e.g. SwMacroField::GetMacro(), add a new SwAuthorityField::GetAuthority() that returns a string which is similar to the one-liner text node in the bibliography table for a given bibliography reference. - Base this on the recently added SwAuthorityFieldType::CreateTOXInternational() and SwTOXAuthority::GetText() to share code with sw::ToxTextGenerator::GenerateText() and SwTOXBaseSection::Update(). - Finally extend SwEditWin::RequestHelp() to actually provide the tooltip on mouse hover. Change-Id: I33a58076c6d141566298259e7e4681541fac1055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110765 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-11Fix typoAndrea Gelmini
Expanding this: https://gerrit.libreoffice.org/c/core/+/110515 Change-Id: I9abe586eac24a4f5ceb26c16440907f96a871594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110543 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-10sw tooltip on bibliography fields: add an SwTOXInternational factoryMiklos Vajna
This is normally created in SwAuthorityFieldType::GetSequencePos(), but this way the logic can be reused when creating an SwTOXAuthority outside SwTOXBaseSection::Update(). Towards providing a tooltip on mouseover for bibliography reference fields. Change-Id: Ide15d0e30223ca40514439c3f3c506651228c69b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110705 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-10clean up SdrObject cloningNoel
using operator= implies that overwriting an SdrObject is a useful operation, but that is not at all true - they are typically linked into and referred to by many other things. So rather use a copy-constructor. Also clean up a couple of weird "do some stuff after the clone" code into the main copy constructor. Change-Id: Iefc1481b527602748b5f3abed06e7cca66c0581c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09sw: document SwTextAttrMiklos Vajna
Just a summary, sw/README has more on this. Change-Id: I43fb32e17520fb60fedbc7ae85cf881d3a343c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110634 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins