summaryrefslogtreecommitdiff
path: root/sw/qa/extras
AgeCommit message (Collapse)Author
2015-05-07Fix typo informations -> informationAndrea Gelmini
Change-Id: Ie8a7bc9800ed0122092f88cedadb126b7891f2a6 Reviewed-on: https://gerrit.libreoffice.org/15655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07tdf#91122 unit test for docx import with wrong vertical positionLászló Németh
Change-Id: Id268393bf28a6edb4a481d7a74ae412b337b3fc8
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: I5d02ba0db00e11af3c17eaf77ce19c635a52077f
2015-05-04tdf#91077 unit tests for shape import of discarded DOCX header/footerLászló Németh
Change-Id: I3e78e3104af97eed91c102e9ca5546e0785c5f8c
2015-05-01tdf#89790 - DOCX: saving LO version number in correct tag in app.xmlRadu Ioan
Converted existing method that provides application name and version in two functions Change-Id: I93b70da7c78ee5db3d6eb710a2a2a9f4b7b4fb86 Reviewed-on: https://gerrit.libreoffice.org/15151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-30tdf#38693: Document property TotalTime misinterpreted as secondsRavindra_Vidhate
Problem Description : The xlsx file has the extended document property <TotalTime>#n</TotalTime> in /docProps/app.xml LibreOffice appears to read this as a a total editing time of in second_ but according to ECMA-376 2nd edition: 22.2.2.27 TotalTime (Total Edit Time Metadata Element) Total time that a document has been edited. The default time unit is minutes. (ECMA-376 1st edition has the same statement in 7.2.2.27) XML difference: None After RT : None Solution : As LO uses the TotalTime in seconds, while importing the TotalTime, the TotalTime mentioned in the app.xml [which is in minutes] converted it to seconds. TODO: Writing a UT seems to be tricky for this change. Need to analyze and will raise the UT in separate CL. Change-Id: Icbe998b9881ac241a9147628573bab6ef63582c4 Reviewed-on: https://gerrit.libreoffice.org/15479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-30tdf#90720 Textframe background was not transparentSushil Shinde
In case of 'no fill' for vml textboxes, MS office rendered as transpanrent textbox. When opened same file on LO, it rendered it as textframe with white background. (Even if the fillstyle is type of 'no fill' and 'backcolortransparency ' is 100%) So, Fixing this issue by applying 100% 'FillTransparency' if it gets above situation. Change-Id: Ied2d3855354ada994288c29c78d9ccb4e5b0b4d6 Reviewed-on: https://gerrit.libreoffice.org/15390 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-27CppunitTest_sw_ooxmlsdrexport: split into two partsMiklos Vajna
Change-Id: I8af572c43542c384718c8f9c75749d2f3cb35cac
2015-04-23fix duplicate attribute export to docx with ooo69297-4.odtCaolán McNamara
Change-Id: I193099d7fffc160f0198e3d42d5d6fd5835c79cf
2015-04-21loplugin:cstylecastStephan Bergmann
Change-Id: I9dfde74fa7e5e3a651ea014e6cc335bac780cb4b
2015-04-21tdf#90421 RTF export: ignore hyperlinks without an URLMiklos Vajna
Commit fe444d1f74abe417962be0bcd3340f40f2446b58 (fdo#62536: sw: fix AutoCorrect bold/underline on existing AUTOFMT, 2013-06-20) adds an empty inet format hint on the text node during autocorrection, on export we can safely ignore that to provide well-formed output. Change-Id: Iafae941a13e29dcc7d8b4bade5ce94a486b59638
2015-04-21Applies CharAttribute to selected text and tests undoAustin Chen
Change-Id: Ibd171fda4ea38de4d76d8f252d6f6d37cf3b9a66 Reviewed-on: https://gerrit.libreoffice.org/15158 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-21RTF import: handle d{x,y}WrapDist* picture propertiesMiklos Vajna
Commit e789c7f0f15a6b571de95b81e77e3a323e9f540e (RTF import of d{x,y}WrapDist* shape properties, 2013-04-09) added support for wrap distance of shapes, but that was ignored for shapes, as dmapper later overwrote the set margins. Fix this by generating the expected tokens in case of pictures, then dmapper will take care of the rest. Also add testcases for the original shape wrap distance feature that was missing. Change-Id: I6f219ee6fef71328368409d142897dbae77a0f2f
2015-04-21tdf#78606: unittest for docx section header export bugEilidh McAdam
Checks that header is exported to DOCX when section is first paragraph. Change-Id: Ie8db2a372754208203f0df62137a3a0c3bbf39b9 Reviewed-on: https://gerrit.libreoffice.org/15370 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-20Related: tdf#90681 table model can have truly empty cellsCaolán McNamara
this time the missing cells are on the left Change-Id: I55a5aa60c8d06b25b0c48b3f6a683694adca8e6a
2015-04-20tdf#80708 RTF export: fix unexpected table row breakMiklos Vajna
Regression from commit 1f77a5e8d5bf8a7f1b7bd7206996d2b2efc59462 (n#203704 fix RTF export table output for subtables, 2012-02-08), the problem is that RtfAttributeOutput::StartTableRow() has two callers depending on if it's the first or a later row, but the m_bTableRowEnded flag storing if that method is called is only set in one case. Fix the problem by moving the update of the flag to the method itself. Change-Id: Ieae1fb53f9528fc74d037d2fd783b3979b17cab8
2015-04-20RtfAttributeOutput::ParaHyphenZone: use \hyphparMiklos Vajna
Previously SvxHyphenZoneItem was serialized to some custom RTF extension that even our own RTF import ignores since LO 3.5. Change-Id: Ia99d9750ad0b1a07105eeef2bee07e6fdbfe7876
2015-04-18testOldComplexMerge: work around buggy libxml by not using //Miklos Vajna
Change-Id: Ia53d7a2aba039386cafcf8d0030c9e768c08b743
2015-04-18silence MacOSX_37-tdf-buildbot failureCaolán McNamara
Change-Id: I2b23d406463168f010c8f2d48889a5a0ff15895c
2015-04-17Resolves: tdf#90681 table model can have truly empty cellsCaolán McNamara
old school complex tables can create a table model where a cell exists in the table but there are no paragraphs in it. -------- | A | C | ---- | B |*D*| -------- i.e. normally for the above there are 4 nodes which get exported, even though C and D are merged. But it can be the case that there are only three nodes, and *D* is missing be conservative for now and only do this for the obviously broken no cell start but cell end case and incrementally build up the test-cases Change-Id: I5703595f61688a66b7fac7f3905ace0c207c9875
2015-04-17RTF filter: export \hyphautoMiklos Vajna
Change-Id: Ide8cb5f45d3eb60c45d86d58a9ab12bbc9f4cf47
2015-04-17tdf#86182 RTF import: fix handling of \rtlparMiklos Vajna
Commit 558d5c25a0b1d6a937d33291a4b6cd7fca6cb15b (implement RTF_LTRPAR and RTF_RTLPAR, 2011-06-09) was just a guess, this one is the proper mapping. Change-Id: I1156ef5ddc34264d761d3e64dd0537bc6ec0ced7
2015-04-17convert SCRIPTTYPE_ constants to scoped enumNoel Grandin
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-16RTF import: fix handling of \objdataMiklos Vajna
There were two problems here: 1) The input stream is read multiple times, so plain naive XInputStream is not enough, XSeekable is needed, as it is the case for the stream provided by the OOXML tokenizer. 2) Seeking to the correct start position is not enough, code using the stream will assume that seeking to the beginning of the stream allows reading the correct data again, so provide a dedicated stream instead. With this, handling of math equations created by Word <= 2007 and embedded to RTF files can be edited finally. Change-Id: Ic225e1e1060f8bdd5651a21e68970620c9ac6b68
2015-04-15DOCX import: convert MathType to Math if MathTypeToMath is enabledMiklos Vajna
With this, math equations created by Word <= 2003 and embedded to docx files can be edited finally. Previously the result was read-only and opened in an unexpected new window. Change-Id: I4f9dd1cca4a149959f6151cf9af9242b53190ef5
2015-04-14tdf#89478: svx: ODF import: SvxBrushItem Graphics should override ColorMichael Stahl
The bugdoc has: <style:page-layout-properties fo:background-color="#007f7f" > <style:background-image xlink:href="Pictures/2000003900002FA3000055F455EC9F63.svm"/> </style:page-layout-properties> In this case it's clearly better to prefer the Graphics. The old code could actually store both in the model but the UI only allows setting either Color or Graphic, so this should be good enough. (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: Id33231ad90815d9791f90289fb0b55455d334c14
2015-04-14tdf#88337 tdf#89193: sw: add missing SwXPageStyle propertiesMichael Stahl
Add the fill style properties so background images etc. are not lost. (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: I517350eec2f32e4b4bb80427666aad23a31d666a
2015-04-14tdf#88337: add test documentRegina Henschel
Change-Id: I7e5f28f6cc8010ac233d58cfa6a2158e3f7be90b
2015-04-14Related: tdf#90130 gradient transparency goes missingCaolán McNamara
Change-Id: I0af8eb24dab7bb9f5831bec68f9a22ba88c2be19
2015-04-13Resolves: tdf#90130 don't clobber new solid-color on seeing old transparencyCaolán McNamara
Change-Id: I1ea86dca37cbce416564c5e198779dd132125b02
2015-04-13Add SwXTextDocument::postKeyEvent() testcase.Miklos Vajna
Change-Id: I76904ed9596dcb0b6aa70bccd19279573687d30c
2015-04-12tdf#75614 RTF import: fix missing text after footnoteMiklos Vajna
Change-Id: I5901094cb603c35a1cd8ac718fd434a9dd55729b Reviewed-on: https://gerrit.libreoffice.org/15266 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-04-10tdf#90230 SwDoc::AppendDoc: take care of marks when inserting page breakMiklos Vajna
SwDoc::AppendDoc() inserts nodes from an other document, and before doing that, it inserts a page break at the end of the document. In case there are marks at the end of the last paragraph, the insertion of the page break moves them to the next page. This is a rare situation, but happens e.g. when the source document is an empty one: then MM puts a mark at the first paragraph of each inserted MM part, and then the first paragraph == the last paragraph, so the mark of the only paragraph in the document gets moved to the next page. This is a problem on its own, but is detected by the SwIndexReg dtor when that empty paragraph gets deleted later in SwNodes::Delete() called by SwDoc::AppendDoc(), resulting in an assertion failure. Triggered by commit a305a2c91420652db450b7f8edd140e1d69f42cf (use bookmarks to mark mailmerge parts in a mailmerge document (fdo#80823), 2014-10-20), these not adjusted bookmarks were not detected before. Change-Id: I89775b477a2fd3182b2bc87144aed2bfe7912aff
2015-04-09tdf#89214 SwDoc::GetUniqueNumRuleName: always return pChkStr if it's unusedMiklos Vajna
Regression from commit bb00a0097900ae054401f7758a915047cfde4065 (do not bother with nice unique names during mailmerge, 2014-11-08), SwAttrSet::CopyToModify() expects that in case SwDoc::FindNumRulePtr() returns 0 for a name, then the call to SwDoc::MakeNumRule() will use the not found name (as SwDoc::GetUniqueNumRuleName() will return the just checked name). As a result, simply always returning a random unique name during mail merge is a problem. Only return a cheap random unique name if no hint is given. Change-Id: I49d65009ced97d00aa2e8db35a529f2f30ac9ae5
2015-04-07tdf#89802: xmloff: fix ODF import of frame with empty style name refMichael Stahl
draw:fill-gradient-name="" in the graphic properties now causes BaseFrameProperties_Impl::FillBaseProperties() to fail and prevent insertion of the SwXTextFrame. (regression from 6e61ecd09679a66060f932835622821d39e92f01) Change-Id: I9b4f3ddb0f0e1b3a80e86bbdc1af2dade1c8edf7
2015-04-07tdf#90362 sw: config option for ignoring protected areasMiklos Vajna
Change-Id: Idfa62aa5bbccf62ee85f863150e13f80b8b5db90 Reviewed-on: https://gerrit.libreoffice.org/15181 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-04-03CppunitTest_sw_ooxmlexport5: fix Fedora 22 alpha buildMiklos Vajna
09:41 <@dtardon> vmiklos, maybe it's a regression in libxml2. "Fix XPath '//' optimization with predicates (Nick Wellnhofer)" in NEWS looks suspicious So tweak the XPath not to use // for now. Change-Id: Ia1c4508d8aede5818bc258d6e4243f026da3a3cd
2015-04-02sw: [loplugin:stringconstant]Michael Stahl
Change-Id: Idb8a113254574ca5f998980ede91e42f9bd09277
2015-04-02Added test function for Search-and-Replace with TransliterationVarun
This test function checks the search-and-replace operation with some Transliteration Flags enabled. Change-Id: I86e0068e9d91e4fe426f9d6c120baf66e59e2b7e Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-01CppunitTest_sw_ooxmlexport5: try to make MacOSX_37-tdf-buildbot happyMiklos Vajna
Blind fix, can't reproduce the problem locally. Even if the XPath we give explicitly requests one XML node, we get multiple ones: equality assertion failed - Expected: 1 - Actual : 2 - In <file:///var/folders/_n/q7swt8596vz0063kvnql9nrw0000gn/T/luyyyujc.tmp>, XPath ´//w:formProt[1]´ number of nodes is incorrect Change-Id: I380fd077c5740b3045f64a6748dd96d1b213e453
2015-04-01tdf#60060: unit test for docx section protection exportEilidh McAdam
Change-Id: I307466e7336bcf767ebb1ac3bb330cfb2130f84c Reviewed-on: https://gerrit.libreoffice.org/15003 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-01Revert "Revert "skip SkipImages unit test on Windows""Michael Stahl
This reverts commit 7ea8046c741c8b7b608f26e312cc5f1056752c09. Unfortunately test still fails on WNT tinderbox but it works for me locally, disable it again.
2015-04-01Revert "skip SkipImages unit test on Windows"Michael Stahl
This reverts commit dae63f3dd8216aea7f6b594433b180d633d5551d. Crash should be fixed by fae6699c2ec8d68766bb8d5f71483d4b65792327
2015-03-31skip SkipImages unit test on WindowsLászló Németh
(temporarily, while fixing the segmentation fault in Tinderbox) Change-Id: Iddc1a14b0cdd8a20ac90fff175e99f60972672a1
2015-03-30cleanup for SkipImages unit testsLászló Németh
Change-Id: I2232fda0acdc7e677e1da278405a8a4c90e00659
2015-03-30Bypass test that fails on OS X without window system accessTor Lillqvist
With this change, 'make' now succeeds for me when logged in through ssh to a Mac where I am not logged in on the console or through Screen Sharing. Change-Id: I8aa7f3174b00544fa8e399c8d4dcd9cc801e0dc0
2015-03-30Unit tests for SkipImagesLászló Németh
SkipImages filter option skips image loading during DOC and DOCX imports, but it keeps the text of textboxes and custom shapes. Change-Id: Ia0ab3b350b9da22d9375787883678cc357a704b3
2015-03-26tdf#89496 fixed crash on rtf shape group parsingVasily Melenchuk
Fix is actually partial revert of my changes done for tdf#49893 (commit 2c411e4487f24968d6a62958fec85e4e3e1fda93): shape groups were not taken into account Change-Id: Ieb442265ac7c0087c3a402a9f1b09e6b3dcbcac1 Reviewed-on: https://gerrit.libreoffice.org/14997 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-25TyposJulien Nabet
Change-Id: I434be0034b26ac4719590238817538ecd90b8923