summaryrefslogtreecommitdiff
path: root/sw/qa/extras
AgeCommit message (Collapse)Author
2022-02-04Revert "lok: copy over the alpha channel too for cairo..."Luboš Luňák
Not needed in the end. This reverts commit 688051edf59a311371b84ea34db4991d3a164d52. Change-Id: If2474ccff0ada5fd0ca5206f10ca2893df0fe1f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129491 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-02-03tdf#134965: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I985b26f4340f17b060c6ef18dfa70c327585e4f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129409 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-03tdf#146803 tdf#146805 OOXML import: fix bodyPr at grouped shapesAttila Bakos (NISZ)
Grouped text boxes (WPG) lost their alignment and spacing, because the bodyPr tag what has the information for this, processed after the textbox content, and applied to the XShape which in case of group shape is not ready. To solve this, the mentioned properties read for the shape member after copied to the XShape when its ready, and than synced to the textbox. Regression from commit 121cbc250b36290f0f8c7265fea57256dad69553 "tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes". Change-Id: Ifb5e8bde58613137441bec2e2b51bc67118dab40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128854 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-03tdf#146802 OOXML import: fix embedded VML in grouped textboxAttila Bakos (NISZ)
E.g. OLE formulas inside them broke document load. Regression from 121cbc250b36290f0f8c7265fea57256dad69553 "tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes". Note: now embedded VML OLE is loaded in WPG shapes, thanks to that the ShapeHandler in oox/ has a stack having the start token inside for each shape. Change-Id: I973d78ed88c5c83efffd9629061e2a2c6fdd25e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128627 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-03tdf#146822 OOXML: fix export of the transparency in hatch fillTünde Tóth
The transparency value of the hatch was not exported. Follow-up to commit 001afbed910b7e565f602c1b11b1b4538cd59442 "tdf#127989 OOXML: fix import of transparent hatching". Change-Id: I9b82a3422de8e4f85c534f861c45c0c097ceb02f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128504 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-03tdf#147115 writerfilter: style is only default if default=trueJustin Luth
This was a dumb mistake in LO 2018 (so perhaps LO 6.2). Regression from commit 6b7f12f6108f136d60bd77e3787ef6a2632038cd Change-Id: I2adc642ffe9c2af1037fcc0a5d2b83c993511258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129386 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-02Related tdf#66039: restore unit tests disabled temporarilyAttila Bakos (NISZ)
Follow-up to 121cbc250b36290f0f8c7265fea57256dad69553 "tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes" Two tests have been restored. One of them had to be modified, where the test document has a pure VML shape inside, and after its reload, the shape has got a DML part with textboxes. This differs from the input, but verification handles it now. Change-Id: Ic71cd06496da7d07c09530770282c03c7438640e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128055 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-02Related tdf#66039 DOCX import: fix Z-order of group shapesAttila Bakos (NISZ)
A missing function resulted covered textboxes which weren't visible in group shapes. Follow-up to 121cbc250b36290f0f8c7265fea57256dad69553 "tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes". Change-Id: I08eb1c1cf4a4f4769af8812500b9cf9778b01e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128279 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-02tdf#147006 sw_fieldmarkhide: fix crash when deleting fly with fieldmarkMichael Stahl
The problem is similar to commit eef10be20a4c5108c68b19ccdda263c5ca852386, there is a fieldmark in a fly and this results in UpdateFramesForRemoveDeleteRedline() re-creating fly frames that have already been deleted in SwUndoFlyBase::DelFly(), and then the SwFlyAtContentFrame::SwClientNotify() crashes on a null anchor position in the SwFormat::ResetFormatAttr(RES_ANCHOR). This time the passed rPam is empty, after removing the dummy characters of the fieldmark; there isn't really anything to do in this case so just return. Change-Id: I475b8fcb0bcf94be58ff553454c261d75076303b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129308 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-02tdf#147008 sw_fieldmarkhide: fix invalid NonTextFieldmark positionsMichael Stahl
Commit ab6176e88f78d0b3aa2490fbc7858304c2d4a437 introduced a crash in ModelToViewHelper when the positions of a NonTextFieldmark are invalid. The NonTextFieldmark must always contain 1 CH_TXT_ATR_FORMELEMENT but after SplitNode() the position is (rr) p *pFieldMark->m_pPos1 $2 = SwPosition (node 10, offset 1) (rr) p *pFieldMark->m_pPos2 $3 = SwPosition (node 9, offset 0) This is because in ContentIdxStoreImpl::SaveBkmks() there is an asymmetry where the m_pPos2 is recorded to be wrongly corrected to node 9, but if the positions were swapped so that m_pPos1 is the start position, then it will not be recorded and remain in node 10. So fix this by changing the NonTextFieldmark to insert its CH_TXT_ATR_FORMELEMENT differently. There is some very subtle code in SwTextNode::Update() that is again asymmetric and (non-obviously) prefers to move m_pPos2 and leave m_pPos1 alone (by moving it to aTmpIdxReg) in case the positions are equal. But then the fieldmark code increments "rEnd" (which is really the m_pPos1 i.e. the start after InsertString() returns), and then decrements m_pPos2. So avoid the problem by removing these 2 pointless adjustments. Then it turns a bunch of tests fail because other code assumes that m_pPos1 is the end of the NonTextFieldmark, so fix MarkManager::changeFormFieldmarkType(), ModelToViewHelper and SwHistoryNoTextFieldmark to use GetMarkStart(). Change-Id: I7c82f9a67661121662c95727e0f8f15e06d85a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129289 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-02CppunitTest_sw_ooxmlexport: remove no longer needed deny listMiklos Vajna
This suite no longer has tests with such document names. Change-Id: I1fbe072c1663f657354493b8db1b69fcedd7f162 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129304 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-02tdf#129578 rtfimport: CJK char properties are not CSJustin Luth
This fixes a LO 6.4/6.3.0.1 regression caused by commit fd95fb975b754d71d3750e85431a4e596a40e659 which was focused on export, and not import. The code originally didn't have any mention of DBCH, so it used the default. However, in the 6.4 change, it was wrongly tied together with the Complex Script indicator. So revert that part of the change. Mark fixed the same problem in 7.1 for font size. Change-Id: I1c87ae856de93ebc693135585574f2eb144b214b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128113 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-01tdf#107413: sw_rtfexport5: Add unittestXisco Fauli
Change-Id: I0f45d472f5ea59625c62b87dd5364bef19a6af27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129216 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-01sw: change test to check the text content instead of just the lengthMichael Stahl
Change-Id: I7a0abd1c7520b441b80ed4da11d3b50c2367cd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129287 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-01fix buildXisco Fauli
After de5aa409353c839483df21d47254fd2a508ab7d9 < tdf#144851 Honor Selection When Applying Title Case Format > +1 from Jenkins was from Nov 11, 2021 Change-Id: Idb16d9ca0fd72d84d77d0542a07d11dac830a734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129291 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-01tdf#141652 partial revert "Reset ShapeProperty priority...Justin Luth
... and handle only crop case." This reverts a portion of a tdf#134210 related, LO 7.2/7.1.2ish commit b90a67838e189f3aee6a50724c78c0a50d416970 that was introduced for no apparent reason. I have no understanding about shapes, and so I have no idea why setting FillBitmap to an xGraphic is different from setting it to a name, but it makes a huge difference on the image size, and the crop values aren't scaled to the reduced size. Since this section of code looks like a cut/paste relic of early stages of developing the fix, lets just revert this portion since the original author has made no response at all to the regression report. Change-Id: I9488c419ceb41bd4ebd7b10494a52fb816654832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128260 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-01tdf#146964 sw layout: fix reappearing deletion in Hide ChangesLászló Németh
mode at moving text. Test: in Hide Changes mode, move the selected text by cutting and pasting it with change tracking. Before the fix, hidden deletion reappeared again (only clicking on Show Changes and Hide Changes again fixed the layout). Regression from commit f51fa7534421a195a58b4a737a2e836d8c25ba81 "tdf#145718 sw, DOCX import: complete tracked text moving" Change-Id: Ia86f570bd634dd513fdbb93a83a929fd0ba4e273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129223 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-01tdf#144851 Honor Selection When Applying Title Case FormatMichael Warner
Prevents Title Case formmating from occuring outside of a user's selection. This is relevant if the user has started or ended a selection in the middle of a word. Change-Id: I39d8f2445acf5d9bb225bf8e3b36e2eb3b518857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124102 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-31Related tdf#66039 DOCX WPG import: Do not put extra paragraph at the endAttila Bakos (NISZ)
Regression from 121cbc250b36290f0f8c7265fea57256dad69553 tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes Change-Id: I16195d1d3b0955d5686fe225bbba6def2c28ef93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128043 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Attila Bakos <bakos.attilakaroly@nisz.hu> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-31tdf#46037 remove confighelper from uiwriter testsDhiraj Holden
Change-Id: I984d707e61d526791c60d57dd35727432f7f42bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-29CppunitTest_sw_rtfexport*: remove unused includesXisco Fauli
Change-Id: I38a439709b9a0c6a1298f21bdb9bf19c5121b827 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129127 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-29Fix typosAndrea Gelmini
Change-Id: Id74af6775a04fee013df6a02b0261155908dc22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129122 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-28Fix --with-latest-c++ buildStephan Bergmann
...after e53ad7928fc1cbe9950efebe41f1aa5a1a289439 "CppunitTest_sw_uiwriter*: remove unused includes" and ba593f5fdfecd1b8b2036f99618b39e18facca55 "CppunitTest_sw_ooxmlexport*: remove unused includes" caused > In file included from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:8, > from include/test/bootstrapfixture.hxx:20, > from sw/qa/inc/swmodeltestbase.hxx:26, > from sw/qa/extras/ooxmlexport/ooxmlexport.cxx:10: > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h: In instantiation of ‘typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type CppUnit::StringHelper::toString(const T&) [with T = char16_t; typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type = std::__cxx11::basic_string<char>]’: > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:50: required from ‘static std::string CppUnit::assertion_traits<T>::toString(const T&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’ > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:58: required from ‘void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’ > sw/qa/extras/ooxmlexport/ooxmlexport.cxx:967:5: required from here > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char16_t) [with _Traits = char_traits<char>]’ > 25 | ost << x; > | ~~~~^~~~ > In file included from ~/gcc/trunk/inst/include/c++/12.0.1/bits/unique_ptr.h:41, > from ~/gcc/trunk/inst/include/c++/12.0.1/memory:76, > from sw/qa/inc/swmodeltestbase.hxx:13: > ~/gcc/trunk/inst/include/c++/12.0.1/ostream:558:5: note: declared here > 558 | operator<<(basic_ostream<char, _Traits>&, char16_t) = delete; > | ^~~~~~~~ etc. Change-Id: I85087a8472eab923065ceb7ca6a1585f7ade75e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129118 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-28CppunitTest_sw_layoutwriter*: remove unused includesXisco Fauli
Change-Id: I5f826496f7fbdbe6ef4139f0907c4baf04826bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129106 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-28CppunitTest_sw_ooxmlexport*: remove unused includesXisco Fauli
Change-Id: Ic568ff3fc7eaf11dc496a0df685990acd3506b40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129091 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-28CppunitTest_sw_uiwriter: no need to inherit from HtmlTestToolsXisco Fauli
Change-Id: I62413319720e110503a186e65ba0f7167a0cb069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129093 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-28CppunitTest_sw_uiwriter*: remove unused includesXisco Fauli
Change-Id: I9f06f259df43ba5f5ea591427e86b1191c712dfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129087 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27CppunitTest_sw_uiwriter4: use CPPUNIT_TEST_FIXTUREXisco Fauli
there are two reason why i'm doing this: 1. Use the same way to define tests as CppunitTest_sw_uiwriter2 and CppunitTest_sw_uiwriter3 2. Over time, these files grow quite large, it's easier to split them when they use CPPUNIT_TEST_FIXTURE Change-Id: I4f23882b5622106a17cb14ed0525cfb3fecf88ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129058 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27v2 tdf#134951 docxexport: don't lose postponed commentJustin Luth
This patch basically reverts and re-writes the original fix. Prior to mstahl's 7.4 commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3 tdf#143039 tdf#143106 sw: DOCX export: don't export duplicate flys ooxmlexport5's comment would only last for one or two round-trips, and then be lost after that. It kept moving around into things like the fly itself, or the footnote. With mstahl's commit, it was lost immediately (same as Word 2016), and so the ooxmlexport5 unit test that broke was commented out. Change-Id: Ia7e881143f1243a3ab81bb94c02b57189f3730f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128703 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-27CppunitTest_sw_uiwriter: use CPPUNIT_TEST_FIXTUREXisco Fauli
there are two reason why i'm doing this: 1. Use the same way to define tests as CppunitTest_sw_uiwriter2 and CppunitTest_sw_uiwriter3 2. Over the time, these files grow quite large, it's easier to split them when they use CPPUNIT_TEST_FIXTURE Change-Id: Ibdeb23f08237d15063e99637297615343cb7ee1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129042 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27CppunitTest_sw_uiwriter4: remove duplicated codeXisco Fauli
No need to have blank file either, just pass nullptr to createSwDoc and it will create an empty file Change-Id: I05f34953b5c936d740babeee9a0489048a051cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129036 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27sw_ooxmlexport: distribute the num of tests more equallyXisco Fauli
Num of tests before: - ooxmlexport11: 124 - ooxmlexport12: 25 Num of tester after: - ooxmlexport11: 68 - ooxmlexport12: 81 Change-Id: I698d129d375783a2f1b0a944e077330a63defa2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129034 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-26tdf#139737 sw_fieldmarkhide: add unit testMichael Stahl
Change-Id: I4adfed97a00db71d42bbc4771221f5ebde43197c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128997 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-26tdf#146966 sw: fix inserting empty rows at copying multiple rowsLászló Németh
HTML expansion of the clipboard content is used to calculate the row number of the table on the clipboard. Skip its empty <tr></tr> elements here, similar to Paste As HTML in Edit->Paste Special-> Paste Special... to avoid inserting empty rows (e.g. selecting and copying/moving 4 rows inserted 30 extra empty rows). Note: likely this was a regression, related to the new empty rows in the clipboard/expansion code. Change-Id: I58b16c7869c08cda7e2a2c21c3c03bf38446d826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128986 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-26lok: copy over the alpha channel too for cairo...Dennis Francis
...based svp-graphics Conflicts: vcl/source/gdi/bmpacc2.cxx Change-Id: I653a8e4048c712911f44f610e13c7f6c3e323de2 (cherry picked from commit a9c473c3306e28462f9a1898a94277cf0adcbe5e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128891 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-25tdf#146967 sw table: fix freezing in Hide Changes modeLászló Németh
During change tracking, drag & drop or Cut & Paste a table row resulted freezing in Hide Changes mode. Test: In Hide Changes mode, select a table row by clicking on their left border, and drag & drop or Cut & Paste it in a different table row. Regression from commit 5a1c19624eda0c8b847af0dcee70b82502578ceb. Follow-up to commit 5a1c19624eda0c8b847af0dcee70b82502578ceb tdf#146965 sw track changes: fix tracked table row moving Change-Id: Iab606ce036fedcc70e42638e3ccf804c9dbca064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128875 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-25tdf#146965 sw track changes: fix tracked table row movingLászló Németh
During track changes, drag & drop or Cut & Paste a table row resulted a nested table in the first cell of the newly inserted empty table row instead of moving the original table row. Test: select a table row by clicking on their left border, and drag & drop or Cut & Paste it in a different table row. Note: This fixes crashing at Redo of tracked table row insertion, too. Regression from commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9 "tdf#143358 sw: track insertion of empty table rows". Change-Id: I9a31cae2c0e6e5e05450336a1e5b8d792035df35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128726 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-24tdf#139843: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I51b1ef4a9a4af07ddcf68e4a6a4e5ea0d039bef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128885 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-23tdf#146728 lok: IME: preset formatting in the new paragraphSzymon Kłos
When we wrote something using Heading or Title style and then moved to the next paragraph by pressing enter we should get "Text Body" style in the new line. Do not copy style. Use NOHINTEXPAND when inserting initially so we can use EMPTYEXPAND later - at the end of composing - and use correct styling. followup for: lok: IME: directly copy formatting for inserted text d8dbd123bfa7f39489ceb15ac83142635531fd43 https://cgit.freedesktop.org/libreoffice/core/commit/?id=d8dbd123bfa7f39489ceb15ac83142635531fd43 Change-Id: I55b764068337e125eea3fba641edb6486b2ac9d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127875 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128832 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-01-21tdf#140731: sw: move UItest to CppUnittestXisco Fauli
Change-Id: Ib72e03d2ca089ee86fa6d9dd4ae7d555be56ff4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128710 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-20tdf#128375: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I24b862d23d2e8dd9fbe930043457963f4cceec1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128636 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-19tdf#139638: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I7b98453b629734b4b07830687d1ec26b4bd468ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111834 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-19CppunitTest_sw_odfexport2: rework to avoid mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id6d45cfa011a45b0e8ef9f486498d6a89af8e49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128574 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-18tdf#146515: sw_ooxmlexport4: Add unittestXisco Fauli
Change-Id: Ib273156124a677fc774340dbd780393dfbd3070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128548 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-18tdf#145321: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: Id64d3469ed1bd4c38e684c4af0c20121a81043fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-15request the 2nd rect explicitly instead of one with a particular 'top' valueCaolán McNamara
Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14sw tests: audit uses of loadAndSave()Miklos Vajna
When it comes to changing import + import-export-import tests to do only import-export instead, this is only safe if we assert the resulting exported XML. Replace calls to loadAndSave() with loadAndReload() when we want to assert the doc model after an export. Thanks to Justin for flagging this, luckily it seems there is only a single test that fails after restoring the lost asserts (and that has already been fixed). Change-Id: I62cd4330c62d801dd9e6c7ef73decab3972c0b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128411 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-14Restore tdf#134951 docxexport: stop duplicating stuff in postponed textMichael Stahl
Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3 to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported by jluth the test case testfdo79008 that failed was apparently somewhat misleading and the test case testTdf134951_duplicates that should test comments erroneously failed to fail because it is doing a loadAndSave() instead of a loadAndReload(). Change-Id: I7e788287da3b1742f65697ec350997d175db9e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-12CppunitTest_sw_odfexport: rework to avoid preTest()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ie7187c7a843a191475688a4a6390514199c6a1c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-10Move HAVE_MORE_FONTS into an extra config headerJan-Marek Glogowski
No need to recompile most of LibreOffice, because the --with-fonts configure flag changed. This preprocessor define is just used by unit tests anyway. Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>