summaryrefslogtreecommitdiff
path: root/sw/qa/uitest/writer_tests3
AgeCommit message (Collapse)Author
2025-01-30More appealing design for alientformat warn dialogHeiko Tietze
Change-Id: I575f24e6b8f9dd08bd8797343a86ac25b49f19b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180713 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-19UITest_writer_tests3: fix indent in insertQrCodeMiklos Vajna
The indent is 4 spaces, and it hurts readability to violate that, given that this is Python, so no curly braces. Change-Id: I45aa85c23ab3468acbc6a6d7a37f7db19cc94836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178814 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-18Some --disable-zxing fixesStephan Bergmann
For one, UITest_writer_tests3 would crash soffie.bin in an --enable-dbgutil build with > include/vcl/vclptr.hxx:109: VclPtr<reference_type>::~VclPtr() [with reference_type = AbstractQrCodeGenDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. from within that test_insert_qr_code. But even with that out of the way, the test would still hang (in any kind of --disable-zxing build, not just --enable-dbgutil), with the Python process at > File "uitest/uitest/test.py", line 129, in wait_and_yield_dialog > time.sleep(DEFAULT_SLEEP) > File "uitest/uitest/test.py", line 151, in execute_dialog_through_command > yield from self.wait_and_yield_dialog(event, xDialogParent, close_button) > <built-in method next of module object at remote 0x7fb6fc6a0230> > File "instdir/program/python-core-3.10.16/lib/contextlib.py", line 135, in __enter__ > return next(self.gen) > File "sw/qa/uitest/writer_tests3/insertQrCodeGen.py", line 18, in test_insert_qr_code > with self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog: and the soffice.bin process idly yielding at > #14 0x00007fa582369b78 in Application::Yield () at vcl/source/app/svapp.cxx:473 > #15 0x00007fa582368a40 in Application::Execute () at vcl/source/app/svapp.cxx:360 > #16 0x00007fa58ca42fba in desktop::Desktop::Main (this=0x7fffe69ca960) at desktop/source/app/app.cxx:1679 Change-Id: I007d1497e6f0c968039af3649f6252794e222226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-28svx: Simplify "Go to Page" dialog, let SpinButton do its jobMichael Weghorn
Set the allowed range using weld::SpinButton::set_range so that weld::SpinButton makes sure that a value within the correct range is set, instead of having a custom handler called when the text of the spinbutton changes that effectively does the same thing (+ manually setting cursor to the end of the edit, but sticking to the toolkit default there instead makes sense to me for consistency). Adjust the test case to no longer type invalid input for the page number ("3a"), as SalInstanceSpinButton doesn't parse the number then, but would set the value to the minimum (here: 1) instead. (If a different behavior were intended here, that should be implemented in SalInstanceSpinButton or the underlying VCL widgets to be consistent across dialogs.) In GotoPageDlg::GetPageSelection, use weld::SpinButton::get_value to get the integer value right away, instead of getting the text and converting that into an integer manually. All that custom handling provided an interesting test case while implementing support for that dialog using native Qt widgets, see commits up to commit 70825e677f808437bd47651ebecc8a0c53955676 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 28 00:30:10 2024 +0100 tdf#130857 qt weld: Notify about spinbox combined value+text change , but apart from that (which is done now), I think that a more standard approach makes more sense. Change-Id: I06492b6629a4210c6325d50467da8e195daa4c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177463 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-12tdf#162753 - Hyperlink dialog: trim leading/trailing whitespaces of URLsAndreas Heinisch
Change-Id: Ic18d30239e8741f8a28e81e423d3dc223d709a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176409 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-11tdf#162753 - Propose clipboard content only for option internetAndreas Heinisch
Change-Id: I030bc4c824ba8946104fe2e6adfd3b445de2b238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176348 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-06tdf#162753 - Hyperlink dialog: preset only syntactically valid hyperlinksAndreas Heinisch
Change-Id: I682acfa4e41a3cce5f4639d79004bea985cabce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176112 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-07-10sw: uitest for c519de2296Xisco Fauli
Change-Id: If5e03591ba4aef6a111268b32bff305e1ec6ba8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170284 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-01-23tdf#97361 Make unittests more pythonic: XIndexAccessChenxiong Qi
Change-Id: I05ef274dd0ad5dc35b5455cfc01feabc6c0820a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161276 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-08-22tdf#101895 don't unconditionally default to ch[ar]/lineCaolán McNamara
if CJK typography is available. Given that we choose to show cm vs inch based on SvtSysLocaleOptions::GetRealLanguageTag() also choose to use ch[ar] and line based on that setting when bApplyCharUnit is enabled. Change-Id: I812d05e0639f7e214d5c3d4dcca01b0709126fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-27tdf#146576 - Propose clipboard content when inserting a hyperlinkAndreas Heinisch
Change-Id: I30067b88b3d1e196f7ecfd150f5215cc93adf095 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154931 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-28tdf#90496 - Remember last used view in hyperlink dialogAndreas Heinisch
Change-Id: I500e9e58c84486307c50f4ccb878ad0340412246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151039 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-17tdf#132293 remove some unused imports from uitestsUday Sharma
Change-Id: I7a116345e479dd5344396e845ef840bc6b5a6c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149003 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-03tdf#137883 filter: use en-dash instead of hyphen in UINamesMichael Stahl
(regression from commit ed0476b0625c4361df5ff040a6661a9634588cea) Change-Id: I7c380a9871cf16623031751bd735f456a7ea200f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148167 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-20tdf#137883 filter: rename DOCX filters to be less confusingMichael Stahl
Rename misleading "Word 2007–365" filter which corresponds to the sightly incompatible first pre-ISO version of OOXML (ECMA-376 1st edition) and is actually very specifically for Word 2007. Stop confusing users with standardese like "Office Open XML Text Document (Transitional)" and instead use the name of the application that the format is intended for, "Word 2010-365". Hopefully users will now pick the latter filter over the former. Also, the OOXML_Text_Template.xcu was missing EXPORT flag so didn't show up in Save dialog. Also, the OOXML_Text.xcu was missing SUPPORTSSIGNING flag which vmiklos said was by accident. Change-Id: I3aa88ac0fee51c906f11e75558a5d6de4f36a402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147210 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-07uitest: reset value when changing the measurement unitXisco Fauli
Otherwise, changing it in one test might affect other tests Use @contextmanager decorator to change it back to default 'Inch' at the end of the test even if the test hits an assert Change-Id: I1e7b35019cd19b490aa619c0a866bb9f93820950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-01uitest: sw: remove duplicated testsXisco Fauli
These are already covered by CppUnittests Change-Id: If41e73557566304e9e2d44ecccbf0e30b77d2807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146432 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-31uitest: remove wait_until_file_is_availableXisco Fauli
Introduced in 33a49a99c76ca1879dbb0202384aa939a6d44a75 "uitest: introduce wait_until_file_is_available" as a blind fix for https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91 It turned out the root problem was caused by another test and the fix is addressed in https://gerrit.libreoffice.org/c/core/+/146385 "uitest: Always change doc info setting back to false" Change-Id: I4b3d5e24e35a33de6c128dcbf2f144b4cf48a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146389 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-30sw: blind fix for uitest hangXisco Fauli
in sw/qa/uitest/writer_tests6/ there is another test document called edit_file_properties_before_saving.py that changes the option "Edit document properties before saving" to True. My theory is that it might affect save_readonly_with_password.py so let's move it to another folder to make sure this is not affecting the test Change-Id: Ib75361be31aceeec33df76ae31a9ee8c261a2c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146357 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-11tdf#124088 - Propose AutoText and shortcut name based on selected textAndreas Heinisch
Change-Id: I55ab9b41a32d7a4e41465f375179997a5c8dd06a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145175 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-19tdf#152295 sw sd UI: don't reset tiled image size by Area tabTibor Nagy
The background tiling images become larger when opening and closing Area tab: reopening the image properties in the Area tab shows that the Width and Height got reset to the original values of the image. Regression from commit 686349476e03f951f4a9ff9755b9f71951b64ea5 "[GSoC] Move all fill style tabs inside area tab". Change-Id: Ibc4dfd73dedd81b1b7fe17574198dd4999aab967 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143819 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-07tdf#53023 - Revert hanging unit testAndreas Heinisch
Change-Id: I7975ec874c4d636f0747417b138ffe64fb89e2cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143719 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-07tdf#53023 - Remove last empty paragraph from auto textAndreas Heinisch
Remove the last empty paragraph before inserting an auto text. The carriage return at the end of it is appended in SwXMLTextBlockParContext::~SwXMLTextBlockParContext() which can't be removed without introducing side effects. In order to compensate for the change, a paragraph has been added to the existing only text auto texts. Patch was reverted due to a hang of the ui test. It seems that selecting an entire text using mkPropertyValues({"KEYCODE":"CTRL+A"})) does not work anymore. Change-Id: I08f612d50f496c8d7f891c773ddedf27c3d80864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143781 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-07Revert "tdf#53023 - Remove last empty paragraph from auto text"Andreas Heinisch
This reverts commit ce64398653a896c8a48dd6cabe2b75d9c025873d. Reason for revert: UI-Tests hang Change-Id: Ib4b576e66da8642f3ffe8774e92a7e7c2c527b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143717 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-06tdf#53023 - Remove last empty paragraph from auto textAndreas Heinisch
Remove the last empty paragraph before inserting an auto text. The carriage return at the end of it is appended in SwXMLTextBlockParContext::~SwXMLTextBlockParContext() which can't be removed without introducing side effects. In order to compensate for the change, a paragraph has been added to the existing only text auto texts. Change-Id: Ie098f23d7bdc70798197e5714e041c8fd79f0439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143353 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-08-09uitest: sw: add test for add and remove in customize dialogXisco Fauli
intended to be a test for tdf#149966 but it's not reproducible with gen. Anyway, it's worth it to have it Change-Id: I2323bdec1f1c2b17ddd310257edec5156862b176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138036 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-08-09uitest: sw: remove duplicated testXisco Fauli
Besides, remove empty lines and simplify code a bit Change-Id: I0e756a0209b3f126f4384e1485fcbc3d8075a372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138034 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-30tdf#132293 remove unused imports and unused variables in swm.hashemian
Change-Id: I00ae07a9d02e834de34f8dd7a7f53f0c68490832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136627 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-12tdf#56363 - UI test fails if the selected font is not presentAndreas Heinisch
Change-Id: Ic8ff99464b435169460d678590896decc91f5152 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132712 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-04-09tdf#56363 - Search font family without the font feature after the colonAndreas Heinisch
In the special character dialog, search font family without the font feature after the colon in order to find the correct item in the font combobox. Change-Id: I60d068bb22782bcce062365a8d4d53e15ec34c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131953 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-02-28uitest: simplify tests even moreXisco Fauli
- No need to open the dialog to click the cancel button - Avoid repeated calls to document.DrawPage.getByIndex(0). Similar to 26298f29e9d36313be527b785a9bb96089582037 this might fix the different failures these tests sometimes have Change-Id: I4e175b6c5d48c4651e5877ec2a72c4858b590321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130727 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-28uitest: remove duplicated testsXisco Fauli
They are pretty much the same as the other one in the same file Besides, the 'with self.assertRaises(IndexOutOfBoundsException)' nonsense Change-Id: I0ad9aaf80721eb49080d94a34deb43b0bc39724c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130718 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-10uitest: executeCommand doesn't return anythingXisco Fauli
Change-Id: Ie59ed6926c42b96471f3b74a9547f7f1f2cd175a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-15uitest: simplify codeXisco Fauli
Change-Id: Id3355be0e763217a4915b53d22220c30536415e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126852 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-01uitest: fix consistency of footersXisco Fauli
According to TEMPLATE.SOURCECODE.HEADER Change-Id: I50b9d5e65c5da654914ba42d0688a2acbda1d2cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126187 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2021-12-01uitest: fix license headersXisco Fauli
Change-Id: I6b1a2808af9e6bb4d3240a83798c3c5958ef38e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126183 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-11-09uitest: pos must be of type strXisco Fauli
Change-Id: Iea469066b11abefd889143d11f86c4cdcb5e03ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124923 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-29tdf#141193 Added support for bar codes in qrcode dialog box[API Change].homeboy445
Change-Id: I6b79ece1d5419ef92b76755d3bd921a64d6e38fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113989 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-06-30uitest: combine create_doc_in_start_center methodsXisco Fauli
Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: guard create_doc_in_start_center in swXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I513c76fe3536ce2d541b3588ce3f23990a0771be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118145 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: combine execute_dialog_through_command methodsXisco Fauli
Change-Id: Iaa03d37a9ac3862b8cb08a81e37a611632433880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118077 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: guard execute_dialog_through_command in swXisco Fauli
Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9def7e8fd8256c3131ca2904f78976b9cd59aa96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118037 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-24Revert "uitest: guard create_doc_in_start_center"Xisco Fauli
This reverts commit 374baf308979306aa35575118c40ccd7caae1e29. Many uitests are failing randomly in jenkins for no apparent reason Change-Id: I5960330fab4967518bfeea32b3b8c5f8bfbea57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117752 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22uitest: guard create_doc_in_start_centerXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I75ef7712af3676363a9a464acf83f6f68ffc4f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117617 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22uitest: guard load_fileXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ia924293dc2a12230fd13f69fd734875ced86be8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117593 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22configure: Improve help-options handlingJan-Marek Glogowski
This patch includes: * A README.help.md as a general documentation for the different help types, the LO code and help-related build options. * Adds --disable-xmlhelp for removing the xmlhelp support from the build. Disable for iOS, Android and Emscripten. This was partly included in HAVE_FEATURE_DESKTOP before. * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the actual usage AFAIK. * Depend --with-omindex on --with-help=online and don't override the --with-help setting. Error out on conflicting options. * Depend --with-helppack-integration on build help variants, which actually result in help packs. Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a ("Building without --with-help is not supposed to disable help functionality"). Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-21uitest: guard execute_blocking_actionXisco Fauli
so even if an assert fails, the dialog is closed afterwards for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9a3adb52546238d960eeaaaf03b6bdbbd5718cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117392 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-08Make test_tdf141166 work also on macOS (where help is ⌘H, not ^H)Stephan Bergmann
However, without the additional 'FOCUS' action, the test would no longer verify the fix for <https://bugs.documentfoundation.org/show_bug.cgi?id=141166> "Crash in: mergedlo.dll: Press "Help" button in Hyperlink dialog", namely 92220638362755f0e776e222fa4e8b79377e75eb "tdf#141166 widget with id 'tabcontrol' might not be a TabControl": At least for a --without-help Linux build, in Window::RequestHelp at vcl/source/window/window.cxx:1897, > else if (!mpWindowImpl->maHelpRequestHdl.IsSet() || mpWindowImpl->maHelpRequestHdl.Call(*this)) the leading `!mpWindowImpl->maHelpRequestHdl.IsSet()` would be true, so the trailing `mpWindowImpl->maHelpRequestHdl.Call(*this)` would not be called and would thus not lead to the problematic call of VclBuilder::get<TabControl>. Change-Id: I35a687834b4eef46b81cc032c2f298ded8490f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113347 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-08tdf#132293 removed all the unused imports from the folder swVatsal32
Change-Id: I5a37f30941a73c276bc238fa9fbdfcfd8381791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112563 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-20 05:56:55 +0000