summaryrefslogtreecommitdiff
path: root/sw/qa/uitest/writer_tests4
AgeCommit message (Collapse)Author
2024-12-26pdf: Rearrange general tab of PDF dialog, add PDF vers. selectionTomaž Vajngerl
Repurpuses PDF/A combobox to also add PDF 1.7 and PDF 2.0 as options, as those are exclusive (either you have classic PDF, or you select PDF/A which is a special version of some PDF version. No need to have a check box for PDF/A anymore, so this was removed. - Moved the version selection to top - Added "Forms" frame, which for all the form options. - Moved Tagged PDF into "Structure" frame. - Reworded some text (extended tips, tooltips) for PDF versions Change-Id: I731222ee02afea6a49e4213d18f27d1beae9da10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178270 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178768 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-08tdf#155447 a11y: Set accessible ID that Orca expectsMichael Weghorn
Orca commit [1] commit 40a2d302eb52295433fd84e6c254a7dbe5108a24 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Nov 7 14:15:07 2024 +0100 Spellcheck: Check for accessible id in more places Do the following case-insensitive checks: * If the object's accessible id starts with "suggestions" treat it as the suggestions list. * If the object's accessible id starts with "replacement" treat it as the object (likely entry) which contains the proposed replacement. * If the label's/widget's accessible id starts with "error" treat it as the container displaying the misspelled word. Note that the first of the three is based on what LO 25.2 currently exposes ("suggestionslb"). The other two are not in use yet, but adding them facilitates implementation in, and getting feedback from, apps and toolkits. Also modify the existing check for the window. We were doing an exact match on "SpellingDialog". Making that case insensitive and limiting to starts with "spelling" works with the current LO implementation and removes an implementation detail ("dialog"). introduced logic to identify more UI elements in the spelling dialog by their accessible ID. Adjust the GtkBuilder ID (which gets reported as accessible ID as well) of the drawing area that holds the misspelt text to match the expectations as mentioned in the commit message above. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24 Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-02tdf#145161: Change pdf and image compression dialog stringAditya Sahu
Since image/pdf compression does not always reduce image or pdf resolution, change the misleading label from "reduce" to "change" wherever possible. Keep identifiers having "reduce" in their name as is as of now, only change the string values containing "reduce" to "change". Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-30tdf#153040 PDF export: disable export of form fields as PDF forms by defaultMiklos Vajna
Open <https://bugs.documentfoundation.org/attachment.cgi?id=195586>, notice that from "bbb", the middle "b" is bold, export to PDF, none of the "b"s are bold. The reason for this is that by default we map form controls and content controls to fillable PDF forms, which can only contain plain text. Fix the problem by defaulting to not exporting form controls / content controls to PDF forms: most users just want a PDF that is close to what they saw in the edit window -- and the ones who want a fillable PDF form can still opt in. Once the UI checkbox is enabled, we even remember that. Based on <https://gerrit.libreoffice.org/c/core/+/152622>, thanks Justin! Change-Id: Iddb75d1dbd969045321e139154f254c059eebf16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171226 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-07-13Python: use is None/is not None instead of == None/!= NoneJulien Nabet
Change-Id: I1c34181897506ad29a063865d752cb85ab76dbc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170408 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-03-28tdf#158803 Remove unused imports from uitestBogdan Buzea
Change-Id: I9808d74b5499660f80242c09f1ccfe4975e2b39e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165328 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-21tdf#159418: sw: Add UItestXisco Fauli
Change-Id: Ic41eac4909e85544f5c195cebb59e32745c09f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165070 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-19Fix for test related to tdf#157992Oliver Specht
KEYCODE is 'RIGHT' not 'KEY_RIGHT' Change-Id: I908f11db40737d9c188a9f4464f71ac0c67b40dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163595 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-02-15tdf#157992: add test to make sure footnotes don't get deletedOliver Specht
This tests calls the SpellDialog with a paragraph containing a footnote. Prior to the fix of tdf#157992 the footnote had been deleted when the spelling error has been manually fixed. Change-Id: Ib57d49d8fad153c96daa1b1f6554abebd272a7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163351 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-23tdf#97361 Make unittests more pythonic: XIndexAccessChenxiong Qi
Change-Id: I05ef274dd0ad5dc35b5455cfc01feabc6c0820a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161276 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-12-21Add export sheet range option to calcNickWingate
User can specify which sheets to export e.g. '2-5,7' exports sheets 2,3,4,5,7. Note: this is different from exporting pages as one sheet may contain several pages worth of content. Also fix a bug where exporting only a selected sheet causes the next sheet to be exported. e.g.: Sheet 1 is empty, Sheet 2 has content. Exporting Sheet 1 results in Sheet 2's content being exported Signed-off-by: NickWingate <nick.wingate@collabora.com> Change-Id: Iecd42188ddbbbcd70eb37bec80783e29e3cb5b19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156255 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-18tdf#45949, tdf#152492: move UITest to CppUnittestXisco Fauli
Disable the test on mac because it fails with Test name: testTdf45949::TestBody equality assertion failed - Expected: 2 - Actual : 1 Change-Id: I366eba2db939b25f70a859c6622901c1e0f55718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158082 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-04tdf#128192: Fix Tools/AutoCorrect/ApplyBaole Fang
AutoCorrect() is applied in GET_ALL_INFO and HAS_FMTCOLL stage. Also, UITest is added by examining whether "Replace dashes" is performed. Change-Id: Idcb34ad03c4fe8df27ed126bf39ce23ab4f02846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151008 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-16tdf#39667 filter,officecfg: PDF export dialog: set initial view to...Michael Stahl
... Outline for PDF/UA. * change the dialog to disable the radio buttons if PDF/UA is enabled * also change the configuration to make Outline the default Change-Id: Iea8c5e0f8560c972dc250859198bea1cb9fc3597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148883 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-13tdf#39667 Enable tagged PDF by defaultSamuel Mehrbrodt
And adjust some tests accordingly Change-Id: If81803ba48485273939f419ad589dc6dd2e9c531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148303 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-02-07uitest: reset value when changing the measurement unitXisco Fauli
Otherwise, changing it in one test might affect other tests Use @contextmanager decorator to change it back to default 'Inch' at the end of the test even if the test hits an assert Change-Id: I1e7b35019cd19b490aa619c0a866bb9f93820950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-01uitest: sw: remove duplicated testsXisco Fauli
These are already covered by CppUnittests Change-Id: If41e73557566304e9e2d44ecccbf0e30b77d2807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146432 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-01tdf#107427: sw: move UItest to CppUnittestXisco Fauli
Change-Id: I13b8757c384c3ecd23c0b06b93e2db03ce0b364e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146431 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-31uitest: remove wait_until_file_is_availableXisco Fauli
Introduced in 33a49a99c76ca1879dbb0202384aa939a6d44a75 "uitest: introduce wait_until_file_is_available" as a blind fix for https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91 It turned out the root problem was caused by another test and the fix is addressed in https://gerrit.libreoffice.org/c/core/+/146385 "uitest: Always change doc info setting back to false" Change-Id: I4b3d5e24e35a33de6c128dcbf2f144b4cf48a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146389 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-26tdf#146248: sw: move UItest to CppUnittestXisco Fauli
Change-Id: Ibb198808d124457f6676cdf642b75289948514d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146174 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-10tdf#146248 sw: fix crash at Undo of hiding page header/footerLászló Németh
When Same content on first page is enabled, Undo could result crashing after hiding header/footer with its local menu. Note: the problem could occur in DOCX more frequently, because of special handling of its header/footer, see commit f5dc6b11d2218d94c9effe7a1ab418d0133da5e3 "tdf#140117 sw UI: keep headers/footers when inactive". Manual test: load the unit test document, delete the header with its blue local menu (not with the Page Style dialog window!), and press Undo. (The Python UITest does the same, but with dispatcher calls). Regression from commit 65e52cb61d74b0c71b45b63b2da131bc6b621104 "tdf#141613 sw: fix crash at header/footer undo". Change-Id: If89d5af2e0d123d6913dfc6a4bea1ddbaf3bd80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145244 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-06tdf#65535 sw spellDialog.py: fix lo-upsan buildLászló Németh
Lo-upsan build didn't replace the bad word in the test, maybe because of dictionary or timer problems. Skip testing the (here: sometimes missing) text changes, keep only testing of the remaining comment, which was the target of the original fix. This reverts commit d2614337e8291b9b6d114fda5ae914f6940c353a "tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build" and commit 81163c384364e4b5c99392b76f027f8c2b87c259 "tdf#65535 sw spellDialog.py: fix lo-upsan build better". Change-Id: Ib5faa4e02bf6dd085d6666748ae76f67b4e07497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145138 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-05tdf#65535 sw spellDialog.py: fix lo-upsan build betterLászló Németh
Follow-up to commit d2614337e8291b9b6d114fda5ae914f6940c353a "tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build". Change-Id: Ibb7e5e4afe1cab99fc24342afb94458f612ec3f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145073 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-03tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan buildLászló Németh
The problem reported by Stephan Bergmann: FAIL: test_tdf65535 (spellDialog.SpellingAndGrammarDialog) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests4/spellDialog.py", line 237, in test_tdf65535 self.assertEqual("Bad baad", output_text) AssertionError: 'Bad baad' != 'Baad baad' - Bad baad + Baad baad ? + Change-Id: Icd656544946f3d6b67fefd9980872bbee6608fab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144964 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19tdf#65535 sw: fix lost comments using spelling dialogLászló Németh
Choosing one of the spelling suggestions in the spelling dialog, or rewriting the bad word removed also its inword comment. Keep the comment at the end of the fixed word. Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8 "0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002". Change-Id: Iaf083453fad4e0ca99e254f53b20ead86b3ba15e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144458 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-13tdf#45949 sw: add spell checking to hyperlinked textLászló Németh
Recognize plain words within hyperlinks and check their spelling. Not only URLs and e-mail addresses, but plain text of hyperlinks were removed from spell checking, which didn't conform to the specification: "URLs are skipped during spell checking Spelling of URLs in document doesn't make sense, because the words are not separated and often they aren't natural words at all. Since we can only decide what we know, we will only except URLs from spelling already recognized/formatted as URLs and if the URL and the text representation are equal." http://specs.openoffice.org/appwide/linguistic/Spellcheckdialog.sxw, see also https://bz.apache.org/ooo/show_bug.cgi?id=40133. Follow-up to commit ec8fdffec29de7c80da0c2a440e467c35a297119 "tdf#152492 sw: fix unwanted spell checking of parts of URLs" and commit 2cca160f8bfc4597cf0ad3aaaf0017a5210ea0ec "tdf#126657, tdf#145104: Don’t set language to none on defined styles". Change-Id: If2698c54bcdee0de635abd324173c909d9161a02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144044 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-13tdf#152492 sw: fix unwanted spell checking of parts of URLsLászló Németh
In new documents, spell checking started to report spelling mistakes within the recognized URLs. Regression from commit 2cca160f8bfc4597cf0ad3aaaf0017a5210ea0ec "tdf#126657, tdf#145104: Don’t set language to none on defined styles". Note: skipping spell checking of recognized URLs was specified by http://specs.openoffice.org/appwide/linguistic/Spellcheckdialog.sxw, see also https://bz.apache.org/ooo/show_bug.cgi?id=40133. Unfortunately, the original implementation caused possible regressions in text layout, so it was reverted in the previous commit. Change-Id: Ic5f84c8ec195677640a8870f2c484f3b6ef8b9db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143946 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-06-30tdf#132293 remove unused imports and unused variables in swm.hashemian
Change-Id: I00ae07a9d02e834de34f8dd7a7f53f0c68490832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136627 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-14sw: uitest: remove assert that fails depending on which...Xisco Fauli
... components are installed Change-Id: Ib0090d6afcc824942ac9a0c89757ba7faf068637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135798 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-16Fix a UITest on WindowsMike Kaganski
Change-Id: I943a7696fd896c8709fdcd25bce650dd80244daf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134367 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-16Fix a UITest on WindowsMike Kaganski
Change-Id: Ieb6d04e344b1d875f2661833e17f64930681e528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134366 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-11tdf#148395: sw: Add UItestXisco Fauli
Change-Id: Id0e49ba6f0834dc85a26f4d9064dfe029a50fa35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132837 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-25uitest: introduce wait_until_file_is_availableXisco Fauli
For export - import tests See https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91 Change-Id: I3c2537a43cc69067355f18162d6463e268420090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130530 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-24uitest: check the value and not the textXisco Fauli
This fails for me with AssertionError: '90%' != '90\xa0%' - 90% + 90 % Change-Id: Ieec52a4aff721705451a0545eb606c97235b1248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130507 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-15uitest: simplify codeXisco Fauli
Change-Id: Id3355be0e763217a4915b53d22220c30536415e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126852 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-14tdf#136855: sw: Add UItestXisco Fauli
Change-Id: I2626f56d59456f0e4c0942f4783c6b5270534260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126843 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-01uitest: fix consistency of footersXisco Fauli
According to TEMPLATE.SOURCECODE.HEADER Change-Id: I50b9d5e65c5da654914ba42d0688a2acbda1d2cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126187 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2021-12-01uitest: fix license headersXisco Fauli
Change-Id: I6b1a2808af9e6bb4d3240a83798c3c5958ef38e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126183 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-11-28Revert "tdf#129183 sw: textboxes in group shapes - part 3"Stephan Bergmann
This reverts commit eabcfb3f18a6944d9ad89cecd3eb3ca7a2259cf3. Conflicts: sw/source/core/doc/textboxhelper.cxx It caused UITest_writer_tests4 to fail in an ASan build with > ==2987325==ERROR: AddressSanitizer: heap-use-after-free on address 0x6130000e5048 at pc 0x7f20cb3112ac bp 0x7f1e62de92d0 sp 0x7f1e62de92c8 > WRITE of size 8 at 0x6130000e5048 thread T47 > #0 in SwFrameFormat::SetOtherTextBoxFormat(SwTextBoxNode*) at sw/inc/frmfmt.hxx:106:77 > #1 in SwTextBoxNode::~SwTextBoxNode() at sw/source/core/doc/textboxhelper.cxx:1680:30 > #2 in SwFrameFormat::~SwFrameFormat() at sw/source/core/layout/atrfrm.cxx:2564:9 > #3 in SwDrawFrameFormat::~SwDrawFrameFormat() at sw/source/core/layout/atrfrm.cxx:3455:1 > #4 in SwDrawFrameFormat::~SwDrawFrameFormat() at sw/source/core/layout/atrfrm.cxx:3453:1 > #5 in SwFrameFormats::DeleteAndDestroyAll(bool) at sw/source/core/doc/docfmt.cxx:2115:9 > #6 in SwDoc::~SwDoc() at sw/source/core/doc/docnew.cxx:565:28 > #7 in SwDoc::release() at sw/source/core/doc/doc.cxx:118:9 > #8 in rtl::Reference<SwDoc>::clear() at include/rtl/ref.hxx:196:19 > #9 in SwDocShell::RemoveLink() at sw/source/uibase/app/docshini.cxx:444:16 > #10 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:372:5 > #11 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #12 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #13 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:163:29 > #14 in tools::SvRef<SfxObjectShell>::~SvRef() at include/tools/ref.hxx:56:36 > #15 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at sfx2/source/doc/sfxbasemodel.cxx:245:5 > #16 in void std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15 > #17 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:537:4 > #18 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2 > #19 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6 > #20 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11 > #21 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31 > #22 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1272:9 > #23 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:757:13 > #24 in SwXTextDocument::dispose() at sw/source/uibase/uno/unotxdoc.cxx:549:19 > #25 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1482:5 > #26 in SwXTextDocument::close(unsigned char) at sw/source/uibase/uno/unotxdoc.cxx:562:19 > #27 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:718:13 > #28 in SwXTextDocument::dispose() at sw/source/uibase/uno/unotxdoc.cxx:549:19 > #29 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > #30 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 > #31 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13 > #32 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:235:13 > #33 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:78:26 > #34 in request at binaryurp/source/reader.cxx:85:9 > #35 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100:17 > #36 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:164:31 > #37 in threadFunc at include/osl/thread.hxx:189:15 > #38 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:264:9 > #39 in start_thread at <null> > #40 in __GI___clone3 at <null> > > 0x6130000e5048 is located 328 bytes inside of 376-byte region [0x6130000e4f00,0x6130000e5078) > freed by thread T47 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3 > #1 in SwFlyFrameFormat::~SwFlyFrameFormat() at sw/source/core/layout/atrfrm.cxx:2912:1 > #2 in SwFrameFormats::DeleteAndDestroyAll(bool) at sw/source/core/doc/docfmt.cxx:2115:9 > #3 in SwDoc::~SwDoc() at sw/source/core/doc/docnew.cxx:565:28 > #4 in SwDoc::release() at sw/source/core/doc/doc.cxx:118:9 > #5 in rtl::Reference<SwDoc>::clear() at include/rtl/ref.hxx:196:19 > #6 in SwDocShell::RemoveLink() at sw/source/uibase/app/docshini.cxx:444:16 > #7 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:372:5 > #8 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #9 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #10 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:163:29 > #11 in tools::SvRef<SfxObjectShell>::~SvRef() at include/tools/ref.hxx:56:36 > #12 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at sfx2/source/doc/sfxbasemodel.cxx:245:5 > #13 in void std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15 > #14 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:537:4 > #15 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2 > #16 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6 > #17 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11 > #18 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31 > #19 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1272:9 > > previously allocated by thread T10 here: > #0 in operator new(unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 > #1 in SwDoc::MakeFlyFrameFormat(rtl::OUString const&, SwFrameFormat*) at sw/source/core/doc/docfmt.cxx:756:33 > #2 in SwDoc::MakeFlySection_(SwPosition const&, SwContentNode const&, RndStdIds, SfxItemSet const*, SwFrameFormat*) at sw/source/core/doc/doclay.cxx:171:33 > #3 in SwDoc::MakeFlySection(RndStdIds, SwPosition const*, SfxItemSet const*, SwFrameFormat*, bool) at sw/source/core/doc/doclay.cxx:337:19 > #4 in SwXFrame::attachToRange(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, SwPaM const*) at sw/source/core/unocore/unoframe.cxx:2821:29 > #5 in SwXFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3115:9 > #6 in SwXTextFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3346:15 > #7 in SwXText::insertTextContent(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, unsigned char) at sw/source/core/unocore/unotext.cxx:615:15 > #8 in SwXText::insertTextContentWithProperties(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unotext.cxx:1472:5 > #9 in non-virtual thunk to SwXText::insertTextContentWithProperties(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unotext.cxx > #10 in SwTextBoxHelper::create(SwFrameFormat*, SdrObject*, bool) at sw/source/core/doc/textboxhelper.cxx:100:29 > #11 in SwXShape::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) at sw/source/core/unocore/unodraw.cxx:1165:25 > #12 in SdXMLShapeContext::SetStyle(bool) at xmloff/source/draw/ximpshap.cxx:701:27 > #13 in SdXMLCustomShapeContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at xmloff/source/draw/ximpshap.cxx:3545:5 > #14 in SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at xmloff/source/core/xmlimp.cxx:805:15 > #15 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) at sax/source/fastparser/fastparser.cxx:468:27 > #16 in sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:1304:21 > #17 in (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:331:18 > #18 in xmlParseStartTag2 at workdir/UnpackedTarball/libxml2/parser.c:9658:6 > #19 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11453:14 Change-Id: I752190e05fc3c282b75021724527f623f56ee6a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125977 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-24tdf#129183 sw: textboxes in group shapes - part 3Attila Bakos (NISZ)
Grouping/ungrouping nested groups works now. Manual test: 1. Insert Shape. 2. Right-click on selected shape, Add Text Box (and some text). 3. Insert a new shape. 4. Select and group the two shapes. 3. Insert a third shape. 4. Select and group the shape and the previously grouped shapes. The text box remains in the nested shape group. Details: 1) tdf#144271 memory leak of SwTextBoxHelper, by replacing the textbox structure vector with std::unordered map, and rethinking of the ownership of the objects. If a SwFrameFormat dies, and that is a FLYFRMFMT, it will be deleted from the textbox node and the FrameFormat table in the doc too, and the drawing will be stay as it was before. If the dying format is a drawing, all the textboxes, and the node will be deleted. 2) Introducing the new UNO property TextBoxContent, which is needed for writerfilter/xmloff later to set a new textbox for the shape via UNO. 3) Missing parameters are present now for syncing the textbox parameters. 4) Introducing a new function namely the handleGroupTextBox() to do the tasks simply with all textboxes in a group shape. This can handle nested groups as well (group in a group). Known issues: now copy of nested group objects is implemented but not enabled, because it causes an assert. Change-Id: I931886eda01c7a3db93098de10f5e5f48f2f217b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124657 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-12uitest: sw: Add UItest for .uno:ExportToPDFXisco Fauli
Change-Id: Icb28ec46e2db5c67f105a61a79e65edfde1df6a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125081 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13uitest: combine execute_modeless_dialog_through_command methodsXisco Fauli
Change-Id: Idada1927f6b8b55133e1ff8c776a987699df1dc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122012 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-13uitest: guard execute_modeless_dialog_through_command in swXisco Fauli
Change-Id: Ie3acd6eb716d6d3532bb50b5b9002f80044a2bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121913 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-06uitest: move table tests where they belongXisco Fauli
Change-Id: I2f756b3176f1f406cc659ff1c13a368906e33cbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118469 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: combine create_doc_in_start_center methodsXisco Fauli
Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: guard create_doc_in_start_center in swXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I513c76fe3536ce2d541b3588ce3f23990a0771be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118145 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: combine execute_dialog_through_command methodsXisco Fauli
Change-Id: Iaa03d37a9ac3862b8cb08a81e37a611632433880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118077 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: guard execute_dialog_through_command in swXisco Fauli
Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9def7e8fd8256c3131ca2904f78976b9cd59aa96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118037 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-27uitest: remove duplicated calls to get_component()Xisco Fauli
after 8298aa62726312eee6f8fbb64a9fc9b12680447f < uitest: guard execute_blocking_action > Change-Id: I954c11c42620660afd48a585f5c59ff2196f4b6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117738 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-25uitest: guard execute_dialog_through_actionXisco Fauli
Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I8b0e4aa746f7973b1bd1343219820d8b2315cf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117703 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>