summaryrefslogtreecommitdiff
path: root/sw/qa/uitest/writer_tests8
AgeCommit message (Collapse)Author
2024-12-10tdf#125969 cui: add in-use area image to bitmap listJustin Luth
This fixes a five year old (non-)easyhack with 3 duplicates. Note the nice-to-have dependencies in the bug report(s). When the document has a unique background (area) image, it is now added to the list of available images IF/WHEN the user looks in the area tab. This allows the user to switch back after changing, or re-use it in other places in the document. Most of this patch ended up being plumbing to ensure that this added image is ONLY available to the current document, because it MUST NOT be saved to the user profile. This change affects all apps and all types of areas: NICE -tested Writer pages, paragraphs, headers, textbox, sidebar(page) -tested Calc page style -tested Draw page, sidebar(page), textbox Caveats: -the bitmap list is NOT updated at the time of document import, only when area property inspected. (The bug requesting inclusion at the time of import is tdf#100832). make -srj1 UITest_writer_tests8 \ UITEST_TEST_NAME=tdf125969.tdf125969.test_tdf125969 \ SAL_USE_VCLPLUGIN=gen Change-Id: Ic9fea9b199602c4df1376e781d5df019526473d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176253 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-16tdf#132293 Remove unused import from uitestAshok
Change-Id: Id248ccedd7e99a434528c2afb0d1b00631c927de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174984 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-03tdf#134166 sw: Fixed RTL/LTR toolbar buttons not updatingJonathan Clark
This change fixes an intermittent issue causing the text direction toolbar button states to not reflect page text flow setting changes. Change-Id: Ia20283b7efd4402dfa3b4ea9532d2b8ca6b1c8e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174414 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-07-28sfx2, solenv, sw: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: Iab375e8c8aa4c4915f3c70a9ef6aede268e4619f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171138 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-13Python: use is None/is not None instead of == None/!= NoneJulien Nabet
Change-Id: I1c34181897506ad29a063865d752cb85ab76dbc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170408 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-07-03disable most of tdf159102 UITest againNoel Grandin
because it fails reliably on my machine and on the ASAN box Change-Id: I4eddbcc04f96837783a41fb30e4d003d11c14aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169890 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-02tdf#159102 sw: add missing get_url_for_data_file to the unit testLászló Németh
Partial revert of commit 5fa3abd3b28b7c30d015dc058f7719112003f51e "tdf#158803 Remove unused imports from uitest". Follow-up to commit c6d7b7fa686b742c6ffef42aa6cc280358babe0d "tdf#159102 sw: enable unit test again with extended test document". Change-Id: Id6397d322f25f1b3e981d8e206a54bb79a54b831 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169848 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-07-01tdf#159102 sw: enable unit test again with extended test documentLászló Németh
It seems, incomplete document settings resulted broken unit testing on some platforms, so complete the test document with the removed document settings, and enable the test again. This reverts also commit 1b83ebf42c535528b73baac2407b347f19070d07 "disabling UITest tdf159102". Change-Id: I53f008a096aa209fb2c634e7e2464a1a4acbab71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169842 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-07-01tdf#160170 sw: test for fix overshrank lines with hyphenationLászló Németh
Follow-up to commit ca540209a8c20a2734f180d4706d5153bdf64523 "tdf#160170 sw: fix overshrunk justified lines at hyphenation". Change-Id: Ia983e7f560b996f9b11b679d346186ad39e85598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169840 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-05-08Revert "tdf#150037 Writer: text fieldmark behaviour changed"Justin Luth
This reverts 24.8 commit 96323a10d3a55d212c350886e2a1344c0cd2ba95. A mouse click selects the fieldmark to be able to overwrite the field with the next text input. But I did not revert: Additionally the EN SPACE (0x2002) character is visualized by the DEGREE symbol when 'View/Formatting Marks' is active. The problem was that the field itself was also selected, so not only was the placeholder text overwritten, but so was the entire field. Additionally, it is ONLY placeholder text that should be selected, but this was also selecting non-placeholder (i.e. custom user-entered text) that was being pre-selected which is NOT what happens in MS Word. The whole point of the patch in the first place was to emulate MS Word's response to placeholder text, so we should also be emulating what happens to non-placeholder text. That would require tracking whether the field's text was placeholder or not, which is not currently track in legacy fields. Change-Id: I0a1a22f82827cd5f9d9abfb52cd562dff4651b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167139 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-03-28disable part of tdf150443 UITest for nowNoel Grandin
Very unreliable. Running make UITest_writer_tests8 by itself will fail 50% of the time for me. Change-Id: I841429d69249f3dd302013b781e7664d25e1387c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165453 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-28tdf#158803 Remove unused imports from uitestBogdan Buzea
Change-Id: I9808d74b5499660f80242c09f1ccfe4975e2b39e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165328 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-08tdf#146356: sw: move UItest to CppUnittestXisco Fauli
Change-Id: Ic1cd24dabf58e2aea2ed7c6e4a6c62f4fbc4f094 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164565 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-07test of tdf#146356Oliver Specht
Inserts a paragraph in front of a protected table of contents and inserts text into the new paragraph Change-Id: I951fa2bea63dc2b5721876268aa27a8df579b210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164480 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-07tdf#157518: add uitest for password policySarper Akdemir
Change-Id: If246779c944fe250c0070094450545d688712ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164390 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-03-04tdf#150443: replace missing fonts in testfileXisco Fauli
This commit reverts 0b21e2a404c114529376dc50764dc0286dafc745 "sw: UITest_writer_tests8 test_tdf150443 more tolerant" Change-Id: If83a7b0a8dc2289aba3201edfdf19d0ca839459a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164392 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-03-04Fix typoAndrea Gelmini
Change-Id: I4242a774d29bd700a5459485938d593a49abfaa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164391 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-04sw: UITest_writer_tests8 test_tdf150443 more tolerantMichael Stahl
This fails on Fedora 39, also in the libreoffice-24-2 branch, with: self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], "4") AssertionError: '5' != '4' Presumably a font substitution changing metrics problem, as "NexusSansOT" is not found. It looks like the exact page doesn't matter for the test. Change-Id: I62eadb8321352ea47a0f8f83ab91fd50ff01f7e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164353 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-03-01Revert "Unit test to tdf159797"Xisco Fauli
This reverts commit 173a79365b110cf70f628a602a22049562a477f5. Reason for revert: This is already covered in 66b30842e86fb6041bd6a453c6e3a877a3c177c1 with a CppUnittest, which is preferable to UItests Change-Id: I80ddb4f3d1da047e0c994fd3137a78ab70081edb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164191 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-01Unit test to tdf159797Oliver Specht
checks replacement of dash to endash after sentence Change-Id: I61843825faaf212eb5560797f1b6a2fdad5efce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164086 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-02-15sw: move some UItests from writer_tests7 to writer_tests8Xisco Fauli
writer_tests7 had 47 tests while writer_tests8 6 Now they have 31 and 22 respectively Change-Id: Iac839c7328d346bc8342ce2f8a20359aeca1206a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163384 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-01-25disabling UITest tdf159102Noel Grandin
because it still fails on my machine reliably Change-Id: I482b8235cd910ff16b1b15bb0427c5d6a8140751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-24tdf#106733 sw cui: add CharNoHyphenation checkboxLászló Németh
On Position tab of Character formatting dialog window as a new checkbox "Exclude from hyphenation" (UX design by Heiko Tietze). With this, it's possible to disable hyphenation with direct character formatting (e.g. combined with Find All), or using character styles, and setting "Exclude from hyphenation" in them. This feature is conformant to the OpenDocument standard, and unlike the previous locale=None workaround, it keeps spell checking and locale dependent text layout. Note: Clear direct formatting (Ctrl-M) is an alternative way to remove the enabled CharNoHyphenation (e.g. in version 24.2, where this commit won't be back-ported). Follow-up to commit b5e275f47a54bd7fee39dad516a433fde5be872d "tdf#106733 sw: implement CharNoHyphenation". Change-Id: I26823e6ec2a3ca39dcf0f7c051d96e638921c589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162514 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-01-19tdf#106733 sw: implement CharNoHyphenationLászló Németh
Implement CharNoHyphenation character property to disable automatic hyphenation of words in paragraphs with enabled hyphenation. Fix also fo:hyphenate mapping to CharNoHyphenation using automatic inversion of their boolean values defined by xmloff's XML_TYPE_NBOOL, as suggested by Michael Stahl. Update also the test for tdf#159102 to check the available hyphenation dictionary (also custom hyphenation patterns work only with supported locales of the hyphenator). Note: patch of thints.cxx contains also partial revert of commit 53b289eabb3d265b47bc7fb6cc430291c97f0c0b "use more TypedWhichId". Follow-up to commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372 "tdf#106733 xmloff: keep fo:hyphenate in character formatting". Change-Id: If99b94ddcd44a5c2426e646be149078a3b9773b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162300 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2024-01-18tdf#159102 sw smart justify: fix automatic hyphenationLászló Németh
As before with soft hyphens, automatic hyphenation could result too much shrinking, because of calculating with an extra non-existing space in the line. Also try to shrink the line only if a space likely will be available in it. During testing, extend user dictionary temporarily with custom automatic hyphenation to avoid of false tests because of non-available hyphenation patterns. (Note: maybe the other tests with non-user dictionary based automatic hyphenations are not correct.) Follow-up to commit d511367c102ef2ada0f73dbe81744d39865d58ba "tdf#195085 sw smart justify: fix bad shrinking at soft hyphen". Change-Id: I58ecb8f1ea9f55ef2457d7ff4aca6aefa59a6dd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162199 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-01-17tdf#150037 Writer: text fieldmark behaviour changedOliver Specht
A mouse click selects the fieldmark to be able to overwrite the field with the next text input. Additionally the EN SPACE (0x2002) character is visualized by the DEGREE symbol when 'View/Formatting Marks' is active. Word's FORMTEXT ist usually filled with EN SPACE. Change-Id: I82446473d31bc5ea101bd1b94a50a855351d88b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161044 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-27tdf#158803 Fix issues detected by pyflakesChenxiong Qi
Change-Id: Iaa329dff61db894e7d5fecd840e785a53a48b26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160889 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-12-04UITest_writer_tests8: do not use custom configurationXisco Fauli
Added with b6e273aaaf597b60f78c1dd3db8676eea958a9f5 "tdf#156243 Fix off-by-one bug for autocorrect" Change-Id: Ib9ce030cbc83514db174c39f5688d7382698d874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160297 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-11-25tdf#156243 Fix off-by-one bug for autocorrectMatt K
This change removes the "-1" from the code that applies the autocorrection so that the entire string to be autocorrected is replaced, instead of leaving off the last character. Also, the starting character of the string is preserved (i.e. non-bold if changing to bold) by adding 1 to the start position; this is for the case when the user cancels the autocorrect dialog. Change-Id: Ibe500a1ba0ca5b12ec9c918b51353074b8dd12ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154685 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>