summaryrefslogtreecommitdiff
path: root/sw/qa/uitest
AgeCommit message (Collapse)Author
2021-06-22configure: Improve help-options handlingJan-Marek Glogowski
This patch includes: * A README.help.md as a general documentation for the different help types, the LO code and help-related build options. * Adds --disable-xmlhelp for removing the xmlhelp support from the build. Disable for iOS, Android and Emscripten. This was partly included in HAVE_FEATURE_DESKTOP before. * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the actual usage AFAIK. * Depend --with-omindex on --with-help=online and don't override the --with-help setting. Error out on conflicting options. * Depend --with-helppack-integration on build help variants, which actually result in help packs. Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a ("Building without --with-help is not supposed to disable help functionality"). Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-21uitest: guard execute_blocking_actionXisco Fauli
so even if an assert fails, the dialog is closed afterwards for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9a3adb52546238d960eeaaaf03b6bdbbd5718cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117392 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-18tdf#109083 sw table styles: fix missing format update of tablesBalazs Santha
at table (cell) selection. Table styles (implemented as table templates yet) allows to format all tables (with the same table style) at once. Unfortunately, this worked only without table selection, putting the text cursor in a table cell. But if a table cell/row/column or the whole table was selected (e.g. after changing its format), Manage Styles(F11)->Table Styles-> Style actions menu (see top-right corner of the pane)-> Update Selected Style updated only the style, but it doesn't propagate the changes to the other tables with the same table style. This patch removes the selection to fix the problem in the same way, as the proposed workaround. Note: this fixes the usage of the user-defined table styles, too (created by Style actions->New Style from Selection). Change-Id: I58d01036d5a11e522407405e9ebc16c2c3c83e9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117079 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-17tdf#90401 xmloff: remove personal info of comments and changesLászló Németh
If Options → LibreOffice → Security → Security Options and Warnings → Options... → Security Options → Remove personal information on saving" is enabled. Use the same time (1970-01-01T00:00:00) for mandatory time stamps, and replace authors and creator-initials with "1", "2", "3" etc., also to avoid of joining adjacent redline ranges. Note: to see the work of the unit test in Linux command line: (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info" SAL_USE_VCLPLUGIN=gen) Change-Id: I3b4d710dbeeee12177aff378597cd2b683ca6c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-07sw/qa/uitest: close the dialog if thrown an exceptionHenry Castro
if a unit test opens a dialog and exception is thrown if does not exist a control, the terminate() method fails, the unit test will wait indefinitely for the subprocess to terminate. Change-Id: I6dc77b2db8ce042ead78d13ce57e91892cd2db90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113896 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-06-04Fix UITestMike Kaganski
The test had previously raced between the effect of vnd.sun.star.findbar:FocusToFindbar, typing, and pressing the "Find All" button. If typing happened before focusing, then focusing selected the already typed text. If button was clicked before focusing, it found the edit unfocused, and grabbed the focus, selecting its content. This adds "HasFocus" property to WindowUIObject::get_state. Change-Id: Ib277bd70508a3c1e86e1668afb7592d7a1523947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116697 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-04Fix UITestMike Kaganski
It needs to wait until vnd.sun.star.findbar:FocusToFindbar does its magic, which was racing with Python executing its typing. This adds "SelectedText" property to ComboBoxUIObject::get_state. Change-Id: I30faab2cc36a3cde59cf72ae5a383738a3ad4738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116694 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-05-26tdf#115088 convert UITest to CppunitTestMiklos Vajna
So that when it fails, it's easier to debug because it's in-process. Change-Id: Ia7d12291b25304967a22e546b12803864a713541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116127 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-23tdf#142448 sw offapi: add custom color metadata field shadingLászló Németh
using the new com::sun::star::rdf::URIs::LO_EXT_SHADING URI (modelled after odf:prefix and odf:suffix). Custom color field shading of text:meta annotated text ranges and text:meta-field metadata fields allows quick visual check of metadata categories. For example, RDF triple content.xml#id1753384014 urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0odf#shading FF0000 sets red (FF0000) shading color for the text span with xml:id="id1753384014". Pressing Ctrl-F8 or View->Field Shadings can disable custom color metadata field shading on the UI. Note: neither LO_EXT_SHADING, nor odf:prefix and odf:suffix changes invalidate the View (MetaPortion), but run-time update of shading color can be triggered without save and reload of the document e.g. by using (temporary) bookmarks on the annotated text spans. To run unit test with enabled visibility, use (cd sw && make UITest_sw_styleInspector UITEST_TEST_NAME="styleInspector.styleNavigator.test_metadata_shading_color" SAL_USE_VCLPLUGIN=gen) in Linux command line. Change-Id: I5de93cfa32ac6793d7dbdc7b64e6f4beacb2e8d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116015 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-21tdf#138556 Don’t add Open Values to stock chart types 1 and 3Aritz Erkiaga
A new function was defined, XdataInterpreter::getChartTypeSpecificData. Being 100% chart-type-agnostic when retrieving chart data is impossible; candlestick charts can have different numbers of sequences per series, and this information is not present in any other chart type. Change-Id: I0f54b09202c42667331b083d54d90e4ceee81083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-19Fix typosAndrea Gelmini
Change-Id: I800e966cee8343099fb79f08959ba246a831aee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115826 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-05-18tdf#118883: sw: Add UItestXisco Fauli
Change-Id: I38e7c1a0accf569a70d1d3bc5e04042538afadff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115756 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-10sw: test fix of tdf#140731 (freezing with track changes)Balazs Santha
Follow-up to commit e463d239555d3a4dc61797eeb8c638b6442112a3 "tdf#140731: sw transliteration: avoid too many redlines" Change-Id: I49d80d6fa5744797b7bb56d470ebc6f3b5f898d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113402 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-06tdf#126226: sw: Add UItestXisco Fauli
Change-Id: Id236fa585ae02cb0282a7d6179b9cb2d779dfdf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115182 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-05tdf#141935 svx cui: apply line cap setting of line stylesLászló Németh
Only line dash pattern of the selected line style was applied on the selected line or shape using the 1) Line Style popup menu of Drawing toolbar and sidebar pane Properties and 2) Style popup menu of Line pane of Line setting dialog window. Now both line dash and line cap settings are applied, supporting the usage of the new "rounded" preset styles and the old not "rounded" versions. Follow-up to commit b9b2c6a98fec798fc0ec76ec3cd407724f19dcac "tdf#141933 add preset dash styles with round cap". Change-Id: Ib3f64afcdcb50545166d40476a03a4b45f7d0b8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114461 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-05tdf#141933 add preset dash styles with round capLászló Németh
New OOXML-compatible preset styles weren't recognized on the UI, including the Drawing Object Properties toolbar and Line Style settings, if the preset styles use round cap, e.g. line styles with dot-like dots (i.e. not tiny squares as dots). As a workaround for interoperability and access to the line styles with dot-like dots, add "Rounded" version for every OOXML-compatible preset styles with round cap. This allows to apply dot-like dotted lines to new shapes, too. Background: round cap modifies the DotLen and DashLen values of the LineDash struct during the OOXML import, using ~zero values to get dot-like dots. For the details, see commit 3f3b50015e4fd9efc3459612a70409fca49cf390 "tdf#134053 tweak dash and space length for ooxml" and commit 24d770799660d3ec94ee7add435645794426042b "tdf#134128 Use Gdiplus::DashCapRound for round dash or dot". Follow of commit 183c06fc02a50fb117bb6162e4d6e56cdd34fad1 "tdf#139301 fix OOXML-compatible preset dash styles". Change-Id: I4f3173579964b2c00618ada475b012c85320f758 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114459 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-04tdf#141613: sw_uiwriter3: fix unittestXisco Fauli
The original test added in sw/qa/uitest/writer_tests7/tdf46561.py doesn't fail without the fix in place. While at it, move the UItest to CppUnittest Change-Id: I254c4ed042b14adee8c702d4c047572e69040887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115103 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-04tdf#141613 sw: fix crash at header/footer undoDaniel Arato (NISZ)
Undoing the creation of a header/footer used to leave their corresponding document nodes intact, causing the node index of a previous undo entry to point to the wrong node. We now force the destruction of the header/footer nodes manually. We also cut the redo chain which loses the redo history, but solves another crash for now (when redoing the creation of the header). The proper solution would be to create a new SwUndo* derived class from scratch to represent the creation of a new header/footer section in the document. Regression from commit 8d8486f43c1a8a51157bfc3e0b87090b05a9229e (tdf#46561 sw: fix lost undo stack setting header/footer) Change-Id: I97188aa8ded802bc6b6fa88ddd83a95c40de8bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114667 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-28sw bibliography, refer to a page: add insert/delete UIMiklos Vajna
If the toggle button's activate state changes, adapt the sensitivity of the next spinbutton, this way a new page number can be added and an old one can be deleted. Change-Id: I97067182e8cd42a02b164ac941598bada2630e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114750 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-22Resolves: tdf#141721 text from 1st col not clipped if 2nd col is emptyCaolán McNamara
Change-Id: I07257c59c20c3a2aeb789bbb370955e9e70226ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19tdf#141550 tdf#141557 tdf#140975 sw: fix textbox crashAttila Bakos (NISZ)
and regressions by refactoring SwTextBoxHelper. tdf#141550 was a DOCX import regression from commit ff321dd36554d25f0817903becf4598065e0a194 (tdf#140828 sw textbox: fix AS_CHAR regression), resulting bad horizontal position of the frame of the textbox. tdf#141557 was a regression resulting crash by changing text box anchoring "To Paragraph". tdf#140975 was an implementation error, resulting broken textbox by changing box anchoring to "As Character". In the SwTextBoxHelper class there were many repeating code parts for textbox positioning. Now these parts have been replaced with the calls of several new functions: 1) getShapeFormat() returns with the SwFrameFormat of the UNO XShape; 2) setWrapThrough() only sets the surround of the textframe (used in the code frequently); 3) changeAnchor() sets the anchor of the textframe according to the anchor of the shape; 4) doTextFramePositioning() sets the position of the textbox according to the shape (used in the code frequently); 5) isAnchorTypeDifferent() shows difference of the anchor types of the shape and the textframe. Also it handles the situation of anchoring "As Character"; 6) isTextBoxHasValidTextFrame() checks if the shape is a part of a textbox or not. Every function returns with true on success, otherwise gives information to the log. All of them can be called with ShapeFormat or UNO XShape. The goal of this to make the possibility to advance this class for further functions – rotation, grouped textboxes etc. – without code copying. Change-Id: I4441cab87931f161d0ace4983646d6d2a68a7321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113463 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-17tdf#30709 sw Style Inspector: show bookmark dataLászló Németh
If the current character position is there in a bookmark (or in multiple bookmarks), show bookmark names and RDF metadata under the node "Bookmarks" in the Style Inspector. Follow-up of commit dd45df62d217db59be3f515b6c7e1bfd17ec4350 "tdf#30709 sw: show RDF metadata in Style Inspector". Change-Id: I943682bd13e7760a8f7a8d534f497e88f2769275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114225 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-17tdf#30709 sw Style Inspector: show metadata xml:idLászló Németh
Follow-up of commit dd45df62d217db59be3f515b6c7e1bfd17ec4350 "tdf#30709 sw: show RDF metadata in Style Inspector". Change-Id: Id488f268e3c2d668680735f2092eddb252966cd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114224 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-08Make test_tdf141166 work also on macOS (where help is ⌘H, not ^H)Stephan Bergmann
However, without the additional 'FOCUS' action, the test would no longer verify the fix for <https://bugs.documentfoundation.org/show_bug.cgi?id=141166> "Crash in: mergedlo.dll: Press "Help" button in Hyperlink dialog", namely 92220638362755f0e776e222fa4e8b79377e75eb "tdf#141166 widget with id 'tabcontrol' might not be a TabControl": At least for a --without-help Linux build, in Window::RequestHelp at vcl/source/window/window.cxx:1897, > else if (!mpWindowImpl->maHelpRequestHdl.IsSet() || mpWindowImpl->maHelpRequestHdl.Call(*this)) the leading `!mpWindowImpl->maHelpRequestHdl.IsSet()` would be true, so the trailing `mpWindowImpl->maHelpRequestHdl.Call(*this)` would not be called and would thus not lead to the problematic call of VclBuilder::get<TabControl>. Change-Id: I35a687834b4eef46b81cc032c2f298ded8490f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113347 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-08tdf#132293 removed all the unused imports from the folder swVatsal32
Change-Id: I5a37f30941a73c276bc238fa9fbdfcfd8381791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112563 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07uitest: remove duplicated codeXisco Fauli
Change-Id: I86a4cd75e103445a288ad52a8c2167fa5b20c794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113720 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07tdf#119661: sw: Add UItestXisco Fauli
Change-Id: I7e24060b9b8e3b2b673a854256c8d8afaf399eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113707 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-06tdf#141084: sw: Add UItestXisco Fauli
Change-Id: Ib301adfe480217550b008f88938bb9cacc8c98ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113664 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-01Fix typoAndrea Gelmini
Change-Id: I5c55d9d51f1935406bca5a26307f78edfb73b9f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113373 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-03-31tdf#140863: sw: Add UItestXisco Fauli
Change-Id: Ic1d3a56857dd68f436b870168ab394729a31d629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113416 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-31tdf#141158 DOCX: import discarded headers/footersAttila Bakos (NISZ)
Before the inactive DOCX headers/footers lost during import time. Now it can be restored by disabling the options “Same content on left and right pages” and “Same content on first page” on the Header and the Footer panes of the Page style. This is for improving the interoperability with other Office programs, e.g. supporting DOCX text document templates better. Follow-up of commit f5dc6b11d2218d94c9effe7a1ab418d0133da5e3 (tdf#140117 sw UI: keep headers/footers when inactive). To start the py-UItest run: $ make UITest_writer_tests7 UITEST_TEST_NAME="tdf141158.TestTdf141158.test_tdf141158" Note: In spite of this patch implements the left/first/first_left page header/footer stash at import time, the left one works correctly at now. This is because the first pages have different page styles so changing the right page style will restore the hidden header/footer content. For this problem further improvements are planned, exactly in the filter part. Number of unit tests had to be modified, because before these headers and footers were dropped. Co-developed-with: Daniel Arato (NISZ) Change-Id: I3dd452a648bc465710698707c083734dc762ed94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112580 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-30For now, skip problematic test_tdf141166 also for --with-helpStephan Bergmann
...similar to how it already got skipped with 10fbf2b80e11620f3fc1691aa7968e6d3d460db9 "Skip a problematic UITest for --with-help=html/online". (And note how the check for "-DWITH_HELP" in $SCPDEFS would unfortunately also hit for the --with-help=html case, see configure.ac, if that were not already filtered with the preceding check, anyway.) The better fix would arguably be to make the code close both the "LibreOffice Help" window and the "LibreOffice Help Not Installed" dialog, whichever shows up for a given configuration. But this temporary fix at least gets --with-help builds like <https://ci.libreoffice.org/job/lo_ubsan/1961/> going again. Change-Id: I9d9d6ffeb26a056fa3fe65085264d75822e7646c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-28tdf#30709 sw: show RDF metadata in Style InspectorLászló Németh
Show associated metadata of the actual paragraph (text:p/text:h with xml:id) and annotated text range or metadata fields at the actual cursor position (text:meta and text:meta-field) under the tree node "Metadata Reference". Show text of the annotated text ranges and metadata fields in Character Direct Formatting/Nested Text Content (note: without the text of the children, e.g. helping the detection of unwanted annotations, e.g. annotating the already annotated text range again. In this case, positioning the cursor at the beginning of the outer text range, "Nested Text Content" will show empty text content in the Style Inspector). Change-Id: I2f5149f1f2584d0cf4a4fbbfc4f58f5802844e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113259 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-25tdf#134734 sd,sw: add UITestsMichael Stahl
Change-Id: I674066b1c998f35e1d21a575669a131721e41113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113004 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-24QR Code Dialog: Change term 'border' to 'margin'homeboy445
This adds a margin around the qr code (white space), not a border. Change-Id: If3e74dfe19dd7f9c063eaa6439810d617a99cb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112831 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-24Skip a problematic UITest for --with-help=html/onlineStephan Bergmann
Change-Id: I703eba78bb2980ac27dd11f36e03ef86c9662338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112993 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-03-23tdf#141166: sw: Add UItestXisco Fauli
Change-Id: If81d02ad19232250c49b4446a905603250a5a2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112938 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-21select_by_text helper method for uitestsNoel Grandin
reduce the boilerplate associated with selecting an item in a combobox Change-Id: I035967d7b45c84788d67b9ab5bebf2dbfc13fdf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-17tdf#46561 sw: fix lost undo stack setting header/footerDaniel Arato (NISZ)
Changing 'shared' setting of left vs right or first vs non-first page headers or footers removed the whole undo stack. Note: style changes before a 'shared' change can still not be undone. Co-authored-by: Attila Bakos (NISZ) Change-Id: I6875bd0581869ffeb853911347dbc9f8c666214b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111635 Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu> Tested-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-03-17throw exception for errors in uitest actionsNoel Grandin
so we abort early when a uitest goes wrong, instead of letting tests become fragile because it looks like its passing, but the code is just accidentally working Remove code in python uitests that was not actually doing anything (and now crashes because we throw an exception for actions that don't mean anything) Change-Id: I9c52f9fdc06f1c01e9b93b58a5200f9c3684db1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-11remove intermediate containers in sidebarsCaolán McNamara
tested extension sidebars of: a) Wollmux extension sidebars b) Analog Clock Extension demo https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension Change-Id: If9729e20526681928137989f01a8ae733a9b0cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11Revert "uitest: sw: re-enable test to see if it still fails"Xisco Fauli
This reverts commit 3d2ed830d63f0d1adcb0404ad979d5fcf9706ca2. Jenkins still fails with this test. See https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/82317/console Meanwhile, sw/qa/uitest/writer_dialogs/openDialogs.py:20 doesn't fail Change-Id: I19d3fc2993e8d7a5a0c031f30d258d57a9cda114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112321 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#140661: sw: Add UItestXisco Fauli
Change-Id: I637bcd2c8dbe215aa40b0eea69e559935a6d5eaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112205 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#40427: use node index as position, not Y position on screenMike Kaganski
As mentioned in comment to SwContent::nYPosition in sw/source/uibase/inc/swcont.hxx: some subclasses appear to use this for a tools/gen.hxx-style geometric Y position, while e.g. SwOutlineContent wants to store the index in its subtree Abusing the nYPosition to store vertical position *on screen* gives wrong results when a following section is positioned on screen higher than a previous section - e.g., when multiple-page view is active. So just use the section's node as Y position of the Navigator entry. When the section is inside a fly frame, use the frame's anchor node. Change-Id: I6caf26aeb19d845129dc837138c37f42bbc18655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112197 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09Add missing comments as per TEMPLATE.SOURCECODE.HEADERMike Kaganski
Change-Id: I6a8ed8598690795d5e23fb461db50f7f7852912a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112216 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09decompose SwNavigationPIUIObject and use sub components directlyCaolán McNamara
Change-Id: Ia4722972fe579646b4c3f06de339d72a931b05d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09SetCurItemId takes an ItemId not a PositionCaolán McNamara
Change-Id: Id0b34364cf45b9305f865d46cf8c3c0f838ce630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112147 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-08uitest: sw: re-enable test to see if it still failsXisco Fauli
it doesn't fail for me, let's see for others. Change-Id: If214efcaebb74b660c8cef2d60c910261379785a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112169 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-07tdf#140051 SI property values like "Bold" are now localisableshivam-51
This patch now allows "Bold", "Italic" and "Normal" to be localisable. Change-Id: Icd8102ce84db9a3c68ab69f5f9eadf0cf04755b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110475 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-03-03Fix typosAndrea Gelmini
Change-Id: Ie7751b61c06dba426b8ebd7e61a0e56b09a34f15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111824 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-15 14:46:48 +0000