summaryrefslogtreecommitdiff
path: root/sw/qa
AgeCommit message (Collapse)Author
2017-12-14tdf#41650 doc(x) export split paragraphTamas Bunth
Fix for documents with one paragraph only. Add unit test for splitting paragraph on section border. Change-Id: I224f60ed362deae7b67dde79e04f26f949de034a Reviewed-on: https://gerrit.libreoffice.org/46457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-12-14tdf#43569 DOC input: insert ConditionalText field instead of field marksSerge Krot
In case of IF field input inside DOC document the ConditionalText field should be created instead of the two field marks that leads to handling of unsupported field routine. Added unit tests. Change-Id: I31875d8e6be7f536766ef640a366b843f7e0532c Reviewed-on: https://gerrit.libreoffice.org/46022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-13tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-12tdf#113183 DOCX import: fix not independent text box alignmentsMiklos Vajna
The alternative would be to clear them in writerfilter::dmapper::DomainMapper::getPositionOffset(), but that runs before writerfilter::dmapper::PositionHandler::lcl_sprm(), so it would be too early. Change-Id: I287b9a4025c4b1844ae467c48815b5d7ffe3f98e Reviewed-on: https://gerrit.libreoffice.org/46279 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-11tdf#96505 Deleted suffix long (L) where it is possibletagezi
Change-Id: Iafe5ea3822f7f0170d2fb041fea604e95dbfa015 Reviewed-on: https://gerrit.libreoffice.org/46041 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-11tdf#112443 disable off-page content positioningPatrick Jaap
Disable the positioning for objects that are completely off-page. During import, LO writer forces content always back to the page and causes unwanted content on the page in constrast to MSO. To achive this the top/left position of the content is compared to the bottom/right border of the clipping region. A new compatibility flag OFF_PAGE_POSITIONING is introduced for legacy rendering of legacy documents. A unit test demonstrates the issue. It resolves tdf#112443. Change-Id: I263c129f9f09ed909ad777a34f8b9ffc84d871e4 Reviewed-on: https://gerrit.libreoffice.org/43313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-11tdf#97362: convert sw java complex tests to Python (#final)jmzambon
Move test documents to python folder. Delete remaining java helper class "TestDocument" and parent folder. Change-Id: I76ba4e82e96b39df207c337fc1f17052b750774d Reviewed-on: https://gerrit.libreoffice.org/46188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-11Enable RTF import tests on WindowsMike Kaganski
Change-Id: I4c14679d5cb91dc3cf35c3f47cb9120d3ee0f9cf Reviewed-on: https://gerrit.libreoffice.org/46212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-11tdf#114333: consider trleft for 1st cell width on import; don't...Mike Kaganski
... recalculate cell widths by factor pagewidth/tablewidth on export This makes the import and export symmetrical. Unit test included. Some existing unit tests were updated: - testTdf97035: the previous width of B1 cell (3571 twips) was not stable enough on round-trip. Old code saved table with wrong width, and incidentally that made it to output correct width of the cell. New code outputs table width correctly, and drops unneeded cell width adjustment on export, so the rounding error on initial import makes output cell width wrong. We have a cumbersome arithmetics to import cell widths from RTF: 1. In DomainMapperTableManager::sprm (case NS_ooxml::LN_CT_TblGridBase_gridCol) we do convertTwipToMM100 on initial sizes in twips; 2. Then, in DomainMapperTableManager::endOfRowAction, we do rtl::math::round((fGridWidth * 10000) / nFullWidthRelative) on the mm100 sizes (the 10000 is UNO_TABLE_COLUMN_SUM from unotbl.cxx, which allows to measure cell widths in 100ths of percent of table's width instead of absolute sizes) 3. Last, in SwTable::NewSetTabCols, we do lcl_MulDiv64<long>(nNewPos, rParm.nNewWish, nNewWidth) where rParm.nNewWish is table's width in twips (again), and nNewWidth is 10000. So, the three permutations give us twips back, but rounding errors may make result differ from initial value (as in case of cell width 1927 twips and table width 15527 twips, which results in 1926). The unstable width that resulted in roundtrip error was changed by 1. The changed unit test file is checked to still correctly test tdf#97035 - testFdo55525: previously, the testdoc was imported with wrong width (too narrow); that caused rounding error on cell width calculation. Current tested value is more correct. Change-Id: I69112521c35b316ed6df11d5e4ff7336534164bd Reviewed-on: https://gerrit.libreoffice.org/46094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-11Use platform-specific newline in unit testMike Kaganski
Change-Id: I7ff67ff952ecb2682a163866b91a9f2621dde935 Reviewed-on: https://gerrit.libreoffice.org/46210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-09Removed duplicated includeAndrea Gelmini
Change-Id: Ie4f0f27451e4cff2567239ec47dbf7a707987eb2 Reviewed-on: https://gerrit.libreoffice.org/46150 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-09tdf#114308 DOC import correctly watermark without paddingSzymon Kłos
Change-Id: If44eb4d1354386f66c697206db9ab4d7f2be374d Reviewed-on: https://gerrit.libreoffice.org/46110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-08tdf#114308 Export Watermark size as isSzymon Kłos
* refactoring * removed size hack * export/import "trim" attribute * DOC: export set of parameters to fit shape & frame Change-Id: Ib00654626ae1e10ac5110d22eada7528e03357e7 Reviewed-on: https://gerrit.libreoffice.org/46036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-08sw lok: enable Page Header/FooterHenry Castro
Change-Id: I5e0d080c53079069a086f06c2a314b6372bf6391 Reviewed-on: https://gerrit.libreoffice.org/39782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07tdf#106988 New names for the new numbering stylesYousuf Philips
Change-Id: Ibc93aaa552652d61ac49652cf0ac5fcb68b48a12 Reviewed-on: https://gerrit.libreoffice.org/37995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-07lokit: add .uno:DocumentRepair commandHenry Castro
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07tdf#97648 ooxmlimport: horizontal lines have no marginsJustin Luth
Change-Id: I170ab7a742f8e9d8029512592abda9fc54edda18 Reviewed-on: https://gerrit.libreoffice.org/42437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-12-05tdf#104016 RTF import: deduplicate before text indent from numberingMiklos Vajna
We already deduplicated first line indentation since commit 3915bf2dc877d5f1140798e24933db0f21386a4a (tdf#95376 DOCX import: fix incorrectly indented tab stops, 2016-01-26), the same is necessary for before text indent. Change-Id: I11394881d116f76922c1a706dd14b6a7cdf3c89f Reviewed-on: https://gerrit.libreoffice.org/45844 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-04tdf#113037 Watermark centered in DOCSzymon Kłos
Change-Id: I3b0383ef85f82c3076331026a49c0005f920ea61 Reviewed-on: https://gerrit.libreoffice.org/45804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-04tdf#97648 ooxmlimport: calculate percentage-based widthsJustin Luth
MSO seems to write 100% width horizontal lines with a "suggested" width of 0, so we need to calculate what the proper width is. A better fix would be to add "percentage-width" support to the shape class itself, but that complex enhancement is way beyond my abilities. Limiting the patch ONLY to shapes with an undefined width because it otherwise slightly increases the size of various other unit tests, and I'm not sure if those are desirable changes or not. The list of the unit tests is documented in the bug report. Change-Id: Ied80beca42a7513b8ea3b94b9c4ea9898e787200 Reviewed-on: https://gerrit.libreoffice.org/42128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-04Related tdf#113696 Unit test for Writer images fallback graphicSamuel Mehrbrodt
Change-Id: I2f14d6ab9a107f5b50ab0ec83019f86751dd79f6 Reviewed-on: https://gerrit.libreoffice.org/45778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-02tdf#113037 Unify Watermark in DOC & DOCXSzymon Kłos
* use correct font for calculations Change-Id: Idd370678c000bf22c460c3323bd55cd827ba7153 Reviewed-on: https://gerrit.libreoffice.org/45698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-01Unit test for tdf#113696Samuel Mehrbrodt
Change-Id: I566cd5d38cf86547b664f0ae9a1c2f8c37edc0ca Reviewed-on: https://gerrit.libreoffice.org/45560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-30TypedWhichId for RES_PARAATR constantsNoel Grandin
Change-Id: If2257d32fdd66703735466982e6913070ac1166d Reviewed-on: https://gerrit.libreoffice.org/45402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-29tdf#65955 Bookmarks on two paragraphsSzymon Kłos
Change-Id: I61fe660ee4fc5d3f6fc86c29e07369811eb38935 Reviewed-on: https://gerrit.libreoffice.org/45434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-28ODF export: expose font style and weight of embedded fontsMiklos Vajna
We don't need this info ourselves, but when converting the flat ODF output to other formats, this information is hard to find out, so state them explicitly. Names correspond to existing CSS ones, where it's necessary to state these explicitly. The EPUB export will make use of these attributes. (It is unclear why the test fails on the windows_msc_dbgutil_32 slave, it works for me locally.) Change-Id: I05030b6a14aca842e5a740786f3743e9ae838293 Reviewed-on: https://gerrit.libreoffice.org/45384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-28tdf#104035 RTF export: fix handling of absolute tab positionsMiklos Vajna
RtfAttributeOutput::ParaTabStop() assumed that they are always absolute, but WW8AttributeOutput::ParaTabStop() points out what compat setting decides if they are absolute or relative. Change-Id: Iafe8f6bb8733cae38a89f6c407763b0327e894e8
2017-11-28tdf#83877 Unit test for OOXML SignatureLine RoundtripSamuel Mehrbrodt
Change-Id: I40c116f28c0e8efe81e33e48fa05098d1dd76731 Reviewed-on: https://gerrit.libreoffice.org/45152 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28tdf#41650 DOCX export: insert empty header/footerTamas Bunth
Insert an empty header (or footer) to section which follows a section with a header in it. It is needed, because in case a section does not contain a header definition, Word will use the preceding section's rule. It causes problem if a document contains two page styles: one has header (or footer), the other does not. In that case after saving to docx it will end up in two sections. (only if it's not a plausable title page) Change-Id: I5add284d0cf1544923885e7205d9a2ac4e3cc9af Reviewed-on: https://gerrit.libreoffice.org/44832 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-11-27rhbz#1517407 Capitalize every word doesn't work after bracketsCaolán McNamara
Change-Id: Iab2da3f74f6116bb1b9855044df2a2ece977bb95 Reviewed-on: https://gerrit.libreoffice.org/45335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27tdf#108048: update InsertBreak slot to use PageNumberFilled paramMike Kaganski
Since commit c2ccd20c0fd92bddfff76447754541705e3eb8f3 (tdf#44689), SwWrtShell::InsertPageBreak takes page number as optional argument. The FN_INSERT_BREAK_DLG case in SwTextShell::Execute expects third parameter (FN_PARAM_3) to be boolean flag indicating if page number is filled. But corresponding sw slot was not updated to that fact. This prevented macros inserting page breaks with page numbers to be properly recorded, and one couldn't fix that manually, too, because the slot didn't expect that extra param (which would be dropped in TransformParameters). This adds the boolean parameter named PageNumberFilled to the list of InsertBreak slot. Unit test included. Change-Id: Ibccaece59b0e9848c0b754aa91b6700054b7fe97 Reviewed-on: https://gerrit.libreoffice.org/45319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27loplugin:countusersofdefaultparams in sw (2)Noel Grandin
Change-Id: Ibb045a0b7750cf6807d6f5caba86a9e6e59828ae Reviewed-on: https://gerrit.libreoffice.org/45237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24tdf#67207: export MERGEDIELD to DOCX and DOCMike Kaganski
Also removed a hack for i119803, because proper solution is implemented. This does not export data source information yet. Unit tests for DOC and DOCX are included. RTF export is already covered in testFdo80905. Change-Id: Id4f6d53344edf474add7e885e8ae6f36618e569f Reviewed-on: https://gerrit.libreoffice.org/45193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-24TypedWhichId for RES_CHRATR constantsNoel Grandin
Change-Id: Id6c45c237e9c8c55597d97b647b443eab9d1880a Reviewed-on: https://gerrit.libreoffice.org/45147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24tdf#65955 DOCX: bookmarks at the end of paragraphSzymon Kłos
End of line handling was incorrect and all bookmark tags placed at the end were exported before last text. I added additional collection to separate final marks and export them after last piece of text. Change-Id: Icc8f89164619c85405a846fda9871430c91dcbe1 Reviewed-on: https://gerrit.libreoffice.org/45168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-23ofz#3301 add bugdocMichael Stahl
Change-Id: I9a6425f5c0ed519ef7cb90e66b0d4c8e0fe700d4
2017-11-22RTF filter: drop now redundant astyle.optionsMiklos Vajna
I (tried to) keep the RTF filter style consistent locally with astyle in the past, but now that's redundant when we have an enforcing clang-format mechanism in place. So drop the astyle config and switch to clang-format in the RTF filter case. To minimize backport pain, do this shortly before the libreoffice-6-0 branch-off. Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f
2017-11-21loplugin:flatten in swNoel Grandin
Change-Id: I64176f48d90303f078e326c8838da9eb2daf8126 Reviewed-on: https://gerrit.libreoffice.org/44937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21RTF import: add even section break testcaseMiklos Vajna
lcov points out this was not covered so far. Change-Id: I11ff9eb8a819268382e6564be873403c47ec2176 Reviewed-on: https://gerrit.libreoffice.org/45018 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-21clang-format fixesMiklos Vajna
Hopefully the last such commit, now that the in-gerrit verification is in place and also a warning is printed locally for those who push directly. Change-Id: Ib80cbca0b29dc7f71cbb182a38ad6839a659ff41 Reviewed-on: https://gerrit.libreoffice.org/45002 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-21tdf#86087 don't decode linksSzymon Kłos
Example of link causing problems: "file:///foo#bar" Change-Id: Ifb781c27c3b9726ba262f10cf07c13cfd889dcd3 Reviewed-on: https://gerrit.libreoffice.org/45010 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-19tdf#86087 Save relative links in DOCXSzymon Kłos
Save links depending on preferences set Options -> Load/Save -> General -> Save URLs relative to ... Change-Id: I96d06cfdc405d1e1254515106926374aee279f6c Reviewed-on: https://gerrit.libreoffice.org/44785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-19tdf#108947 Added Unittest.Thomas Beck
Added different branches for Windows/Linux because of differences in linebreaks. Recommit with ifdef guard for preventing tinderbox failure Change-Id: I08c45e3e653990a47a85aee6f63f063b2f9385a7 Reviewed-on: https://gerrit.libreoffice.org/44677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-18silence some coverity warningsCaolán McNamara
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15coverity#1421163 Unchecked dynamic_castCaolán McNamara
and coverity#1421165 Unchecked dynamic_cast Change-Id: Iabd9560d41ec3ddbdb7a560b7839024b7749f917
2017-11-14tdf#113037 DOCX Watermark correct ratioSzymon Kłos
Import and export Watermark with padding like MSO does. Shape is scaled to save correct ratio. Change-Id: Iebd8eb5f168e0030320406d4fd6b287e451267bd Reviewed-on: https://gerrit.libreoffice.org/44319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-14tdf#113790: skip charfmt grabbag items existing in autofmt grabbagMike Kaganski
Change-Id: Icc0065c1da9471cb36bfef0da45e2f67381a1a31 Reviewed-on: https://gerrit.libreoffice.org/44706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-14RTF import: add odd section break testcaseMiklos Vajna
lcov points out this was not covered so far. Change-Id: I7c5047b75f6548e7738e6118f8d3c0eb9ed76045 Reviewed-on: https://gerrit.libreoffice.org/44702 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-13More proper construction of vnd.sun.star.pkg URLMike Kaganski
See commit bff8d843bd4e5dcca5dc1a60c2c7852b1b72a00b The SwUiWriterTest::testEmbeddedDataSource unit test is adjusted to test the paths with "#". Change-Id: I8d85147128915c7100ab9cc2888eb73c94fe6486 Reviewed-on: https://gerrit.libreoffice.org/44678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-06 03:13:13 +0000