summaryrefslogtreecommitdiff
path: root/sw/qa
AgeCommit message (Collapse)Author
2020-05-12Fix the buildStephan Bergmann
...after apparently a mid-air collision between f5636817e7677a3081263df9004940a7d5ac54af "tdf#112287 DOCX frame import: fix default vAnchor" and ec6eaa58addf0d8823f8c56d4ec168ff389da8c5 "fix memory leak of xmlDoc objects" Change-Id: I8fc70ee18aeb4be03b29da66bce666c563933249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94051 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-12tdf#132811 DOCX: fix formula alignment – part 2Attila Bakos
Formula are aligned inline again, but in the right position, fixing both import and export. This partially reverts commit 8b613c4603047dc24aa9b03fb49f4fe1b65af2a3 (tdf#121525 OOXML import: fix formula alignment). Co-author: Tibor Nagy (NISZ) Change-Id: If5c13db749fe5c3b1aee754b47dabc9fabd7ebb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93631 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12tdf#132802 DOCX import: fix list bottom auto marginsLászló Németh
of the last list item, when its numbering based on the paragraph style. Before tables, table rows and before paragraphs without numbering or with different numbering list items got a regression from commit 9a132c8fab7d4d70b91e5ed92429c70a0466afcb (tdf#122342 DOCX import: fix bottom auto margin in lists) Change-Id: I23c73d94569e785ec780d708d983764534e356c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93973 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12tdf#112287 DOCX frame import: fix default vAnchorTibor Nagy
Vertical frame alignment was calculated from above margin instead of the bottom one, resulting bad positions, when vAnchor wasn't defined. Co-author: Attila Bakos (NISZ) Change-Id: I81bcf53ec826d5dcc9790c661d784b507d9ababc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93556 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12tdf#127778 DOCX import: fix unexpected heading on non-first page ...Miklos Vajna
... when the first page has a heading Regression from commit 17e51f427b3f0cec74ac8e0a1b3f51189006ae6f (DOCX import: first page header should always set default headers as well, 2014-11-21), the problem is around how to split a first + follow page style on import, and then do the opposite on export. This is described using a single section in OOXML, but Writer has 2 page styles for this (unlike in case of the DOC filter). This means the header margin has to be taken from one of these page styles. The above commit tweaked the import, so the follow page style has the wanted header margin, but this leads to incorrect layout. Fix the problem by tweaking the export instead: it has random access to the doc model, so it can take the header margin from the first page style if needed, and then the import side can be reverted, leading to correct layout. Also remove some leftover debug code in test/, which was added in commit 5352d45dd4a04f8f02cf7f6ad4169126d3b3586a (convert AnimationImport to fast-parser APIs, 2020-02-18). Change-Id: I4bbf7271f3a437e8432399bd1e32e9d24190a501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94013 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-11CppUnittest: Revert all my previous commits asserting pagesXisco Fauli
The problem is that I assumed I could automatically assert all tests where the number of pages is the same at import and export time but I didn't consider the number of pages might be already wrong at import time as it happens with a few docx files. Reverting for now until I come with a better solution Change-Id: Ieddcf7e5f33c99ad35d0c96a12893e0996415aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94008 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-11lok: MSForms: send also the placeholder text.Tamás Zolnai
Change-Id: I5cce5af22f56079e840707cfffb01785d7a15c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93960 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-11fix buildCaolán McNamara
Change-Id: I6a8f5735f15a6691c277803c5e25989e0df61598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93955 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-11tdf#132766: DOCX export: always try to set bullet font for listVasily Melenchuk
There are some problems with bullet if we use MS Wingdigs bullets and do not specify Symbol font for it. It shiuld be either UTF-8 or Symbol, but not mixture of both. Change-Id: Ie4a6f7e8fee6cfab21a18fc080f33d1bff455dd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93846 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-11tdf#95189: docx import: apply list ovverride only onceVasily Melenchuk
List overrides should be applied only once on first list with override appearance in document. Next reference to this list should not override again and reset list numbering. Change-Id: I7a24398d5980ca97a74fa8ad09d91ac9adff15ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93894 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-11tdf#132754: DOCX import: changed default list start nubmerVasily Melenchuk
Default value for list numbering startAt is zero. If it is not proveded numbering starts from this value. Change-Id: I2cf7be9063e7bfb8b72d6ba77fcd9507e33bb848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93899 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-11tdf#105478 sw layout: treat minHeight as "do not split row"Justin Luth
Already, if minHeight is greater than the content of the row, then the row will "stay intact" and not split just because there is space for part of it on the preceeding page. However, if the content is greater than minHeight, it can split anywhere and moveBwd - since LO 5.3. At least for MS compatibility, this needs to not be split. But others agreed to change this for ODT as well, especially since this matches pre-5.3 behaviour, and will help at design-time for MS interoperability, as well as making minHeight consistent for the two different scenarios. Change-Id: Id15c44da2e7c38f6d552ffe32f92ab1c6b3c3349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93414 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-11tdf#49247: implement soft edges document model and import/exportMike Kaganski
... for ODF and OOXML. Two object properties added: SoftEdge (boolean, effect enabled/disabled) SoftEdgeRad (sal_Int32, effect radius in 100ths of mm) Two corresponding ODF attributes added: loext:softedge ("visible"/"hidden") loext:softedge-radius (metric) Change-Id: I0dc4d7fc3e5b0c2c36092d430568ebcfd3a68c9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93833 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-10CppUnittest: ww8export3: assert pages where possibleXisco Fauli
Change-Id: I04938d26bbf65b1d4b6aaa80fd730dffb91afbb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93922 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-10CppUnittest: ww8export2: assert pages where possibleXisco Fauli
Change-Id: I2d779004bc732413f30976216158c020c6cb6b46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93923 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-10CppunitTest: ooxmlexport8: disable assert on macXisco Fauli
Jenkins failed intermittently on mac with - Expected: 4 - Actual : 3 Change-Id: I9e9c75be0f058e09c09bedefad379b23956a3e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93916 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-10CppUnittest: odfexport: assert pages where possibleXisco Fauli
Change-Id: Id19601b61f508899304683296464923fbe121e87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93920 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-10CppUnittest: ooxmlexport11: assert pages where possibleXisco Fauli
Change-Id: Iebd0219075705dea6b7573f109eedf5e616827b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93734 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09CppUnittest: ooxmlfieldexport: Assert pages where possibleXisco Fauli
Change-Id: Id89b55cfbb730d17767927f2f23dcc3cdb8ad1b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93741 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09CppUnittest: ooxmlexport12: assert pages where possibleXisco Fauli
Change-Id: I6820c6d3a688d55922cce8430c0ae5127c9d8600 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93714 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09CppUnittest: ooxmlexport5: assert pages where possibleXisco Fauli
Change-Id: I72e222b7fb64b3262afd5b733a300bb94280ee03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93738 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09CppUnittest: ooxmlexport8: assert pages where possibleXisco Fauli
Change-Id: I7057226d46c78fb134f2eb9d439ae4e240325fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93740 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09lok: MSForms: test & fix two corner cases of drop-down field.Tamás Zolnai
Change-Id: I2c54e2e2a94d15d42b23e04a896211936e9e1852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93845 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-09CppUnittest: ooxmlexport14: Assert pages where possibleXisco Fauli
Change-Id: Ia8c9484420401dc3607c84ada375dfe063bc15cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93736 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09CppUnittest: ooxmlexport6: assert pages where possibleXisco Fauli
Change-Id: I18d1379fc340ba16616a47501e2d6936621babe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93739 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09lok: MSForms: add a test case about editing drop down form field.Tamás Zolnai
Change-Id: I926b322d3af3047fc72c6ee9b923bc4435111328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93661 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-09tdf#94628: sw: allow setting for bullet for outline paragraphsVasily Melenchuk
Paragraphs in outline (having style "Header XXX") can also be a part of list and have custom bullets. Simplified code of SwXNumberingRules::SetPropertiesToNumFormat(): do not check for properties special for outline/chapters and removed redundant data shuffle with local maps. Change-Id: I1fa7f8f5359acee1d5aa62d9700641490bb91b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93672 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-08lok: MSForms: dont send form field button data with empty text area.Tamás Zolnai
Change-Id: I88d793765b58a3c483aad51d1a0e2e9f0159d5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93660 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08CppUnittest: ooxmlexport13: assert pages where possibleXisco Fauli
Change-Id: I793d63d549ecd51a301abe064a6d7c84aa1a9d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93735 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08CppUnittest: ooxmlencryption: assert pages where possibleXisco Fauli
Change-Id: Id4a7ed5ecab048a6249444e30a38c1ffa310f96e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93733 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08improve loplugin:referencecastingNoel Grandin
to catch a few more cases Change-Id: I0323fba51bb2b4ba255e1db5aa0d890c5c6a2e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08lok: MSForms: Send also the drop down field params to the client code.Tamás Zolnai
Change-Id: Id42f428b7944d97d1b61a5b60d6e0807cb51cc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93658 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08tdf#132270: sw: restore unittestXisco Fauli
Removed in f9fc420dceb1ece2c98767da16a21aaff771f140 Change-Id: Ib2cc294f5efa3c1f10c43c481c9be4d1738f6fe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93720 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08lok: MSForms: Add callback for form field button.Tamás Zolnai
Show and hide the button and send the button area, where it should be displayed. Change-Id: I5922eb9f5e544483dd4efd12e4218d2e51270632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93657 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08CppUnittest: ooxmlexport9: assert pages where possibleXisco Fauli
Change-Id: Ifc6593869079b6b875a5a8c15468fc1a338bc8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93703 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-07tdf#101181: store glow radius in 100ths of mm instead of EMUsMike Kaganski
... as we do for all metric values. This fixes storing values like "190.5cm" in ODF for 15 pt (should be "0.529cm"). Change-Id: I382756af56464424dcb24ed8801d0a4203658c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-07CppUnittest: ooxmlexport10: Assert pages where possibleXisco Fauli
Change-Id: I40cc389edf9d072f643c724bdb2c70c48edced63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93645 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-07sw: fix SwModelTestBase::parseExportedFile()Michael Stahl
Both tests in fodfexport.cxx didn't test anything becuase this was called twice and the first time the stream was created for 0-sized file and the 2nd time the existing stream was reused so still no data. Change-Id: I97794490751d1f205919619484bb0c4ed962d4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93174 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-07tdf#98409 doc export: export (non-default) cell marginsJustin Luth
Previously, the only cell margins that were being exported were the row defaults from the last column. These cell margins are tricky, because multiple cells and multiple sides can be combined together into a single definition. A previous commit for tdf#73056 was needed to import these sequences. Change-Id: I513c432ec11a78c7bb52ac6fb628851192e88023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92701 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-07fix memory leak of xmlDoc objectsNoel Grandin
in unit tests Change-Id: Id16731bbbe2f1b0e3642722d77aba04fc98db4cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07tdf#132637 doc import: don't open readonly for lockRevJustin Luth
Just like with forms, the password should not be required to make changes when only enforcement of track changes is specified. So just grabbag the password and let the document open in read-write mode. TODO for the overly zealous: actually enforce file->properties->security->protect track changes, and also export it. (This has been done for DOCX.) Change-Id: Ib68ec5785aa0f5dbac507a3d50059a443f7ff42b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93551 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-05-06tdf#122342 DOCX import: fix bottom auto margin in listsLászló Németh
at paragraph style based numbering. See also commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b (tdf#106690 DOCX import: fix automatic spacing before/after numbered para block). Change-Id: I532181019ca97a86475c9bb0a1eea1c836705bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93581 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-06sw from-bottom relative orientation: add ODF filterMiklos Vajna
Map between RelOrientation::PAGE_PRINT_AREA_BOTTOM and loext:vertical-rel="page-content-bottom". Change-Id: I1d614bf7c82a76285f4268b8008e08c25ef9b7f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93120 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-06Resolves: tdf#123801 captioning issuesCaolán McNamara
revert attempt to by default create a msword roundtrip friendly caption. commit 2333786aa0eaf70c45c80e546239fb3565b1b4e7 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Mar 20 11:48:28 2018 +0000 Resolves: tdf#116474 bring hidden text property under undo control commit ebd43aee5b9cf98ed96ce28985267ad0bc980b7a Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 7 13:41:38 2017 +0100 rework setting hidden property on line break commit feedd45ba2dd308af2d3a1b2f64681b9467535b6 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Oct 27 14:37:03 2016 +0100 in msword the hard-break between image and caption has a width commit ba401ee10be2fb051bc961680f35b04e4e77a32d Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 1 09:39:37 2016 +0100 coverity#1372378 Dereference null return value commit 93ab0ff24cb71c36c9e7958046e96d7472b5af90 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 10 15:46:57 2015 +0100 Related: tdf#93676 default to as-char inside captions Change-Id: I460046a10f36bed13e2f4651b4c0a9b9b0662015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-06tdf#132603: sw: Add unittestXisco Fauli
Change-Id: I2706ba434034aa4307619cde12f020deb40d669e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93509 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-06tdf#132373 Remove blinking character property from the UI/editorGabor Kelemen
So far from document body and Character properties tab only. Importing and exporting existing files still works. Change-Id: I42179b47c64fe5c7db0393d0d4373363d772b51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92875 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-06tdf#108493 DOCX import: fix hanging indent of listsLászló Németh
when its value comes from the numbering style, but the left indentation is overwritten by paragraph settings. The problem caused by that these settings are not independent in Writer core. Change-Id: I5d6759bb215b82dfcaa5cbd3e191ac7ea8a8bb00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93478 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-05sw from-bottom relative orientation: fix calculation of position limitsMiklos Vajna
Create a new Writer doc, insert a rectangle with height = 10cm, try to position it 2cm above the bottom of the page, so that would be -12cm, but we limited the metric field to -2cm because 2cm was the page margin. Teach SwFEShell::CalcBoundRect() about text::RelOrientation::PAGE_PRINT_AREA_BOTTOM, then this will work without problems. Change-Id: Ib6ddccc1512d39fff5bff2e989973b156a6c2bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93501 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05tdf#132187: sw: Add unittestXisco Fauli
Change-Id: I767f96fd8d373df9b8cbecd9cb75ed114166d0f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93485 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-04tdf#116883: sw: unittest for lists with complex level formatVasily Melenchuk
Change-Id: I12a9cc1d08525536182227f26e5c44c7b8a4b319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93125 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-01-23 23:24:24 +0000