summaryrefslogtreecommitdiff
path: root/sw/qa
AgeCommit message (Collapse)Author
2024-11-29tdf#158237 sw: use c++20 contains() instead of find() and end()Bogdan Buzea
Change-Id: Ic8622a035fcd3c8a4a9883db9df8275cf6b10a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176801 Tested-by: Jenkins Reviewed-by: Simon Chenery <simon_chenery@yahoo.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-29sw: layout: fix toggling Hidden Paragraphs not shrinking flysMichael Stahl
There are 2 as-char flys with 2 hidden paragraphs each, and when turning off show hidden paragraphs, the paragraphs shrink to height 0 but the flys don't - this is because due to other hidden paragraphs earlier, the position of the flys change and Shrink() is called before MakePos() and then it uses the old position to check and that results in a negative nRstHeight, so the upper doesn't actually shrink. Fix this by always calling MakePos() before MakeValidZeroHeight(). (presumably regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups) Change-Id: I9a4ffadff02b6a2bc59c6a37aa15abec429e1068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177524 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-11-29sw: layout: fix toggling Hidden Paragraphs that have followsMichael Stahl
When a hidden paragraph is split across pages, there is nothing that joins its follow (SwContentFrame::MakePrtArea() has code to do it but it wasn't called even before the previous commit?) and when the follow is formatted is doesn't move back. So just join all follows asap in SwContentFrame::MakeAll(). (presumably regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups) Change-Id: Icecdf17c1c1e11a3b62c7e5bf2c6624f234c94f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177500 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-11-29tdf#163325 - Check Lower() frame during ToC previewAndreas Heinisch
Change-Id: Ife0e974d66d5ddbe3c831c64e4da28442e476da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177234 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-11-29tdf#164048 sw a11y: improve error/warning levels withBalazs Varga
adding two A11y issue level: Error and warning level, and categorizing our accesibility issues based on how the PAC 2024 tools and WCAG behave with the different warnings/errors. Change-Id: If4e4800497340318bb990326c64de655f24a47e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-29tdf#146553 Enable additonal functions in editable section while in r/o modeOliver Specht
Insert/Edit table, insert lists, insert AutoText automatic spell checking Change-Id: Iccef3965316dc6079ea56a0283023c5a658512cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165031 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28tdf#164074 sw inline heading: add up/down outline movingLászló Németh
Move inline headings with their outline tree in Navigator, clicking on the Move Heading Up/Down icons. Instead of changing CompareSwOutlineNodes, which breaks the code at other places, add a new SwOutlineNodesInline and CompareSwOutlineNodesInline to sort inline headings (put in Inline Heading frames) with normal headings only for MoveOutlinePara and other part of Navigator's outline moving. Reordering chapters and sections using the Navigator was limited for normal (root) headings, but not for headings in text frames and tables. Recent implementation of inline headings use text frames with Inline Heading frame style, anchored as characters to their paragraphs. Now these inline headings are movable with the Navigator, with their outline tree, i.e. the paragraph where the inline heading anchored as character, the following paragraphs without inline heading, or the following subsections. Note: selecting the inline headings is possible by the Navigator content tree or or by clicking inside the text of the inline heading in the document. Note: according to the fix for tdf#143569, multiple headings in the same text frame or table are ordered alphabetically in the Navigator. This doesn't effect the inline headings, where there is only a single heading in an Inline Heading text frame. Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880 "tdf#48459 sw inline heading: apply it on the selected words", commit d87cf67f8f3346a1e380383917a3a4552fd9248e "tdf#131728 sw inline heading: fix missing/broken DOCX export" and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8 "tdf48459 sw inline heading: add Inline Heading frame style". Change-Id: I7618aa1d4e1ddc20512d81c9a2babfa660053cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177438 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-11-28svx: Simplify "Go to Page" dialog, let SpinButton do its jobMichael Weghorn
Set the allowed range using weld::SpinButton::set_range so that weld::SpinButton makes sure that a value within the correct range is set, instead of having a custom handler called when the text of the spinbutton changes that effectively does the same thing (+ manually setting cursor to the end of the edit, but sticking to the toolkit default there instead makes sense to me for consistency). Adjust the test case to no longer type invalid input for the page number ("3a"), as SalInstanceSpinButton doesn't parse the number then, but would set the value to the minimum (here: 1) instead. (If a different behavior were intended here, that should be implemented in SalInstanceSpinButton or the underlying VCL widgets to be consistent across dialogs.) In GotoPageDlg::GetPageSelection, use weld::SpinButton::get_value to get the integer value right away, instead of getting the text and converting that into an integer manually. All that custom handling provided an interesting test case while implementing support for that dialog using native Qt widgets, see commits up to commit 70825e677f808437bd47651ebecc8a0c53955676 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 28 00:30:10 2024 +0100 tdf#130857 qt weld: Notify about spinbox combined value+text change , but apart from that (which is done now), I think that a more standard approach makes more sense. Change-Id: I06492b6629a4210c6325d50467da8e195daa4c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177463 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-28tdf#126533 vml gradient export: fix radial color swappingJustin Luth
This fixes my 24.8 regression 6dd6891a3deed8718bf2b0fcf564f229f676f8ba related tdf#126533 tdf#159824 VML: don't export: negative angles So far I really haven't touched radial gradient code, but the above patch swapped the colors around for linear/axials, and (while the import for radials is probably wrong) that also changed round-tripped radials - swapping colors each time. Note that on the unit test, the initial focus is 100, so on the first import the colors are NOT swapped. But since we don't write a focus, re-imports will start swapping. See FillModel::pushToPropMap in oox/source/vml/vmlformatting.cxx make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf126533_pageGradient Change-Id: I469fe7fba520e338df90e2eb0d8bdf96709d2ecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177452 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-26tdf#147819 doc export: only ShapeFlag::Background if XATTR_FILLJustin Luth
The mere presence of an object somewhere in the document was causing the document background to force a white color. This code was developed in the heady days of figuring out what bits meant what, so the documentation and code-reading is NOT clear. make CppunitTest_sw_ww8export \ CPPUNIT_TEST_NAME=testTdf41542_imagePadding (My ODT file had obviously spent some of its lifetime as a DOC because it had a white page background. I unzipped the file, and hand-adjusted styles.xml to set fo:background-color="transparent" and draw:fill="none") Change-Id: I41484ab7f71f4a3156e3193e49127b14e58949cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177347 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-26Remove exec bits on odt fileAndrea Gelmini
Change-Id: Ic528aa0d92d3d5e9ac971be8b5343a0b2b4da5c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177328 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-26Fix typoAndrea Gelmini
Change-Id: I2a3df5cad1bd4daa18292cc106d5e8fedefca364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177325 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-26tdf#146269: don't set modified when connecting frame, model and controllerMike Kaganski
Change-Id: I487a989a97389af11c98e10ac001c860d7855aec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177300 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-25tdf#152839 remove paragraph spacing attributes in fill cellsOliver Specht
Invisible cells in Word are added to Writer tables to get regular tables. Borders of such cells are allready switched off. Now also paragraph spacing is removed to not determine the row height. Change-Id: I27d3d033de54f051527cf29e2655e7a564d1a5ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176219 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-11-25tdf#163870 remove list attribute on style applyOliver Specht
Follow-up to 075560420a7aa238182e2d80dfe1c5fbaad3edbd Removes hard list attribute also if the applied paragraph style is applied again. Change-Id: Ic08241b5e244690825dfe79c419298c5d5f7c17e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177270 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-11-25tdf#108820 tdf#158713 sw layout: no footnote in repeated table rowsJustin Luth
This fixes my LO 7.1 regression from bug 108820. The problem was that footnotes-placed-in-table-headline were being visually removed if a split-table was ever joined during editing, etc. (i.e. one less page needed). Avoid the join() cleanup code being triggered on GetFollow frames because those were wrongly being informed that there was a footnote, despite being deliberately disallowed in IsFootnoteAllowed, so it really must not HasFootnote()! make CppunitTest_sw_core_layout \ CPPUNIT_TEST_NAME=testTdf158713_footnoteInHeadline Change-Id: I8f395217ba66a258738fc3f32846b952c69d367b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177059 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-11-25sw: fix property set implementation of SwXTextRange RANGE_IS_SECTIONMichael Stahl
Use cursor that includes section nodes, the core implementation should not need start/end to be a text node. Fix one case in SwDoc::ResetAttrs() where a text node is expected. (regression from commit 7ab349296dac79dad3fec09f60348efcbb9ea17e) Change-Id: I56960b5d233ced02703a7c522ebe6afa3347cd25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177259 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-24Turn SW_MOD macro to a functionMike Kaganski
Change-Id: Ide1f6fd2fc8a80b31353a14e416505a2349cea2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23tdf#162195: use SwFrame::IsHiddenNow when building indexMike Kaganski
Before commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 (tdf#159565 prerequisite: make hidden sections have zero-height frames, 2024-02-15), the hidden sections were absent from layout, so didn't appear in the SwTOXBaseSection::Update* functions. Now they are zero-height, but present, so their visibility must be taken into account explicitly. Change-Id: I95cc72b383a99e1f65152579c5458e253a3f60ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177079 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-22ReqIF: avoid 'type' attribute in 'ul' elementsMike Kaganski
Change-Id: I028737cac0b89344be5df55f9b60046230603979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176987 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-21sw: layout: fix unhiding section containing multiple page breaksMichael Stahl
With multiple page breaks in a hidden section, the following frames were only moved on the first break, and with the second break the frames go out of order in SwSectionFrame::SwClientNotify(). Also handle multiple columns there. (regression from commit a97e245ba11598050e1800fde9ace796d20e9df2) Change-Id: I4120e72bf083f3bed75f9305fbd757efd55f0b3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176773 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-21tdf#163974: ignore nested footnotes on ODF importMike Kaganski
That is a valid, but unsupported, markup, that is explicitly mentioned in ODF 1.4 part 3 "Schema" sect. 6.3.4 "<text:note-body>": Note: The schema allows for the inclusion of <text:note> elements as a descendant of a child of the <text:note-body> element. While this may be reasonable for note types, it is not reasonable for footnotes and endnotes. Conforming consumers need not support notes inside notes. (The "reasonable for note types" is obviously an editorial error from the time when ODF 1.1 text "reasonable for some future note types" was reviewed for ODF 1.2.) As the ODF also specifies, that a conforming consumer "need not interpret the semantics of all elements, attributes and attribute values" (ibid., sect. 2.4 "Consumer"), it is OK to silently drop this data, just as done for other similar cases. Change-Id: I0a417981087ebf225565628f14409661058d100d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176906 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-20CppunitTest_sw_tiledrendering: factor out common codeXisco Fauli
Change-Id: Icc8958f9f86844149bc66d12d60111bdcac0f8ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176867 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-20CppunitTest_sw_tiledrendering2: move to tiledrendering folderXisco Fauli
In preparation for a follow-up commit Change-Id: Id790d14ccbbb17f4ca086c67a702e199397d272b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176864 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-20CppunitTest_sw_htmlexport: split in twoXisco Fauli
It already had 114 tests Change-Id: I16bddb42364c542fb2b5e115672096984b29e975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176847 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-20Resolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-11-20CppunitTest_sw_tiledrendering2: try to make this more stableMiklos Vajna
This fails from time to time, see <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/177770/console> for a case. When it fails, we get no status callback at all, while the interesting failure is when we get a status callback, but it's wrong. Just give up in the rare case when we get no status callback to avoid false alarms for now. Change-Id: I8f971b64db878d207f9fd2e4fffc4d4b9a4a14e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176818 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-19tdf#163956 calculate line height differently in FORMTEXTOliver Specht
Lines containing EN_SPACES only ignore character height while calculating line height. In FORMTEXT fieldmarks the character height of the default EN_SPACES is not ignored. Change-Id: I8a89f13875f61ed287ce1697a91b42f20bd17192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176147 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-11-19tdf#162198 Reset default cell padding in RTFOliver Specht
66b4bfe302e248fc1503c5c74b83f4fb5fee4026 introduced a default left/right cell margin of 0.19 cm in DOCX import but is was also applied in RTF. This is no longer applied in RTF import. Change-Id: I192b2d17018c234837b926be64fdf27554b024e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173981 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-18CppunitTest_sw_layoutwriter2: split in twoXisco Fauli
It already had 109 tests Change-Id: I52e7416091bb3ffa80c39a1409dc283771f7d9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176710 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-13tdf#163873 sw inline heading: use HTML text, not lo-res bitmap exportLászló Németh
Text frames formatted with Inline Heading style and anchored as characters were converted to unacceptably low resolution images in the HTML export. Now the HTML export contains normal h1–h6 elements with display:inline; CSS setting to get text-based/searchable inline headings, fixing also the rendering quality. Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880 "tdf#48459 sw inline heading: apply it on the selected words", commit d87cf67f8f3346a1e380383917a3a4552fd9248e "tdf#131728 sw inline heading: fix missing/broken DOCX export", commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8 "tdf48459 sw inline heading: add Inline Heading frame style" and commit 984f0e49d35ba87c105310f27d945147a23d1198 "tdf#163874 sw inline heading: fix XHTML export". Change-Id: I02f7af8a39314e78d670b4db9a76897e931b3a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176512 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-11-13tdf#36709 sw: Writer layout for font-relative first-line indentJonathan Clark
This change implements layout for font-relative paragraph first-line indentation in Writer. Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-12loplugin:reftotemp in swNoel Grandin
Change-Id: I370d18643b0c83c60846a0b6f051440a043c647a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12tdf#162753 - Hyperlink dialog: trim leading/trailing whitespaces of URLsAndreas Heinisch
Change-Id: Ic18d30239e8741f8a28e81e423d3dc223d709a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176409 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-11tdf#162753 - Propose clipboard content only for option internetAndreas Heinisch
Change-Id: I030bc4c824ba8946104fe2e6adfd3b445de2b238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176348 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-08tdf#155447 a11y: Add test for accessible IDs expected by OrcaMichael Weghorn
Add a new AccessibilityTools::getAccessibleObjectForId helper that can be used in a11y tests to identify an object by its accessible ID. Add a test that checks that the accessible ID of the spelling dialog matches what Orca's logic expects in order to identify it, and that more UI elements with expected accessible IDs exist. This is to prevent breaking Orca logic without noticing. Any changes affecting this test should be discussed with the Orca maintainer first. See the comment above the newly added test for more details and a link to the corresponding Orca commits. The new test initially only checks that objects with corresponding IDs exist, could be extended to verify more of their properties as needed. Logic for checking availability of a dictionary, needed for spell check was taken over from the existing tdf155705 test in sw/qa/extras/accessibility/tdf155705.cxx, whose sample doc is also used. Change-Id: I0c5629272a89a4a570e080e62e99b6c105369cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176281 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-08tdf#155447 a11y: Set accessible ID that Orca expectsMichael Weghorn
Orca commit [1] commit 40a2d302eb52295433fd84e6c254a7dbe5108a24 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Nov 7 14:15:07 2024 +0100 Spellcheck: Check for accessible id in more places Do the following case-insensitive checks: * If the object's accessible id starts with "suggestions" treat it as the suggestions list. * If the object's accessible id starts with "replacement" treat it as the object (likely entry) which contains the proposed replacement. * If the label's/widget's accessible id starts with "error" treat it as the container displaying the misspelled word. Note that the first of the three is based on what LO 25.2 currently exposes ("suggestionslb"). The other two are not in use yet, but adding them facilitates implementation in, and getting feedback from, apps and toolkits. Also modify the existing check for the window. We were doing an exact match on "SpellingDialog". Making that case insensitive and limiting to starts with "spelling" works with the current LO implementation and removes an implementation detail ("dialog"). introduced logic to identify more UI elements in the spelling dialog by their accessible ID. Adjust the GtkBuilder ID (which gets reported as accessible ID as well) of the drawing area that holds the misspelt text to match the expectations as mentioned in the commit message above. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24 Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-07tdf#163720 sw smart justify: fix hyphenated single portion linesLászló Németh
Hyphen length wasn't calculated in single portion lines at shrinking, because the width of the overhanging line without the hyphen overwrote the calculated correct line width. This resulted less shrinking, than needed, also lost hyphen in the PDF export. Regression from commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46 "tdf#162220 sw smart justify: fix shrinking for single portion lines". Follow-up to commit 17eaebee279772b6062ae3448012133897fc71bb "tdf#119908 sw smart justify: fix justification by shrinking". Change-Id: I512e7f1f86f80ff6ea3d0b6a0b0db8255f5d0a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176207 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-11-07[API CHANGE] a11y: Switch AccessibleRelationType to enumMichael Weghorn
Switch css::accessibility::AccessibleRelationType from integer constants to an enum. This provides more type safety and improves the debugging experience, e.g. GDB now prints com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO instead of just "2" when printing the value of a corresponding variable, so it's no longer necessary to manually look up what constant has that integer value to know what relation this refers to. offapi/com/sun/star/accessibility/AccessibleRelationType.idl had this comment: > <p>We are using constants instead of a more typesafe enum. The reason > for this is that IDL enums may not be extended. Therefore, in order to > include future extensions to the set of roles we have to use constants > here.</p> However, the a11y UNO API is internal (not published), so that shouldn't be a concern. Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-06Libreoffice Theme Part 1.0: Make registry colors accessible from VCLSahil Gautam
Enable UI color customization via an extension. This patch doesn't include any UI changes as that needs to be discussed with the community first (ticket: https://bugs.documentfoundation.org/show_bug.cgi?id=163620) Part 1.0 (this change) is responsible for loading all the ThemeColors from the registry into a `static ThemeColors` object, which then is accessed in various VCL_PLUGINS as a source for the application colors. The user now has to go to the registry (expert configuration), and enable the theme by setting "LibreofficeTheme" to "true". It can also be enabled via an extension (demonstrated in the Theme Template). `testGetViewRenderState` changes to "Dark" scheme which is not present. Changes in this patch don't allow that and use 'Automatic' as the fallback. This caused the unit test to fail. So the test was changed to have "Dark" scheme before changing to it. Theme Template: https://github.com/printfdebugging/libreoffice-theme-template Project Report: https://printfdebugging.in/libreoffice/01-themes-gsoc-2024/ Change-Id: I5193d4d34fcd2f4c5d6f124a871bd5c7f14e95a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168016 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-06tdf#162268 sw: formatting: paragraph style also applies to para markerMichael Stahl
... so check it in SwTextFrame::IsHiddenNow(). During RTF import, the \v produces a RTFSprm that may be deleted before inserting by cloneAndDeduplicate() because the style already has the same value; this happens in one paragraph in the table in the footer of the bugdoc and that's why that row is visible. (regression from commit 7b8cec8322b60673e686660caf875bc71117bbd0) Change-Id: I064ecdc04c26afab7ef2196ac4da338b9d0bb1f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176093 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-06tdf#162268 sw: layout: hidden formatting is ignored on cell end markerMichael Stahl
... in Word, so ignore it in Writer on the last paragraph in a cell. (regression from commit 7b8cec8322b60673e686660caf875bc71117bbd0) Word also uses hidden character formatting on the row end marker to determine if a row should be hidden; this isn't possible yet. Change-Id: I7ceaea0d807193155631083616a93cdd058e20d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176060 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-11-06tdf#95239 sw: fix wrong order of PDF ToC, if headings put in text framesLászló Németh
PDF outlines (called also as PDF bookmarks or ToC) contained headings in the wrong order if they were placed in a text frame: Heading 2 (frame) ... 2 Heading 3 (frame) ... 2 Heading 1 ........... 1 Now PDF export didn't list text frame headings only at the start of the ToC, but in their correct position and hierarchy, based on the page and vertical position of the headings: Heading 1 ................ 1 Heading 2 (frame) ...... 2 Heading 3 (frame) ... 2 This is useful for the recently implemented inline headings, where e.g. APA Style Heading 4 and Heading 5 are there in text frames anchored as characters, see tdf#48459. Extend PDFium test environment for bookmarks, and add tdf#131728 DOCX and an APA Style .fodt unit tests. Note: if the higher headings are only in text frames, but not the lower ones, only the order corrected, but not the full hierarchy, yet. This is a follow-up to commit d87cf67f8f3346a1e380383917a3a4552fd9248e "tdf#131728 sw inline heading: fix missing/broken DOCX export", commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8 "tdf#48459 sw inline heading: add Inline Heading frame style" and commit 49765a9e7be41d4908729ff7d838755276b244cb "tdf#48459 tdf#131728 sw inline heading: new frame style: fix DOCX export". Change-Id: I87dffb9244d8aea553c98bf16c70955bb9b732d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176050 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2024-11-06tdf#162753 - Hyperlink dialog: preset only syntactically valid hyperlinksAndreas Heinisch
Change-Id: I682acfa4e41a3cce5f4639d79004bea985cabce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176112 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-05Don't need to send both text and htmlCaolán McNamara
now that the other end can use html Change-Id: Idb7959b041ebbbd9284007594473019cf603981f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175166 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 9ed5dd5d1b48b9a17967d85c0fad4994c40caafa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-05tdf#153636 - Search for outline node only if index is for the current chapterAndreas Heinisch
Otherwise, "Use level from source chapter" does not work for Graphics and Frames in user-defined indices. Change-Id: I148a097276cf8a60d69a208266ceb9def0444654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175783 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-02tdf#145161: Change pdf and image compression dialog stringAditya Sahu
Since image/pdf compression does not always reduce image or pdf resolution, change the misleading label from "reduce" to "change" wherever possible. Keep identifiers having "reduce" in their name as is as of now, only change the string values containing "reduce" to "change". Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-28 18:19:49 +0000