summaryrefslogtreecommitdiff
path: root/sw/qa
AgeCommit message (Collapse)Author
2016-06-27ODF import: add embedded pdf supportMiklos Vajna
The use-case is to have a .svm and .pdf alternative, need to pick .pdf from those. The test fails with any of the below commits reverted: - the xmloff part of this commit - fda68426374ed915783fd306c2f56463c757774a (ODT export: add embedded pdf support, 2016-06-27) - 878a860dff10bd91491d6c9f2f4e2308bfe4f0b2 (vcl: add initial PDF import-as-graphic filter, 2016-06-23) Change-Id: Id5b298d25a46af6ce7aa5f8c71a29c3914e1a7ce Reviewed-on: https://gerrit.libreoffice.org/26706 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-27tdf#76322 writer: allow column breaks in headers/footersJustin Luth
The code blocking this came in the original OpenOffice flowfrm. Either IsInSct() or FindFooterOrHeader() works to resolve this bug. I chose FindFooterOrHeader because it seemed to match the existing targets (docbody, flyframe) better. Change-Id: I51fc3bdc51c76e290b47ec7b9044780e5b67136c Reviewed-on: https://gerrit.libreoffice.org/26208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-26n#766487 additional docx testcaseJustin Luth
This testcase has been a real thorn and adding this test for the first page style will make it even worse. original testcase commit b776233cba128bd7610834691da612b2b1a438a0 Change-Id: Ic9401da31849604c5afa1a511c128071bc562808 Reviewed-on: https://gerrit.libreoffice.org/26660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-24GSoC Table Style Family: insertByName, replaceByName, removeByNameJakub Trzebiatowski
- also implements SwXTextTableStyle::replaceByName - some refactorization + use std::unique_ptr - fixes some bugs: + posible nullptr dereference in tblafmt.cxx + SwXTextTableStyle::getName() returned translated name + remvoed unnecesary SetXObject in Cell Style Family replacebyName - tests Change-Id: Idd25d54695ab5a4bdd4daf7ebf37b05fbc2366e7 Reviewed-on: https://gerrit.libreoffice.org/26578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-23tdf#76349 writer: treat single-column break as page breakJustin Luth
Writerfilter imports docx-defined column breaks that exist without being in a column. Word treats these as if they were a page break. Writer basically just preserved and ignored them. I limited the fix to only consider SVX_BREAK_COLUMN_BEFORE since writerfilter is only given “column break” and treats it as column_before. Change-Id: I0d974441d53243c4426048dd7cb60b3897b803f6 Reviewed-on: https://gerrit.libreoffice.org/26181 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22sw: fix loplugin:defaultparamsMiklos Vajna
Change-Id: I017c0107f421590bc61c4b1b7f3df458dd0b18f9
2016-06-21Added Test for tdf#72788 clear direct formattingVarun Dhall
Change-Id: I9732691cb71272d690b800316a87c06b96eb7b05 Reviewed-on: https://gerrit.libreoffice.org/26529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-21sw: add LOK_CALLBACK_TEXT_VIEW_SELECTION testcaseMiklos Vajna
Fails with 9f66db9c474f71f43d7a3667230241fd4fa4183f (sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTION, 2016-06-21) reverted. Change-Id: Ide21167ce2dc4287b1860b5f03a6975dc9edd4c6 Reviewed-on: https://gerrit.libreoffice.org/26550 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTIONMiklos Vajna
So a view can be aware where selections of other views are. Change-Id: I5026b1ff2b99a4eedfd0bde32a05ceb8e2f424bc Reviewed-on: https://gerrit.libreoffice.org/26542 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21sfx2 lok: fix missing view cursors in a new viewMiklos Vajna
When a new view was created, the old views got the position of the new view, but not the other way around. Make sure that the old views notify the new one right after registering the callback. Change-Id: If26edbd57aa939e453d95f4907a0e5722329dd65 Reviewed-on: https://gerrit.libreoffice.org/26523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20Add MS binary format validation in writer export testsVasily Melenchuk
Validation is done with Microsoft Office Binary File Format Validator if it is enabled. Since currently all doc files are not passing validation, they are included into validation blacklist. Change-Id: Ia36c5c9f2248122b13401a6d2834b729dbb75d6c Reviewed-on: https://gerrit.libreoffice.org/26422 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-20GSoC Table Styles, Export Cell StylesJakub Trzebiatowski
Exporting cell-styles Exporting table-template To be able to map SwTableAutoFormat to table-template 1:1 extended table-template by the following elements: loext:first-row-even-column loext:last-row-even-column loext:first-row-end-column loext:first-row-start-column loext:last-row-end-column loext:last-row-start-column Added attributes describing box format to SwXTextCellStyle Change-Id: I2967ba461dfc6f030c1e5cdbba62e2673d3b232b Reviewed-on: https://gerrit.libreoffice.org/26185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-17GSoC Table Styles, TableStyle isInUse, isUserDefined, mutex fixesJakub Trzebiatowski
Also added: + SwXTextCellStyle::IsInUse() + check_styles.py SwXTextTableStyle::isUserDefined() tests Change-Id: I76cb166107f186098599c4a8da6f94f7c40cc545 Reviewed-on: https://gerrit.libreoffice.org/26366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-16comphelper: enable LibreOfficeKit::isViewCallback() by defaultMiklos Vajna
This requires porting the sw/sd/sc_tiledrendering test code to the new internal API, as only the public LOK API is unchanged. Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9 Reviewed-on: https://gerrit.libreoffice.org/26379 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16tdf#91684 RTF import: handle fFlipH and fFlipV shape propsMiklos Vajna
Change-Id: I930f99647de00c2e43ef94b1ac0320daa440eae9 Reviewed-on: https://gerrit.libreoffice.org/26349 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15tdf#100105 sw: RTF export: fix empty hyperlinksMichael Stahl
For empty hyperlinks the EndURL() is called immediately after StartURL() Due to the way the various buffers are written, the group closing braces are written before the groups are opened, which is rather invalid. Using the m_aRun buffer instead of m_aStyles appears to fix the problem. (regression from b8907bf3d3b37c686a414ffbbd2d732348aab5b9) Change-Id: I6910e1afa0ee262ae0496cf1d3aa83ae3e537ad0
2016-06-14crashtesting: fix ~SwIndexReg assert on exporting tdf46441-2.odt to .docCaolán McNamara
Change-Id: I770c1f5ed4ebfb216810e30de83eb053606c2f8d
2016-06-14Related: tdf#91684 RTF import: fix scaling of group shape childrenMiklos Vajna
It was assumed that the child size is in twips, but it's in relative coordinates. Change-Id: I51352180c2e61a70b1a34faad5d73f96121168a8 Reviewed-on: https://gerrit.libreoffice.org/26240 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13Added Test for tdf#73162 TOC/IndexVarun
Change-Id: I1bd6dc18277aa009c23c75b85932d1c93fc13b5e Reviewed-on: https://gerrit.libreoffice.org/26190 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-06-13GSoC Table Styles, CellStyleJakub Trzebiatowski
- insertByName - replaceByName - removeByName Change-Id: I964aa0dc2e7f5a5be9eaec719b8944e847eb9d6a Reviewed-on: https://gerrit.libreoffice.org/26037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-08tdf#97103 sw: fix restoring of SetRedlineMode on DOCX/RTF exportMichael Stahl
In order to prevent ~SwIndexReg asserts, this was changed to restore the redline mode not in MSWordExportBase::ExportDocument() but in SwWriter::Write(). Unfortunately only the DOC export actually uses SwWriter::Write(), so fix the original problem differently by moving the cursors onto a EndNode. The m_pCurPam will be deleted anyway, and the m_pOrigPam usually also will be, and in the case it isn't deleted i hope it's not important :) (regression from 0b037361b890a83a735186b98d5a3cef124027f4) Change-Id: Ib3d0cc32862256fdc4363b6035c190cbbcfe5df3
2016-06-08fdo47267 odf import unit testJakub Trzebiatowski
Change-Id: I0f745483245b0e75b250ae1c2752f2e157307f0a Reviewed-on: https://gerrit.libreoffice.org/26012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-07sw UNO Cell Style family, SwXTextCellStyleJakub Trzebiatowski
Cell Family :: getByName Cell Family :: getElementNames Cell Family :: getCount Change-Id: I37d567ee284054f847c704d9fce370d174a0c48c Reviewed-on: https://gerrit.libreoffice.org/25896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-07tdf#50821 RTF import: fix handling of \trpaddf{b,l,r,t}Miklos Vajna
The width type is an attribute, not an sprm; this resulted in zero cell margin in the table -> the text overlapped with the border shape. Change-Id: I611feb084a16c76faf281d376e1a4a31e162f53d Reviewed-on: https://gerrit.libreoffice.org/25997 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-03Resolves: tdf#93971 freeze on load of specific html docCaolán McNamara
this is similar to commit 6acd5c45c764d81aea1539e66adbfadb51df0aa3 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jan 21 15:25:03 2015 +0000 Resolves: fdo#87601 specific html doc hangs on load and is a consequence of the old changeover from unsigned shorts for old string class to signed int for new string class Change-Id: I47022c641cbc329d8802765927005d43211b0d88
2016-06-01sw UNO API XTextTable add TableTemplateName propertyJakub Trzebiatowski
Change-Id: I8450fd4003ad5f9b082817765a2d44fc00dea15e Reviewed-on: https://gerrit.libreoffice.org/25688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-31tdf#77349 RTF import: automatically generate names for images if neededMiklos Vajna
The DOC/ODT import can call SwDoc::SetAllUniqueFlyNames() at the end of the process to assign unique names to fly frames which lack a name. Add a similar (but much simpler) feature to the domain mapper to avoid empty image names in the DOCX/RTF import result, so it's easier to click on the items in Writer's navigator. Change-Id: I432fc741f8d75d735e1dfe88daba50ba0797042d Reviewed-on: https://gerrit.libreoffice.org/25705 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-31Sw UNO API SwXTextCellStyle; TableStyles createInstance, XNameAccessJakub Trzebiatowski
Making createInstance("com.sun.star.style.TableStyle") possible Making SwXTextTableStyle a XNameAccess container of SwXTextCellStyles Implementing basic SwXTextCellStyle CellStyleMap based on svx/source/table/tabledesign.cxx Change-Id: I5afff1f514582a63a6eb9f9fb44667665749855a Reviewed-on: https://gerrit.libreoffice.org/25558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27improve exception throwing in java class util.utilsNoel Grandin
so that we get nice stack traces in our test error logs instead of just the title of the exception Change-Id: I47f30d80b9efbc7dbeff7f4456755e416e577b5a Reviewed-on: https://gerrit.libreoffice.org/25510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Sw UNO API TableStyles getByNameJakub Trzebiatowski
Implementing TableStyle family getByName, hasByName, getByIndex Implementing SwXTextTableStyle Implementing basic tests Change-Id: I256189db8631a713c4aae6b449409bbfaa776f24 Reviewed-on: https://gerrit.libreoffice.org/25410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-25Resolves: tdf#97879 loop in style hierarchy on odt loopCaolán McNamara
Change-Id: I0098c434b89b6a57e8b888a4d4f643e4d0865d29
2016-05-25tdf#74795 RTF import: handle row-level default cell marginsMiklos Vajna
Change-Id: I5bdd7b8624a9e2ac1aef963ccc5ed457ebda3f84 Reviewed-on: https://gerrit.libreoffice.org/25443 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-24Implement basic TableStyle FamilyJakub Trzebiatowski
Change-Id: I3da13d26ced05e1948d483d432d6268b10c208b5 Implementing: getCount, getElementNames Reviewed-on: https://gerrit.libreoffice.org/25351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-23loplugin:stringconstantNoel Grandin
Change-Id: I4600970fc1eb288aeb6fd5fb55947d936981f491
2016-05-23Add a test for comparing table cells and table cell rangesslideon
Also add the method sw_CompareCellsByRowFirst into unotbl.hxx so that it can be used elsewhere, just like sw_CompareCellsByColFirst can. Change-Id: I4a88455ba73356013f9f630d07610825568c263c Reviewed-on: https://gerrit.libreoffice.org/25260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-20Add test for checking the color of characters and paragraphsslideon
check_change_color.py only checked for page-related colors previously. Change-Id: I3b188db34c1f43ed6ed977f792615bb6646fbcce Reviewed-on: https://gerrit.libreoffice.org/25183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-18tdf#82073 RTF import: handle \clcbpatrawMiklos Vajna
Quoting the RTF spec: "Same as \clcbpatN for use with table styles." Change-Id: Icdb89bac5b41036dadb1901f18aeb21ef2512908 Reviewed-on: https://gerrit.libreoffice.org/25077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-12CppunitTest_sw_uwriter: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I535f28ff9307702e6070bfeaeb6e811d079e373e Reviewed-on: https://gerrit.libreoffice.org/24914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-11CppunitTest_sw_macros_test: fix loplugin:cppunitassertequals errorsMiklos Vajna
Change-Id: I1cb5f51a4dda9b2a38f4de84e4e69b0f1a7e623b Reviewed-on: https://gerrit.libreoffice.org/24873 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-11tdf#99145 refactored to pep8ackepenek
Change-Id: I4896cd0bda97331a8291588e6a4f29a881d1229c Reviewed-on: https://gerrit.libreoffice.org/23925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10tdf#96275 RTF import: fix anchor of shapes inside tablesMiklos Vajna
Table text is buffered, so buffer the shape import as well, otherwise the anchor will precede the buffered text -> incorrect anchor position. Change-Id: I527b898e2cd5fafaf122a20e11df66ba8d3185cf Reviewed-on: https://gerrit.libreoffice.org/24822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-10Remove default outline indent, fixes tdf#95576Luke Deller
The default document outline style has indents set appropriately for numbered headings. However numbering was disabled in the default outline style 20 years ago (!) so update the indents accordingly. Also revert commit 05fd8cb848ecba425124d61cd76e2f9418d5378c which attempted to work around this issue by explicitly setting a zero indent on the default paragraph styles "Heading 1", "Heading 2", etc, as this is no longer required. This change fixes a DOC import issue tdf#95576 (!) Reference: see this old German comment https://cgit.freedesktop.org/libreoffice/core/tree/sw/source/core/doc/number.cxx?id=84a3db80#%6E647 Change-Id: Id289143ed859861f2584e21969f16f348e215f6f Reviewed-on: https://gerrit.libreoffice.org/24806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-05Related: tdf#84695 sw: fix TextBox begin text edit by pressing normal charMiklos Vajna
When a draw shape is selected, but its text is provided by a TextBox, then F2 and Enter could start editing already, but pressing a normal character didn't work (unlike for TextFrames or regular draw shapes). Fix this by calling into lcl_goIntoTextBox() at one more place. Change-Id: Ia594279918a6c3087cac8b0c859ce7432e4a685d Reviewed-on: https://gerrit.libreoffice.org/24671 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-04CPPUNIT_ASSERT(a == b) -> CPPUNIT_ASSERT_EQUAL(b, a)Miklos Vajna
Change-Id: I84dcd5ccc48d46f4aaa1ad33b341bfe7542757a3 Reviewed-on: https://gerrit.libreoffice.org/24631 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-03tdf#98512 sw: add unit testMichael Stahl
... and fix the SAL_WARN not to warn spuriously. Change-Id: Ic951fc0d811e5cab39989285d34bdd2fff8f95fd
2016-05-03tdf#95707 RTF import: handle device-independent bitmapsMiklos Vajna
See <https://msdn.microsoft.com/en-us/library/dd183374%28v=vs.85%29.aspx> for more info about the header structure that has to be prepended to the real data to make our BMP import filter happy. Change-Id: Iabdf4cd169b82ea951d1c1b12432d97d61b7af51 Reviewed-on: https://gerrit.libreoffice.org/24604 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2025-02-06 21:49:00 +0000