summaryrefslogtreecommitdiff
path: root/sw/qa
AgeCommit message (Collapse)Author
2015-02-16sw: test case for search-and-replace bug fixed by commit ...Michael Stahl
... b60ce8465c8f01242354abccebe00742d164af60 Change-Id: Iba1a059b3aeb5b2266398d80e6995f98fd580f14
2015-02-16sw: work around buggy boost::intrusive::circular_list_algorithms::unlink()Michael Stahl
Boost is clearly following the C++ tradition of surprising omissions. Change-Id: I205ef17f87b176da938ebfa3e1a0748e94605daf
2015-02-16(related: tdf#80715) sw: fix Ring::MoveTo() not doing anything...Michael Stahl
... if the parameter is currently in the same list. The "boost::intrusive::circular_list_algorithms::transfer" has a precondition that the 2 parameters must not be in the same list. This causes an infinite loop in SwFindParaText::Find(), which is hiding the infinite loop that i'm trying to debug... While at it, remove some unnecessary complexity. Change-Id: Ib41f52c6d5c44ecc358c6170ee1e6e98729e1302
2015-02-15RTF filter: handle mirrored marginsMiklos Vajna
Change-Id: I122f5f23e510ae42664d2b69504f4722aa05597e
2015-02-14tdf#87574 - Outline numbering "None" is not retained in docxMark Hung
Partially revert commit d30a8ec448bcd08c6a52a37d6ae41a4b71c235da (Correct number format mapping for CJK numbered lists in rtf/doc/docx filters., 2014-11-04). Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/14211 Change-Id: I0876ecd982cfd8d97887495b23af0e0370821101
2015-02-13tdf#49893 partial fix for blank rentangle problem in RTFVasily Melenchuk
* pib structure in rtf shape is processed always, if exists, not only for shape #75 (picture frame): it is possible for other shapes, at least for #1 (rectangle) * picture inside shape gets width and height from shape: this picture looks like pib object and should fit shape frame Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Reviewed on: https://gerrit.libreoffice.org/14396 Change-Id: I5cf2e692940c4ddd8ab8b291ef65c0cc44c45f5d
2015-02-13loplugin:unreffunStephan Bergmann
Change-Id: Id56bc94e95e59f9bfe1dca02ff1f5e16844de45a
2015-02-13cp#1000115 forgot to add bugdocMiklos Vajna
Change-Id: Ia9ac12c0d03d960aced5d7066306a6f68c95996b
2015-02-13cp#1000115 SwTxtFrm: don't join follow just because it has no contentMiklos Vajna
The problem was that the bugdoc had a table, and inside the table there was a long paragraph that flows to the next page, but only the paragraph mark of it does so. We first split the frame to have space for the paragraph mark, but later decided that all the content would fit the first frame, and this way the last hard line break and the paragraph mark was painted on each other. This is normally not a problem without tables, because SwTxtFrm::FormatAdjust() just calls SplitFrm(), sets its nNew flag to non-zero make sure that later SwTxtFrm::_AdjustFollow() doesn't try to join it, and we're ready. However, when the paragraph is inside a table, then the paragraph was formatted multiple times, and next time when we already had a follow nNew was not set, so even if there was a correct split first, the new frame was joined later. Fix the problem by explicitly setting nNew for the "in a table and paragraph ends with a hard line break" case, that way we don't blindly join the frame, only in case there is enough space for the follow in the master. Change-Id: Iede654740dcb0d8aa768d742ee330208291a383a
2015-02-13disable control shape grouping test for nowDavid Tardon
Change-Id: I29ca828a2049a72e2238986892c172e7c135b44b
2015-02-13correct assertion messageLionel Elie Mamane
Change-Id: I934ef3cbe67bba7d7439e464f71b9fd4a1da4e50
2015-02-13add unittest for grouped control shapesLionel Elie Mamane
they should keep their control models Change-Id: Iaa27cd8a9bc3a1165db665e0ad172da622e00c6b
2015-02-07Fixup --without-x buildRiccardo Magliocchetti
Accept gl linkage in hope of future offscreen mesa support. Avoid linking with GLX though. Change-Id: I4e666f60e74fe34075a8da9eeba95807cf8fe38c Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/13452 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-06tdf#76291 unit test for html export href encodingVasily Melenchuk
Change-Id: I273af8b570adfcb7bfb784495bc31d2f4f1ee00b Reviewed-on: https://gerrit.libreoffice.org/14333 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-06bnc#637947 improve DrawingML export of custom shapesAndras Timar
Change-Id: Iaa880528cf3c899ce66e4349c6d989dfbe5cbeb6 Reviewed-on: https://gerrit.libreoffice.org/14346 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-03xmloff: write character borders in the extension namespace for nowMiklos Vajna
Change-Id: Ia112cf626126149ea9cf09c5d6ff812d5d5ffec5
2015-02-03CppunitTest_sw_odfexport: fix non-charborder-related issues in charborder.odtMiklos Vajna
- style:border-line-width's first value should be positive (follow-up fix could be to handle such existing documents, but this is a test document, so let's just modify it) - style:contextual-spacing is written as loext:contextual-spacing today Change-Id: I4463ad83d45bb85f39257cc5bfda96ae1ef2c2a1
2015-02-03tdf#88811 SwXText::convertToTextFrame: handle shapes anchored to usMiklos Vajna
Change-Id: Iedf8eacd37b8ed8e307a10e8ade32f53c7417c4a Reviewed-on: https://gerrit.libreoffice.org/14306 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-03Update for CJK numbered list enhancement.Mark Hung
1. Revert koreanDigital2 back to NUMBER_HANGUL_KO (import). 2. Map NUMBER_LOWER_ZH in Simplified Chinese document to chineseCountingThousand (export). Change-Id: I62ec255626c250802288bf7fbec7371076e727d3 Reviewed-on: https://gerrit.libreoffice.org/14155 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-02oox: 89 DPI is not such a great defaultMiklos Vajna
Using the DPI from Application::GetDefaultDevice() is a much better idea, especially that now oox::GraphicHelper::GraphicHelper() and oox::drawingml::DrawingML::WriteSrcRect() are in sync. Should fix the testCropPixel() failure in CppunitTest_sw_ooxmlexport that appears on HiDPI systems. Also, fix all the rounding problems that now became visible when the DPI is the same for both import and export. Change-Id: Iceb34a8a5a1eaa8ce0824491521ad6b4d2f6949c Reviewed-on: https://gerrit.libreoffice.org/14280 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-02tdf#68183 sw: config option for disabling the creation of automatic RSID marksMiklos Vajna
It was a problem since the initial commit 062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c (sw: Improved document comparison based on RSIDs., 2011-12-22) that this new feature -- which is annoying for some use-cases -- could not be disabled, let's allow that. Change-Id: I33fa77382919586fb00198246f737caa68dcbd85 Reviewed-on: https://gerrit.libreoffice.org/14277 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-02-02RTF export: need to take care of fill attributes when building the color tableMiklos Vajna
Change-Id: Iab7b4941e9b41249f2a30fa6139313239a98c501 Reviewed-on: https://gerrit.libreoffice.org/14276 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-01writerfilter: import paragraph color as fill attributesMiklos Vajna
In theory this is to be in sync with the ODF import. In practice the old UNO property seems not to have a proper fallback to populate the doc model with the fillattributes, so without this even if the import result is visible, it would be lost on ODF export. Additionally, this detected a bug in SwUnoCursorHelper::makeRedline(), where paragraph format redline tried to use the map of a text portion instead of a paragraph. Change-Id: I026e38e1990ed2a460624a8d967a16ae3fb6c512
2015-01-31tdf#88583 MSWordExportBase: fix handling of paragraph background colorMiklos Vajna
Regression from 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: i#124638 Second step of DrawingLayer FillAttributes..., 2014-06-02), the problem was that exporters still expect an SvxBrushItem for the para background color, while doc model was changed to have an XFillStyleItem / XFillColorItem pair instead. Change-Id: Ib94fda103ec35a6f087307aafdd890183d9d935f
2015-01-29tdf#75996: sw: correct bookmark positions when deleting textMichael Stahl
The problem is that SwUndoDelete will move the fully selected nodes to the UndoNodes but it leaves bookmarks with their SwIndex pointing to the deleted nodes. The SwNodeIndex are corrected by SwNodes::_MoveNodes() so they point to a different node than the SwIndex. This only happens if only one position of the bookmark is inside the deletion range; if both are, the bookmark will be deleted by SwUndoSaveCntnt::DelCntntIndex(). Also joining the 2 start/end nodes of the selection will accidentally correct the bookmarks but only if it happens to delete the end node. (and apparently there is also a DeleteRange method that doesn't join) Change-Id: I91ec362bb833328f8d681fd9458cb915c4efb267
2015-01-26Visible function type RTTI for Clang -fsanitize=functionStephan Bergmann
...by adding some further SAL_DLLPUBLIC_RTTI type annotations (cf. b4f6b26b5a1a78fecfa95ec2eb7ac8b80495d8aa "SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVM") and by making sure relevant function types do not use incomplete types in their parameter and return types (which would make the RTTI hidden). Change-Id: Id7aadcbc0704b9759968ae36266fc9ce11a2e340
2015-01-22writerfilter: DOCX import: better error handling than "catch (...) {}"Michael Stahl
If there is a SAXParseException, OOXMLDocumentImpl::resolve() should not ignore it, because if it occurs in a substream some end tag handlers may not have been run and the DomainMapper may be in an inconsistent state, so continuing to parse the outer document is probably not a good idea. Also add some exception mangling so sfx2 can present a useful error dialog. Change-Id: I169ba6db25f2ae264af08a64edf76a6bf6757f85
2015-01-22loplugin:stringconstantStephan Bergmann
Change-Id: Ia23865a38eff10304a1c1748b2b4f17af7b4d3ae
2015-01-22fdo#68963 recognize __RefHeading__ bookmarks as TOC in .doc filesJustin Luth
LibreOffice recognizes MS Office Table Of Contents, but LO files saved as .doc didn't show the Cross-Refence heading - it was blank. Now bookmarks using the LO naming convention are also imported as TOC bookmarks from .doc files. Testcase included. Change-Id: Icae5c0de31856ccc75ede9a97c0ea046dd97325f Reviewed-on: https://gerrit.libreoffice.org/14018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-22Some more loplugin:cstylecast: swStephan Bergmann
note the two TODOs about suspicious casts Change-Id: I324fa05b30a5c8aa1d9e9a6d488a1e295226e788
2015-01-21Resolves: fdo#87601 specific html doc hangs on loadCaolán McNamara
Change-Id: I67f472d72efe123b533d4d94be0084986c0e8349
2015-01-21RotateAngle of UNO type longStephan Bergmann
Change-Id: Id3aec16d17b55366c2a35810b21b0a1c73439741
2015-01-21fdo#87488 Wrong text rotation inside a preset shape from docxGary Houston
Preset shape text rotation values are read in a few places and stored in moRotation. With these changes, moRotation is always read unchanged, but multiplied by -1 when it's used. Change-Id: I633d665c21daa69e15fa828a43300f10d2bf2054 Reviewed-on: https://gerrit.libreoffice.org/13561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-20sw: add unit test for 5c363cf3f1d75e37835a6663a96b4e22c754c4cbMichael Stahl
Change-Id: If83f4900fcecde07f75d88c7f0b7c9088974b093
2015-01-18ODT export: fix namespace of <table:covered-table-cell> inside shapesMiklos Vajna
Change-Id: If96b46bac7f8212cfb83dc8b4528986137f1eaea
2015-01-14rhbz#1180114: writerfilter: don't crash on w:customXmlDelRangeStart etc.Michael Stahl
We can't do anything sensible with these CustomXML elements but now we have to handle them because. (regression from 9dbf817fe5c5253fba0831aefa17575ae0ba3af1) Change-Id: If4247890ff9961a77434587802670d28608a7922
2015-01-12java: no need to instantiate the AccessibilityTools objectNoel Grandin
since all of it's methods and fields are static. Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08Disable html tests on x86_64 on windowsDavid Ostrovsky
Change-Id: Idae98f65bd87d08c62b27c5c604e4d98fcacbe1e Reviewed-on: https://gerrit.libreoffice.org/13660 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-01-07WW8 filter: zoom type testcaseJustin Luth
Change-Id: I57f90a84b49c4a3bd49c66e23d059939684a6aef Reviewed-on: https://gerrit.libreoffice.org/13765 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-07fix windows buildNoel Grandin
and a handful of other currently uncompiled spots, after my commit 7f8f277b94704a289fbbd1b836e4e5d66311580d "fdo#84938: convert STREAM_ #defines to 'enum class'" Change-Id: I550f6fb850e1d71a6f08767eeb222a18071b89d5
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05Resolves: fdo#87003 Kill BOOST_FOREACH on masterNathan Yee
use C++11s range-based for() loops instead Conflicts: sd/source/filter/eppt/pptx-epptooxml.cxx Change-Id: I0868eb345932c05b7e40b087035da252b99bf0b9 Reviewed-on: https://gerrit.libreoffice.org/13714 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-04fdo#79738: Test case for patch that fixes 79738Charu Tyagi
Reviewed on: https://gerrit.libreoffice.org/13541 Change-Id: I40ba14503ad9f5458d8326741a4fe7a13653b05a
2015-01-04fdo#79738: test document for patch that that fixes 79738Charu Tyagi
Reviewed on: https://gerrit.libreoffice.org/13542 Change-Id: I8d6289b814a063ba8037d07a7600a44fa77f860d
2015-01-03fdo#72486 SwWrtShell::SelAll: if in table, then call extended select all ...Miklos Vajna
... only in case the whole table is already selected Change-Id: If7626954460e16945af6b21402a84e90c71ae138
2015-01-02CppunitTest_sw_ww8export: use SAL_NEWLINE_STRINGMiklos Vajna
This makes CppunitTest_sw_ww8export pass on Windows again. Change-Id: I16fed4eabbe7b9ccdcc0c71361b85b0e13f2245a
2014-12-30i#93570 DOC import: handle commented text ranges via RES_FLTR_ANNOTATIONMARKMiklos Vajna
And add a minimal reproducer that shows how the old way was broken. Change-Id: Ic2dadf9905d603b0fd0573651b235ecd5dd70e71
generated by cgit (git 2.34.1) at 2025-01-28 03:42:43 +0000