summaryrefslogtreecommitdiff
path: root/sw/sdi
AgeCommit message (Collapse)Author
2018-10-31Translate German commentsJohnny_M
Change-Id: I94cdb753d01dfd0d5b8f78ede1819b281b840ab2 Reviewed-on: https://gerrit.libreoffice.org/62669 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-15tdf#120429 - Functions Insert Columns Exist Two Timesheiko tietze
Legacy UNO commands InsertRows and InsertCols hidden from customization Commands are still accessible via macro Also fixed terminology in Draw/Impress for Insert Columns from Left/Right to Before/After Change-Id: I29a6b2fdb7481db43ad1a8ad25be5e9107558bd6 Reviewed-on: https://gerrit.libreoffice.org/61579 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-12tdf#118621 - Optionally disable floating header/footer menuheiko tietze
UNO command UseHeaderFooterMenu introduced Change-Id: I4be009e08bc66dc675c7c903552c6376e22639f1 Reviewed-on: https://gerrit.libreoffice.org/61706 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-11tdf#64242 sw add minimize table col/row UIJustin Luth
A followup commit will modify the optimize functions, which currently function as a minimize, so lets make sure that the ability to minimize is still available. Minimize column width: Adjusts the width of the selected columns to fit the selected content. The table can shrink if necessary, but will not grow. (This is how Optimize column width worked in LO <= 6.1.) Minimize row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. (This is how Optimize row height worked in LO <= 6.1.) Change-Id: I2c0b8c7b7a05c31328f2feef464ef0e131318ff8 Reviewed-on: https://gerrit.libreoffice.org/60902 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03Enable the align group button for framesMaxim Monastirsky
Change-Id: I6ba8b5fe0d185817e61986c90f5264493b6d5339 Reviewed-on: https://gerrit.libreoffice.org/59951 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-02tdf#117835 Paste as Unformatted for comments in WriterMaxim Monastirsky
Change-Id: Ia96f8c51cc0a3898c1169454bd7c3031e08c45d4 Reviewed-on: https://gerrit.libreoffice.org/59906 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-02tdf#118674 Paste special and unformatted for shapes in WriterMaxim Monastirsky
Change-Id: I348a6f93b61ea644077dcd3a16ba9d9fe17afb91 Reviewed-on: https://gerrit.libreoffice.org/59905 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-24tdf#119236 Dimension dialog for Writer and CalcMaxim Monastirsky
Change-Id: Ifbc6c8959afcedac0fd9ec7a3f5e2cca63c11eda Reviewed-on: https://gerrit.libreoffice.org/59484 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-10Translate German commentsJohnny_M
Including correction of earlier translations in case of and around "packen" Change-Id: Icaeaebb46a15edcc4abdcfee55d07b43e1767e06 Reviewed-on: https://gerrit.libreoffice.org/57156 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-08tdf#89893: Enable previous/next track changes in read-only modeXisco Fauli
Change-Id: Ie7dd41b2f79347e9b959a73d58888915379f2e2a Reviewed-on: https://gerrit.libreoffice.org/57100 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-06Translate German comments and debug stringsJohnny_M
And correct a few comments (translation and grammar) Change-Id: Ifafa521c683e9ca65aeba8031cd4cbfc1fadc137 Reviewed-on: https://gerrit.libreoffice.org/54888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-13tdf#83877 Add dialog to sign signature linesSamuel Mehrbrodt
actual signing still missing Change-Id: I41f013a2867f923155203dcee58ff453a43fa7c2 Reviewed-on: https://gerrit.libreoffice.org/51735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-10tdf#114523 Make inline tooltips for changes optionalheiko tietze
Revert redline shenanigans from change 46971; option is now set with view Change-Id: I55fcfef8a40ad621630dfcefed9e50fdafa94005 Reviewed-on: https://gerrit.libreoffice.org/52586 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-03-22tdf#83877 Move SignatureLineDialog to svxSamuel Mehrbrodt
To prepare using from Calc Change-Id: I102ecf2c956922dd1458c99bd7cd7be30f6f5ec4 Reviewed-on: https://gerrit.libreoffice.org/51726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13tdf#114552 Convert anchor toggle to anchor menuSamuel Mehrbrodt
Since we now have three, not two anchor types. Change-Id: I9654de574a9d546d2191093cba9c192fac3cd3d7 Reviewed-on: https://gerrit.libreoffice.org/50987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-27Replace the 2 occurences of Navigation by NavigatorJulien Nabet
and get rid of: warn:legacy.osl:10410:10410:sfx2/source/control/msgpool.cxx:211: GroupId-Name not defined in SFX! Indeed "Navigation" isn't taken into account in getGidResId from msgpool.cxx (sfx2) Change-Id: Ie5d54175106c1ca835a487ccfe2a38f3f21dc93d Reviewed-on: https://gerrit.libreoffice.org/50400 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-01make 'Navigate By' control avaliable in read only modeJim Raykowski
Change-Id: I02926aa962c045081dcf61bfc7a8d2cf522d6e92 Reviewed-on: https://gerrit.libreoffice.org/47011 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-14tdf#83877 Edit existing signature linesSamuel Mehrbrodt
Change-Id: I7a6861f599cb8794bcb8c246179cf6c7ff9966f3 Reviewed-on: https://gerrit.libreoffice.org/46289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-13tdf#83877 Add dialog to generate signature lineSamuel Mehrbrodt
Change-Id: Iacc929edf1469c7e37707f8d9518cd07642bb9dd Reviewed-on: https://gerrit.libreoffice.org/45810 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-09tdf#113715 Fix .uno: names appearing in the customization dialogMaxim Monastirsky
Change-Id: Ia4a4231acf2f15ebf58f2acd02b7fc0ab5a88072 Reviewed-on: https://gerrit.libreoffice.org/46062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-11-27tdf#108048: update InsertBreak slot to use PageNumberFilled paramMike Kaganski
Since commit c2ccd20c0fd92bddfff76447754541705e3eb8f3 (tdf#44689), SwWrtShell::InsertPageBreak takes page number as optional argument. The FN_INSERT_BREAK_DLG case in SwTextShell::Execute expects third parameter (FN_PARAM_3) to be boolean flag indicating if page number is filled. But corresponding sw slot was not updated to that fact. This prevented macros inserting page breaks with page numbers to be properly recorded, and one couldn't fix that manually, too, because the slot didn't expect that extra param (which would be dropped in TransformParameters). This adds the boolean parameter named PageNumberFilled to the list of InsertBreak slot. Unit test included. Change-Id: Ibccaece59b0e9848c0b754aa91b6700054b7fe97 Reviewed-on: https://gerrit.libreoffice.org/45319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-08sw lok: add Accept/Reject All tracked changes, tdf#101977Henry Castro
Change-Id: I04d747343e24cb498a621c965d034d0791411d83 Reviewed-on: https://gerrit.libreoffice.org/44311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-10-20RotGrfFlyFrame: Added interactive rotation modeArmin Le Grand
The FlyFrames containing a graphic now support an interactive rotation mode. Added a rotation icon to the Toolbar close to right/left 90degree rotation. When activated, works as similar to draw object mode as possible. Shear and move of the rotation center is deactivated since not supported. It uses as much of the existing interaction stuff as possible. Change-Id: Ia1a4e5c064d8576b114c3fcf3a96ccb42c9372bb
2017-10-20RotGrfFlyFrame: Initial adaptionsArmin Le Grand
To allow free rotation of Graphic FlyFrames in Writer, several adaptions are necessary. This change takes care of all needed changes to internally support a freely definable rotation angle for that case. Save/Load round trip is working, the graphic does no longer get modified and added in 90-degree-changed state to the object, the original will be preserved. Support for needed slot in core/ui is implemented. Rotation can be applied from Menus/Toolbars in the known 90/180 degree steps. Added a slot/Button/command to reset rotation in these cases. Added support in Sidebar to rotate using the rotation wheel and/or numeric field. These fields and support added to Image TabPage, too, fully functional. Missing now is a solution for displaying the rotated Graphic. For now, it just gets rotated, but this will not be the final state of this change. Change-Id: I6f3b85ebb5be2b4ad3311c536d54f27a37a494e7 RotGrfFlyFrame: Linux build adaptions Change-Id: I365287ecd6525b1972e8436d61332f7121d88649
2017-09-26TSCP: paragraph classification dialogAshod Nakashian
Change-Id: I3a5f201f9ed28452ee7392cb30aebf21955f3620 Reviewed-on: https://gerrit.libreoffice.org/42737 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-21TSCP: add advanced classification dialogTomaž Vajngerl
This adds a advanced classification dialog, which enables the user to manually construct a header/footer message from classification properties in cases where the user needs more control. All the text is inserted as fields into the end document and can be changed by changing the document properties. The simple classification still functions as it did before, which is what most users will want to use in this case. The BAF policy has been extended with new xml extension elements: - loext:Marking - loext:IntellectualPropertyPart - loext:IntellectualPropertyPartNumber They are used to fill the values in the advanced classification dialog. Change-Id: Ie2d638d69b8a9b0799cff9c2b785eb789f8af1d5 Reviewed-on: https://gerrit.libreoffice.org/42474 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-28Translate German comments/debug strings (leftovers in dirs starmath to sysui)Johnny_M
Translates leftovers found using a custom regex. Additionally translated: - One randomly found comment in /reportdesign - Test strings in /stoc/test (let's see if it works) Change-Id: I5f893c194c4b56b5365700928a3b8b63936d03e2 Reviewed-on: https://gerrit.libreoffice.org/41583 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17implementing callback for ruler invalidationAditya Dewan
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-16Translated "Methoden" to complete b1f6e6299cf5Andrea Gelmini
No more "methoden" in the tree... Change-Id: I4deec3c47bfab12beabd1b6d56c9b9c3c2b6c4a7 Reviewed-on: https://gerrit.libreoffice.org/41226 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-10tdf#79167 Change search type through a drop down controlJames Raykowski
drop down control to change 'navigate by' search element small navigation popup relationally linked to drop down control dynamic tool tips added to previous and next 'navigate by' toolbar controls Change-Id: I4b1215b74b488f2571b529d9946f6574de6e270a Reviewed-on: https://gerrit.libreoffice.org/40776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-26convert SfxGroupId to scoped enumNoel Grandin
in the process I had to teach the idl compiler to cope with identifiers like SfxGroupID::Math, which has the side effect of requiring a space before a ':' in some of the .sdi files. Change-Id: If256599cb8aa1dfc0a33642c5070c5560702f3ba Reviewed-on: https://gerrit.libreoffice.org/40441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21de-hrc various thingsCaolán McNamara
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-10UI Wrap InBackground: transition to wrapthru transparency toggleJustin Luth
The UI for placing a frame in the background is confusing because: -in menus, the icon looks like a checkbox, but functions as a radio button -it isn't obvious that "in background" is the opposite of "wrap through" -it doesn't act like the checkboxes below it like "First paragraph" -in dialog boxes, it is actually implemented as a checkbox toggle. So it looks like a checkbox, and you can enable the checkbox, but once enabled it can never be disabled. (The currently designed way is to select wrap off/page/optimal/through in order to disable in background.) This patch creates FN_FRAME_WRAPTHRU_TOGGLE to replace most uses of the previous function. Change-Id: Ia46ddbd47899e8ca569bf3adb2b1c4ad7cfa1920 Reviewed-on: https://gerrit.libreoffice.org/39673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-09Added margin feature to the Draw's SideBarpv2k
Change-Id: I53b5430d1563fcceae29418fd5907ac42ea856e7 Reviewed-on: https://gerrit.libreoffice.org/37626 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-06GSoC: Recent Charaters Toolbar Dropdown ControlAkshay Deep
Change-Id: Ib04d26fa5556e5c32db6799c16d0bbedc45504ec Reviewed-on: https://gerrit.libreoffice.org/38944 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-14tdf#39468 translate german comments in swBernhard Widl
Change-Id: I22114e9c8adaad67f71811f2b44fdd8a6d6e7f7b Reviewed-on: https://gerrit.libreoffice.org/38767 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-18Watermark: Insert watermark commandSzymon Kłos
* added new command .uno:Watermark * if no arguments are provided the dialog is opened where user can enter the text * with provided Text argument the watermark is created * created SfxWatermarkItem to transfer watermark properties * dialog loads current setings * SetClassification use SetWatermark Change-Id: Ifc1319f5aa7c11bb141f8e4b5b9a5088613021c2 Reviewed-on: https://gerrit.libreoffice.org/37599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-11tdf#107258 Create show/hide all comments toggle button.Gulsah Kose
Created new show/hide all comments button for calc by ShowAnnotations command. Unifyied writer, calc and impress's ShowAnnotations slot. Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/36697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-05Defining SID_UNICODE_NOTATION_TOGGLE once is enoughMaxim Monastirsky
Change-Id: I6d63ee582ad5530ecb713dd65350912ee27dc15d
2017-05-01Remove SlotType sdi propertyMaxim Monastirsky
sdi files have two ways to specify the type of a slot: (a) Put it at the beginning of the first line (b) Using the SlotType property Where (b) have higher priority, and (a) is actually ignored for "method slots" (i.e. the ones that have parameter parentheses, even empty, and therefore get the SfxSlotMode::METHOD flag), which is very confusing. The goal here is to make exclusive use of (a) for all kinds of slots, and eventually remove the SlotType support code from svidl (in a follow-up commit). Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-05-01FN_TOOL_ANCHOR cleanupMaxim Monastirsky
Drop unused execute method, and fix state method to match actual use. Change-Id: I93b86bbe10b48bf7fca7d9068446a698d7dd9036
2017-04-04Make HangingIndent a commandSzymon Kłos
New command .uno:HangingIndent. Code moved from the sidebar to slots. Change-Id: Ib389f9fb3368409a90cf90ad8b19f1be322fa120 Reviewed-on: https://gerrit.libreoffice.org/35930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Notebookbar: Separated paragraph spacing controlsSzymon Kłos
One big paragraph spacing control was splitted to separated widgets. It will be possible to reuse that in the sidebar. Also layout is better because explicit size setting is no longer needed. Change-Id: Ieb200af4a9a6120ae03b22b27da56256aa816193 Reviewed-on: https://gerrit.libreoffice.org/35801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-28remove unused interfaces from sdi filesNoel Grandin
Change-Id: I69e880e348372b3695b14efd4928f38f29bda37e Reviewed-on: https://gerrit.libreoffice.org/35747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Kill remaining PseudoSlots usageMaxim Monastirsky
Change-Id: I14a820b7c0baba8d8b17d07715bf17c42c73c8fb TODO: Remove support code from idl and sfx2 modules Reviewed-on: https://gerrit.libreoffice.org/35718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-03-22create SfxDisableFlags enumNoel Grandin
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17sw lok: Use unique redline identifier, instead of array indicesPranav Kant
Use a static integer counter as identifier to each redline Change few unit-tets that was testing redlines by using a hardcoded array index. Instead use these unique redline identifiers now. Change-Id: I63aec3fc8ab10d0dad0c936600d16e96999a2bcd Reviewed-on: https://gerrit.libreoffice.org/35276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>