summaryrefslogtreecommitdiff
path: root/sw/source/core/crsr/trvltbl.cxx
AgeCommit message (Collapse)Author
2019-11-05tdf#127759 Writer: add table row/column insert modeLászló Németh
using enhanced table selection. When the table rows or columns are selected by enhanced table selection, ie. clicking in front of them, next Cut operation cuts the selected rows or columns completely without leaving empty cells. Pasting them results insertion before the actual row/column instead of overwriting the actual and the next rows/columns. This greatly speeds up moving table rows and columns, like in MSO. Change-Id: I6d82ca8aad4888ab37bdb9a89d37102763fcd6c6 Reviewed-on: https://gerrit.libreoffice.org/81503 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-26tdf#42949 Fix IWYU warnings in sw/source/core/[a-c]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1c68650bb93f918d7ff38491ffedf9af96d80b52 Reviewed-on: https://gerrit.libreoffice.org/78083 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-07Fix typosAndrea Gelmini
Change-Id: Ib3ada3eb5b7d2699a86f05bb646b71f30d8a7003 Reviewed-on: https://gerrit.libreoffice.org/77041 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f Reviewed-on: https://gerrit.libreoffice.org/67486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-19sw: rework annoying GetFrameOfModify/getLayoutFrame parametersMichael Stahl
The bCalcFrame is only evaluated if a pPoint is given; this is surprising and should be more visible in the interface, so people don't go on a goose chase to find places that may do formatting in inappropriate places. So put these parameters into a pair instead, which doesn't have particularly good ergonomics in C++, particularly since compilers warn about taking the address of a temporary object... Change-Id: I101c6eeb5bd6baf83c2bd9a6cb91ccaa04036cc3 Reviewed-on: https://gerrit.libreoffice.org/60695 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-20remove unnecessary braces in GotoNextTableNoel Grandin
and comment the flow a little, it can be confusing Change-Id: I22fb11896a6d7e3b2007d822021b791b06caa1de Reviewed-on: https://gerrit.libreoffice.org/53185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19Satisfy Coverity errorJim Raykowski
Change-Id: Ib619617adca0cb64fb69daffb3b57214e882d9b4 Reviewed-on: https://gerrit.libreoffice.org/53145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-14tdf#115600 Display messages in Findbar for Table navigationJim Raykowski
...and make Table navigation wrap Change-Id: Iac645cb7db65517519cfb791ca1eb26f2567ee7c Reviewed-on: https://gerrit.libreoffice.org/52865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: swStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I0f49d21dfdf82742f11b27709f74294feb1e419e
2017-10-31RotateFlyFrame2: Unified FrameAreaDefinitionArmin Le Grand
Isolated all Frame AreaDefinition and it's layout flags to SwFrameAreaDefinition class which is now base for SwFrame. Adapted calls to get/set and WriteAccess hekper classes accordingly. This allows much deeper understanding what Writer is doing when layouting it's frames and needed when reaction on such changes is necessary Change-Id: I96220a1d140e69c76cc63023aae26e4ed17f3504
2017-10-30Adapted to get/setSwFrame and get/setSwPrintArmin Le Grand
Change-Id: I6cce40ec49dd5bd32d94fe06b9d2dabd368448be
2017-10-30Isolated SwFrame members maFrane and maPrtArmin Le Grand
To gain more control over changes of the Writer layout, isolated mentioned members and replaced all calls with inline methods for read and/or write access. Moved to own class to also identify 'private' accesses reliably. Change-Id: Ib0b7f852f5176744e860e2aad12dd13c9a906d68
2017-10-07sw: always use "" for includes in current source's directoryMike Kaganski
Change-Id: Ida715fad0c4587a9566184180bf159da12470dd7 Reviewed-on: https://gerrit.libreoffice.org/43207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-05tdf#112292 - fix memory leak and use more auto ref counting in swNoel Grandin
this bug was introduced in commit a754294ac7a902fe96fbbd6b8b6824a360d6b248 use rtl::Reference in SwDocFac instead of manual acquire/release fix it by using automatic ref-counting (i.e. rtl::Reference) everywhere. Note that the logic in SwViewShell::~SwViewShell is somewhat interesting. From my reading of it, it was previously potentially calling getIDocumentLayoutAccess on an SwDoc that had just been deleted. So if there is a problem with this commit I would look there first. Change-Id: I95b6b7e7523689c8b56063af642c3a84cbdcd331 Reviewed-on: https://gerrit.libreoffice.org/43131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12convert SwTableSearchType to o3tl::typed_flagsNoel Grandin
Change-Id: I4fbe114d96ac34540d0774fedbe1fed210efa906 Reviewed-on: https://gerrit.libreoffice.org/36459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: swStephan Bergmann
Change-Id: I288c5125a1316828df74f73aeaac85392638ffd8
2016-11-29convert SwCursorSelOverFlags to o3tl::typed_flagsNoel Grandin
Change-Id: I399db07f508e5aeba005c8c6746cf5adc42702d2 Reviewed-on: https://gerrit.libreoffice.org/31350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin
Change-Id: I81055c6973247e226dc9dc3fda072aef94fa8966
2016-08-31remove the SwMoveFnCollection* typedefsNoel Grandin
which were just obscuring the code, and pass it around by const& Change-Id: I4fce5ef4bf616867c46a145f660a8e90d3c94462
2016-08-29Get rid of pointless indirect function pointer variablesTor Lillqvist
Change-Id: Ic8eddec51d59b531ae22421b796a148267b9f3c1
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I27ff0f4f0eb395d7e0a60dd604758c220a3134c4
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-02-22loplugin:commaoperator in sw/Noel Grandin
Change-Id: I9b00755707687e4c10c02bf49866571f2c44d8ba
2015-11-25bin/rename-sw-abbreviations.shlibreoffice-5-1-branch-pointRobinson Tryon
This commit renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I77e5134f42f25e3786afa36b7a505c7e3237a9e8
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I01e11fa956a249974e77dce9deebe79311f098d0
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: I90dd921077bbfc57200e398e7959306f26c65cfe
2015-03-20tdf#89756 Switched postfix to prefix operator++/--Gulsah Kose
Replaced postfix to prefix operator++/-- to improving performance Change-Id: Iaee7b22dbe21441b82612ae3a3e336cf56eb280f Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/14903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-10coverity#1267654: sw: logically dead code in SwCrsrShell::GoNextCell()Michael Stahl
IsTableMode() should imply cursor is in table. Change-Id: Ibb94911430f947038abba2ebe013fc82fae7dd54
2015-01-26coverity#704347 Logically dead codeCaolán McNamara
const bool bSelectUp = ( bVert && !bRow ); ... if ( bSelectUp ) ... else bVert ? (bRow ? 0 : 3) : (bRow ? 2 : 1) the bRow is only queried on the non-bSelectUp path if bVert is true then bRow must be also true, because if bVert is true and bRow is false we would be in the other branch Change-Id: I784b41dbfda1afaf574fd8259eff3ab5cc5550fe
2014-12-04use C++11 iterationBjoern Michaelsen
Change-Id: I780df3b23e6ee9ad61dcd57472d0efb37d640d15
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12loplugin: cstylecastNoel Grandin
Change-Id: Ica3b54a7c331f0179294e2b52aadd884f53d53dc
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-12Refactored IDocumentLayoutAccess out of SwDoc.Valentin Kettner
Into the new class DocumentLayoutManager. Change-Id: I02d0cfcc63633d0bdab380508b2ef563187fd269
2014-07-07coverity#1213080 Explicit null dereferencedCaolán McNamara
Change-Id: I8f696307164c30d1fd2b1214171982da426cf9b8
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-05coverity#1213246 Dereference null return valueCaolán McNamara
Change-Id: I682a1e912728d6e52df258c7528e358f2883b323
2014-04-30sw: sal_Bool->boolNoel Grandin
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-15Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: I58c425ab9d2c01f8844226aff820dd56d88ec09c
2014-04-14typo: updateing -> updatingThomas Arnhold
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ibeb658e73b588f90242c95d23149f2ef45a7a815
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-11-14xub_StrLen to sal_Int32 in SwIndex and some relatedMatteo Casalin
Change-Id: I66735635a88844c30a7fa1c886d2c1df34008f4f
2013-10-26sw: ViewShell -> SwViewShell renameMiklos Vajna
It's a public class, so it should have the 'Sw' prefix. Change-Id: I0040c1cc37ffcba7fc5f58b71c86f4a7cb0bfce4
2013-10-18convert sw/source/core/crsr/*.cxx from String to OUStringNoel Grandin
Change-Id: I5fa7cc6ef54d0fed5752e422ab750f83a36d72ee
2013-10-15convert sw/inc/crsrsh.hxx from String to OUStringNoel Grandin
Change-Id: Ic3e4e0372593bdc28705ebc8f8f462b062f3da3e
2013-09-07add/remove blank lines and braces (in sw/source/core/crsr/)Philipp Riemer
Change-Id: I4dea8ea84d83c28eb258d0e8ddc2966476a50223 Reviewed-on: https://gerrit.libreoffice.org/272 Reviewed-by: Philipp Riemer <ruderphilipp@gmail.com> Tested-by: Philipp Riemer <ruderphilipp@gmail.com>
generated by cgit (git 2.34.1) at 2024-06-26 22:16:20 +0000