summaryrefslogtreecommitdiff
path: root/sw/source/filter/ww8/ww8par.hxx
AgeCommit message (Collapse)Author
2021-11-05tdf#144668: docx export: simpler way to create lvlText in numberingsVasily Melenchuk
Oldr approach with populating ListLabelString with some predefined values and than replacing them by placeholders is not so good. It can lead to collisions if we use numbers in format string. Anow with support of list strings in core we do not need this: it is enougth to replace LO placeholders %1%, %2%, ... by MS binary placeholders \0, \1, ... Additionally added support for list level initialization in DOC import: that case was still setting just prefix/suffix leaving list level uninitialized. Change-Id: Ia85551f46b4e229dea93c663459ec1a8715c8a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124326 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e0b41fcb56e51f20684da4ba44d7ed6e0e1a3234) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124698 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-17Resolves: tdf#142003 tracked changes in footnotes offset in .doc importCaolán McNamara
Reverts: commit e71d05eaa9a8c9e628b256f3e889b85ac11ed474 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 27 15:42:26 2018 +0100 ofz#8038 defer subdocument redlining to end of parse like main document Change-Id: Ie8d7a98c7927dcba53228ebcd991d715d8faabe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b5870d727685ec10447e8ae446ada895250fec2e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120580 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-01ofz#34749 don't remove trailing paragraph if something got anchored to itCaolán McNamara
Change-Id: Ic6eec2f9829c415abd4f2628bc51efbf98f918fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30std::unique_ptr->std::optionalNoel Grandin
Change-Id: I674ef2bccaa56d1435b821e3e161f7c47340202f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-13inline some typedefsNoel Grandin
Change-Id: I1608e03ff9f6fbc55987010e88897e034b690b3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27use string_view in INetURLObject::decodeNoel Grandin
Change-Id: I10e04970ceac33c9c3fbfd0182dd2140e06cb80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-23tdf#106541 doc import numbering: default nListLevel to MAXLEVELJustin Luth
WW8ListManager::nMaxLevel is a valid value meaning "Body Text". If a valid setting is provided during initialization, you can't tell if the property set contained the setting (or at least not so easily). The other related items (LFOPosition and mnWW8OutlineLevel) both use out-of-range initializers, so it just makes sense to do the same here. This will be especially important to see whether inheritance should come into play. This should effectively be a Non-Functional-Change. Change-Id: I05a2013e72c84653a16d61652fd8f23d3f441521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114399 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-04-21tdf#94326 doc import: allow direct numbering to cancel outlineStyleJustin Luth
Prior to this, if a Chapter Numbering style was assigned as the paragraph style, any direct numbering would have been skipped. In this unit test, DOC defines WW8Num2 as the numbering style for the Heading styles. LO copies this to its special "Outline" style. So any direct formatting with WW8Num2 must be ignored. However, any other numbering rules should be allowed, and that is what this patch does. Make sure that WW8Num2 can also be applied outside of the Heading styles. (Unfortunately, the numbering is probably broken since these are now considered to be two different lists - unless someone has connected them in the background some way.) Change-Id: If29c8bbd096acc0edd6f1fe32cedc054f16460d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114298 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-19cid#1476017 Read_GrafLayer's subfunction params are never nullJustin Luth
A more comprehensive backtrack of pRecord shows that it was never null in this context (and might as well do the same for any other never-null-variables in these sub-functions). I also took pains to (most of the time) clang-format the lines that I modified. I'm not sure how some subfunctions (like SetAttributesAtGrfNode) get away with no errors when they are passed a pointer, but never check if it exists. Perhaps if you use it without ever checking it accepts that? Change-Id: Iaaacd142310340d1f54af4eb61d856d61df0dd50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113990 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-03-31tdf#140343 sw page rtl gutter margin: add DOC filterMiklos Vajna
The import's tokenizer was there since commit 3e13e053749e1bf19179bf83bdf0a18a9488b5e8 (#i2408# Import and export set/ask references fields as set/input, change references to bookmarks to show variable as appropiate, 2002-02-04), but it tried to read 2 bytes, not 1 byte, so it was broken. This did not cause problems in practice till commit b897cc4dfc7111eb8dfd5d8aa8c970f21ab035d6 (consistently track amount of buffers remaining, 2017-04-10) started to check for not reading past the end of the buffer. The export was missing, since we previously tried to handle this at import time, so the doc model didn't have the info anymore. Change-Id: I0d15a16893de96104812b0cba4566c53f92673ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113415 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-12Revert "merge sw::hack::Position and SwFltPosition"Caolán McNamara
This reverts commit 4f35958c64d5e63c30e67434936c3a0352f57698. (which was an attempt at groundwork at fixing ofz#31538) because ooo46246-1.doc fails to load in crashtesting Change-Id: I334fc4ff1d1a934d92fe69eae63206c0a480e55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11rename GrafikCtor to GraphicCtorNoel
Change-Id: Ib9f4665a9b77e0d90070060f635466a046058431 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112266 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01merge sw::hack::Position and SwFltPositionCaolán McNamara
because they both attempt the same thing Change-Id: Ica0201fc114dd6251f05aa94c685258e322f7314 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111749 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-06tdf#91920 sw page gutter margin, from top: add DOC filterMiklos Vajna
But leave the fRTLGutter case alone for now, I can't find the Word UI for that. Change-Id: I1d97e85308aa13892f50c0fcd3680cec514ef566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110471 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-03tdf#91920 sw page gutter margin: add DOC filterMiklos Vajna
Map between sprmSDzaGutter and SvxLRSpaceItem::m_nGutterMargin, but leave the fRTLGutter and iGutterPos cases alone for now. Change-Id: I6f2ede619a8ea47404c4c37480b0e6d886cf5fce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110382 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-18loplugin:stringviewparam: No good reason to exclude operator functionsStephan Bergmann
(at least not in general) Change-Id: I71337b53dc9735e90a37ee532d0a8a08797b518c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-03ofz#26943 detect if FormatOfJustInsertedApo was deletedCaolán McNamara
move FrameDeleteWatch for reuse in the doc filter Change-Id: I6e53549a837968cb738b5188e8670dd3e38a9c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30ofz#26753 avoid infinite regressCaolán McNamara
Change-Id: I3f5f14aa63c234ffdf1acd8bb730ce0ff08c7a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20use tools::Long in swNoel
Change-Id: I44be72b3a9b14823ec37a3c799cffb4fb4d6e1de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-02SwWW8FltAnchorStack ctor never given a null SwDoc*Caolán McNamara
and similar Change-Id: I046be0e41b79f2fd51ebec0da20fccb17d947732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I28048bb0396dffa7bcbcb8bcf5fe10e1c359ec79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-05dito->dittoCaolán McNamara
Change-Id: I432dcc61dfb53e6b439052c495a602aab8a58f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-20tdf#117217 ww8: export/import all cell backgroundsJustin Luth
... using TDefTableShd2nd and TDefTableShd3rd P.S. There might be some other subtleties going on here. > sprmTDefTableShdRaw: > If a cell is set to ShdAuto in rgShd, the cell is > not shaded. If a cell is set to ShdNil in rgShd, the cell is shaded > according to the table style. By default, cells are shaded according > to the table style. (sprmTDefTableShdRaw not imported in LO, and ShdNil unknown) > sprmTDefTableShd: > If nFib is greater than 0x00D9 and the application understands > table styles, then this Sprm MUST be ignored. (aka NewShd from MSO 2000ish - never ignored by LO, and almost certainly LO doesn't understand these table styles despite ?nFib == 0x0101? ) These seem to be very "late" modifications to the .doc format, so likely very few things support the advanced features. In any case, I haven't done anything novel here - just copying what was done for template1 into template2 and template3, so these subtleties are irrelevant for this patch. Change-Id: Ic330179cf771a6f2531ed75dfb441fba10a04c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98856 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-17tdf#120394: doc import: use list format stringVasily Melenchuk
Since introducion of list level format string there is no need in complex parsing of doc level string and convering it to prefix-number-suffix format. We can just replace there special chars by %n placeholders (used in docx and now in LO) and this should be enough. Change-Id: I4e947939c4d4f393ee7e16c851cf22567d352ac3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94475 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-25sw: add XPackageEncryption support for binary docVasily Melenchuk
This adds read support for API-based MS-CRYPTO algos. DRM encryption is implemented as a service and desrption will be called if we found corresponding streams inside binary OLE package. Change-Id: Ie1a5b0417e1e7851b24d410c8f41dc85dd9210f7 Reviewed-on: https://gerrit.libreoffice.org/81600 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84437 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-24inline some use-once typedefsNoel Grandin
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09compact namespace in swNoel Grandin
Change-Id: Ie2c3e3f95a687b12b89bcfc5cad44fb7a1d4568f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-30Update name pReffedStck to xReffedStckAndrea Gelmini
In commit 2a72602824bf8aec44319e7fb9fe6dd3cebc72b3 it was updated Change-Id: I2dbc799f379805b94055e229606d032dc802d6fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90875 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-20Translate German variable namesJohnny_M
Ende -> End Change-Id: I205600e263d2291faa97d967c9a8c7fc0baadb1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92029 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-13Revert "loplugin:constfields in sw"Noel Grandin
This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea. Change-Id: I527e9366b05e8a20633720e334395b285991c524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05sw padded numbering: add DOC footnote filterMiklos Vajna
Import side: remove the duplication between SwWW8ImplReader::CoreLoad() and WW8ListManager::ReadLVL(). The CoreLoad() version did not support reading 0x16 as it did a "& 0xf" on the value before parsing. Export side: Writer supports footnote numbering type per-document, Word supports it per-section. So next to the per-document export add a per-section one, that's what Word actually reads. Similar code was there already for DOCX. Change-Id: Ic94e953cfee4514aabe507a8bcf75445bf05f401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90023 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-04std::set<T*> -> o3tl::sorted_vector in sw/Noel Grandin
Change-Id: I7b8e221b9e76f98efdbed9ee1c83e32379fde73f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-18Fix typo in codeAndrea Gelmini
Change-Id: Ic464f818204af4d5e0d6d1a0b1c29cac620f6250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86588 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-25Remove some redundantly user-declared copy ctors and assignment opsStephan Bergmann
...that trigger -Werror,-Wdeprecated-copy ("definition of implicit copy {constructor, assignment operator} for ... is deprecated beause it has a user-declared copy {assignment operator, constructor}") new in recent Clang 10 trunk (and which apparently warns about more cases then its GCC counterpart, for which we already adapted the code in the past, see e.g. the various "-Werror=deprecated-copy (GCC trunk towards GCC 9)" commits) Change-Id: Ie37bd820e6c0c05c74e1a862bb1d4ead5fb7cc9c Reviewed-on: https://gerrit.libreoffice.org/83698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15ofz#18526 sw: WW8 import: don't insert control charactersMichael Stahl
Sanitize string before calling InsertString(). This segfaults since: commit b522fc0646915d4da94df38dd249c88b28f25be7 Date: Tue Sep 24 18:11:45 2019 +0200 sw: maintain fieldmarks in DeleteRange()/DeleteAndJoin()/ReplaceRange() Change-Id: I9ef73d924420686f6838fa21900ec57b4d25c905 Reviewed-on: https://gerrit.libreoffice.org/81949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08Let WW8_TCell zero-initialize its membersStephan Bergmann
...which removes the need for WW8TabBandDesc::setcelldefaults and its dubious memset operating on a non-trivial type (as WW8_TCell has WW8_BRCVer9 data members, which in turn has a user-provided default ctor) Change-Id: Iabb02e353387f4fc2a002578b1b2b116d2f7313c Reviewed-on: https://gerrit.libreoffice.org/80394 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-28loplugin:constmethod in swNoel Grandin
Change-Id: I73c3c6d2165287d2d581a04b23b1d3b48166a488 Reviewed-on: https://gerrit.libreoffice.org/79780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-13warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-03Fix typosAndrea Gelmini
Change-Id: Ia6a6d93bade801fab77bfba701b64a905328c695 Reviewed-on: https://gerrit.libreoffice.org/76774 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-23convert nsRedlineType_t to scoped enumNoel Grandin
and move the auto-format embedded flag to a separate field Change-Id: I02155702389178fbfdf874f592d47a29f8759974 Reviewed-on: https://gerrit.libreoffice.org/72771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-01-15use unique_ptr in SwWW8ImplReader::ConstructApoNoel Grandin
Change-Id: I104168fbbd04f81d500bc9d63d4328aee0a11f24 Reviewed-on: https://gerrit.libreoffice.org/66318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-17tdf#121110 ww8import Jc80 justify is absolute, not Bidi relativeJustin Luth
Paragraph justification can be specified either absolutely (in old versions or with eWW8:Jc80) or relatively (with eWW8:Jc). The last processed SPRM wins (I assume). The WW8 format seems to ALWAYS specify Jc80, and that is overwritten by an optional Jc SPRM. I haven't seen Jc be processed before a Jc80 SPRM, but if it does, then the justify would need to be treated as absolute. If for some reason neither of these exist, BiDi will adjust by default only if it is the newer WW8 format. Again, that is an assumption because I haven't seen such a document to test. Change-Id: I966077d743f1d148fe2fb9faba87fbdd8f3507f3 Reviewed-on: https://gerrit.libreoffice.org/63591 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-16tdf79435 doc/docx: round-trip legacy input formfieldsJustin Luth
GrabBag the settings which LO doesn't implement (which is all of them) so that the document round-trips without losing the config settings. Change-Id: I00de6c483af68073634430dd74fd445e981573ab Reviewed-on: https://gerrit.libreoffice.org/62241 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-10-28ofz#11125 pass param len aroundCaolán McNamara
Change-Id: I4b382271df21c58de0e102af6e0b07a88a1d9610 Reviewed-on: https://gerrit.libreoffice.org/62443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05use more std::move in sw/Noel Grandin
Change-Id: Id2f063550db3a3110e4bae8e18d0e7b9a7bf5df3 Reviewed-on: https://gerrit.libreoffice.org/61368 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:constfields in swNoel Grandin
Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f Reviewed-on: https://gerrit.libreoffice.org/61177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>