summaryrefslogtreecommitdiff
path: root/sw/source/filter
AgeCommit message (Collapse)Author
2018-01-25introduce SwClient::EndListeningAll()Bjoern Michaelsen
- this is to reduce the use of GetRegisterdIn(), which should be an implementation detail - remove SwTOXMark::DeRegister() which did the same for a part of the class tree - remove SwUndoSetFlyFormat::DeRegisterFromFormat(), same - remove doubletracking FrameDeleteWatch::m_bDeleted, just check GetRegisteredIn() Change-Id: Id9364076759446ee5ff1898683c3ca700c1014c9
2018-01-22limit the rest of CSS1_PIXLENGTH usersCaolán McNamara
Change-Id: I59487bb337bc8821cb995fd258602ff7fb580d54 Reviewed-on: https://gerrit.libreoffice.org/48311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ofz#5561 Integer-overflowCaolán McNamara
Change-Id: I57660848190efff8e6354670eb68b60ed57f0094 Reviewed-on: https://gerrit.libreoffice.org/48308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22sw: add an assert wrt. recent bug in SwHTMLParser::SplitAttrTab()Michael Stahl
Change-Id: I1fa64beb4724675c2e23bd5d4f0766f6d4cf7873
2018-01-22crashtesting: dodgy aRect is unused anywayCaolán McNamara
assert on conversion fdo66047-1.odt to doc of too large long from Fraction Change-Id: I057eb41791eb3b454192540da5e1f1d099487839 Reviewed-on: https://gerrit.libreoffice.org/48324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21Fix typosAndrea Gelmini
Change-Id: Id3e707e89bd0fda4d86e02a185a16336c89e7c82 Reviewed-on: https://gerrit.libreoffice.org/48281 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-20ofz#5253 restore some sort of valid state on missing RestoreCaolán McNamara
Change-Id: Ic12e1567f5a3370d1580d8c471ee38d3069568ce Reviewed-on: https://gerrit.libreoffice.org/48217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19ofz#5483 Integer-overflowCaolán McNamara
Change-Id: If364a961f5e144cc0f3572108020c99db6febfb8 Reviewed-on: https://gerrit.libreoffice.org/48177 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19tdf#115088: Pasting multi-line text from external source behaves strangelyTamás Zolnai
Regression from: e68b6e349c31ac1376e90218013e1e7612f2b522 AppendTextNode might be sufficient for import (when there is no content in the document), but for clipboard operations better to use the original SplitNode method. Change-Id: I7de3e9bc9c5356acb0b4cc43927a0d39079522b2 Reviewed-on: https://gerrit.libreoffice.org/48124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-19sw: loplugin:unreffunMichael Stahl
HTMLTable::FixFillerFrameFormat is unused now. Change-Id: Ic09d9585368ead7317325068eabb0171b76b6a9b
2018-01-19inline some definesNoel Grandin
which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
2018-01-19loplugin:unusedmethods also check for functions returning boolNoel Grandin
we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19new loplugin:emptyifNoel Grandin
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19sw: remove no longer building ww8toolbar dump codeMiklos Vajna
Such dumper code for other ww8 features is in the separate mso-dumper repo. If it is found really useful later, it can be still restored and fixed up to actually build, though. Change-Id: Id542fef9c0111c8bc88b943e268c9a02f3503d72 Reviewed-on: https://gerrit.libreoffice.org/48161 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-19sw: HTMLTable::m_pTopTable is always "this"Michael Stahl
Ever since commit cc144e5544a41acdc703f7d243ad1747b0a2b33d fix for i#76959 the pTopTable parameter of HTMLTable was always null. Simplify HTMLTable by removing dead code. Change-Id: Ie13313f54d6ee656e56a209bc29bcc77132de269
2018-01-19pack these without holesCaolán McNamara
Change-Id: Idb5184e141c5a15d4d77268f8d45ee549c6e9a7f Reviewed-on: https://gerrit.libreoffice.org/47714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19SAL_W32 is just an alias for _WIN32Stephan Bergmann
...so consistently use the latter instead of the former Change-Id: I144d5e7c472632f93b2258461510346bc85892d9 Reviewed-on: https://gerrit.libreoffice.org/48135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-18ofz#4754 sw: HTML import: fix invalid tables being createdMichael Stahl
This 75-byte horror creates 2 nested tables, where one SwTableBox is in the SwTableLine of the inner SwTable but in the SwSortBoxes of the outer table, which is of course invalid. The root cause is that in SwHTMLParser::SplitAttrTab(), we move the m_pPam backward once and forward twice, moving it ouside the inner table. Change-Id: I63f6508afe1270ccdeb05da6f222b0aba5259889
2018-01-18Fix typosAndrea Gelmini
Change-Id: I633e4921042809c628e55825b70c540767eba1d3 Reviewed-on: https://gerrit.libreoffice.org/48140 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18tdf#76817 ooxmlexport: only use stylename for Outline listJustin Luth
In LibreOffice, the special, built-in, Outline numbering style ("Chapter Numbering") is connected via the paragraph style to control the numbering. Thus, only the ParaStyleName should be written to the paragraph properties, and not the direct numbering properties. Both MSO and LO get confused when there are multiple definitions for outline numbering. Change-Id: I1af54fdea164d68e5e156c256b478e518daa5e99 Reviewed-on: https://gerrit.libreoffice.org/47828 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-18Fix typosAndrea Gelmini
Change-Id: I7aa101a5e1e47118ab94527eb37269dd7e544cf4 Reviewed-on: https://gerrit.libreoffice.org/48093 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18Fix typosAndrea Gelmini
Change-Id: Iaad78e5f1100df1ca69d34bf7693e4a9feac17eb Reviewed-on: https://gerrit.libreoffice.org/48084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17tdf#115013: quote columns with spaces and properly escape charactersMike Kaganski
Unit test updated Change-Id: If36c90c0ff372ce45666674d2487e6edf2536dbf Reviewed-on: https://gerrit.libreoffice.org/48038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-17ofz#5444 asserts and Null-dereference READCaolán McNamara
Change-Id: I35f31e8553045ae61f39dd5679af638ddc3364d8 Reviewed-on: https://gerrit.libreoffice.org/48059 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17Silence MSVC warning C4701Stephan Bergmann
..."potentially uninitialized local variable 'nProgressReference' used" after 49f05934edd3723666b7c52eccbf4d0c9a688eb7 "coverity#1427629 Unchecked return value" Change-Id: I710221f730c1c8fb416378de1a57f7e713244cef
2018-01-17ofz#5447 on plcf save force current Fkp to stick in cacheCaolán McNamara
Change-Id: Id7b6c442df10c6de7226702a9bf3ba559a0c2e9a Reviewed-on: https://gerrit.libreoffice.org/48040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17coverity#1427629 Unchecked return valueCaolán McNamara
Change-Id: If12d57826817d5ca866ecc14d81b21f494ff4487
2018-01-17Fix typosAndrea Gelmini
Change-Id: I5fff9ccb1bc74b85ee378439ffa2272583ffcb0f Reviewed-on: https://gerrit.libreoffice.org/48024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-16Fix typoAndrea Gelmini
Change-Id: I02379f413d59226c81a8919dc1bc0786cecf900a Reviewed-on: https://gerrit.libreoffice.org/47927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2 Reviewed-on: https://gerrit.libreoffice.org/47858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Remove unused CSS1_OUTMODE_SPAN_TAG1_OFFStephan Bergmann
...no other traces of it apart from its definition in 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import" Change-Id: Id18fef73416a5159b002ff6ab6d54c2ced51cbfd Reviewed-on: https://gerrit.libreoffice.org/47921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-16ofz#5391 Integer-overflowCaolán McNamara
Change-Id: Ic252a95cf535bc40560d8e772224871f2b944345
2018-01-16ofz#5347 Indirect-leakCaolán McNamara
Change-Id: I4eb18c7ee52b29de9fabb555ad59cd9051d376b2 Reviewed-on: https://gerrit.libreoffice.org/47922 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-16tdf#115013: write merge field column into docx merge fieldsMike Kaganski
Change-Id: If1e0a8968407c72e42cb7ca487541d0b8227aabc Reviewed-on: https://gerrit.libreoffice.org/47895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-15tdf#113877 Insert document: merge two lists into oneSerge Krot
When inserting a new document into current position we need to concat to lists into one only when they have the same list properties. Added unit test. Change-Id: I66a8090fdeacd3a630700113d6a26a1cad75dc41 Reviewed-on: https://gerrit.libreoffice.org/47814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-15ofz#5299 TimeoutCaolán McNamara
Change-Id: I9c7968d44fc608431615b6fe0b1013e8a677bf60 Reviewed-on: https://gerrit.libreoffice.org/47871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-15More loplugin:cstylecast: swStephan Bergmann
Change-Id: I75f75b53e58221a3bd0a6eb837483e7ebae3a02b
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14ofz#5294 Indirect-leakCaolán McNamara
Change-Id: Ie183f1fcf3ac3358f5960382ec043a9250876679 Reviewed-on: https://gerrit.libreoffice.org/47864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-14Fix typosAndrea Gelmini
Change-Id: Icc5fc590a6a90e30afa5f61028d4dd0279fbe120 Reviewed-on: https://gerrit.libreoffice.org/47861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-12More loplugin:cstylecast: swStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I0f49d21dfdf82742f11b27709f74294feb1e419e
2018-01-11ofz#5247 Integer-overflowCaolán McNamara
Change-Id: I333f8bb2d7168f43d7d85c48dd39c6ed02ca970d Reviewed-on: https://gerrit.libreoffice.org/47769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11ofz#5235 Bad-castCaolán McNamara
Change-Id: I041f09f37941a92ccee3f0ebf9e5a950dee0c52f Reviewed-on: https://gerrit.libreoffice.org/47747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11tdf#91292 ooxmlexport: cleared fill != use grabbag infoJustin Luth
A while back the way that backgrounds are handled changed. This was one spot where the changes didn't sync up. When the background is cleared, then the imported grabbag attributes should be tossed, not re-applied during save. Change-Id: I9759def6321697a634bcbd66ecdc9d73693ce1a3 Reviewed-on: https://gerrit.libreoffice.org/44040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-10ofz: Integer-overflowCaolán McNamara
Change-Id: Iad8ebd0861a74399f6bb4a18aecf0de735a60b61 Reviewed-on: https://gerrit.libreoffice.org/47694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-10ofz#5211 limit table parsing depthCaolán McNamara
Change-Id: I77b569faacc6f2655b050d09a236f78843e87560 Reviewed-on: https://gerrit.libreoffice.org/47691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09ofz#5193 Negative-size-paramCaolán McNamara
Change-Id: I8c3cf71e4d7ad15d61e5aff738ebc6d326574635
2018-01-09just use a simple vectorCaolán McNamara
Change-Id: I4aeb611ba7e50c008a9d28d1f7efa308c77ba0a1 Reviewed-on: https://gerrit.libreoffice.org/47647 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09don't need to dynamically allocate theseCaolán McNamara
Change-Id: I847dfd45ea7115cdc1e8f95740477b76f1c68f7a Reviewed-on: https://gerrit.libreoffice.org/47646 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>